All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jerry Ray <jerry.ray@microchip.com>
To: Andrew Lunn <andrew@lunn.ch>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Vladimir Oltean <olteanv@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>,
	"Paolo Abeni" <pabeni@redhat.com>, <jbe@pengutronix.de>,
	<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux@armlinux.org.uk>, Jerry Ray <jerry.ray@microchip.com>
Subject: [PATCH net-next v5 4/6] dsa: lan9303: Performance Optimization
Date: Fri, 9 Dec 2022 16:47:11 -0600	[thread overview]
Message-ID: <20221209224713.19980-5-jerry.ray@microchip.com> (raw)
In-Reply-To: <20221209224713.19980-1-jerry.ray@microchip.com>

As the regmap_write() is over a slow bus that will sleep, we can speed up
the boot-up time a bit my not bothering to clear a bit that is already
clear.

Signed-off-by: Jerry Ray <jerry.ray@microchip.com>
---
 drivers/net/dsa/lan9303-core.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/drivers/net/dsa/lan9303-core.c b/drivers/net/dsa/lan9303-core.c
index b0f49d9c3d0c..694249aa1f19 100644
--- a/drivers/net/dsa/lan9303-core.c
+++ b/drivers/net/dsa/lan9303-core.c
@@ -891,8 +891,11 @@ static int lan9303_check_device(struct lan9303 *chip)
 	if (ret)
 		return (ret);
 
-	reg &= ~LAN9303_VIRT_SPECIAL_TURBO;
-	regmap_write(chip->regmap, LAN9303_VIRT_SPECIAL_CTRL, reg);
+	/* Clear the TURBO Mode bit if it was set. */
+	if (reg & LAN9303_VIRT_SPECIAL_TURBO) {
+		reg &= ~LAN9303_VIRT_SPECIAL_TURBO;
+		regmap_write(chip->regmap, LAN9303_VIRT_SPECIAL_CTRL, reg);
+	}
 
 	return 0;
 }
-- 
2.17.1


  parent reply	other threads:[~2022-12-09 22:47 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-09 22:47 [PATCH net-next v5 0/6] dsa: lan9303: Move to PHYLINK Jerry Ray
2022-12-09 22:47 ` [PATCH net-next v5 1/6] dsa: lan9303: align dsa_switch_ops members Jerry Ray
2022-12-09 22:47 ` [PATCH net-next v5 2/6] dsa: lan9303: move Turbo Mode bit initialization Jerry Ray
2022-12-10  4:13   ` Jakub Kicinski
2022-12-09 22:47 ` [PATCH net-next v5 3/6] dsa: lan9303: Add exception logic for read failure Jerry Ray
2022-12-09 22:47 ` Jerry Ray [this message]
2022-12-12 18:43   ` [PATCH net-next v5 4/6] dsa: lan9303: Performance Optimization Vladimir Oltean
2022-12-09 22:47 ` [PATCH net-next v5 5/6] dsa: lan9303: Determine CPU port based on dsa_switch ptr Jerry Ray
2022-12-11 22:46   ` Vladimir Oltean
2022-12-12 17:42     ` Jerry.Ray
2022-12-12 18:36       ` Vladimir Oltean
2022-12-09 22:47 ` [PATCH net-next v5 6/6] dsa: lan9303: Migrate to PHYLINK Jerry Ray

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221209224713.19980-5-jerry.ray@microchip.com \
    --to=jerry.ray@microchip.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=f.fainelli@gmail.com \
    --cc=jbe@pengutronix.de \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=netdev@vger.kernel.org \
    --cc=olteanv@gmail.com \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.