From: Willy Tarreau <w@1wt.eu>
To: Sven Schnelle <svens@linux.ibm.com>
Cc: "Paul E . McKenney" <paulmck@kernel.org>,
Josh Triplett <josh@joshtriplett.org>,
Steven Rostedt <rostedt@goodmis.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Lai Jiangshan <jiangshanlai@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/5] nolibc: fix fd_set type
Date: Sat, 10 Dec 2022 09:46:19 +0100 [thread overview]
Message-ID: <20221210084619.GA21743@1wt.eu> (raw)
In-Reply-To: <20221209141939.3634586-2-svens@linux.ibm.com>
On Fri, Dec 09, 2022 at 03:19:35PM +0100, Sven Schnelle wrote:
> The kernel uses unsigned long for the fd_set bitmap,
> but nolibc use u32. This works fine on little endian
> machines, but fails on big endian. Convert to unsigned
> long to fix this.
Thank you for spotting and fixing this one! I had been using these for
a long time, including for pure user-land code to manipulate bits and
never thought about the risk of incompatibility when passing them as-is
to the kernel! It's fairly possible that I'm having non-working code for
64-bit BE machines at a few places!
> Signed-off-by: Sven Schnelle <svens@linux.ibm.com>
Acked-by: Willy Tarreau <w@1wt.eu>
Willy
next prev parent reply other threads:[~2022-12-10 8:46 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-09 14:19 [PATCH 0/5] add s390 support to nolibc and rcutorture Sven Schnelle
2022-12-09 14:19 ` [PATCH 1/5] nolibc: fix fd_set type Sven Schnelle
2022-12-10 8:46 ` Willy Tarreau [this message]
2022-12-09 14:19 ` [PATCH 2/5] nolibc: add support for s390 Sven Schnelle
2022-12-10 9:07 ` Willy Tarreau
2022-12-10 9:34 ` Sven Schnelle
2022-12-10 9:37 ` Willy Tarreau
2022-12-10 9:39 ` Sven Schnelle
2022-12-10 9:44 ` Willy Tarreau
2022-12-10 17:57 ` Paul E. McKenney
2022-12-10 22:05 ` Willy Tarreau
2022-12-11 5:51 ` Paul E. McKenney
2022-12-27 21:35 ` Willy Tarreau
2023-01-02 8:17 ` Sven Schnelle
2023-01-02 8:41 ` Willy Tarreau
2023-01-02 9:33 ` Sven Schnelle
2023-01-02 9:50 ` Willy Tarreau
2022-12-09 14:19 ` [PATCH 3/5] selftests/nolibc: add s390 support Sven Schnelle
2022-12-10 9:08 ` Willy Tarreau
2022-12-09 14:19 ` [PATCH 4/5] rcutorture: add support for s390 Sven Schnelle
2022-12-09 14:19 ` [PATCH 5/5] rcutorture: build initrd for rcutorture with nolibc Sven Schnelle
2022-12-09 15:03 ` [PATCH 0/5] add s390 support to nolibc and rcutorture Paul E. McKenney
2022-12-09 15:28 ` Willy Tarreau
2022-12-10 1:26 ` Paul E. McKenney
2022-12-10 9:12 ` Willy Tarreau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221210084619.GA21743@1wt.eu \
--to=w@1wt.eu \
--cc=jiangshanlai@gmail.com \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=paulmck@kernel.org \
--cc=rostedt@goodmis.org \
--cc=svens@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.