From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Heiko Thiery <heiko.thiery@gmail.com>
Cc: Eric Le Bihan <eric.le.bihan.dev@free.fr>,
Matt Weber <matthew.weber@collins.com>,
Aleksander Morgado <aleksander@aleksander.es>,
buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v2 3/3] package/modem-manager: bump version to 1.20.2
Date: Sun, 11 Dec 2022 14:46:11 +0100 [thread overview]
Message-ID: <20221211144611.437eda70@windsurf> (raw)
In-Reply-To: <20221208133928.303101-3-heiko.thiery@gmail.com>
Hello Heiko!
On Thu, 8 Dec 2022 14:39:32 +0100
Heiko Thiery <heiko.thiery@gmail.com> wrote:
> -MODEM_MANAGER_VERSION = 1.18.12
> -MODEM_MANAGER_SOURCE = ModemManager-$(MODEM_MANAGER_VERSION).tar.xz
> -MODEM_MANAGER_SITE = http://www.freedesktop.org/software/ModemManager
> +MODEM_MANAGER_VERSION = 1.20.2
> +MODEM_MANAGER_SOURCE = ModemManager-$(MODEM_MANAGER_VERSION).tar.gz
> +MODEM_MANAGER_SITE = https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/archive/$(MODEM_MANAGER_VERSION)
> MODEM_MANAGER_LICENSE = GPL-2.0+ (programs, plugins), LGPL-2.0+ (libmm-glib)
> MODEM_MANAGER_LICENSE_FILES = COPYING COPYING.LIB
> MODEM_MANAGER_SELINUX_MODULES = modemmanager
> -MODEM_MANAGER_DEPENDENCIES = host-pkgconf libglib2 $(TARGET_NLS_DEPENDENCIES)
> +MODEM_MANAGER_DEPENDENCIES = host-pkgconf dbus libglib2 $(TARGET_NLS_DEPENDENCIES) host-libxslt
So D-Bus is no longer just a runtime dependency? Why? If that's really
the case then package/modem-manager/Config.in needs to be adjusted, as
it claims D-Bus is a runtime dependency.
> MODEM_MANAGER_INSTALL_STAGING = YES
> -MODEM_MANAGER_CONF_OPTS = --disable-more-warnings
> +MODEM_MANAGER_CONF_OPTS = \
> + -Dpowerd_suspend_resume=false \
> + -Dudevdir=/usr/lib/udev
Is this needed even when -Dudev=false? Doesn't -Dudevdir=/usr/lib/udev
belong instead the BR2_PACKAGE_LIBGUDEV==y conditional?
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-12-11 13:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-08 13:39 [Buildroot] [PATCH v2 1/3] package/libmbim: bump version to 1.28.2 Heiko Thiery
2022-12-08 13:39 ` [Buildroot] [PATCH v2 2/3] package/libqmi: bump version to 1.32.2 Heiko Thiery
2022-12-11 13:47 ` Thomas Petazzoni via buildroot
2022-12-08 13:39 ` [Buildroot] [PATCH v2 3/3] package/modem-manager: bump version to 1.20.2 Heiko Thiery
2022-12-11 13:46 ` Thomas Petazzoni via buildroot [this message]
2022-12-12 9:19 ` Aleksander Morgado
2022-12-12 9:29 ` Thomas Petazzoni via buildroot
2022-12-12 9:52 ` Heiko Thiery
2022-12-11 13:47 ` [Buildroot] [PATCH v2 1/3] package/libmbim: bump version to 1.28.2 Thomas Petazzoni via buildroot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221211144611.437eda70@windsurf \
--to=buildroot@buildroot.org \
--cc=aleksander@aleksander.es \
--cc=eric.le.bihan.dev@free.fr \
--cc=heiko.thiery@gmail.com \
--cc=matthew.weber@collins.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.