From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Giulio Benetti <giulio.benetti@benettiengineering.com>
Cc: James Hilliard <james.hilliard1@gmail.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 2/2] package/rtl8192eu: fix build failure on Big Endian architectures
Date: Sun, 11 Dec 2022 21:29:57 +0100 [thread overview]
Message-ID: <20221211212957.27aa9e19@windsurf> (raw)
In-Reply-To: <0D32AFEE-0712-48AE-A855-3FFC249371DD@benettiengineering.com>
On Tue, 29 Nov 2022 23:25:29 +0100
Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:
> > Clearly, all of this is rubbish in Buildroot context. So what we should do is to set
> >
> > RTL8192EU_MODULE_MAKE_OPTS = ... CONFIG_PLATFORM_I386_PC=n
> >
> > At that point, we can set all the appropriate config options we like, which would be the -DCONFIG_IOCTL_CFG80211 -DRTW_USE_CFG80211_STA_EVENT in USER_EXTRA_CFLAGS.
>
> Yes, this is another approach, but there is only a patch with my proposed solution applied [1]
> so maybe for consistency we could keep it the same, what about it?
Well, Arnout has a point that having CONFIG_PLATFORM_I386_PC=y is not
really good. So perhaps 354f9387f33b5fab023cb98e52d84d58624f0ecf also
needs to be changed like Arnout suggested?
Best regards,
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-12-11 20:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-29 21:07 [Buildroot] [PATCH 1/2] DEVELOPERS: add Giulio Benetti to rtl8192eu package Giulio Benetti
2022-11-29 21:08 ` [Buildroot] [PATCH 2/2] package/rtl8192eu: fix build failure on Big Endian architectures Giulio Benetti
2022-11-29 22:16 ` Arnout Vandecappelle
2022-11-29 22:25 ` Giulio Benetti
2022-12-11 20:29 ` Thomas Petazzoni via buildroot [this message]
2022-12-13 21:14 ` Giulio Benetti
2022-11-29 22:07 ` [Buildroot] [PATCH 1/2] DEVELOPERS: add Giulio Benetti to rtl8192eu package Arnout Vandecappelle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221211212957.27aa9e19@windsurf \
--to=buildroot@buildroot.org \
--cc=giulio.benetti@benettiengineering.com \
--cc=james.hilliard1@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.