All of lore.kernel.org
 help / color / mirror / Atom feed
From: Waiman Long <longman@redhat.com>
To: Jens Axboe <axboe@kernel.dk>, Tejun Heo <tj@kernel.org>,
	Josef Bacik <josef@toxicpanda.com>,
	Zefan Li <lizefan.x@bytedance.com>,
	Johannes Weiner <hannes@cmpxchg.org>,
	Andrew Morton <akpm@linux-foundation.org>
Cc: cgroups@vger.kernel.org, linux-block@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	"Michal Koutný" <mkoutny@suse.com>,
	"Dennis Zhou (Facebook)" <dennisszhou@gmail.com>,
	"Waiman Long" <longman@redhat.com>
Subject: [PATCH-block v2 0/3] blk-cgroup: Fix potential UAF & miscellaneous cleanup
Date: Sun, 11 Dec 2022 17:20:55 -0500	[thread overview]
Message-ID: <20221211222058.2946830-1-longman@redhat.com> (raw)

 v2:
  - Remove unnecessary rcu_read_{lock|unlock} from
    cgroup_rstat_css_cpu_flush() in patch 3.

It was found that blkcg_destroy_blkgs() may be called with all blkcg
references gone. This may potentially cause user-after-free and so
should be fixed. The last 2 patches are miscellaneous cleanups of
commit 3b8cc6298724 ("blk-cgroup: Optimize blkcg_rstat_flush()").

Waiman Long (3):
  bdi, blk-cgroup: Fix potential UAF of blkcg
  blk-cgroup: Don't flush a blkg if destroyed
  blk-cgroup: Flush stats at blkgs destruction path

 block/blk-cgroup.c     | 26 ++++++++++++++++++++++++++
 include/linux/cgroup.h |  1 +
 kernel/cgroup/rstat.c  | 18 ++++++++++++++++++
 mm/backing-dev.c       |  8 ++++++--
 4 files changed, 51 insertions(+), 2 deletions(-)

-- 
2.31.1


             reply	other threads:[~2022-12-11 22:20 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-11 22:20 Waiman Long [this message]
2022-12-11 22:20 ` [PATCH-block v2 1/3] bdi, blk-cgroup: Fix potential UAF of blkcg Waiman Long
2022-12-11 22:20   ` Waiman Long
2022-12-12 22:13   ` Tejun Heo
     [not found]     ` <Y5enmzQM7BIiEv9n-NiLfg/pYEd1N0TnZuCh8vA@public.gmane.org>
2022-12-12 22:16       ` Waiman Long
2022-12-12 22:16         ` Waiman Long
     [not found] ` <20221211222058.2946830-1-longman-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2022-12-11 22:20   ` [PATCH-block v2 2/3] blk-cgroup: Don't flush a blkg if destroyed Waiman Long
2022-12-11 22:20     ` Waiman Long
2022-12-12 12:59     ` Michal Koutný
2022-12-12 14:58       ` Waiman Long
2022-12-12 14:58         ` Waiman Long
2022-12-12 22:16       ` Tejun Heo
     [not found]         ` <Y5eoQ8UBN8Xpc+Wp-NiLfg/pYEd1N0TnZuCh8vA@public.gmane.org>
2022-12-13  0:21           ` Waiman Long
2022-12-13  0:21             ` Waiman Long
2022-12-11 22:20 ` [PATCH-block v2 3/3] blk-cgroup: Flush stats at blkgs destruction path Waiman Long
     [not found]   ` <20221211222058.2946830-4-longman-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2022-12-12 22:24     ` Tejun Heo
2022-12-12 22:24       ` Tejun Heo
2022-12-13  0:19       ` Waiman Long

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221211222058.2946830-1-longman@redhat.com \
    --to=longman@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=axboe@kernel.dk \
    --cc=cgroups@vger.kernel.org \
    --cc=dennisszhou@gmail.com \
    --cc=hannes@cmpxchg.org \
    --cc=josef@toxicpanda.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lizefan.x@bytedance.com \
    --cc=mkoutny@suse.com \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.