From: Andrew Morton <akpm@linux-foundation.org>
To: mm-commits@vger.kernel.org, yang.lee@linux.alibaba.com,
shuah@kernel.org, david@redhat.com, akpm@linux-foundation.org
Subject: [merged mm-stable] mm-gup_test-fix-pin_longterm_test_read-with-highmem.patch removed from -mm tree
Date: Sun, 11 Dec 2022 18:14:59 -0800 [thread overview]
Message-ID: <20221212021500.7EC58C433F0@smtp.kernel.org> (raw)
The quilt patch titled
Subject: mm/gup_test: fix PIN_LONGTERM_TEST_READ with highmem
has been removed from the -mm tree. Its filename was
mm-gup_test-fix-pin_longterm_test_read-with-highmem.patch
This patch was dropped because it was merged into the mm-stable branch
of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
------------------------------------------------------
From: David Hildenbrand <david@redhat.com>
Subject: mm/gup_test: fix PIN_LONGTERM_TEST_READ with highmem
Date: Mon, 5 Dec 2022 20:37:13 +0100
Patch series "selftests/vm: fix some tests on 32bit".
I finally had the time to run some of the selftests written by me
(especially "cow") on x86 PAE. I found some unexpected "surprises" :)
With these changes, and with [1] on top of mm-unstable, the "cow" tests
and the "ksm_functional_tests" compile and pass as expected (expected
failures with hugetlb in the "cow" tests). "madv_populate" has one
expected test failure -- x86 does not support softdirty tracking.
#1-#3 fix commits with stable commit ids. #4 fixes a test that is not in
mm-stable yet.
A note that there are many other compile errors/warnings when compiling on
32bit and with older Linux headers ... something for another day.
[1] https://lkml.kernel.org/r/20221205150857.167583-1-david@redhat.com
This patch (of 4):
... we have to kmap()/kunmap(), otherwise this won't work as expected
with highmem.
Link: https://lkml.kernel.org/r/20221205193716.276024-1-david@redhat.com
Link: https://lkml.kernel.org/r/20221205193716.276024-2-david@redhat.com
Fixes: c77369b437f9 ("mm/gup_test: start/stop/read functionality for PIN LONGTERM test")
Signed-off-by: David Hildenbrand <david@redhat.com>
Cc: Shuah Khan <shuah@kernel.org>,
Cc: Yang Li <yang.lee@linux.alibaba.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
mm/gup_test.c | 10 +++++++---
1 file changed, 7 insertions(+), 3 deletions(-)
--- a/mm/gup_test.c~mm-gup_test-fix-pin_longterm_test_read-with-highmem
+++ a/mm/gup_test.c
@@ -4,6 +4,7 @@
#include <linux/uaccess.h>
#include <linux/ktime.h>
#include <linux/debugfs.h>
+#include <linux/highmem.h>
#include "gup_test.h"
static void put_back_pages(unsigned int cmd, struct page **pages,
@@ -297,10 +298,13 @@ static inline int pin_longterm_test_read
return -EFAULT;
for (i = 0; i < pin_longterm_test_nr_pages; i++) {
- void *addr = page_to_virt(pin_longterm_test_pages[i]);
+ void *addr = kmap_local_page(pin_longterm_test_pages[i]);
+ unsigned long ret;
- if (copy_to_user((void __user *)(unsigned long)user_addr, addr,
- PAGE_SIZE))
+ ret = copy_to_user((void __user *)(unsigned long)user_addr, addr,
+ PAGE_SIZE);
+ kunmap_local(addr);
+ if (ret)
return -EFAULT;
user_addr += PAGE_SIZE;
}
_
Patches currently in -mm which might be from david@redhat.com are
reply other threads:[~2022-12-12 2:17 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221212021500.7EC58C433F0@smtp.kernel.org \
--to=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mm-commits@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=yang.lee@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.