From: Christoph Hellwig <hch@lst.de>
To: Qu Wenruo <quwenruo.btrfs@gmx.com>
Cc: Christoph Hellwig <hch@lst.de>, Chris Mason <clm@fb.com>,
Josef Bacik <josef@toxicpanda.com>,
David Sterba <dsterba@suse.com>, Qu Wenruo <wqu@suse.com>,
linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 3/3] btrfs: call rbio_orig_end_io from rmw_rbio
Date: Mon, 12 Dec 2022 08:59:20 +0100 [thread overview]
Message-ID: <20221212075920.GA11851@lst.de> (raw)
In-Reply-To: <0d509df3-4f20-7a10-ee3d-8c7474af87a8@gmx.com>
On Mon, Dec 12, 2022 at 03:39:57PM +0800, Qu Wenruo wrote:
> This changed the schema, as all work functions, rmw_rbio(), recover_rbio(),
> scrub_rbio() all follows the same return error, and let the caller to call
> rbio_orig_end_io().
>
> I'm not against the change, but it's better to change all *_rbio()
> functions to follow the same behavior instead.
I hadn't looked at the other work items, but yes it seems like they
would benefit from a similar change.
prev parent reply other threads:[~2022-12-12 7:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-12 7:06 small raid56 cleanups Christoph Hellwig
2022-12-12 7:06 ` [PATCH 1/3] btrfs: cleanup raid56_parity_write Christoph Hellwig
2022-12-12 7:34 ` Qu Wenruo
2022-12-12 7:06 ` [PATCH 2/3] btrfs: cleanup rmw_rbio Christoph Hellwig
2022-12-12 7:35 ` Qu Wenruo
2022-12-12 7:06 ` [PATCH 3/3] btrfs: call rbio_orig_end_io from rmw_rbio Christoph Hellwig
2022-12-12 7:39 ` Qu Wenruo
2022-12-12 7:59 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221212075920.GA11851@lst.de \
--to=hch@lst.de \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=quwenruo.btrfs@gmx.com \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.