From: Yu Zhang <yu.c.zhang@linux.intel.com>
To: Sean Christopherson <seanjc@google.com>
Cc: pbonzini@redhat.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] KVM: X86: Use the common definition - 'GPA_INVALID' for X86
Date: Tue, 13 Dec 2022 17:26:25 +0800 [thread overview]
Message-ID: <20221213092534.tvmmhff6rvhhpefv@linux.intel.com> (raw)
In-Reply-To: <Y5gTFPxUTXDsQb5p@google.com>
On Tue, Dec 13, 2022 at 05:52:20AM +0000, Sean Christopherson wrote:
> What if we rename GPA_INVALID to INVALID_GPA and modify _those_ users? I have
> a slight preference for INVALID_GPA, and we also have INVALID_PAGE. It'll also
> yield a smaller diff.
>
> EVMPTR_INVALID is the counter argument, but that's more of an error code than a
> semi-arbitrary value, e.g. there's also EVMPTR_MAP_PENDING.
>
> $ git grep GPA_INVALID | wc -l
> 17
> $ git grep INVALID_GPA | wc -l
> 55
>
Good point. Thanks!
B.R.
Yu
prev parent reply other threads:[~2022-12-13 9:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-09 2:36 [PATCH] KVM: X86: Use the common definition - 'GPA_INVALID' for X86 Yu Zhang
2022-12-13 5:52 ` Sean Christopherson
2022-12-13 9:26 ` Yu Zhang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221213092534.tvmmhff6rvhhpefv@linux.intel.com \
--to=yu.c.zhang@linux.intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=seanjc@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.