From: Andreas Kemnade <andreas@kemnade.info>
To: Tom Rini <trini@konsulko.com>
Cc: marex@denx.de, u-boot@lists.denx.de, t-kristo@ti.com,
kristo@kernel.org, tony@atomide.com
Subject: Re: [PATCH 2/2] musb-new: omap2430: fix musb probing in gadget mode
Date: Tue, 13 Dec 2022 09:30:39 +0100 [thread overview]
Message-ID: <20221213093039.15f9731a@aktux> (raw)
In-Reply-To: <20221212190057.GA85481@bill-the-cat>
Hi,
On Mon, 12 Dec 2022 14:00:57 -0500
Tom Rini <trini@konsulko.com> wrote:
> On Sat, Nov 26, 2022 at 11:30:10PM +0100, Andreas Kemnade wrote:
>
> > Host mode structures were accessed but not initialized
> > and gadget dm did not compile at all.
> >
> > Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> > ---
> > drivers/usb/musb-new/omap2430.c | 42 ++++++++++++++++++++-------------
> > 1 file changed, 25 insertions(+), 17 deletions(-)
>
> This breaks omap3_beagle and omap3_evm.
>
sorry, I will retest again. Probably best to add a CONFIG_DM_USB_GADGET
conditional there. That seems to be the problem there. I just thought
that nobody would care about non-CONFIG_DM_USB_GADGET and overlooked
the omap3 configs.
Regards,
Andreas
next prev parent reply other threads:[~2022-12-13 8:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-26 22:30 [PATCH 0/2] musb-new: fix omap peripheral support Andreas Kemnade
2022-11-26 22:30 ` [PATCH 1/2] omap4: make musb probeable by simple bus Andreas Kemnade
2022-12-12 21:35 ` Tom Rini
2022-11-26 22:30 ` [PATCH 2/2] musb-new: omap2430: fix musb probing in gadget mode Andreas Kemnade
2022-11-26 22:50 ` Marek Vasut
2022-12-12 19:00 ` Tom Rini
2022-12-13 8:30 ` Andreas Kemnade [this message]
2022-12-13 20:32 ` Andreas Kemnade
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221213093039.15f9731a@aktux \
--to=andreas@kemnade.info \
--cc=kristo@kernel.org \
--cc=marex@denx.de \
--cc=t-kristo@ti.com \
--cc=tony@atomide.com \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.