From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 537CDC4332F for ; Tue, 13 Dec 2022 15:06:43 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id C85FB81E4E; Tue, 13 Dec 2022 15:06:42 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org C85FB81E4E Authentication-Results: smtp1.osuosl.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Rg4CVutK X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8W5IIsvKX9Kl; Tue, 13 Dec 2022 15:06:42 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp1.osuosl.org (Postfix) with ESMTPS id 7051381E0D; Tue, 13 Dec 2022 15:06:41 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 7051381E0D Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 4F93EC0033; Tue, 13 Dec 2022 15:06:41 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138]) by lists.linuxfoundation.org (Postfix) with ESMTP id C8BD8C002D for ; Tue, 13 Dec 2022 15:06:39 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 24A3281E0D for ; Tue, 13 Dec 2022 15:06:38 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 24A3281E0D X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id SiERrigauMWe for ; Tue, 13 Dec 2022 15:06:37 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 7142D81E49 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by smtp1.osuosl.org (Postfix) with ESMTPS id 7142D81E49 for ; Tue, 13 Dec 2022 15:06:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1670943995; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=QIV38DnRgw5d8eTHW5XOjPjMdQVy/JxED3DRuC/h3DU=; b=Rg4CVutKaYIPhGJ5x524jy2+Y8lJH70UlmdoL8YSfhoEmqaAjs1hn4nMLaz4kR5734BrXU 2+X/nG4AtWWCvYe2mdnti+TK+VtOZnVs/tNKt5qxiaaOhVLaXv//hQ2jQmzZrGATqBL8d5 0fKwA4YaP4l+GO8ORH88UmBNWwDsewo= Received: from mail-lf1-f71.google.com (mail-lf1-f71.google.com [209.85.167.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-388-wlqnLZppOL634D5VlUIQGQ-1; Tue, 13 Dec 2022 10:06:31 -0500 X-MC-Unique: wlqnLZppOL634D5VlUIQGQ-1 Received: by mail-lf1-f71.google.com with SMTP id v19-20020ac25933000000b004b55ec28779so1270356lfi.8 for ; Tue, 13 Dec 2022 07:06:31 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=QIV38DnRgw5d8eTHW5XOjPjMdQVy/JxED3DRuC/h3DU=; b=vIfkuoaWIlNFMA2Mq0Ax/wIsM8RZnJNk1RU1Ae7tb7NHHQjXe0IXXPPMBpMbgybRd2 9Gz9X3lJKGIaemXet02VwhH/gK74vKLxnifK1JLA2Fpbz/+p9EfFzSR+hkPLoMAywz11 U/bzB8ko8TZndgN87Ob8+a2rEBi+7zrr4s1Bne6VPIahkFlP8bnfYfHPQi8zt0a1Lm23 v0yE0OdjKKnHPCLMahmzs5FA/YzSxrM0eePYazA32LK9qFCRoaN7GfoYLLyo8jzXOFcI XIwzTC9fPZyK2woe2XEKyFAvAL/YeVJUTWiZqeKYTDOs96ieVgRGDxlOx+XVveflzgDZ strg== X-Gm-Message-State: ANoB5plIyesE0UWZ26ndQxYy0L13OJtcSktb+nhBIEuzFMz3k5wo+cTn XOKEH5rd0RwfhDFcohboLd/MWXTrp6+053xvfFHb5e9cGSNWx8xgfpW9kBwllpxI2naLrwAF5ij 7TjWO1POa2bEoeItgbbFutiZ824bH8/If7ABUo7s+Qw== X-Received: by 2002:a05:6512:25a4:b0:4b5:87da:8b35 with SMTP id bf36-20020a05651225a400b004b587da8b35mr6373272lfb.61.1670943988393; Tue, 13 Dec 2022 07:06:28 -0800 (PST) X-Google-Smtp-Source: AA0mqf7vgbEpA6HaWdsVzT53anYyRdWOSR1rrrHGJQiAPEgrJcsGLx4k6nbiisfQn77DohtXbaWyzg== X-Received: by 2002:a05:6512:25a4:b0:4b5:87da:8b35 with SMTP id bf36-20020a05651225a400b004b587da8b35mr6373254lfb.61.1670943988122; Tue, 13 Dec 2022 07:06:28 -0800 (PST) Received: from redhat.com ([2.52.138.183]) by smtp.gmail.com with ESMTPSA id x13-20020a5d650d000000b002365730eae8sm14773wru.55.2022.12.13.07.06.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Dec 2022 07:06:27 -0800 (PST) Date: Tue, 13 Dec 2022 10:06:23 -0500 From: "Michael S. Tsirkin" To: Stefano Garzarella Subject: Re: [PATCH net-next v6] virtio/vsock: replace virtio_vsock_pkt with sk_buff Message-ID: <20221213100510-mutt-send-email-mst@kernel.org> References: <20221213072549.1997724-1-bobby.eshleman@bytedance.com> <20221213102232.n2mc3y7ietabncax@sgarzare-redhat> MIME-Version: 1.0 In-Reply-To: <20221213102232.n2mc3y7ietabncax@sgarzare-redhat> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Cc: Bobby Eshleman , Cong Wang , Stefan Hajnoczi , Jiang Wang , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, Eric Dumazet , Krasnov Arseniy , kvm@vger.kernel.org, Jakub Kicinski , Paolo Abeni , "David S. Miller" , Bobby Eshleman X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" On Tue, Dec 13, 2022 at 11:22:32AM +0100, Stefano Garzarella wrote: > > + if (len <= GOOD_COPY_LEN && !skb_queue_empty_lockless(&vvs->rx_queue)) { > > Same here. > > If there are no major changes to be made, I think the next version is the > final ones, though we are now in the merge window, so net-next is closed > [1], only RFCs can be sent [2]. > > I suggest you wait until the merge window is over (two weeks usually) to > send the next version. Nah, you never know, could be more comments. And depending on the timing I might be able to merge it. -- MST _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5CD9BC4708D for ; Tue, 13 Dec 2022 15:07:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235949AbiLMPHY (ORCPT ); Tue, 13 Dec 2022 10:07:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46706 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236049AbiLMPHU (ORCPT ); Tue, 13 Dec 2022 10:07:20 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C8C4421822 for ; Tue, 13 Dec 2022 07:06:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1670943994; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=QIV38DnRgw5d8eTHW5XOjPjMdQVy/JxED3DRuC/h3DU=; b=UksQ/OtQlN++tltqW+VEaJnx3n1SFuYCvLB7etKVN2EIhEUvPfHUzPyTUjzx63tFb03ayW AcPMD6vIHXu28p9AY/7n6dTvCfnpLij0nS4Pne/f1mV/VAEXPb/pOU1eytmEe7y3SqsOvw hwcZx3fY5sbYcWSjZOkXAPMubrFJPF4= Received: from mail-lj1-f198.google.com (mail-lj1-f198.google.com [209.85.208.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-190-5cxqpJoYMyGYgV1IcjWdDg-1; Tue, 13 Dec 2022 10:06:33 -0500 X-MC-Unique: 5cxqpJoYMyGYgV1IcjWdDg-1 Received: by mail-lj1-f198.google.com with SMTP id r26-20020a2e80da000000b00279e2a0f0e1so1006882ljg.11 for ; Tue, 13 Dec 2022 07:06:33 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=QIV38DnRgw5d8eTHW5XOjPjMdQVy/JxED3DRuC/h3DU=; b=SmqxpqBScb1rEGIF3tHlrbcO1G5sfIEylJAkN0UkU75PgIzEcYP+/7PYWm06SXxFxS J4HBONvGSfsqLeA4nAOn34QmXRlJpeAyKb2OmJ7KXlsqKn5eYpLZxA6NP9FgjGOW27vX 0Ay3a5NoCY3Dar4X/UZg67Cy2fw3GoECHmHW/QDT/F8G9dGSOcI0S5GkEf2h1u1aDB34 uKlG6imJd5e8g6b29FLDWmY4jMn26mHhkHxcvJbLB31u0iLtN/r/lJ66ELF4N4RzuHqW dbSlmT7z7KGckQFRJYqOwKUoc/e0sKRleF6J6RSRLXYhtiWuTVPRnySQMQcXUrtlQ5ra sgmA== X-Gm-Message-State: ANoB5pm3/i6ZqoUvh9VBxxyStzT0fS+vcb2ufVfxAnCeisuuX+L6UjxK WZ2nOH8uooHplIOJ4F2inMxIYWqtFppsOXVwRmrMt+ebWJ08CN3K95pcrTIXcuB681RQLqJNzCJ thuKDBY/M817M X-Received: by 2002:a05:6512:25a4:b0:4b5:87da:8b35 with SMTP id bf36-20020a05651225a400b004b587da8b35mr6373267lfb.61.1670943988392; Tue, 13 Dec 2022 07:06:28 -0800 (PST) X-Google-Smtp-Source: AA0mqf7vgbEpA6HaWdsVzT53anYyRdWOSR1rrrHGJQiAPEgrJcsGLx4k6nbiisfQn77DohtXbaWyzg== X-Received: by 2002:a05:6512:25a4:b0:4b5:87da:8b35 with SMTP id bf36-20020a05651225a400b004b587da8b35mr6373254lfb.61.1670943988122; Tue, 13 Dec 2022 07:06:28 -0800 (PST) Received: from redhat.com ([2.52.138.183]) by smtp.gmail.com with ESMTPSA id x13-20020a5d650d000000b002365730eae8sm14773wru.55.2022.12.13.07.06.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Dec 2022 07:06:27 -0800 (PST) Date: Tue, 13 Dec 2022 10:06:23 -0500 From: "Michael S. Tsirkin" To: Stefano Garzarella Cc: Bobby Eshleman , Bobby Eshleman , Cong Wang , Jiang Wang , Krasnov Arseniy , Stefan Hajnoczi , Jason Wang , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , kvm@vger.kernel.org, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v6] virtio/vsock: replace virtio_vsock_pkt with sk_buff Message-ID: <20221213100510-mutt-send-email-mst@kernel.org> References: <20221213072549.1997724-1-bobby.eshleman@bytedance.com> <20221213102232.n2mc3y7ietabncax@sgarzare-redhat> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221213102232.n2mc3y7ietabncax@sgarzare-redhat> Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Tue, Dec 13, 2022 at 11:22:32AM +0100, Stefano Garzarella wrote: > > + if (len <= GOOD_COPY_LEN && !skb_queue_empty_lockless(&vvs->rx_queue)) { > > Same here. > > If there are no major changes to be made, I think the next version is the > final ones, though we are now in the merge window, so net-next is closed > [1], only RFCs can be sent [2]. > > I suggest you wait until the merge window is over (two weeks usually) to > send the next version. Nah, you never know, could be more comments. And depending on the timing I might be able to merge it. -- MST