From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 87775C4167B for ; Tue, 13 Dec 2022 16:32:14 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p58CG-0005A0-2X; Tue, 13 Dec 2022 11:32:00 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p58CA-00059Y-PL for qemu-devel@nongnu.org; Tue, 13 Dec 2022 11:31:54 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p58C9-0002Fz-Az for qemu-devel@nongnu.org; Tue, 13 Dec 2022 11:31:54 -0500 Received: from pps.filterd (m0098421.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 2BDGBJrw009905; Tue, 13 Dec 2022 16:31:50 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=pp1; bh=5zAyglenPhujVQmpqtk1K5welcDqdD/2rVIt7ZEwD2g=; b=Mb3ojRSJGZl+MujdkCkfJ2781oEYtVFy70Jw+dLF54vvIlAviofojB4LeaQGgGeCvYuf bwTia34lgcapoxYNldjS+LqygyvFL/rVAOfFt2OybEkkszTuauMdeVglELhpfPHvB6YZ 3ClcunyIXxegMFBuB9Kgk7F/gQuBQSS5YP33pFFMVH7803c3SyKjs10zbCqsGXLv+XMP Z08TKrYJ/bqKjbwXCOBAWNz2iHBIO0f5vXEI3tdJeW3yQ6ddWu6kUtc6loXOrfe6m+7g 1SA4xf4XJNOG9UAmQsEQWK6qm8kN8QnmUYrRuATbPJUV/Su770ulp89WszJpq8CeKG2V dw== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3meu5fugpt-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 13 Dec 2022 16:31:50 +0000 Received: from m0098421.ppops.net (m0098421.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 2BDGCbm9012410; Tue, 13 Dec 2022 16:31:49 GMT Received: from ppma06ams.nl.ibm.com (66.31.33a9.ip4.static.sl-reverse.com [169.51.49.102]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3meu5fugp2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 13 Dec 2022 16:31:49 +0000 Received: from pps.filterd (ppma06ams.nl.ibm.com [127.0.0.1]) by ppma06ams.nl.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 2BD5UJxH007832; Tue, 13 Dec 2022 16:31:48 GMT Received: from smtprelay01.fra02v.mail.ibm.com ([9.218.2.227]) by ppma06ams.nl.ibm.com (PPS) with ESMTPS id 3mchcf4fda-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 13 Dec 2022 16:31:47 +0000 Received: from smtpav06.fra02v.mail.ibm.com (smtpav06.fra02v.mail.ibm.com [10.20.54.105]) by smtprelay01.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 2BDGVjil46334278 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 13 Dec 2022 16:31:45 GMT Received: from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 8135B20040; Tue, 13 Dec 2022 16:31:45 +0000 (GMT) Received: from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 37FFF20043; Tue, 13 Dec 2022 16:31:45 +0000 (GMT) Received: from heavy (unknown [9.179.23.216]) by smtpav06.fra02v.mail.ibm.com (Postfix) with ESMTPS; Tue, 13 Dec 2022 16:31:45 +0000 (GMT) Date: Tue, 13 Dec 2022 17:31:43 +0100 From: Ilya Leoshkevich To: Richard Henderson , qemu-devel@nongnu.org Cc: thuth@redhat.com Subject: Re: [PATCH v4 27/27] tcg/s390x: Avoid the constant pool in tcg_out_movi Message-ID: <20221213163143.psnvmgn4kiboaayo@heavy> References: <20221209020530.396391-1-richard.henderson@linaro.org> <20221209020530.396391-28-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221209020530.396391-28-richard.henderson@linaro.org> X-TM-AS-GCONF: 00 X-Proofpoint-GUID: F8Wc8YrTnHiM1N8Ap2IH1qyDLm_-gt6x X-Proofpoint-ORIG-GUID: CriYNqTMQi9Po0bpTpoHWaWmJ-9raYTg X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-12-13_03,2022-12-13_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 spamscore=0 lowpriorityscore=0 malwarescore=0 clxscore=1015 mlxscore=0 suspectscore=0 impostorscore=0 mlxlogscore=824 bulkscore=0 priorityscore=1501 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000 definitions=main-2212130142 Received-SPF: pass client-ip=148.163.158.5; envelope-from=iii@linux.ibm.com; helo=mx0b-001b2d01.pphosted.com X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Thu, Dec 08, 2022 at 08:05:30PM -0600, Richard Henderson wrote: > Load constants in no more than two insns, which turns > out to be faster than using the constant pool. > > Suggested-by: Ilya Leoshkevich > Signed-off-by: Richard Henderson > --- > tcg/s390x/tcg-target.c.inc | 23 +++++++++++++++++------ > 1 file changed, 17 insertions(+), 6 deletions(-) Thanks! Reviewed-by: Ilya Leoshkevich