From: Jakub Kicinski <kuba@kernel.org>
To: "Seija K." <doremylover123@gmail.com>
Cc: "Bjørn Mork" <bjorn@mork.no>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Paolo Abeni" <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: Fix for packets being rejected in the xHCI controller's ring buffer
Date: Tue, 13 Dec 2022 17:48:10 -0800 [thread overview]
Message-ID: <20221213174810.553b0196@kernel.org> (raw)
In-Reply-To: <CAA42iKxeinZ4gKfttg_K8PdRt+p-p=KjqgcbGjtxzOqn_C0F9g@mail.gmail.com>
On Tue, 13 Dec 2022 12:40:52 -0500 Seija K. wrote:
> Signed-off-by: Seija Kijin <doremylover123@gmail.com>
You need to update the Author / the From field as well as the sign-off.
>
No empty lines between tags.
> Co-Authored-By: TarAldarion <gildeap@tcd.ie>
We need sign-offs for co-authors.
Please take the "must be your real legal name" requirement seriously,
we mean it.
> diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c
> index 554d4e2a84a4..39db53a74b5a 100644
> --- a/drivers/net/usb/qmi_wwan.c
> +++ b/drivers/net/usb/qmi_wwan.c
> @@ -842,6 +842,13 @@ static int qmi_wwan_bind(struct usbnet *dev,
> struct usb_interface *intf)
> }
> dev->net->netdev_ops = &qmi_wwan_netdev_ops;
> dev->net->sysfs_groups[0] = &qmi_wwan_sysfs_attr_group;
> + /* LTE Networks don't always respect their own MTU on the receiving side;
> + * e.g. AT&T pushes 1430 MTU but still allows 1500 byte packets from
> + * far-end networks. Make the receive buffer large enough to accommodate
> + * them, and add four bytes so MTU does not equal MRU on network
> + * with 1500 MTU. Otherwise, usbnet_change_mtu() will change both.
> + */
> + dev->rx_urb_size = ETH_DATA_LEN + 4;
> err:
> return status;
The patch is still pooped, please try with git send-email.
next prev parent reply other threads:[~2022-12-14 1:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-13 17:40 [PATCH] net: Fix for packets being rejected in the xHCI controller's ring buffer Seija K.
2022-12-13 18:23 ` Daniele Palmas
2022-12-13 19:54 ` Seija K.
2022-12-14 15:18 ` Daniele Palmas
2022-12-14 21:39 ` Seija K.
2022-12-14 1:48 ` Jakub Kicinski [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-12-13 17:14 Seija K.
2022-12-13 18:40 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221213174810.553b0196@kernel.org \
--to=kuba@kernel.org \
--cc=bjorn@mork.no \
--cc=davem@davemloft.net \
--cc=doremylover123@gmail.com \
--cc=edumazet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.