From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CAB99C4332F for ; Tue, 13 Dec 2022 21:10:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236073AbiLMVKQ (ORCPT ); Tue, 13 Dec 2022 16:10:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58528 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235574AbiLMVKP (ORCPT ); Tue, 13 Dec 2022 16:10:15 -0500 Received: from mail-pf1-x431.google.com (mail-pf1-x431.google.com [IPv6:2607:f8b0:4864:20::431]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B6F7A38A6 for ; Tue, 13 Dec 2022 13:10:14 -0800 (PST) Received: by mail-pf1-x431.google.com with SMTP id 21so3095639pfw.4 for ; Tue, 13 Dec 2022 13:10:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fromorbit-com.20210112.gappssmtp.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=hadOBlhZ0LgV9SDQeQd2Aydc95qiZ+JqtdMXDKY6ntw=; b=r6mFUEuTxSGL6nPKeQaBsPNILzGlWE26+u0Qfep9+Rbkj1gUoWODw0dA8zTcoE/axO ZhTWW5bdzr7h0ECnGwjYiKr5wYztGLebHMIexWD6d7PetIa1gDmC7wm3h+ixuK/OgJCM yUHrp4FFmE7XYnykG29Hxh6DcP4+qGinpekWyhu6jYMhNay1kv+XSUCEC2r8phVP4/6d QjyXPlCkioZ092OCeLhgF1W+7OhP0ukwawqoahPFtSQ+JRxwwB5EXj0W7S7H+IENfI+7 I4dtGJjRblP3mVv0X4m6ONiBx1/BC+MtXgBUjCjYsRxQ5BHO34UxNs5oPezGwYTkQtne KqDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=hadOBlhZ0LgV9SDQeQd2Aydc95qiZ+JqtdMXDKY6ntw=; b=vyAXaYn6gfqzC0/SjZRbWmd8GFsPwEq6s1bQFgiPxX9keuvX81ddtUyqOLJveBvRI2 UIKoHSJt9QyLcDXSudB479jFrujSRviCEMqQvhjNjao5nEc755DB2Qzl/nnEdX7F4huq m5/sMnQ6x3IHmwqrIqhl2BjnWUr1EeEvSw77kiU1ocuCyl/mIRYqCX15M0j9dS0gcUsR ofMmREkiChBxf9LYSvjcE9llGKG+322Eexmpnlj1oKOynk4wd/MEzwwc6zoJB8jJUf9N 8gzXs0c25ttVVNYRCe5HFlqNPOKQ6Yt7G2QMK3fwCrK+ePb060Rnwlc56hPvi83kX4h5 h+uQ== X-Gm-Message-State: ANoB5pkTGb0+l69FfmY4l3fIbIku/ZOCdBDyq+FGjB+DA3x2tyR2/d1b g7h0ahVqCqhwxE52nK8Yfw7zBg== X-Google-Smtp-Source: AA0mqf6o0CFF/uAYsJFXasGYiQ/c9HujQxHgJ2Zih6hOCbrcPL9R5Nc0LXOypClKLFSDHHMXmZbPdw== X-Received: by 2002:a62:7983:0:b0:577:8d87:d8f4 with SMTP id u125-20020a627983000000b005778d87d8f4mr22643807pfc.34.1670965813777; Tue, 13 Dec 2022 13:10:13 -0800 (PST) Received: from dread.disaster.area (pa49-181-138-158.pa.nsw.optusnet.com.au. [49.181.138.158]) by smtp.gmail.com with ESMTPSA id a197-20020a621ace000000b00574d8d64560sm8329302pfa.175.2022.12.13.13.10.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Dec 2022 13:10:13 -0800 (PST) Received: from dave by dread.disaster.area with local (Exim 4.92.3) (envelope-from ) id 1p5CXS-0085by-SF; Wed, 14 Dec 2022 08:10:10 +1100 Date: Wed, 14 Dec 2022 08:10:10 +1100 From: Dave Chinner To: Eric Biggers Cc: Matthew Wilcox , Andrey Albershteyn , linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [RFC PATCH 02/11] pagemap: add mapping_clear_large_folios() wrapper Message-ID: <20221213211010.GX3600936@dread.disaster.area> References: <20221213172935.680971-1-aalbersh@redhat.com> <20221213172935.680971-3-aalbersh@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Tue, Dec 13, 2022 at 11:33:54AM -0800, Eric Biggers wrote: > On Tue, Dec 13, 2022 at 05:55:22PM +0000, Matthew Wilcox wrote: > > I'm happy to work with you to add support for large folios to verity. > > It hasn't been high priority for me, but I'm now working on folio support > > for bufferhead filesystems and this would probably fit in. > > I'd be very interested to know what else is needed after commit 98dc08bae678 > ("fsverity: stop using PG_error to track error status") which is upstream now, > and > https://lore.kernel.org/linux-fsdevel/20221028224539.171818-1-ebiggers@kernel.org/T/#u > ("fsverity: support for non-4K pages") which is planned for 6.3. Did you change the bio interfaces to iterate a bvec full of variable sized folios, or does it still expect a bio to only have PAGE_SIZE pages attached to it? Cheers, Dave. -- Dave Chinner david@fromorbit.com