From: Stephen Hemminger <stephen@networkplumber.org>
To: Tyler Retzlaff <roretzla@linux.microsoft.com>
Cc: dev@dpdk.org, david.marchand@redhat.com, dmitry.kozliuk@gmail.com
Subject: Re: [PATCH 1/2] eal: add missing call marking memory config complete
Date: Wed, 14 Dec 2022 08:52:39 -0800 [thread overview]
Message-ID: <20221214085239.22dd8113@hermes.local> (raw)
In-Reply-To: <1670287169-15325-2-git-send-email-roretzla@linux.microsoft.com>
On Mon, 5 Dec 2022 16:39:28 -0800
Tyler Retzlaff <roretzla@linux.microsoft.com> wrote:
> Memory configuration was not being marked as completed add the missing
> call to rte_eal_init() for Windows.
>
> Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
> ---
> lib/eal/windows/eal.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/lib/eal/windows/eal.c b/lib/eal/windows/eal.c
> index adb929a..56fadc7 100644
> --- a/lib/eal/windows/eal.c
> +++ b/lib/eal/windows/eal.c
> @@ -462,6 +462,9 @@ enum rte_proc_type_t
> */
> rte_eal_mp_remote_launch(sync_func, NULL, SKIP_MAIN);
> rte_eal_mp_wait_lcore();
> +
> + eal_mcfg_complete();
> +
> return fctret;
> }
>
Should this have a Fixes tag?
Reviewed-by: Stephen Hemminger <stephen@networkplumber.org>
next prev parent reply other threads:[~2022-12-14 16:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-06 0:39 [PATCH 0/2] enable lcores test on Windows Tyler Retzlaff
2022-12-06 0:39 ` [PATCH 1/2] eal: add missing call marking memory config complete Tyler Retzlaff
2022-12-14 16:52 ` Stephen Hemminger [this message]
2022-12-15 9:59 ` David Marchand
2022-12-15 18:07 ` Tyler Retzlaff
2022-12-06 0:39 ` [PATCH 2/2] test: enable lcores test on Windows Tyler Retzlaff
2022-12-14 16:53 ` Stephen Hemminger
2022-12-12 20:36 ` [PATCH 0/2] " Tyler Retzlaff
2022-12-16 17:16 ` [PATCH v2 0/2] Enable the lcores test on Windows instead of skipping it Tyler Retzlaff
2022-12-16 17:16 ` [PATCH v2 1/2] eal: add missing call marking memory config complete Tyler Retzlaff
2022-12-16 17:16 ` [PATCH v2 2/2] test: enable lcores test on Windows Tyler Retzlaff
2022-12-21 15:03 ` [PATCH v2 0/2] Enable the lcores test on Windows instead of skipping it David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221214085239.22dd8113@hermes.local \
--to=stephen@networkplumber.org \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=roretzla@linux.microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.