From: Christoph Hellwig <hch@lst.de>
To: Qu Wenruo <quwenruo.btrfs@gmx.com>
Cc: Christoph Hellwig <hch@lst.de>, Chris Mason <clm@fb.com>,
Josef Bacik <josef@toxicpanda.com>,
David Sterba <dsterba@suse.com>, Qu Wenruo <wqu@suse.com>,
linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 5/8] btrfs: cleanup scrub_rbio
Date: Wed, 14 Dec 2022 17:45:19 +0100 [thread overview]
Message-ID: <20221214164519.GA13110@lst.de> (raw)
In-Reply-To: <d4124214-f09b-5089-38c8-47f29a07b7d5@gmx.com>
On Wed, Dec 14, 2022 at 07:32:00AM +0800, Qu Wenruo wrote:
>
> One personal thing is, I'd prefer "_wait_" for functions that may wait for
> IOs. Thus submit_read_bios() may be better renamed to
> submit_read_wait_bios().
> (bios means it still directly handle a bio list, or just
> submit_read_wait_bio_list()?)
I can do either one.
>
> Another changes is, since there is no bio_list out of the
> <work>_read_bios(), the "bios" naming can be removed.
> Something like <work>_read_wait() may be a little better.
Sure.
next prev parent reply other threads:[~2022-12-14 16:45 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-13 8:41 small raid56 cleanups v2 Christoph Hellwig
2022-12-13 8:41 ` [PATCH 1/8] btrfs: cleanup raid56_parity_write Christoph Hellwig
2022-12-13 8:41 ` [PATCH 2/8] btrfs: cleanup rmw_rbio Christoph Hellwig
2022-12-13 8:41 ` [PATCH 3/8] btrfs: cleanup rmw_read_wait_recover Christoph Hellwig
2022-12-13 8:41 ` [PATCH 4/8] btrfs: cleanup recover_rbio Christoph Hellwig
2022-12-13 8:50 ` Qu Wenruo
2022-12-13 8:41 ` [PATCH 5/8] btrfs: cleanup scrub_rbio Christoph Hellwig
2022-12-13 8:53 ` Qu Wenruo
2022-12-13 13:24 ` Christoph Hellwig
2022-12-13 23:32 ` Qu Wenruo
2022-12-14 16:45 ` Christoph Hellwig [this message]
2022-12-13 8:41 ` [PATCH 6/8] btrfs: call rbio_orig_end_io from rmw_rbio Christoph Hellwig
2022-12-13 8:54 ` Qu Wenruo
2022-12-13 8:41 ` [PATCH 7/8] btrfs: call rbio_orig_end_io from recover_rbio Christoph Hellwig
2022-12-13 8:54 ` Qu Wenruo
2022-12-13 8:41 ` [PATCH 8/8] btrfs: call rbio_orig_end_io from scrub_rbio Christoph Hellwig
2022-12-13 8:55 ` Qu Wenruo
2022-12-13 8:59 ` small raid56 cleanups v2 Qu Wenruo
2022-12-13 13:25 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221214164519.GA13110@lst.de \
--to=hch@lst.de \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=quwenruo.btrfs@gmx.com \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.