From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8C9BC4167B for ; Thu, 15 Dec 2022 11:33:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230174AbiLOLdo (ORCPT ); Thu, 15 Dec 2022 06:33:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45612 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230172AbiLOLdN (ORCPT ); Thu, 15 Dec 2022 06:33:13 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1AEBC12AE1 for ; Thu, 15 Dec 2022 03:31:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1671103916; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=+FgMluJl7FAJ334+76uBKCfgm7N2VpXkx+EvMvxNZ0w=; b=hKT0lcA7S3FCxoJA76/naGASEpD/N4yYzj+szZeurStgTSWu7iXx55EORkYmKYUOpvDtSm Cb8bFpdl/R8G0YqqcWj9N9VMz52okVZed2J5nSuByhUIPXNK8GZ6n5v/g97UlSy4Z/4Hzx LAGhSSZYVnHfx9uK2+yiBwXg6At8Etg= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-172-nea6zczNOLOi9qWz2ao1Mw-1; Thu, 15 Dec 2022 06:31:53 -0500 X-MC-Unique: nea6zczNOLOi9qWz2ao1Mw-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 7424A382C969; Thu, 15 Dec 2022 11:31:52 +0000 (UTC) Received: from eperezma.remote.csb (unknown [10.39.193.137]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0160F2166B26; Thu, 15 Dec 2022 11:31:48 +0000 (UTC) From: =?UTF-8?q?Eugenio=20P=C3=A9rez?= To: qemu-devel@nongnu.org Cc: Liuxiangdong , Stefano Garzarella , Zhu Lingshan , Si-Wei Liu , Laurent Vivier , "Gonglei (Arei)" , Stefan Hajnoczi , Jason Wang , "Michael S. Tsirkin" , Cindy Lu , Gautam Dawar , Eli Cohen , Cornelia Huck , Paolo Bonzini , Longpeng , Harpreet Singh Anand , Parav Pandit , kvm@vger.kernel.org, virtualization@lists.linux-foundation.org Subject: [PATCH v9 00/12] ASID support in vhost-vdpa net Date: Thu, 15 Dec 2022 12:31:32 +0100 Message-Id: <20221215113144.322011-1-eperezma@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org Control VQ is the way net devices use to send changes to the device state, = like=0D the number of active queues or its mac address.=0D =0D QEMU needs to intercept this queue so it can track these changes and is abl= e to=0D migrate the device. It can do it from 1576dbb5bbc4 ("vdpa: Add x-svq to=0D NetdevVhostVDPAOptions"). However, to enable x-svq implies to shadow all Vi= rtIO=0D device's virtqueues, which will damage performance.=0D =0D This series adds address space isolation, so the device and the guest=0D communicate directly with them (passthrough) and CVQ communication is split= in=0D two: The guest communicates with qemu and qemu forwards the commands to the= =0D device.=0D =0D Comments are welcome. Thanks!=0D =0D v9:=0D - Reuse iova_range fetched from the device at initialization, instead of=0D fetch it again at vhost_vdpa_net_cvq_start.=0D - Add comment about how migration is blocked in case ASID does not met=0D our expectations.=0D - Delete warning about CVQ group not being independent.=0D =0D v8:=0D - Do not allocate iova_tree on net_init_vhost_vdpa if only CVQ is=0D shadowed. Move the iova_tree allocation to=0D vhost_vdpa_net_cvq_start and vhost_vdpa_net_cvq_stop in this case.=0D =0D v7:=0D - Never ask for number of address spaces, just react if isolation is not=0D possible.=0D - Return ASID ioctl errors instead of masking them as if the device has=0D no asid.=0D - Rename listener_shadow_vq to shadow_data=0D - Move comment on zero initailization of vhost_vdpa_dma_map above the=0D functions.=0D - Add VHOST_VDPA_GUEST_PA_ASID macro.=0D =0D v6:=0D - Do not allocate SVQ resources like file descriptors if SVQ cannot be used= .=0D - Disable shadow CVQ if the device does not support it because of net=0D features.=0D =0D v5:=0D - Move vring state in vhost_vdpa_get_vring_group instead of using a=0D parameter.=0D - Rename VHOST_VDPA_NET_CVQ_PASSTHROUGH to VHOST_VDPA_NET_DATA_ASID=0D =0D v4:=0D - Rebased on last CVQ start series, that allocated CVQ cmd bufs at load=0D - Squash vhost_vdpa_cvq_group_is_independent.=0D - Do not check for cvq index on vhost_vdpa_net_prepare, we only have one=0D that callback registered in that NetClientInfo.=0D - Add comment specifying behavior if device does not support _F_ASID=0D - Update headers to a later Linux commit to not to remove SETUP_RNG_SEED=0D =0D v3:=0D - Do not return an error but just print a warning if vdpa device initializa= tion=0D returns failure while getting AS num of VQ groups=0D - Delete extra newline=0D =0D v2:=0D - Much as commented on series [1], handle vhost_net backend through=0D NetClientInfo callbacks instead of directly.=0D - Fix not freeing SVQ properly when device does not support CVQ=0D - Add BIT_ULL missed checking device's backend feature for _F_ASID.=0D =0D Eugenio P=C3=A9rez (12):=0D vdpa: use v->shadow_vqs_enabled in vhost_vdpa_svqs_start & stop=0D vhost: set SVQ device call handler at SVQ start=0D vhost: allocate SVQ device file descriptors at device start=0D vhost: move iova_tree set to vhost_svq_start=0D vdpa: add vhost_vdpa_net_valid_svq_features=0D vdpa: request iova_range only once=0D vdpa: move SVQ vring features check to net/=0D vdpa: allocate SVQ array unconditionally=0D vdpa: add asid parameter to vhost_vdpa_dma_map/unmap=0D vdpa: store x-svq parameter in VhostVDPAState=0D vdpa: add shadow_data to vhost_vdpa=0D vdpa: always start CVQ in SVQ mode if possible=0D =0D hw/virtio/vhost-shadow-virtqueue.h | 5 +-=0D include/hw/virtio/vhost-vdpa.h | 16 ++-=0D hw/virtio/vhost-shadow-virtqueue.c | 44 ++------=0D hw/virtio/vhost-vdpa.c | 140 +++++++++++------------=0D net/vhost-vdpa.c | 174 ++++++++++++++++++++++++-----=0D hw/virtio/trace-events | 4 +-=0D 6 files changed, 237 insertions(+), 146 deletions(-)=0D =0D -- =0D 2.31.1=0D =0D