All of lore.kernel.org
 help / color / mirror / Atom feed
From: Glenn Washburn <development@efficientek.com>
To: "grub-devel @ gnu . org" <grub-devel@gnu.org>,
	Daniel Kiper <dkiper@net-space.pl>
Cc: Glenn Washburn <development@efficientek.com>
Subject: [PATCH v4 11/15] gdb: Allow user defined "onload_<modname>" command to be run when module is loaded
Date: Thu, 15 Dec 2022 23:29:34 -0600	[thread overview]
Message-ID: <20221216052938.224564-12-development@efficientek.com> (raw)
In-Reply-To: <20221216052938.224564-1-development@efficientek.com>

When debugging a module it can be desirable to set break points on code
in the module. This is difficult in GRUB because, at GDB start, the
module is not loaded and on EFI platforms its not known ahead of time
where the module will be loaded. So allow users to create an
"onload_<modname>" command which will be run when the module with name
"modname" is loaded.

Create new command "is_user_command" which sets $ret to true value if
the first argument is the name of a user-defined command.

Signed-off-by: Glenn Washburn <development@efficientek.com>
---
 grub-core/gdb_grub.in | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/grub-core/gdb_grub.in b/grub-core/gdb_grub.in
index a0c6b1ae07..8ae6344edf 100644
--- a/grub-core/gdb_grub.in
+++ b/grub-core/gdb_grub.in
@@ -9,6 +9,20 @@
 ### Lubomir Kundrak <lkudrak@skosi.org>
 ###
 
+define is_user_command
+	eval "pipe help user-defined | grep -q '%s'", $arg0
+	set $ret = ! $_shell_exitcode
+end
+document is_user_command
+	Set $ret to true value if first argument is the name of a user-defined
+	command.
+end
+
+define is_onload_command
+	eval "set $is_onload_command_name = \"onload_%s\"", $arg0
+	is_user_command $is_onload_command_name
+end
+
 define dynamic_load_kernel_exec_symbols
 	shell rm -f .remove-kernel.exec.symfile.gdb
 	shell sh gdb_helper.sh gen_kernel_exec_loadsym $arg0 >.kernel.exec.loadsym.gdb
@@ -76,8 +90,18 @@ end
 ###
 
 define load_module
+	set $load_module_onload_cmd = ""
+	is_onload_command $arg0->name
+	if $ret
+		eval "set $load_module_onload_cmd = \"onload_%s (grub_dl_t)%p\"", $arg0->name, $arg0
+	end
+
 	dump_module_sections $arg0
 	match_and_load_symbols
+
+	if ! $_streq($load_module_onload_cmd, "")
+		eval "%s", $load_module_onload_cmd
+	end
 end
 document load_module
 	Load debugging information for module given as argument.
-- 
2.34.1



  parent reply	other threads:[~2022-12-16  5:31 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-16  5:29 [PATCH v4 00/15] GDB script fixes and improvements Glenn Washburn
2022-12-16  5:29 ` [PATCH v4 01/15] gdb: Fix redirection issue in dump_module_sections Glenn Washburn
2022-12-16  5:29 ` [PATCH v4 02/15] gdb: Prevent wrapping when writing to .segments.tmp Glenn Washburn
2022-12-16  5:29 ` [PATCH v4 03/15] gdb: If no modules have been loaded, do not try to load module symbols Glenn Washburn
2022-12-16  5:29 ` [PATCH v4 04/15] gdb: Move runtime module loading into runtime_load_module Glenn Washburn
2022-12-21 14:57   ` Daniel Kiper
2022-12-16  5:29 ` [PATCH v4 05/15] gdb: Reliably load modules in runtime_load_module Glenn Washburn
2022-12-16  5:29 ` [PATCH v4 06/15] gdb: Add functions to make loading from dynamically positioned targets easier Glenn Washburn
2022-12-16  5:29 ` [PATCH v4 07/15] gdb: Remove Perl dependency for GRUB GDB script Glenn Washburn
2022-12-16  5:29 ` [PATCH v4 08/15] gdb: If enabled, print line used to load EFI kernel symbols when using gdb_grub script Glenn Washburn
2022-12-21 15:20   ` Daniel Kiper
2022-12-21 17:57     ` Glenn Washburn
2022-12-22 18:17       ` Daniel Kiper
2022-12-24  1:26         ` Glenn Washburn
2022-12-16  5:29 ` [PATCH v4 09/15] gdb: Conditionally run GDB script logic for dynamically or statically positioned GRUB Glenn Washburn
2022-12-16  5:29 ` [PATCH v4 10/15] gdb: Only connect to remote target once when first sourced Glenn Washburn
2022-12-16  5:29 ` Glenn Washburn [this message]
2022-12-16  5:29 ` [PATCH v4 12/15] gdb: Allow running user-defined commands at GRUB start Glenn Washburn
2022-12-21 15:27   ` Daniel Kiper
2022-12-21 18:19     ` Glenn Washburn
2022-12-22  6:08       ` Glenn Washburn
2022-12-22 18:21         ` Daniel Kiper
2022-12-16  5:29 ` [PATCH v4 13/15] gdb: Add extra early initialization symbols for i386-pc Glenn Washburn
2022-12-21 15:28   ` Daniel Kiper
2022-12-21 18:21     ` Glenn Washburn
2022-12-22 18:25       ` Daniel Kiper
2022-12-16  5:29 ` [PATCH v4 14/15] gdb: Add ability to turn on shell tracing for gdb helper script Glenn Washburn
2022-12-16  5:29 ` [PATCH v4 15/15] docs: Add debugging chapter to development documentation Glenn Washburn
2022-12-21  3:07   ` Jeremy Szu
2022-12-22  6:12     ` Glenn Washburn
2022-12-21 15:50   ` Daniel Kiper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221216052938.224564-12-development@efficientek.com \
    --to=development@efficientek.com \
    --cc=dkiper@net-space.pl \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.