From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D9867C4332F for ; Fri, 16 Dec 2022 11:05:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=JxhF9XxYOk1bcTNkK9E+enpLpreFXMQB6d/8wpH0Ahg=; b=1Y1AlUPhjA2ovL IAIrTsPxFhu9ovTVLkR33eXXENXOLF7f1exq2EjsKu1/xvp0kOLvr4IJwd1qJijTlkxrfK6UA74Wm aNvUGdTkjVxSOIJLj+9/0znF61VPqq1ZuvmKZK2V6lArHw3qf4emoxtaCQIwawNDioZjGPSqU+YSL 0Jfs/2Z6ZT1ULWVZMZH4IhrfEuLHgZxyU3ymUtAPb9d2OBgq/V9ZettWAXB+u51Z/NoYCw31xW5h/ uRpwQYu0e2gOW+TpEJrAdVEAjeiYDzBb+1Mk9H5ShX8SnU5mfOkd+GH2foeO3U++ElM67VIaIIY7S GRnEJbSIAeg4TMz3OxKg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p68We-00EKKB-J5; Fri, 16 Dec 2022 11:05:12 +0000 Received: from relay3-d.mail.gandi.net ([217.70.183.195]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p68Wa-00EKEA-2i for linux-mtd@lists.infradead.org; Fri, 16 Dec 2022 11:05:10 +0000 Received: (Authenticated sender: miquel.raynal@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 6F0D16000C; Fri, 16 Dec 2022 11:04:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1671188699; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cc15E8qfpFQPzwFN+i7Fa1zEjs2q/85OLqjlHHQnE8M=; b=Nu8oEEFquMqSFjafKjSo64ODymjLtgk2CilDQNoxz5RFXZ6HBFI0Fdx9q/3b91tkEJeliq DiKjEYkU+2Ju/HIOL8lI5CJ7837f4kdL16emctdHl5axyY8hg9wA9Zf/6vZurwQgwvpeTy D7IG4njrvnh0czSYUaCgmybuDbiR0nLJxw8pOJlW+CPDxhvHXglG1qVPea562DUq0GstN/ L4/rVXNeNVXKZST1wzSbEGZZOdXCooQqxX879K61h+KUEvC3BFuFO2t0KYOQVzwNiSw0a0 XE8p+rUaLccpLPaAFRxBxH4qMOqnBJWm2tyLNfV+B8m1d9S7oh7HvLP/Q4+mpQ== Date: Fri, 16 Dec 2022 12:04:56 +0100 From: Miquel Raynal To: Saravana Kannan Cc: Maxim Kiselev , Maxim Kochetkov , Thorsten Leemhuis , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, Vignesh Raghavendra , Richard Weinberger , =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , "regressions@lists.linux.dev" , Rob Herring , Krzysztof Kozlowski , Greg Kroah-Hartman , "Rafael J. Wysocki" Subject: Re: nvmem-cells regression after adding 'call of_platform_populate() for MTD partitions' Message-ID: <20221216120456.52072f9f@xps-13> In-Reply-To: References: <20221212101449.4e465181@xps-13> <20221212173730.64224599@xps-13> <20221213104643.052d4a06@xps-13> <20221213175424.79895b63@xps-13> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221216_030508_416148_F29B9DDF X-CRM114-Status: GOOD ( 46.73 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org SGkgU2FyYXZhbmEsIE1heGltLCBNYXhpbSwKCnNhcmF2YW5ha0Bnb29nbGUuY29tIHdyb3RlIG9u IFdlZCwgMTQgRGVjIDIwMjIgMTM6NTM6NTQgLTA4MDA6Cgo+IE9uIFR1ZSwgRGVjIDEzLCAyMDIy IGF0IDg6NTQgQU0gTWlxdWVsIFJheW5hbCA8bWlxdWVsLnJheW5hbEBib290bGluLmNvbT4gd3Jv dGU6Cj4gPgo+ID4gSGkgTWF4aW0sCj4gPgo+ID4gYmlndW5jbGVtYXhAZ21haWwuY29tIHdyb3Rl IG9uIFR1ZSwgMTMgRGVjIDIwMjIgMTQ6MDI6MzQgKzAzMDA6Cj4gPiAgCj4gPiA+IEkgbG9va2Vk IGNsb3NlciBhdCBjb21taXQgNjU4YzQ0NDhiYmJmIGFuZCBiY2RmMDMxNWE2MWEsIDVkYjFjMmRi YzA0YzE2IGNvbW1pdHMuCj4gPiA+IExvb2tzIGxpa2Ugd2UgaGF2ZSB0d28gZGlmZmVyZW50IGZl YXR1cmVzIGJpbmRlZCB0byBvbmUgcHJvcGVydHkgLSAiY29tcGF0aWJsZSIuCj4gPiA+Cj4gPiA+ IEZyb20gb25lIHNpZGUgaXQgaXMgdGhlIGFiaWxpdHkgdG8gZm9yd2FyZCB0aGUgc3Vibm9kZSBv ZiB0aGUgbXRkCj4gPiA+IHBhcnRpdGlvbiB0byB0aGUgbnZtZW0gc3Vic3lzdGVtICg2NThjNDQ0 OGJiYmYgYW5kIGFjNDJjNDZmOTgzZSkuCj4gPiA+IEFuZCBmcm9tIGFub3RoZXIgc2lkZSBpcyB0 aGUgYWJpbGl0eSB0byB1c2UgY3VzdG9tIGluaXRpYWxpemF0aW9uIG9mCj4gPiA+IHRoZSBtdGQg cGFydGl0aW9uIChiY2RmMDMxNWE2MWEgYW5kIDVkYjFjMmRiYzA0YzE2KS4KPiA+ID4KPiA+ID4g V2hhdCBJIG1lYW46Cj4gPiA+IEFjY29yZGluZyB0byBhYzQyYzQ2Zjk4M2UgSSBjYW4gY3JlYXRl IERUIGxpa2UgdGhpczoKPiA+ID4gIC0gfAo+ID4gPiAgICAgcGFydGl0aW9ucyB7Cj4gPiA+ICAg ICAgICAgY29tcGF0aWJsZSA9ICJmaXhlZC1wYXJ0aXRpb25zIjsKPiA+ID4gICAgICAgICAjYWRk cmVzcy1jZWxscyA9IDwxPjsKPiA+ID4gICAgICAgICAjc2l6ZS1jZWxscyA9IDwxPjsKPiA+ID4K PiA+ID4gICAgICAgICBwYXJ0aXRpb25AMCB7Cj4gPiA+ICAgICAgICAgICAgIGNvbXBhdGlibGUg PSAibnZtZW0tY2VsbHMiOwo+ID4gPiAgICAgICAgICAgICByZWcgPSA8MHg0MDAwMCAweDEwMDAw PjsKPiA+ID4gICAgICAgICAgICAgI2FkZHJlc3MtY2VsbHMgPSA8MT47Cj4gPiA+ICAgICAgICAg ICAgICNzaXplLWNlbGxzID0gPDE+Owo+ID4gPiAgICAgICAgICAgICBtYWNhZGRyX2dtYWMxOiBt YWNhZGRyX2dtYWMxQDAgewo+ID4gPiAgICAgICAgICAgICAgICAgcmVnID0gPDB4MCAweDY+Owo+ ID4gPiAgICAgICAgICAgICB9Owo+ID4gPiAgICAgICAgIH07Cj4gPiA+ICAgICB9Owo+ID4gPgo+ ID4gPgo+ID4gPiBBbmQgYWNjb3JkaW5nIHRvIDVkYjFjMmRiYzA0YzE2IEkgY2FuIGNyZWF0ZSBE VCBsaWtlIHRoaXM6Cj4gPiA+ICAtIHwKPiA+ID4gICAgIHBhcnRpdGlvbnMgewo+ID4gPiAgICAg ICAgIGNvbXBhdGlibGUgPSAiZml4ZWQtcGFydGl0aW9ucyI7Cj4gPiA+ICAgICAgICAgI2FkZHJl c3MtY2VsbHMgPSA8MT47Cj4gPiA+ICAgICAgICAgI3NpemUtY2VsbHMgPSA8MT47Cj4gPiA+Cj4g PiA+ICAgICAgICAgcGFydGl0aW9uQDAgewo+ID4gPiAgICAgICAgICAgICBjb21wYXRpYmxlID0g InUtYm9vdCxlbnYiOwo+ID4gPiAgICAgICAgICAgICByZWcgPSA8MHg0MDAwMCAweDEwMDAwPjsK PiA+ID4gICAgICAgICB9Owo+ID4gPiAgICAgfTsKPiA+ID4KPiA+ID4gQnV0IEkgY2FuIG5vdCB1 c2UgdGhlbSBib3RoLCBiZWNhdXNlIG9ubHkgb25lICJjb21wYXRpYmxlIiBwcm9wZXJ0eSBhbGxv d2VkLgo+ID4gPiBUaGlzIHdpbGwgYmUgaW5jb3JyZWN0Ogo+ID4gPiAgLSB8Cj4gPiA+ICAgICBw YXJ0aXRpb25zIHsKPiA+ID4gICAgICAgICBjb21wYXRpYmxlID0gImZpeGVkLXBhcnRpdGlvbnMi Owo+ID4gPiAgICAgICAgICNhZGRyZXNzLWNlbGxzID0gPDE+Owo+ID4gPiAgICAgICAgICNzaXpl LWNlbGxzID0gPDE+Owo+ID4gPgo+ID4gPiAgICAgICAgIHBhcnRpdGlvbkAwIHsKPiA+ID4gICAg ICAgICAgICAgY29tcGF0aWJsZSA9ICJ1LWJvb3QsZW52IjsgICMgZnJvbSBhYzQyYzQ2Zjk4M2UK PiA+ID4gICAgICAgICAgICAgY29tcGF0aWJsZSA9ICJudm1lbS1jZWxscyI7ICMgZnJvbSA1ZGIx YzJkYmMwNGMgIAo+ID4KPiA+IFdoYXQgYWJvdXQ6Cj4gPgo+ID4gICAgICAgICAgICAgICBjb21w YXRpYmxlID0gInUtYm9vdCxlbnYiLCAibnZtZW0tY2VsbHMiOwo+ID4KPiA+IGluc3RlYWQ/IHRo YXQgc2hvdWxkIGFjdHVhbGx5IHdvcmsuCj4gPiAgCj4gPiA+ICAgICAgICAgICAgIHJlZyA9IDww eDQwMDAwIDB4MTAwMDA+Owo+ID4gPiAgICAgICAgICAgICAjYWRkcmVzcy1jZWxscyA9IDwxPjsK PiA+ID4gICAgICAgICAgICAgI3NpemUtY2VsbHMgPSA8MT47Cj4gPiA+ICAgICAgICAgICAgIG1h Y2FkZHJfZ21hYzE6IG1hY2FkZHJfZ21hYzFAMCB7Cj4gPiA+ICAgICAgICAgICAgICAgICByZWcg PSA8MHgwIDB4Nj47Cj4gPiA+ICAgICAgICAgICAgIH07Cj4gPiA+ICAgICAgICAgfTsKPiA+ID4g ICAgIH07Cj4gPiA+ICAKPiA+ID4gPiBjb21wYXRpYmxlOiBEdXBsaWNhdGUgcHJvcGVydHkgbmFt ZSAgCj4gPiA+Cj4gPiA+INCy0YIsIDEzINC00LXQui4gMjAyMiDQsy4g0LIgMTI6NDYsIE1pcXVl bCBSYXluYWwgPG1pcXVlbC5yYXluYWxAYm9vdGxpbi5jb20+OiAgCj4gPiA+ID4KPiA+ID4gPiBI aSBNYXhpbSwKPiA+ID4gPgo+ID4gPiA+IGZpZG9fbWF4QGluYm94LnJ1IHdyb3RlIG9uIE1vbiwg MTIgRGVjIDIwMjIgMjA6NTc6NDkgKzAzMDA6Cj4gPiA+ID4gIAo+ID4gPiA+ID4gSGksIE1pcXVl bCEKPiA+ID4gPiA+Cj4gPiA+ID4gPiBPbiAxMi4xMi4yMDIyIDE5OjM3LCBNaXF1ZWwgUmF5bmFs IHdyb3RlOgo+ID4gPiA+ID4gIAo+ID4gPiA+ID4gPiBMZXQgbWUgdHJ5IHRvIHJlY2FwIHRoZSBz aXR1YXRpb24gZm9yIGFsbCB0aGUgcGVvcGxlIEkganVzdCBpbnZvbHZlZDoKPiA+ID4gPiA+ID4K PiA+ID4gPiA+ID4gKiBBbiBFdGhlcm5ldCBkcml2ZXIgZ2V0cyBpdHMgbWFjIGFkZHJlc3MgZnJv bSBhbiBudm1lbSBjZWxsLiBUaGUKPiA+ID4gPiA+ID4gICAgRXRoZXJuZXQgY29udHJvbGxlciBE VCBub2RlIHRoZW4gaGFzIGFuICJudm1lbS1jZWxscyIgcHJvcGVydHkKPiA+ID4gPiA+ID4gICAg cG9pbnRpbmcgdG93YXJkcyBhbiBudm1lbSBjZWxsLgo+ID4gPiA+ID4gPiAqIFRoZSBudm1lbSBj ZWxsIGNvbWVzIGZyb20gYW4gbXRkIHBhcnRpdGlvbi4KPiA+ID4gPiA+ID4gKiBUaGUgbXRkIHBh cnRpdGlvbiBpcyBmbGFnZ2VkIHdpdGggYSBwYXJ0aWN1bGFyIGNvbXBhdGlibGUKPiA+ID4gPiA+ ID4gICAgKHdoaWNoIGlzIGFsc28gbmFtZWQgIm52bWVtLWNlbGxzIikgdG8gdGVsbCB0aGUga2Vy bmVsIHRoYXQgdGhlIG5vZGUKPiA+ID4gPiA+ID4gICAgcHJvZHVjZXMgbnZtZW0gY2VsbHMuCj4g PiA+ID4gPiA+ICogVGhlIG10ZCBwYXJ0aXRpb24gaXRzZWxmIGhhcyBubyBkcml2ZXIsIGJ1dCBp cyB0aGUgY2hpbGQgbm9kZSBvZiBhCj4gPiA+ID4gPiA+ICAgICJwYXJ0aXRpb25zIiBjb250YWlu ZXIgd2hpY2ggaGFzIG9uZSAoaW4gdGhpcyBjYXNlLAo+ID4gPiA+ID4gPiAgICAiZml4ZWQtcGFy dGl0aW9ucyIsIHNlZSB0aGUgc25pcHBldCBiZWxvdykuCj4gPiA+ID4gPiA+Cj4gPiA+ID4gPiA+ IEJlY2F1c2UgdGhlICJudm1lbS1jZWxscyIgcHJvcGVydHkgb2YgdGhlIEV0aGVybmV0IG5vZGUg cG9pbnRzIGF0IHRoZQo+ID4gPiA+ID4gPiBudm1lbS1jZWxsIG5vZGUsIHRoZSBjb3JlIGNyZWF0 ZSBhIGRldmljZSBsaW5rIGJldHdlZW4gdGhlIEV0aGVybmV0Cj4gPiA+ID4gPiA+IGNvbnRyb2xs ZXIgKGNvbnN1bWVyKSBhbmQgdGhlIG10ZCBwYXJ0aXRpb24gKHByb2R1Y2VyKS4KPiA+ID4gPiA+ ID4KPiA+ID4gPiA+ID4gVGhlIGRldmljZSBsaW5rIGluIHRoaXMgY2FzZSB3aWxsIG5ldmVyIGJl IHNhdGlzZmllZCBiZWNhdXNlIG5vIGRyaXZlcgo+ID4gPiA+ID4gPiBtYXRjaGVzIHRoZSAibnZt ZW0tY2VsbHMiIGNvbXBhdGlibGUgb2YgdGhlIHBhcnRpdGlvbiBub2RlLgo+ID4gPiA+ID4gPgo+ ID4gPiA+ID4gPiBSZXZlcnRpbmcgY29tbWl0IGJjZGYwMzE1YTYxYSAoIm10ZDogY2FsbCBvZl9w bGF0Zm9ybV9wb3B1bGF0ZSgpIGZvciBNVEQKPiA+ID4gPiA+ID4gcGFydGl0aW9ucyIpIHdvdWxk IElNSE8gbm90IG1ha2UgbXVjaCBzZW5zZSwgdGhlIHByb2JsZW0gY29tZXMgZnJvbSB0aGUKPiA+ ID4gPiA+ID4gZGV2aWNlIGxpbmsgc2lkZSBhbmQgZXZlbiB0aGVyZSwgdGhlcmUgaXMgbm90aGlu ZyByZWFsbHkgIndyb25nIiwKPiA+ID4gPiA+ID4gYmVjYXVzZSBJIHJlYWxseSBleHBlY3QgdGhl IG10ZCBkZXZpY2UgdG8gYmUgcmVhZHkgYmVmb3JlIHRoZQo+ID4gPiA+ID4gPiBFdGhlcm5ldCBj b250cm9sbGVyIHByb2JlLCB0aGUgZGV2aWNlIGxpbmsgaXMgbGVnaXRpbWF0ZS4KPiA+ID4gPiA+ ID4KPiA+ID4gPiA+ID4gU28gSSB3b3VsZCBsaWtlIHRvIGV4cGxvcmUgb3RoZXIgYWx0ZXJuYXRp dmVzLiBIZXJlIGFyZSBhIGJ1bmNoIG9mCj4gPiA+ID4gPiA+IGlkZWFzLCBidXQgSSdtIG9wZW46 ICAKPiA+ID4gPiA+Cj4gPiA+ID4gPiBIb3cgYWJvdXQgdG8gY3JlYXRlIHNpbXBsZSBkcml2ZXIg d2l0aCBjb21wYXRpYmxlPSJudm1lbS1jZWxsIiBhbmQgdG8gbW92ZSBhbGwgdGhlIHN1ZmYgZnJv bSBtYWluIG10ZCBkcml2ZXIgd2hpY2ggc2VydmVzIG52bWVtLWNlbGwgdG8gdGhlIHByb2JlIGZ1 bmN0aW9uPyAgCj4gPiA+ID4KPiA+ID4gPiBUaGlzIGlzIHByb2JhYmx5IHdvcnRoIHRoZSB0cnkg YnV0IEkgZG91YnQgeW91IGNhbiBtYWtlIGl0IHdvcmsgd2l0aG91dAo+ID4gPiA+IHJlZ3Jlc3Np b25zIGJlY2F1c2UgSUlSQyB0aGUgbnZtZW0gcmVnaXN0cmF0aW9uIGhhcHBlbnMgbm8gbWF0dGVy IHRoZQo+ID4gPiA+IGNvbXBhdGlibGUgKG5vdCBtZW50aW9uaW5nIHRoZSB1c2VyLW90cCBhbmQg ZmFjdG9yeS1vdHAgY2FzZXMpLiBZb3UgY2FuCj4gPiA+ID4gZGVmaW5pdGVseSB0cnkgdGhpcyBv dXQgaWYgeW91IHRoaW5rIHlvdSBjYW4gY29tZSB1cCB3aXRoIHNvbWV0aGluZwo+ID4gPiA+IHRo b3VnaC4KPiA+ID4gPgo+ID4gPiA+IEJ1dCBJIHdvdWxkIGxpa2UgdG8gaGVhciBmcm9tIHRoZSBk ZXZpY2UtbGluayBndXJ1cyA6KSBiZWNhdXNlIGV2ZW4gaWYKPiA+ID4gPiB3ZSBmaXggbXRkIHdp dGggYSAidHJpY2siIGxpa2UgYWJvdmUsIEkgZ3Vlc3Mgd2UnbGwgdmVyeSBsaWtlbHkgZmluZAo+ ID4gPiA+IG90aGVyIGNvcm5lciBjYXNlcyBsaWtlIHRoYXQgYW5kIEkgYW0gaW50ZXJlc3RlZCBp biB1bmRlcnN0YW5kaW5nIHRoZQo+ID4gPiA+IHJhdGlvbmFsZSBvZiB3aGF0IGNvdWxkIGJlIGEg cHJvcGVyIGZpeC4KPiA+ID4gPiAgCj4gCj4gUmVzcG9uZGluZyB0byB0aGUgd2hvbGUgdGhyZWFk Lgo+IAo+IEknbSBnb2luZyBieSBNaXF1ZWwncyBmaXJzdCBlbWFpbCBpbiB3aGljaCBoZSBjYydl ZCBtZSBhbmQgaGF2ZW4ndAo+IGFjdHVhbGx5IGxvb2tlZCBhdCB0aGUgbXRkIGNvZGUuIENvdXBs ZSBvZiBjb21tZW50czoKPiAKPiBJbmRlcGVuZGVudCBvZiBtdGQvbnZtZW0tY2VsbCwgSSBnZW5l cmFsbHkgZnJvd24gb24gaGF2aW5nIGEKPiBjb21wYXRpYmxlIHN0cmluZyBmb3IgYSBjaGlsZCBu b2RlIHRoYXQgeW91IGRvbid0IHRyZWF0IGFzIGEgZGV2aWNlLgo+IEV2ZW4gbW9yZSBzbyBpZiB5 b3UgYWN0dWFsbHkgY3JlYXRlIGEgc3RydWN0IGRldmljZSBmb3IgaXQgYW5kIHRoZW4KPiBkb24n dCBkbyBhbnl0aGluZyBlbHNlIHdpdGggaXQuIFRoYXQncyBqdXN0IGEgd2FzdGUgb2YgbWVtb3J5 LiBTbywgaW4KPiBnZW5lcmFsIHRyeSB0byBhdm9pZCB0aGF0IGluIHRoZSBmdXR1cmUgaWYgeW91 IGNhbi4KCkFncmVlZCwgaXQgZGlkbid0IHRyaWdnZXJlZCBhbnkgd2FybmluZ3MgaW4gbXkgaGVh ZCBpbiB0aGUgZmlyc3QgcGxhY2UsCnNvcnJ5IGFib3V0IHRoYXQuCgo+IEFsc28sIHRoZXJlIGFy ZSBmbGFncyB0aGUgcGFyZW50IGRldmljZSdzIGRyaXZlciBjYW4gc2V0IHRoYXQnbGwgdGVsbAo+ IGZ3X2Rldmxpbmsgbm90IHRvIHRyZWF0IGEgc3BlY2lmaWMgRFQgbm9kZSBhcyBhIHJlYWwgZGV2 aWNlLiBTbywgaWYgd2UKPiByZWFsbHkgbmVlZCB0aGF0IEknbGwgZGlnIHVwIGFuZCBzdWdnZXN0 IGEgZml4LgoKSW50ZXJlc3RpbmcsIHRoYXQgd291bGQgaW5kZWVkIHZlcnkgbGlrZWx5IGZpeCBp dC4KCj4gTGFzdGx5IGFuZCBtb3JlIGltcG9ydGFudGx5LCBJJ3ZlIGEgc2VyaWVzWzFdIHRoYXQg c3RvcHMgZGVwZW5kaW5nIG9uCj4gdGhlIGNvbXBhdGlibGUgcHJvcGVydHkgZm9yIGZ3X2Rldmxp bmsgdG8gd29yay4gU28gaXQgc2hvdWxkIGJlCj4gc21hcnRlciB0aGFuIGl0IGlzIHRvZGF5LiBC dXQgdGhhdCBzZXJpZXMgaGFzIGtub3duIGJ1Z3MgZm9yIHdoaWNoIEkKPiBnYXZlIHRlc3QgZml4 ZXMgaW4gdGhhdCB0aHJlYWQuIEkgcGxhbiB0byBtYWtlIGEgdjIgb2YgdGhhdCBzZXJpZXMKPiB3 aXRoIHRoYXQgZml4IGFuZCBJJ20gZXhwZWN0aW5nIGl0J2xsIGZpeCBhIGJ1bmNoIG9mIGZ3X2Rl dmxpbmsKPiBpc3N1ZXMuCj4gCj4gRmVlbCBmcmVlIHRvIGdpdmUgdjEgKyBzcXVhc2hpbmcgdGhl IGZpeGVzIGEgc2hvdCBpZiB5b3UgYXJlIGV4Y2l0ZWQKPiB0byB0cnkgaXQuIE90aGVyd2lzZSwg SSdsbCB0cnkgbXkgYmVzdCB0byBnZXQgYXJvdW5kIHRvIGl0IHRoaXMgd2Vlawo+IChraW5kYSBz d2FtcGVkIHRob3VnaCArIGhvbGlkYXlzIGNvbWluZyB1cCwgc28gbm8gcHJvbWlzZXMpLgoKQ2Fu IHlvdSBwbGVhc2UgaW5jbHVkZSB1cyBpbiB5b3VyIG5leHQgc3VibWlzc2lvbj8KKiBNYXhpbSBL aXNlbGV2IDxiaWd1bmNsZW1heEBnbWFpbC5jb20+CiogTWF4aW0gS29jaGV0a292IDxmaWRvX21h eEBpbmJveC5ydT4KKiBNaXF1ZWwgUmF5bmFsIDxtaXF1ZWwucmF5bmFsQGJvb3RsaW4uY29tPgoK PiBbMV0gLSBodHRwczovL2xvcmUua2VybmVsLm9yZy9sa21sLzIwMjIwODEwMDYwMDQwLjMyMTY5 Ny0xLXNhcmF2YW5ha0Bnb29nbGUuY29tLwoKTWF4aW0sIGFueSBjaGFuY2UgeW91IGdpdmUgdGhp cyBhIHRyeT8KClRoYW5rcywKTWlxdcOobAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCkxpbnV4IE1URCBkaXNjdXNzaW9uIG1haWxpbmcgbGlz dApodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LW10ZC8K From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mslow1.mail.gandi.net (mslow1.mail.gandi.net [217.70.178.240]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CF67A1FA4 for ; Fri, 16 Dec 2022 11:16:59 +0000 (UTC) Received: from relay3-d.mail.gandi.net (unknown [217.70.183.195]) by mslow1.mail.gandi.net (Postfix) with ESMTP id 16CEACDEF5 for ; Fri, 16 Dec 2022 11:05:08 +0000 (UTC) Received: (Authenticated sender: miquel.raynal@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 6F0D16000C; Fri, 16 Dec 2022 11:04:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1671188699; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cc15E8qfpFQPzwFN+i7Fa1zEjs2q/85OLqjlHHQnE8M=; b=Nu8oEEFquMqSFjafKjSo64ODymjLtgk2CilDQNoxz5RFXZ6HBFI0Fdx9q/3b91tkEJeliq DiKjEYkU+2Ju/HIOL8lI5CJ7837f4kdL16emctdHl5axyY8hg9wA9Zf/6vZurwQgwvpeTy D7IG4njrvnh0czSYUaCgmybuDbiR0nLJxw8pOJlW+CPDxhvHXglG1qVPea562DUq0GstN/ L4/rVXNeNVXKZST1wzSbEGZZOdXCooQqxX879K61h+KUEvC3BFuFO2t0KYOQVzwNiSw0a0 XE8p+rUaLccpLPaAFRxBxH4qMOqnBJWm2tyLNfV+B8m1d9S7oh7HvLP/Q4+mpQ== Date: Fri, 16 Dec 2022 12:04:56 +0100 From: Miquel Raynal To: Saravana Kannan Cc: Maxim Kiselev , Maxim Kochetkov , Thorsten Leemhuis , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, Vignesh Raghavendra , Richard Weinberger , =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , "regressions@lists.linux.dev" , Rob Herring , Krzysztof Kozlowski , Greg Kroah-Hartman , "Rafael J. Wysocki" Subject: Re: nvmem-cells regression after adding 'call of_platform_populate() for MTD partitions' Message-ID: <20221216120456.52072f9f@xps-13> In-Reply-To: References: <20221212101449.4e465181@xps-13> <20221212173730.64224599@xps-13> <20221213104643.052d4a06@xps-13> <20221213175424.79895b63@xps-13> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: regressions@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hi Saravana, Maxim, Maxim, saravanak@google.com wrote on Wed, 14 Dec 2022 13:53:54 -0800: > On Tue, Dec 13, 2022 at 8:54 AM Miquel Raynal = wrote: > > > > Hi Maxim, > > > > bigunclemax@gmail.com wrote on Tue, 13 Dec 2022 14:02:34 +0300: > > =20 > > > I looked closer at commit 658c4448bbbf and bcdf0315a61a, 5db1c2dbc04c= 16 commits. > > > Looks like we have two different features binded to one property - "c= ompatible". > > > > > > From one side it is the ability to forward the subnode of the mtd > > > partition to the nvmem subsystem (658c4448bbbf and ac42c46f983e). > > > And from another side is the ability to use custom initialization of > > > the mtd partition (bcdf0315a61a and 5db1c2dbc04c16). > > > > > > What I mean: > > > According to ac42c46f983e I can create DT like this: > > > - | > > > partitions { > > > compatible =3D "fixed-partitions"; > > > #address-cells =3D <1>; > > > #size-cells =3D <1>; > > > > > > partition@0 { > > > compatible =3D "nvmem-cells"; > > > reg =3D <0x40000 0x10000>; > > > #address-cells =3D <1>; > > > #size-cells =3D <1>; > > > macaddr_gmac1: macaddr_gmac1@0 { > > > reg =3D <0x0 0x6>; > > > }; > > > }; > > > }; > > > > > > > > > And according to 5db1c2dbc04c16 I can create DT like this: > > > - | > > > partitions { > > > compatible =3D "fixed-partitions"; > > > #address-cells =3D <1>; > > > #size-cells =3D <1>; > > > > > > partition@0 { > > > compatible =3D "u-boot,env"; > > > reg =3D <0x40000 0x10000>; > > > }; > > > }; > > > > > > But I can not use them both, because only one "compatible" property a= llowed. > > > This will be incorrect: > > > - | > > > partitions { > > > compatible =3D "fixed-partitions"; > > > #address-cells =3D <1>; > > > #size-cells =3D <1>; > > > > > > partition@0 { > > > compatible =3D "u-boot,env"; # from ac42c46f983e > > > compatible =3D "nvmem-cells"; # from 5db1c2dbc04c =20 > > > > What about: > > > > compatible =3D "u-boot,env", "nvmem-cells"; > > > > instead? that should actually work. > > =20 > > > reg =3D <0x40000 0x10000>; > > > #address-cells =3D <1>; > > > #size-cells =3D <1>; > > > macaddr_gmac1: macaddr_gmac1@0 { > > > reg =3D <0x0 0x6>; > > > }; > > > }; > > > }; > > > =20 > > > > compatible: Duplicate property name =20 > > > > > > =D0=B2=D1=82, 13 =D0=B4=D0=B5=D0=BA. 2022 =D0=B3. =D0=B2 12:46, Mique= l Raynal : =20 > > > > > > > > Hi Maxim, > > > > > > > > fido_max@inbox.ru wrote on Mon, 12 Dec 2022 20:57:49 +0300: > > > > =20 > > > > > Hi, Miquel! > > > > > > > > > > On 12.12.2022 19:37, Miquel Raynal wrote: > > > > > =20 > > > > > > Let me try to recap the situation for all the people I just inv= olved: > > > > > > > > > > > > * An Ethernet driver gets its mac address from an nvmem cell. T= he > > > > > > Ethernet controller DT node then has an "nvmem-cells" proper= ty > > > > > > pointing towards an nvmem cell. > > > > > > * The nvmem cell comes from an mtd partition. > > > > > > * The mtd partition is flagged with a particular compatible > > > > > > (which is also named "nvmem-cells") to tell the kernel that = the node > > > > > > produces nvmem cells. > > > > > > * The mtd partition itself has no driver, but is the child node= of a > > > > > > "partitions" container which has one (in this case, > > > > > > "fixed-partitions", see the snippet below). > > > > > > > > > > > > Because the "nvmem-cells" property of the Ethernet node points = at the > > > > > > nvmem-cell node, the core create a device link between the Ethe= rnet > > > > > > controller (consumer) and the mtd partition (producer). > > > > > > > > > > > > The device link in this case will never be satisfied because no= driver > > > > > > matches the "nvmem-cells" compatible of the partition node. > > > > > > > > > > > > Reverting commit bcdf0315a61a ("mtd: call of_platform_populate(= ) for MTD > > > > > > partitions") would IMHO not make much sense, the problem comes = from the > > > > > > device link side and even there, there is nothing really "wrong= ", > > > > > > because I really expect the mtd device to be ready before the > > > > > > Ethernet controller probe, the device link is legitimate. > > > > > > > > > > > > So I would like to explore other alternatives. Here are a bunch= of > > > > > > ideas, but I'm open: =20 > > > > > > > > > > How about to create simple driver with compatible=3D"nvmem-cell" = and to move all the suff from main mtd driver which serves nvmem-cell to th= e probe function? =20 > > > > > > > > This is probably worth the try but I doubt you can make it work wit= hout > > > > regressions because IIRC the nvmem registration happens no matter t= he > > > > compatible (not mentioning the user-otp and factory-otp cases). You= can > > > > definitely try this out if you think you can come up with something > > > > though. > > > > > > > > But I would like to hear from the device-link gurus :) because even= if > > > > we fix mtd with a "trick" like above, I guess we'll very likely find > > > > other corner cases like that and I am interested in understanding t= he > > > > rationale of what could be a proper fix. > > > > =20 >=20 > Responding to the whole thread. >=20 > I'm going by Miquel's first email in which he cc'ed me and haven't > actually looked at the mtd code. Couple of comments: >=20 > Independent of mtd/nvmem-cell, I generally frown on having a > compatible string for a child node that you don't treat as a device. > Even more so if you actually create a struct device for it and then > don't do anything else with it. That's just a waste of memory. So, in > general try to avoid that in the future if you can. Agreed, it didn't triggered any warnings in my head in the first place, sorry about that. > Also, there are flags the parent device's driver can set that'll tell > fw_devlink not to treat a specific DT node as a real device. So, if we > really need that I'll dig up and suggest a fix. Interesting, that would indeed very likely fix it. > Lastly and more importantly, I've a series[1] that stops depending on > the compatible property for fw_devlink to work. So it should be > smarter than it is today. But that series has known bugs for which I > gave test fixes in that thread. I plan to make a v2 of that series > with that fix and I'm expecting it'll fix a bunch of fw_devlink > issues. >=20 > Feel free to give v1 + squashing the fixes a shot if you are excited > to try it. Otherwise, I'll try my best to get around to it this week > (kinda swamped though + holidays coming up, so no promises). Can you please include us in your next submission? * Maxim Kiselev * Maxim Kochetkov * Miquel Raynal > [1] - https://lore.kernel.org/lkml/20220810060040.321697-1-saravanak@goog= le.com/ Maxim, any chance you give this a try? Thanks, Miqu=C3=A8l