From: Bernhard Beschow <shentey@gmail.com>
To: qemu-devel@nongnu.org
Cc: qemu-ppc@nongnu.org,
"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
"Laurent Vivier" <laurent@vivier.eu>,
"David Gibson" <david@gibson.dropbear.id.au>,
"Michael Tokarev" <mjt@tls.msk.ru>,
qemu-trivial@nongnu.org,
"Daniel Henrique Barboza" <danielhb413@gmail.com>,
"Greg Kurz" <groug@kaod.org>, "Cédric Le Goater" <clg@kaod.org>,
"Bernhard Beschow" <shentey@gmail.com>
Subject: [PATCH 2/6] target/ppc/mmu_common: Fix table layout of "info tlb" HMP command
Date: Fri, 16 Dec 2022 15:57:05 +0100 [thread overview]
Message-ID: <20221216145709.271940-3-shentey@gmail.com> (raw)
In-Reply-To: <20221216145709.271940-1-shentey@gmail.com>
Starting with the URWX columns the columns didn't line up.
Before:
QEMU 7.2.50 monitor - type 'help' for more information
(qemu) info tlb
TLB0:
Effective Physical Size TID TS SRWX URWX WIMGE U0123
0x0000000000a80000 0x000000000105d000 4K 117 0 SR--UR-- --M-- U----
0x0000000000100000 0x000000000114e000 4K 117 0 SR--UR-- --M-- U----
<snip
TLB1:
Effective Physical Size TID TS SRWX URWX WIMGE U0123
0x00000000c0000000 0x0000000000000000 16M 0 0 SR-XU--- --M-- U----
0x00000000c1000000 0x0000000001000000 16M 0 0 SRW-U--- --M-- U----
<snip>
(qemu)
After:
QEMU 7.2.50 monitor - type 'help' for more information
(qemu) info tlb
TLB0:
Effective Physical Size TID TS SRWX URWX WIMGE U0123
0x00000000b7a00000 0x000000000fcf5000 4K 18 0 SR-- UR-- --M-- U----
0x0000000000800000 0x000000000fd73000 4K 18 0 SR-- UR-X --M-- U----
<snip>
TLB1:
Effective Physical Size TID TS SRWX URWX WIMGE U0123
0x00000000c0000000 0x0000000000000000 16M 0 0 SR-X U--- --M-- U----
0x00000000c1000000 0x0000000001000000 16M 0 0 SRW- U--- --M-- U----
<snip>
(qemu)
Signed-off-by: Bernhard Beschow <shentey@gmail.com>
---
target/ppc/mmu_common.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/ppc/mmu_common.c b/target/ppc/mmu_common.c
index 49067c05e6..8901f4d134 100644
--- a/target/ppc/mmu_common.c
+++ b/target/ppc/mmu_common.c
@@ -980,7 +980,7 @@ static void mmubooke206_dump_one_tlb(CPUPPCState *env, int tlbn, int offset,
pa = entry->mas7_3 & ~(size - 1);
qemu_printf("0x%016" PRIx64 " 0x%016" PRIx64 " %4s %-5u %1u S%c%c%c"
- "U%c%c%c %c%c%c%c%c U%c%c%c%c\n",
+ " U%c%c%c %c%c%c%c%c U%c%c%c%c\n",
(uint64_t)ea, (uint64_t)pa,
book3e_tsize_to_str[tsize],
(entry->mas1 & MAS1_TID_MASK) >> MAS1_TID_SHIFT,
--
2.39.0
next prev parent reply other threads:[~2022-12-16 14:58 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-16 14:57 [PATCH 0/6] Trivial PPC cleanups Bernhard Beschow
2022-12-16 14:57 ` [PATCH 1/6] target/ppc/mmu_common: Log which effective address had no TLB entry found Bernhard Beschow
2022-12-16 16:24 ` Philippe Mathieu-Daudé
2022-12-16 14:57 ` Bernhard Beschow [this message]
2022-12-16 16:24 ` [PATCH 2/6] target/ppc/mmu_common: Fix table layout of "info tlb" HMP command Philippe Mathieu-Daudé
2022-12-16 14:57 ` [PATCH 3/6] hw/ppc/virtex_ml507: Prefer local over global variable Bernhard Beschow
2022-12-16 15:54 ` Edgar E. Iglesias
2022-12-16 16:28 ` Philippe Mathieu-Daudé
2022-12-16 14:57 ` [PATCH 4/6] hw/ppc/e500: Prefer local variable over qdev_get_machine() Bernhard Beschow
2022-12-16 15:06 ` BALATON Zoltan
2022-12-16 16:30 ` Philippe Mathieu-Daudé
2022-12-16 14:57 ` [PATCH 5/6] hw/ppc/e500: Resolve variable shadowing Bernhard Beschow
2022-12-16 14:57 ` [PATCH 6/6] hw/ppc/e500: Move comment to more appropriate place Bernhard Beschow
2022-12-16 15:32 ` [PATCH 0/6] Trivial PPC cleanups Cédric Le Goater
2022-12-16 16:04 ` Bernhard Beschow
2022-12-16 17:50 ` Daniel Henrique Barboza
2022-12-20 22:40 ` Bernhard Beschow
2022-12-20 22:53 ` Bernhard Beschow
2022-12-21 10:27 ` Daniel Henrique Barboza
2022-12-21 17:04 ` Bernhard Beschow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221216145709.271940-3-shentey@gmail.com \
--to=shentey@gmail.com \
--cc=clg@kaod.org \
--cc=danielhb413@gmail.com \
--cc=david@gibson.dropbear.id.au \
--cc=edgar.iglesias@gmail.com \
--cc=groug@kaod.org \
--cc=laurent@vivier.eu \
--cc=mjt@tls.msk.ru \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.