From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B7C70C4332F for ; Sat, 17 Dec 2022 00:05:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=LSY/yVOjwIEsmYgoIU+c8cFkUFTVwdh7w5t/jX88XI4=; b=Gs/1HXjLOivCMz 5bCbWEJDPvzn4PL2ZBY+nnfXYduq8jqVHFkpfmztUsZoskOPMsBXoIufpAV8kvxbI51W+OZXkoLQT Yb0LJ+e0DZhbXyQkr0VCGxUhln6CUyLO6Tf+UxEfzXyMIdTHFcp5D9lehK+5VVRUK6+v6UUJ03qaa c0ncO3ex5Mr1EaXqX+J9z9rE+xfAXKOCYFKwePQF9zBsGP+vlgVSPURptf5vy5okgKt0YmnluQp9H bXkCnwp/iG0Vn0t+Mwtzk754geyJGfzGaXnSagNE/wPVcsEeu35HVSNeNDNjH+CKMvdpgjkar5/6h JNxsoRupUbjVGudBr+1w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p6Kg3-002y60-Jn; Sat, 17 Dec 2022 00:03:43 +0000 Received: from mail-oo1-f42.google.com ([209.85.161.42]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p6KaX-002tCK-2S for linux-arm-kernel@lists.infradead.org; Fri, 16 Dec 2022 23:58:02 +0000 Received: by mail-oo1-f42.google.com with SMTP id o5-20020a4a2c05000000b004ac6ea6c75dso431258ooo.8 for ; Fri, 16 Dec 2022 15:58:00 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Tcdg0k7Cdg8VA/ZRDqBYYjvgYwpOlv75s0RkGKt+5o0=; b=X4DpKb9Y9dRP+sp5a7OfRFJDojbxbhyiAeJCfHFpojdawvBpn9vCqKAlAm5nHs1+dY 8Xqz01eE6PN5LCMBTMnMfHiN+0X7vXPq+179AD6B0X/Y0vyoTorrMidQ4zAXUBoVqnFk QgunKkyJ7BvQKaBfYvJmqWSGYUyRy6D9hcTxpo5YKtFSdp4gOvD7FLu6yO18oGXQ1YYK uEZWDSYcTjHVJAb7+yJqcOte+2/Hms+k/U+agQ+Gr6/1IDIDElwzVSbpYV8WN5a3aguZ qeAOGpWK8lDj/Pw4tuBedohZPJvQV4e7zY4OEMun1slTZdlzcM77PGSJzXp6p46nqyRP l5qg== X-Gm-Message-State: AFqh2kqA53WJm/CBLsSj7CQVON2SraUWTV1kwMEeAB4FkGS2pdGWMiXL Zc6OXJwwEWdqeJo7FbUPqw== X-Google-Smtp-Source: AMrXdXuUo5wmkw7Vf1pNBI7XZd73zpyRDnv75rfYLCy7fG+J7xPYe7FpvV+HszIxkXo8ZdUyYPhOAA== X-Received: by 2002:a4a:e79a:0:b0:4a0:72aa:4ca8 with SMTP id x26-20020a4ae79a000000b004a072aa4ca8mr214132oov.7.1671235079655; Fri, 16 Dec 2022 15:57:59 -0800 (PST) Received: from robh_at_kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id j23-20020a4adf57000000b004a3543fbfbbsm1442686oou.14.2022.12.16.15.57.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Dec 2022 15:57:59 -0800 (PST) Received: (nullmailer pid 108564 invoked by uid 1000); Fri, 16 Dec 2022 23:57:58 -0000 Date: Fri, 16 Dec 2022 17:57:58 -0600 From: Rob Herring To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Cc: Philipp Zabel , David Airlie , Daniel Vetter , Krzysztof Kozlowski , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3 0/2] drm/imx/lcdc: Implement DRM driver for imx21 Message-ID: <20221216235758.GA88372-robh@kernel.org> References: <20221216175006.456831-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221216175006.456831-1-u.kleine-koenig@pengutronix.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221216_155801_208323_78D9F50B X-CRM114-Status: GOOD ( 14.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Dec 16, 2022 at 06:50:04PM +0100, Uwe Kleine-K=F6nig wrote: > Hello, > = > Changes since v2: > = > - added allOf as Krzysztof requested > - reworked driver based on Philipp's comments > (improved error handling, different selects, moved driver to a subdire= ctory, > header sorting, drm_err instead of DRM_ERROR, inlined > imx_lcdc_check_mode_change, make use of dev_err_probe()) > = > Krzysztof also pointed out that we're now having two compatibles for a > single hardware. Admittedly this is unusual, but this is the chance that > the (bad) compatible identifier imx21-fb gets deprecated. The hardware > is called LCDC and only the linux (framebuffer) driver is called imxfb. The problem is you can't have firmware (with the DTB) that supports = both. Well, you can if you want to have some firmware setting that = selects which one. Otherwise, it's really an OS problem to decide what = to use. = Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13F6BC4332F for ; Fri, 16 Dec 2022 23:58:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229851AbiLPX6X (ORCPT ); Fri, 16 Dec 2022 18:58:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39466 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230264AbiLPX6K (ORCPT ); Fri, 16 Dec 2022 18:58:10 -0500 Received: from mail-oo1-f53.google.com (mail-oo1-f53.google.com [209.85.161.53]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7666A73B30 for ; Fri, 16 Dec 2022 15:58:00 -0800 (PST) Received: by mail-oo1-f53.google.com with SMTP id e12-20020a4ab98c000000b004a081e811beso621969oop.2 for ; Fri, 16 Dec 2022 15:58:00 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Tcdg0k7Cdg8VA/ZRDqBYYjvgYwpOlv75s0RkGKt+5o0=; b=o4oHKUcynzL+BKkLY73H5WmqlJ3nA9P+dtJ5wytHSXHC2awAL3l2n4bREbfEYDQ0m6 Qk+XyDWq/1g3KkZsIxdWvW2jZWMksBQkvEI6iyucoPJ3juN1cBXZo9D3RC4LdZUvZyXW F4NQBzySiXuBx4ACdabiq1N7pA//Q4hLEjv9tv93VVyshOREzZ3bTfFGoBJPW9nmXT3y XCwrPZIoqyKerya+Rmg4L2eperjPYFmDkg7eaqWFwmKJKJO/Djs05IGGfIyk6UhqWtYm TjFwjAjNgJjMeDLnr1p8bsQA3ydCgd090maVobNIDJye3TIOuB5c1xuB0Q8lSOj31bpj p04w== X-Gm-Message-State: AFqh2koqp0knJPZ9p6ztNe9IXwVg5qOs+8FMWPSM42+fIWOIr2jWT/NY wHkIfVkRmBZvjC9Wbg3tzw== X-Google-Smtp-Source: AMrXdXuUo5wmkw7Vf1pNBI7XZd73zpyRDnv75rfYLCy7fG+J7xPYe7FpvV+HszIxkXo8ZdUyYPhOAA== X-Received: by 2002:a4a:e79a:0:b0:4a0:72aa:4ca8 with SMTP id x26-20020a4ae79a000000b004a072aa4ca8mr214132oov.7.1671235079655; Fri, 16 Dec 2022 15:57:59 -0800 (PST) Received: from robh_at_kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id j23-20020a4adf57000000b004a3543fbfbbsm1442686oou.14.2022.12.16.15.57.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Dec 2022 15:57:59 -0800 (PST) Received: (nullmailer pid 108564 invoked by uid 1000); Fri, 16 Dec 2022 23:57:58 -0000 Date: Fri, 16 Dec 2022 17:57:58 -0600 From: Rob Herring To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Cc: Philipp Zabel , David Airlie , Daniel Vetter , Krzysztof Kozlowski , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3 0/2] drm/imx/lcdc: Implement DRM driver for imx21 Message-ID: <20221216235758.GA88372-robh@kernel.org> References: <20221216175006.456831-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20221216175006.456831-1-u.kleine-koenig@pengutronix.de> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Fri, Dec 16, 2022 at 06:50:04PM +0100, Uwe Kleine-König wrote: > Hello, > > Changes since v2: > > - added allOf as Krzysztof requested > - reworked driver based on Philipp's comments > (improved error handling, different selects, moved driver to a subdirectory, > header sorting, drm_err instead of DRM_ERROR, inlined > imx_lcdc_check_mode_change, make use of dev_err_probe()) > > Krzysztof also pointed out that we're now having two compatibles for a > single hardware. Admittedly this is unusual, but this is the chance that > the (bad) compatible identifier imx21-fb gets deprecated. The hardware > is called LCDC and only the linux (framebuffer) driver is called imxfb. The problem is you can't have firmware (with the DTB) that supports both. Well, you can if you want to have some firmware setting that selects which one. Otherwise, it's really an OS problem to decide what to use. Rob From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A5A66C4332F for ; Fri, 16 Dec 2022 23:58:09 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5FC1210E643; Fri, 16 Dec 2022 23:58:07 +0000 (UTC) Received: from mail-oo1-f43.google.com (mail-oo1-f43.google.com [209.85.161.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id 352CE10E643 for ; Fri, 16 Dec 2022 23:58:01 +0000 (UTC) Received: by mail-oo1-f43.google.com with SMTP id x38-20020a4a97e9000000b004a5d69cfc90so618763ooi.6 for ; Fri, 16 Dec 2022 15:58:01 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Tcdg0k7Cdg8VA/ZRDqBYYjvgYwpOlv75s0RkGKt+5o0=; b=GJ4dmOmznSVBU+V7XXwlSh3b03Y5qFT8fnkYZ3Lk4FGG3QJMZacUQjrmiauSkY4CXE s3B8VYoK261CWDZAPpxo3dGdvpZuNq89jLLYCIi6q6Dw0e7GB2U4Byi6wAKGLuzCO0ee 8KrezGhe/NaGfDMPB1F1d9f5ynINseT3Q93Qvkm0X+asYZooGcYwnO5+AGjTtHUioC/t FYpjR2hTiCPkz6euBMaomaIG+7VQhp1bjfnwL5WdNtEgHj4jCFynUO9nP8KapZEyoj5J XNhSQpeS7kFfc5vtlxxXQoe8VWqUTzAeq67M1Vb8A4r4ye2Ntylk1HhPGeKLthl7LaLR FAjQ== X-Gm-Message-State: AFqh2kqXLOQ+dOHzkxBHwIkJ4UkOi6faOzULqNiEpZzCofvJ8dvKlkCq eFpC35xxXIpen3yrexXReA== X-Google-Smtp-Source: AMrXdXuUo5wmkw7Vf1pNBI7XZd73zpyRDnv75rfYLCy7fG+J7xPYe7FpvV+HszIxkXo8ZdUyYPhOAA== X-Received: by 2002:a4a:e79a:0:b0:4a0:72aa:4ca8 with SMTP id x26-20020a4ae79a000000b004a072aa4ca8mr214132oov.7.1671235079655; Fri, 16 Dec 2022 15:57:59 -0800 (PST) Received: from robh_at_kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id j23-20020a4adf57000000b004a3543fbfbbsm1442686oou.14.2022.12.16.15.57.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Dec 2022 15:57:59 -0800 (PST) Received: (nullmailer pid 108564 invoked by uid 1000); Fri, 16 Dec 2022 23:57:58 -0000 Date: Fri, 16 Dec 2022 17:57:58 -0600 From: Rob Herring To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Subject: Re: [PATCH v3 0/2] drm/imx/lcdc: Implement DRM driver for imx21 Message-ID: <20221216235758.GA88372-robh@kernel.org> References: <20221216175006.456831-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20221216175006.456831-1-u.kleine-koenig@pengutronix.de> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Sascha Hauer , dri-devel@lists.freedesktop.org, NXP Linux Team , Krzysztof Kozlowski , Shawn Guo , Pengutronix Kernel Team , linux-arm-kernel@lists.infradead.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Fri, Dec 16, 2022 at 06:50:04PM +0100, Uwe Kleine-König wrote: > Hello, > > Changes since v2: > > - added allOf as Krzysztof requested > - reworked driver based on Philipp's comments > (improved error handling, different selects, moved driver to a subdirectory, > header sorting, drm_err instead of DRM_ERROR, inlined > imx_lcdc_check_mode_change, make use of dev_err_probe()) > > Krzysztof also pointed out that we're now having two compatibles for a > single hardware. Admittedly this is unusual, but this is the chance that > the (bad) compatible identifier imx21-fb gets deprecated. The hardware > is called LCDC and only the linux (framebuffer) driver is called imxfb. The problem is you can't have firmware (with the DTB) that supports both. Well, you can if you want to have some firmware setting that selects which one. Otherwise, it's really an OS problem to decide what to use. Rob