From: Jens Axboe <axboe@kernel.dk>
To: io-uring@vger.kernel.org
Cc: dylany@meta.com, asml.silence@gmail.com, Jens Axboe <axboe@kernel.dk>
Subject: [PATCH 1/2] io_uring: don't use TIF_NOTIFY_SIGNAL to test for availability of task_work
Date: Sat, 17 Dec 2022 13:48:39 -0700 [thread overview]
Message-ID: <20221217204840.45213-2-axboe@kernel.dk> (raw)
In-Reply-To: <20221217204840.45213-1-axboe@kernel.dk>
Use task_work_pending() as a better test for whether we have task_work
or not, TIF_NOTIFY_SIGNAL is only valid if the any of the task_work
items had been queued with TWA_SIGNAL as the notification mechanism.
Hence task_work_pending() is a more reliable check.
Signed-off-by: Jens Axboe <axboe@kernel.dk>
---
io_uring/io_uring.h | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/io_uring/io_uring.h b/io_uring/io_uring.h
index c117e029c8dc..e9f0d41ebb99 100644
--- a/io_uring/io_uring.h
+++ b/io_uring/io_uring.h
@@ -266,8 +266,7 @@ static inline int io_run_task_work(void)
static inline bool io_task_work_pending(struct io_ring_ctx *ctx)
{
- return test_thread_flag(TIF_NOTIFY_SIGNAL) ||
- !wq_list_empty(&ctx->work_llist);
+ return task_work_pending(current) || !wq_list_empty(&ctx->work_llist);
}
static inline int io_run_task_work_ctx(struct io_ring_ctx *ctx)
--
2.35.1
next prev parent reply other threads:[~2022-12-17 20:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-17 20:48 [PATCHSET 0/2] tw/wakeup tweaks Jens Axboe
2022-12-17 20:48 ` Jens Axboe [this message]
2022-12-17 20:48 ` [PATCH 2/2] io_uring: include task_work run after scheduling in wait for events Jens Axboe
2022-12-18 3:37 ` [PATCH v2 " Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221217204840.45213-2-axboe@kernel.dk \
--to=axboe@kernel.dk \
--cc=asml.silence@gmail.com \
--cc=dylany@meta.com \
--cc=io-uring@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.