All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: bernd.kuhls@t-online.de, chrismcc@gmail.com, mmayer@broadcom.com,
	thomas.petazzoni@bootlin.com, buildroot@buildroot.org,
	fontaine.fabrice@gmail.com
Subject: Re: [Buildroot] [PATCH v2] package/libgpg-error: Disable unused files installation
Date: Tue, 20 Dec 2022 09:31:06 +0100	[thread overview]
Message-ID: <20221220083106.GD2909@scaer> (raw)
In-Reply-To: <20221219230802.2602798-1-f.fainelli@gmail.com>

Florian, All,

On 2022-12-19 15:08 -0800, Florian Fainelli spake thusly:
> Disable a number of unused files that were being installed into the root
> filesystem and thus inflating its size needlessly:
> 
> * Disable the building of documentation
> 
> * Disable support for other languages which is comprised of Common Lisp that
>   buildroot has no package for
> 
> * Only install binaries and shared/static libraries, remove libtool archive

As Baruch mentioned in his review, disabling the documentation and
removing headers and libtool archives whould already be handled by the
package infra.

So I applied your v1 instead, and makred this one rejected.

Regards,
Yann E. MORIN.

> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
> Changes in v2:
> 
> - remove header files, pkgconfig and other unnecessary files
> 
>  package/libgpg-error/libgpg-error.mk | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/package/libgpg-error/libgpg-error.mk b/package/libgpg-error/libgpg-error.mk
> index 86dea6ad2acd..6ce1f8d908de 100644
> --- a/package/libgpg-error/libgpg-error.mk
> +++ b/package/libgpg-error/libgpg-error.mk
> @@ -14,7 +14,9 @@ LIBGPG_ERROR_INSTALL_STAGING = YES
>  LIBGPG_ERROR_CONFIG_SCRIPTS = gpg-error-config
>  LIBGPG_ERROR_DEPENDENCIES = $(TARGET_NLS_DEPENDENCIES)
>  LIBGPG_ERROR_CONF_OPTS = --disable-tests \
> -		--host=$(BR2_PACKAGE_LIBGPG_ERROR_SYSCFG)
> +		--host=$(BR2_PACKAGE_LIBGPG_ERROR_SYSCFG) \
> +		--disable-languages \
> +		--disable-doc
>  
>  ifeq ($(BR2_TOOLCHAIN_HAS_THREADS),y)
>  LIBGPG_ERROR_CONF_OPTS += --enable-threads
> @@ -22,4 +24,9 @@ else
>  LIBGPG_ERROR_CONF_OPTS += --disable-threads
>  endif
>  
> +define LIBGPG_ERROR_INSTALL_TARGET_CMDS
> +	$(MAKE) -C $(@D) DESTDIR="$(TARGET_DIR)" install-exec
> +	rm -f $(TARGET_DIR)/usr/lib/libgpg-error.la
> +endef
> +
>  $(eval $(autotools-package))
> -- 
> 2.34.1
> 

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  parent reply	other threads:[~2022-12-20  8:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-19 23:08 [Buildroot] [PATCH v2] package/libgpg-error: Disable unused files installation Florian Fainelli
2022-12-20  5:30 ` Baruch Siach via buildroot
2022-12-20  8:31 ` Yann E. MORIN [this message]
2022-12-20 19:00   ` Florian Fainelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221220083106.GD2909@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=bernd.kuhls@t-online.de \
    --cc=buildroot@buildroot.org \
    --cc=chrismcc@gmail.com \
    --cc=f.fainelli@gmail.com \
    --cc=fontaine.fabrice@gmail.com \
    --cc=mmayer@broadcom.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.