From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 25085C4332F for ; Tue, 20 Dec 2022 20:01:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6WuiPzklfYiXUW53uSOpmDxC9Y07VKLoAtjjG/uBlPc=; b=nfaWla08d2eSAS XfrHf/8g9Rg7xVEQDgNlYS0DdGEZWRLBNn9+ylNvKOp0KiCKWMcyV8TPk+6Tlr459VcLGw2r3wYkS WXw2fqy/uYbKDigsLXNadw87YY7P9hH8G1nifzzwpkYD5R4vFNaLEm/GYhCz53FXc3wttwt3/XHjf DJ6Q8odTOATdZStR5TST5DuhyAzP/jHOkyeXPandzi1vxdbebSTuTmr/1jx6fFU2jSb1jL0+gZlzE yep2RjmWx5zWjGY+++ChYW2YOBHJoKIqdktaxFWbBhzfgk88Uu7hgk4sQAv2pcTdYewo9dbvZJRcw 2Joxy7v0Attexq/BnzCg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p7inP-003e69-1N; Tue, 20 Dec 2022 20:01:03 +0000 Received: from mail-oa1-f46.google.com ([209.85.160.46]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p7inK-003e1Y-Qw; Tue, 20 Dec 2022 20:01:00 +0000 Received: by mail-oa1-f46.google.com with SMTP id 586e51a60fabf-1443a16b71cso16680176fac.13; Tue, 20 Dec 2022 12:00:57 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=m7rQADosS+b3+803ppmC4G5l6lsD7QIny2Q7opGqliM=; b=EeAFLhReSWwR02DJ5tNXtCFAk73mbl5XBpRcnQeT1BK4sPa2+TVHAs1X43kTYG0No4 MWd58HtIpeOqnWYn8PzlTz/U88fWRB4zqkdv8q0coXXv+MlCiR7Exd6HWEg6paSpJ+Rf Ykw7dYOhXu/AUAmIme3q5E40OYGrUsZRcPlxc5gNK0SnAYE3ACiOiNsbRGj8w9DEo+8Y HU7M9ZlCAn06DBRT5LwItc9bToGiA6A/rRmGAkUP/72k3jAnIGu5jkDXNCk4QsTgOlwL DFJUWzwI3aFdJN2VCbEHn/awvLZhIP12mbaINXoyzcmOIiBS0yY4cDIZUoQIN7aLOqJM V5rw== X-Gm-Message-State: AFqh2kr2EideeO6S+4T8DrP14+ZtWs9HmpNFAKLl0kTPE07H8PoEFZOb 9D2bRNkvcISBEqEYtWxo3g== X-Google-Smtp-Source: AMrXdXt9sEtEqgQZhotj9V3mZGPtA+Z0Jj7vkU5jn2um2dvY3ioakyoO6JU+NnthNj+8BzLMwIRf8g== X-Received: by 2002:a05:6870:c991:b0:148:500d:c6fb with SMTP id hi17-20020a056870c99100b00148500dc6fbmr7635185oab.38.1671566456641; Tue, 20 Dec 2022 12:00:56 -0800 (PST) Received: from robh_at_kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id y29-20020a056870459d00b0011d02a3fa63sm6504888oao.14.2022.12.20.12.00.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Dec 2022 12:00:55 -0800 (PST) Received: (nullmailer pid 990414 invoked by uid 1000); Tue, 20 Dec 2022 20:00:54 -0000 Date: Tue, 20 Dec 2022 14:00:54 -0600 From: Rob Herring To: Johan Jonker Cc: heiko@sntech.de, hjc@rock-chips.com, krzysztof.kozlowski+dt@linaro.org, airlied@gmail.com, daniel@ffwll.ch, vkoul@kernel.org, kishon@kernel.org, linux-phy@lists.infradead.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 3/5] dt-bindings: phy: add port node to phy-rockchip-inno-usb2.yaml Message-ID: <20221220200054.GA953433-robh@kernel.org> References: <7f38e245-4fc0-1754-e75c-10c1e31bbd4d@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221220_120058_928336_D4FFF74C X-CRM114-Status: GOOD ( 17.68 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org On Mon, Dec 19, 2022 at 05:56:55PM +0100, Johan Jonker wrote: > On Rockchip rk3399 a port node with one endpoint can be connected > to a USB Type-C connector node. > Add a port node to the phy-rockchip-inno-usb2.yaml file. > > Signed-off-by: Johan Jonker > --- > .../devicetree/bindings/phy/phy-rockchip-inno-usb2.yaml | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.yaml b/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.yaml > index f71920082..ffc7e7560 100644 > --- a/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.yaml > +++ b/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.yaml > @@ -115,6 +115,11 @@ properties: > required: > - "#phy-cells" > > + port: > + $ref: /schemas/graph.yaml#/properties/port > + description: > + Port node with one endpoint connected to a USB Type-C connector node. > + This doesn't make sense. First, this phy has an otg and host phy, so which one is it? Second, the USB connector graph is supposed to be connected to the USB controllers, not a phy. But I guess we already have this in use, so I guess just mark it deprecated to discourage more usage.. Rob -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A71A2C4332F for ; Tue, 20 Dec 2022 20:01:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Epr8j7s2MEtsVXgEILkI5/i4h7ToJqCqPvHfzRBt4Ko=; b=KBI32UHe0G2lpD UdmEM/Z19k2b6doS0fydL1NHppa6ckPBjV/tTpMYqIDwsSE6G4iJlWeVkcs2+BLWt2cs9HaEn9xTm sSNQ2p8yW1zuHR5btxInc55JzLiFY/AB0bySA48oEDEQ6v2gWmzvGSJ0Q8yLCr2wUafhw9kLfAUCt hfSL7hPe/RPtnWb4ZHDaRzvkVm/SANwY0Tg0FDxMFXgvF0FajKRe6aPkD2p+qnMZDWZD1Q3jHs4jk PHKjg5a0Si0lyTjH8iAVpX90b2tijgK6R2dpHtTmzh3V/PHQZYp6LHEH6EMrTgOkwn0qVtm/bC5Pu 3oNny+O9arbw9oUNFwgQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p7ine-003eDr-SO; Tue, 20 Dec 2022 20:01:18 +0000 Received: from mail-oa1-f46.google.com ([209.85.160.46]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p7inK-003e1Y-Qw; Tue, 20 Dec 2022 20:01:00 +0000 Received: by mail-oa1-f46.google.com with SMTP id 586e51a60fabf-1443a16b71cso16680176fac.13; Tue, 20 Dec 2022 12:00:57 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=m7rQADosS+b3+803ppmC4G5l6lsD7QIny2Q7opGqliM=; b=EeAFLhReSWwR02DJ5tNXtCFAk73mbl5XBpRcnQeT1BK4sPa2+TVHAs1X43kTYG0No4 MWd58HtIpeOqnWYn8PzlTz/U88fWRB4zqkdv8q0coXXv+MlCiR7Exd6HWEg6paSpJ+Rf Ykw7dYOhXu/AUAmIme3q5E40OYGrUsZRcPlxc5gNK0SnAYE3ACiOiNsbRGj8w9DEo+8Y HU7M9ZlCAn06DBRT5LwItc9bToGiA6A/rRmGAkUP/72k3jAnIGu5jkDXNCk4QsTgOlwL DFJUWzwI3aFdJN2VCbEHn/awvLZhIP12mbaINXoyzcmOIiBS0yY4cDIZUoQIN7aLOqJM V5rw== X-Gm-Message-State: AFqh2kr2EideeO6S+4T8DrP14+ZtWs9HmpNFAKLl0kTPE07H8PoEFZOb 9D2bRNkvcISBEqEYtWxo3g== X-Google-Smtp-Source: AMrXdXt9sEtEqgQZhotj9V3mZGPtA+Z0Jj7vkU5jn2um2dvY3ioakyoO6JU+NnthNj+8BzLMwIRf8g== X-Received: by 2002:a05:6870:c991:b0:148:500d:c6fb with SMTP id hi17-20020a056870c99100b00148500dc6fbmr7635185oab.38.1671566456641; Tue, 20 Dec 2022 12:00:56 -0800 (PST) Received: from robh_at_kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id y29-20020a056870459d00b0011d02a3fa63sm6504888oao.14.2022.12.20.12.00.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Dec 2022 12:00:55 -0800 (PST) Received: (nullmailer pid 990414 invoked by uid 1000); Tue, 20 Dec 2022 20:00:54 -0000 Date: Tue, 20 Dec 2022 14:00:54 -0600 From: Rob Herring To: Johan Jonker Cc: heiko@sntech.de, hjc@rock-chips.com, krzysztof.kozlowski+dt@linaro.org, airlied@gmail.com, daniel@ffwll.ch, vkoul@kernel.org, kishon@kernel.org, linux-phy@lists.infradead.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 3/5] dt-bindings: phy: add port node to phy-rockchip-inno-usb2.yaml Message-ID: <20221220200054.GA953433-robh@kernel.org> References: <7f38e245-4fc0-1754-e75c-10c1e31bbd4d@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221220_120058_928336_D4FFF74C X-CRM114-Status: GOOD ( 17.68 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org On Mon, Dec 19, 2022 at 05:56:55PM +0100, Johan Jonker wrote: > On Rockchip rk3399 a port node with one endpoint can be connected > to a USB Type-C connector node. > Add a port node to the phy-rockchip-inno-usb2.yaml file. > > Signed-off-by: Johan Jonker > --- > .../devicetree/bindings/phy/phy-rockchip-inno-usb2.yaml | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.yaml b/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.yaml > index f71920082..ffc7e7560 100644 > --- a/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.yaml > +++ b/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.yaml > @@ -115,6 +115,11 @@ properties: > required: > - "#phy-cells" > > + port: > + $ref: /schemas/graph.yaml#/properties/port > + description: > + Port node with one endpoint connected to a USB Type-C connector node. > + This doesn't make sense. First, this phy has an otg and host phy, so which one is it? Second, the USB connector graph is supposed to be connected to the USB controllers, not a phy. But I guess we already have this in use, so I guess just mark it deprecated to discourage more usage.. Rob _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AAE0BC4332F for ; Tue, 20 Dec 2022 20:02:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=n3VWequlgpqwQ/y70WcXNh6GxLPdr87ETX0P3yx3spU=; b=tSESVxYisG200m Yvp0esXY7Mg9ckaEg3ZCezdBoUIM9zqpuJhOQ7LFt2A7fc8Zekbs/QiwDkeWy9yilNvrivTw8S3Gj 1blJietQXyyNb2uR0qWqfebJXRtLXvzEcFQz/2f9B6N2EgOufw9aaGFOllNP6lyFP7eQOmqmpfNTl 9cITKosFvkR8LtG3gnlm+LYTSc578O+uauhC9sddY0sRffmbgj1zj2iF3QZ9zJjQkTprvxkq+zJti 21nw01HZkMeou/zaeM91Qmfe//arnLi5ebeqIWD3PchfieqGjiouo+P4W+GKi2hLcpyrDwAtLX9YR UUBfyfV+x1I3gDaf0YZg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p7inQ-003e6V-KQ; Tue, 20 Dec 2022 20:01:05 +0000 Received: from mail-oa1-f46.google.com ([209.85.160.46]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p7inK-003e1Y-Qw; Tue, 20 Dec 2022 20:01:00 +0000 Received: by mail-oa1-f46.google.com with SMTP id 586e51a60fabf-1443a16b71cso16680176fac.13; Tue, 20 Dec 2022 12:00:57 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=m7rQADosS+b3+803ppmC4G5l6lsD7QIny2Q7opGqliM=; b=EeAFLhReSWwR02DJ5tNXtCFAk73mbl5XBpRcnQeT1BK4sPa2+TVHAs1X43kTYG0No4 MWd58HtIpeOqnWYn8PzlTz/U88fWRB4zqkdv8q0coXXv+MlCiR7Exd6HWEg6paSpJ+Rf Ykw7dYOhXu/AUAmIme3q5E40OYGrUsZRcPlxc5gNK0SnAYE3ACiOiNsbRGj8w9DEo+8Y HU7M9ZlCAn06DBRT5LwItc9bToGiA6A/rRmGAkUP/72k3jAnIGu5jkDXNCk4QsTgOlwL DFJUWzwI3aFdJN2VCbEHn/awvLZhIP12mbaINXoyzcmOIiBS0yY4cDIZUoQIN7aLOqJM V5rw== X-Gm-Message-State: AFqh2kr2EideeO6S+4T8DrP14+ZtWs9HmpNFAKLl0kTPE07H8PoEFZOb 9D2bRNkvcISBEqEYtWxo3g== X-Google-Smtp-Source: AMrXdXt9sEtEqgQZhotj9V3mZGPtA+Z0Jj7vkU5jn2um2dvY3ioakyoO6JU+NnthNj+8BzLMwIRf8g== X-Received: by 2002:a05:6870:c991:b0:148:500d:c6fb with SMTP id hi17-20020a056870c99100b00148500dc6fbmr7635185oab.38.1671566456641; Tue, 20 Dec 2022 12:00:56 -0800 (PST) Received: from robh_at_kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id y29-20020a056870459d00b0011d02a3fa63sm6504888oao.14.2022.12.20.12.00.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Dec 2022 12:00:55 -0800 (PST) Received: (nullmailer pid 990414 invoked by uid 1000); Tue, 20 Dec 2022 20:00:54 -0000 Date: Tue, 20 Dec 2022 14:00:54 -0600 From: Rob Herring To: Johan Jonker Cc: heiko@sntech.de, hjc@rock-chips.com, krzysztof.kozlowski+dt@linaro.org, airlied@gmail.com, daniel@ffwll.ch, vkoul@kernel.org, kishon@kernel.org, linux-phy@lists.infradead.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 3/5] dt-bindings: phy: add port node to phy-rockchip-inno-usb2.yaml Message-ID: <20221220200054.GA953433-robh@kernel.org> References: <7f38e245-4fc0-1754-e75c-10c1e31bbd4d@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221220_120058_928336_D4FFF74C X-CRM114-Status: GOOD ( 17.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Dec 19, 2022 at 05:56:55PM +0100, Johan Jonker wrote: > On Rockchip rk3399 a port node with one endpoint can be connected > to a USB Type-C connector node. > Add a port node to the phy-rockchip-inno-usb2.yaml file. > > Signed-off-by: Johan Jonker > --- > .../devicetree/bindings/phy/phy-rockchip-inno-usb2.yaml | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.yaml b/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.yaml > index f71920082..ffc7e7560 100644 > --- a/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.yaml > +++ b/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.yaml > @@ -115,6 +115,11 @@ properties: > required: > - "#phy-cells" > > + port: > + $ref: /schemas/graph.yaml#/properties/port > + description: > + Port node with one endpoint connected to a USB Type-C connector node. > + This doesn't make sense. First, this phy has an otg and host phy, so which one is it? Second, the USB connector graph is supposed to be connected to the USB controllers, not a phy. But I guess we already have this in use, so I guess just mark it deprecated to discourage more usage.. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7BB8DC3DA7A for ; Tue, 20 Dec 2022 20:01:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229750AbiLTUA7 (ORCPT ); Tue, 20 Dec 2022 15:00:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45322 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232195AbiLTUA6 (ORCPT ); Tue, 20 Dec 2022 15:00:58 -0500 Received: from mail-oa1-f46.google.com (mail-oa1-f46.google.com [209.85.160.46]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 874A86419; Tue, 20 Dec 2022 12:00:57 -0800 (PST) Received: by mail-oa1-f46.google.com with SMTP id 586e51a60fabf-143ffc8c2b2so16756081fac.2; Tue, 20 Dec 2022 12:00:57 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=m7rQADosS+b3+803ppmC4G5l6lsD7QIny2Q7opGqliM=; b=RlYkUyh6J0i/1QPLEukHlVydkZkTIFZ5y09riGRmumVrbJ1IZz7WkKeX4maak66OCQ Om+qqCbNZkfXMY8AThn7j3bFBfvaIx4D3FTJOoN5ZRxOw8JZs0Ce2pYzw4qdWo5AW3o3 FkXsWmNPLvJJw78lh5dtuNtOajj3KxEmla5LMmoj6xoUc+0zxJlEtyY4f2DQNqTSynET o3rIFYBmveZ30Cn/aVOJElB8sUfDxuqh4N4zmQIxZYFHGPLxloCLgJr7EYuNpbkeHhHY Lky5jpIbOJs2byDIwoT5zbTVLglerTdnpaNPNCXs9Fg3bFIM7GQ6MZ62jMLM6z3zzA8I IOAw== X-Gm-Message-State: AFqh2koZO/cpbpPxnwf1JZHbdNlu+jqC+nCiGWHB3360JMUY8QTfcuLZ zMQCf8TwZOr4IO6maH0ALsSMJcwkCg== X-Google-Smtp-Source: AMrXdXt9sEtEqgQZhotj9V3mZGPtA+Z0Jj7vkU5jn2um2dvY3ioakyoO6JU+NnthNj+8BzLMwIRf8g== X-Received: by 2002:a05:6870:c991:b0:148:500d:c6fb with SMTP id hi17-20020a056870c99100b00148500dc6fbmr7635185oab.38.1671566456641; Tue, 20 Dec 2022 12:00:56 -0800 (PST) Received: from robh_at_kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id y29-20020a056870459d00b0011d02a3fa63sm6504888oao.14.2022.12.20.12.00.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Dec 2022 12:00:55 -0800 (PST) Received: (nullmailer pid 990414 invoked by uid 1000); Tue, 20 Dec 2022 20:00:54 -0000 Date: Tue, 20 Dec 2022 14:00:54 -0600 From: Rob Herring To: Johan Jonker Cc: heiko@sntech.de, hjc@rock-chips.com, krzysztof.kozlowski+dt@linaro.org, airlied@gmail.com, daniel@ffwll.ch, vkoul@kernel.org, kishon@kernel.org, linux-phy@lists.infradead.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 3/5] dt-bindings: phy: add port node to phy-rockchip-inno-usb2.yaml Message-ID: <20221220200054.GA953433-robh@kernel.org> References: <7f38e245-4fc0-1754-e75c-10c1e31bbd4d@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, Dec 19, 2022 at 05:56:55PM +0100, Johan Jonker wrote: > On Rockchip rk3399 a port node with one endpoint can be connected > to a USB Type-C connector node. > Add a port node to the phy-rockchip-inno-usb2.yaml file. > > Signed-off-by: Johan Jonker > --- > .../devicetree/bindings/phy/phy-rockchip-inno-usb2.yaml | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.yaml b/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.yaml > index f71920082..ffc7e7560 100644 > --- a/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.yaml > +++ b/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.yaml > @@ -115,6 +115,11 @@ properties: > required: > - "#phy-cells" > > + port: > + $ref: /schemas/graph.yaml#/properties/port > + description: > + Port node with one endpoint connected to a USB Type-C connector node. > + This doesn't make sense. First, this phy has an otg and host phy, so which one is it? Second, the USB connector graph is supposed to be connected to the USB controllers, not a phy. But I guess we already have this in use, so I guess just mark it deprecated to discourage more usage.. Rob From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1319BC4332F for ; Tue, 20 Dec 2022 20:00:59 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0755C10E3E3; Tue, 20 Dec 2022 20:00:59 +0000 (UTC) Received: from mail-oa1-f52.google.com (mail-oa1-f52.google.com [209.85.160.52]) by gabe.freedesktop.org (Postfix) with ESMTPS id 77F2A10E3E3 for ; Tue, 20 Dec 2022 20:00:57 +0000 (UTC) Received: by mail-oa1-f52.google.com with SMTP id 586e51a60fabf-1445ca00781so16766083fac.1 for ; Tue, 20 Dec 2022 12:00:57 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=m7rQADosS+b3+803ppmC4G5l6lsD7QIny2Q7opGqliM=; b=eSBKSXHLqrar23DW+ZrhjllUE70Fb0CUBKJ31ou8twPMBazT2dchjd1A1HwM6thTVp FM5IQx6xg2tQ0rmMfP4x2rGqR3h2YL2Q8Xa53YB1XS0CEFFBZLxe6hlMo0VO9HUd2pZN uIh7pPx+XJK9jSRQX7VkzemetDg+FJWY2P76kmprAqiKXXyZurO+HUx7B7d2bN8hBMDM MpdBeiAXkGBsg1mM5hZS61wrQVKmiWxpyx7ZmkUGyUXvMXCz0QI0WPXjEh+QlEwbgeeX 72v7Grhew9at1k3ncYEG3lHTvahHb48NpbWliNPfB9MW8rORoK/PEI2dMX7N13OFAQZ1 4JBw== X-Gm-Message-State: AFqh2kr+T/sLeGJ6UjhU6Pzmh13WI26i8k1XK5nVWXU2UnGhRbpTZdl6 Jt+Fqc8giMdnFdYMgR6kng== X-Google-Smtp-Source: AMrXdXt9sEtEqgQZhotj9V3mZGPtA+Z0Jj7vkU5jn2um2dvY3ioakyoO6JU+NnthNj+8BzLMwIRf8g== X-Received: by 2002:a05:6870:c991:b0:148:500d:c6fb with SMTP id hi17-20020a056870c99100b00148500dc6fbmr7635185oab.38.1671566456641; Tue, 20 Dec 2022 12:00:56 -0800 (PST) Received: from robh_at_kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id y29-20020a056870459d00b0011d02a3fa63sm6504888oao.14.2022.12.20.12.00.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Dec 2022 12:00:55 -0800 (PST) Received: (nullmailer pid 990414 invoked by uid 1000); Tue, 20 Dec 2022 20:00:54 -0000 Date: Tue, 20 Dec 2022 14:00:54 -0600 From: Rob Herring To: Johan Jonker Subject: Re: [PATCH v4 3/5] dt-bindings: phy: add port node to phy-rockchip-inno-usb2.yaml Message-ID: <20221220200054.GA953433-robh@kernel.org> References: <7f38e245-4fc0-1754-e75c-10c1e31bbd4d@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kishon@kernel.org, devicetree@vger.kernel.org, krzysztof.kozlowski+dt@linaro.org, hjc@rock-chips.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, vkoul@kernel.org, linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, Dec 19, 2022 at 05:56:55PM +0100, Johan Jonker wrote: > On Rockchip rk3399 a port node with one endpoint can be connected > to a USB Type-C connector node. > Add a port node to the phy-rockchip-inno-usb2.yaml file. > > Signed-off-by: Johan Jonker > --- > .../devicetree/bindings/phy/phy-rockchip-inno-usb2.yaml | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.yaml b/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.yaml > index f71920082..ffc7e7560 100644 > --- a/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.yaml > +++ b/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.yaml > @@ -115,6 +115,11 @@ properties: > required: > - "#phy-cells" > > + port: > + $ref: /schemas/graph.yaml#/properties/port > + description: > + Port node with one endpoint connected to a USB Type-C connector node. > + This doesn't make sense. First, this phy has an otg and host phy, so which one is it? Second, the USB connector graph is supposed to be connected to the USB controllers, not a phy. But I guess we already have this in use, so I guess just mark it deprecated to discourage more usage.. Rob