From: Dave Chinner <david@fromorbit.com>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH 4/4] xfs: fix off-by-one error in xfs_btree_space_to_height
Date: Wed, 21 Dec 2022 07:39:01 +1100 [thread overview]
Message-ID: <20221220203901.GL1971568@dread.disaster.area> (raw)
In-Reply-To: <Y6HfiWz4R55RbW5G@magnolia>
On Tue, Dec 20, 2022 at 08:20:03AM -0800, Darrick J. Wong wrote:
> On Tue, Dec 20, 2022 at 08:10:08AM -0800, Darrick J. Wong wrote:
> > On Tue, Dec 20, 2022 at 04:00:01PM +1100, Dave Chinner wrote:
> > > For future consideration, we don't use maxrecs in this calculation
> > > at all - should we just pass minrecs into the function rather than
> > > an array of limits?
>
> I prefer to replace all those mxr/mnr array constructs with an explicit
> structure:
>
> struct xfs_btblock_geometry {
> uint16_t leaf_maxrecs;
> uint16_t leaf_minrecs;
>
> uint16_t node_maxrecs;
> uint16_t node_minrecs;
> };
>
> and get rid of all the mp->m_rmap_mxr[leaf != 0] stuff that slows me
> down every time I have to read it.
Yup, that sounds like a great idea - I have to work it out from
first principles every time, too.
-Dave.
--
Dave Chinner
david@fromorbit.com
prev parent reply other threads:[~2022-12-20 20:39 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-20 0:04 [PATCHSET 0/4] xfs: random fixes for 6.2, part 3 Darrick J. Wong
2022-12-20 0:05 ` [PATCH 1/4] xfs: don't assert if cmap covers imap after cycling lock Darrick J. Wong
2022-12-20 4:49 ` Dave Chinner
2022-12-20 0:05 ` [PATCH 2/4] xfs: don't stall background reclaim on inactvation Darrick J. Wong
2022-12-20 4:49 ` Dave Chinner
2022-12-20 16:28 ` Darrick J. Wong
2022-12-20 0:05 ` [PATCH 3/4] xfs: make xfs_iomap_page_ops static Darrick J. Wong
2022-12-20 4:49 ` Dave Chinner
2022-12-20 0:05 ` [PATCH 4/4] xfs: fix off-by-one error in xfs_btree_space_to_height Darrick J. Wong
2022-12-20 5:00 ` Dave Chinner
2022-12-20 16:10 ` Darrick J. Wong
2022-12-20 16:20 ` Darrick J. Wong
2022-12-20 20:39 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221220203901.GL1971568@dread.disaster.area \
--to=david@fromorbit.com \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.