From: Murphy Zhou <jencce.kernel@gmail.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] statx07: umount before un-export
Date: Wed, 21 Dec 2022 15:58:21 +0800 [thread overview]
Message-ID: <20221221075821.3786392-1-jencce.kernel@gmail.com> (raw)
We need to umount first, or there will be an umounted mountpoint
left behind.
Signed-off-by: Murphy Zhou <jencce.kernel@gmail.com>
---
testcases/kernel/syscalls/statx/statx07.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/testcases/kernel/syscalls/statx/statx07.c b/testcases/kernel/syscalls/statx/statx07.c
index e1ae36a35..8cb3e9b6d 100644
--- a/testcases/kernel/syscalls/statx/statx07.c
+++ b/testcases/kernel/syscalls/statx/statx07.c
@@ -149,6 +149,9 @@ static void setup(void)
static void cleanup(void)
{
+ if (mounted)
+ SAFE_UMOUNT(CLI_PATH);
+
if (!exported)
return;
snprintf(cmd, sizeof(cmd),
@@ -156,9 +159,6 @@ static void cleanup(void)
if (tst_system(cmd) == -1)
tst_res(TWARN | TST_ERR, "failed to clear exportfs");
-
- if (mounted)
- SAFE_UMOUNT(CLI_PATH);
}
static struct tst_test test = {
--
2.31.1
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next reply other threads:[~2022-12-21 7:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-21 7:58 Murphy Zhou [this message]
2022-12-22 9:31 ` [LTP] [PATCH] statx07: umount before un-export Richard Palethorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221221075821.3786392-1-jencce.kernel@gmail.com \
--to=jencce.kernel@gmail.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.