From: Christoph Hellwig <hch@lst.de>
To: Igor Klochko <igor.klochko@gmail.com>
Cc: hch@lst.de, iommu@lists.linux.dev, robin.murphy@arm.com,
m.szyprowski@samsung.com
Subject: Re: [PATCH] arch/arm/mm/dma-mapping.c: fix __alloc_from_pool returning a dirty buffer
Date: Fri, 23 Dec 2022 15:39:38 +0100 [thread overview]
Message-ID: <20221223143938.GA29147@lst.de> (raw)
In-Reply-To: <14dccd8c-e29a-fe93-5d4c-f0c3ff4f2430@gmail.com>
On Fri, Dec 23, 2022 at 03:15:47PM +0100, Igor Klochko wrote:
>
> Hi,
>
> A small patch for __alloc_from_pool to clean the buffer before returning.
This does look correct. The "normal" allocators seems to do the
memset through __dma_clear_buffer, but the __alloc_from_pool seems to be
missing it. Please write a proper changelog with a signoff, and
preferably a Fixes tag if you can find what introduced this. Also
the ARM code needs to go to the ARM maintainer and arm mailing list.
next prev parent reply other threads:[~2022-12-23 14:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-23 14:15 [PATCH] arch/arm/mm/dma-mapping.c: fix __alloc_from_pool returning a dirty buffer Igor Klochko
2022-12-23 14:39 ` Christoph Hellwig [this message]
2022-12-23 22:51 ` Igor Klochko
2022-12-23 22:51 ` Igor Klochko
2023-01-03 9:51 ` Russell King (Oracle)
2023-01-03 9:51 ` Russell King (Oracle)
2023-01-03 13:58 ` Robin Murphy
2023-01-03 13:58 ` Robin Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221223143938.GA29147@lst.de \
--to=hch@lst.de \
--cc=igor.klochko@gmail.com \
--cc=iommu@lists.linux.dev \
--cc=m.szyprowski@samsung.com \
--cc=robin.murphy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.