All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Lars Melin <larsm17@gmail.com>
Cc: johan@kernel.org, bjorn@mork.no, netdev@vger.kernel.org,
	linux-usb@vger.kernel.org, Matthew Garrett <mgarrett@aurora.tech>
Subject: Re: [PATCH 1/3] USB: serial: option: Add generic MDM9207 configurations
Date: Mon, 26 Dec 2022 02:08:23 +0000	[thread overview]
Message-ID: <20221226020823.GA10889@srcf.ucam.org> (raw)
In-Reply-To: <10cff30a-719d-f6b0-419c-36c552f4bc4b@gmail.com>

On Mon, Dec 26, 2022 at 08:23:34AM +0700, Lars Melin wrote:
> On 12/26/2022 03:52, Matthew Garrett wrote:
> > +	/* Qualcomm MDM9207 - 0: DIAG, 2: AT, 3: NMEA */
> > +	{ USB_DEVICE(QUALCOMM_VENDOR_ID, 0xf601),
> > +	  .driver_info = RSVD(1) | RSVD(4) | RSVD(5) },
> > +	/* Qualcomm MDM9207 - 2: DIAG, 4: AT, 5: NMEA */
> > +	{ USB_DEVICE(QUALCOMM_VENDOR_ID, 0xf622),
> > +	  .driver_info = RSVD(0) | RSVD(1) | RSVD(3) | RSVD(6) },
> 
> Please tell what the reserved interfaces are used for and why they should be
> blacklisted.

Based on the shipped Windows Qualcomm drivers I have here, for F601 
interface 1 is bound by the qcmdm driver, interface 5 is bound by a QMI 
rmnet, and interfaces 0, 2 and 3 are bound by qcser. That leaves 
interface 4 for adb. For F622, 0 and 1 are RNDIS, 3 is the qcmdm 
interface, 2, 4 and 5 are serial, and 6 is adb. I'm not sure what qcmdm 
does. What format would you like this info in?

> The generic Qualcomm driver for 05c6:f601 (which is used by at least one
> other brand/reseller) specifies that interface#1 is for USB Modem (ppp
> dial-up).

Do you have a pointer to that driver? That seems consistent with the 
Windows drivers, but I have no experience with that.

> I assume that you posses this dongle since you add support for it so you can
> easily verify that function which I assume has not been disabled in your
> version.

Yup, I can check that once I know what it's supposed to be speaking :)

  reply	other threads:[~2022-12-26  2:08 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-25 20:52 Add some USB hotspot IDs Matthew Garrett
2022-12-25 20:52 ` [PATCH 1/3] USB: serial: option: Add generic MDM9207 configurations Matthew Garrett
2022-12-26  1:23   ` Lars Melin
2022-12-26  2:08     ` Matthew Garrett [this message]
2022-12-26  2:43       ` Matthew Garrett
2022-12-26  5:38         ` Lars Melin
2022-12-25 20:52 ` [PATCH 2/3] net: usb: qmi_wwan: Add generic MDM9207 configuration Matthew Garrett
2022-12-25 20:52 ` [PATCH 3/3] USB: serial: option: Add Novatel MiFi 8800L diag endpoint Matthew Garrett

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221226020823.GA10889@srcf.ucam.org \
    --to=mjg59@srcf.ucam.org \
    --cc=bjorn@mork.no \
    --cc=johan@kernel.org \
    --cc=larsm17@gmail.com \
    --cc=linux-usb@vger.kernel.org \
    --cc=mgarrett@aurora.tech \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.