From: Stephen Hemminger <stephen@networkplumber.org>
To: Yajun Wu <yajunw@nvidia.com>
Cc: <matan@nvidia.com>, Maxime Coquelin <maxime.coquelin@redhat.com>,
"Chenbo Xia" <chenbo.xia@intel.com>,
Chengchang Tang <tangchengchang@huawei.com>, <dev@dpdk.org>,
<stable@dpdk.org>
Subject: Re: [PATCH] examples/vdpa: fix devices cleanup
Date: Mon, 26 Dec 2022 10:05:00 -0800 [thread overview]
Message-ID: <20221226100500.65cf96d0@hermes.local> (raw)
In-Reply-To: <20221226065105.2480103-1-yajunw@nvidia.com>
On Mon, 26 Dec 2022 14:51:06 +0800
Yajun Wu <yajunw@nvidia.com> wrote:
> Move rte_eal_cleanup to function vdpa_sample_quit which
> handling all example app quit.
> Otherwise rte_eal_cleanup won't be called on receiving signal
> like SIGINT(control + c).
>
> Fixes: 10aa3757 ("examples: add eal cleanup to examples")
> Cc: stable@dpdk.org
>
> Signed-off-by: Yajun Wu <yajunw@nvidia.com>
> Acked-by: Matan Azrad <matan@nvidia.com>
NAK
rte_eal_cleanup is not signal safe.
This (and several other applications) are not managing termination
signals correctly. It is not safe to call many DPDK functions
from a signal handler. Imagine the case of getting SIGINT in
the middle of a driver holding a spin lock, then calling the
close function of that driver which then acquires the same lock.
The only safe way to handle signals is to set a flag
and do the shutdown and cleanup from the main loop.
prev parent reply other threads:[~2022-12-26 18:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-26 6:51 [PATCH] examples/vdpa: fix devices cleanup Yajun Wu
2022-12-26 18:05 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221226100500.65cf96d0@hermes.local \
--to=stephen@networkplumber.org \
--cc=chenbo.xia@intel.com \
--cc=dev@dpdk.org \
--cc=matan@nvidia.com \
--cc=maxime.coquelin@redhat.com \
--cc=stable@dpdk.org \
--cc=tangchengchang@huawei.com \
--cc=yajunw@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.