From: Christoph Hellwig <hch@lst.de>
To: Keith Busch <kbusch@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>, Keith Busch <kbusch@meta.com>,
linux-block@vger.kernel.org, axboe@kernel.dk,
martin.petersen@oracle.com
Subject: Re: [PATCH] block: save user max_sectors limit
Date: Tue, 27 Dec 2022 17:53:39 +0100 [thread overview]
Message-ID: <20221227165339.GA7682@lst.de> (raw)
In-Reply-To: <Y6siCw6JFqTpsObx@kbusch-mbp>
On Tue, Dec 27, 2022 at 09:49:15AM -0700, Keith Busch wrote:
> > and drop the min_t here. Instead of working around type mismatches
> > just avoid them from the beginning..
>
> Let me just make sure I understand: you don't want BLK_DEF_MAX_SECTORS
> defined in an enum, and instead want it a 'const unsigned int'? Or
> #define?
Just make sure it's marked as unsigned, either and enum or define
works, just make sure it has the u suffix. Note that for enums recent
gccs enforce the same type over different embers, so you might have
to split it from an existing catchall enum into a separate one.
next prev parent reply other threads:[~2022-12-27 16:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-22 17:52 [PATCH] block: save user max_sectors limit Keith Busch
2022-12-23 6:00 ` Christoph Hellwig
2022-12-27 16:49 ` Keith Busch
2022-12-27 16:53 ` Christoph Hellwig [this message]
2022-12-27 2:13 ` Damien Le Moal
-- strict thread matches above, loose matches on Subject: below --
2022-12-21 16:27 Keith Busch
2022-12-22 8:22 ` kernel test robot
2022-12-22 8:32 ` kernel test robot
2022-12-22 8:40 ` Christoph Hellwig
2022-12-22 15:40 ` Keith Busch
2022-12-22 16:07 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221227165339.GA7682@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=kbusch@kernel.org \
--cc=kbusch@meta.com \
--cc=linux-block@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.