Re: [PATCH v5 3/4] event/dlb2: remove superfluous rte_memcpy

[Stephen Hemminger <stephen@networkplumber.org>]

On Wed, 28 Dec 2022 16:10:18 +0100
Morten Brørup <mb@smartsharesystems.com> wrote:

> Copying with the same src and dst address has no effect; removed to
> avoid compiler warning.
> 
> Signed-off-by: Morten Brørup <mb@smartsharesystems.com>
> 
> v5:
> * First patch in series.
> ---
>  drivers/event/dlb2/dlb2.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/event/dlb2/dlb2.c b/drivers/event/dlb2/dlb2.c
> index 60c5cd4804..03d32c779f 100644
> --- a/drivers/event/dlb2/dlb2.c
> +++ b/drivers/event/dlb2/dlb2.c
> @@ -215,7 +215,6 @@ static int
>  dlb2_hw_query_resources(struct dlb2_eventdev *dlb2)
>  {
>  	struct dlb2_hw_dev *handle = &dlb2->qm_instance;
> -	struct dlb2_hw_resource_info *dlb2_info = &handle->info;
>  	int num_ldb_ports;
>  	int ret;
>  
> @@ -277,8 +276,6 @@ dlb2_hw_query_resources(struct dlb2_eventdev *dlb2)
>  	handle->info.hw_rsrc_max.reorder_window_size =
>  		dlb2->hw_rsrc_query_results.num_hist_list_entries;
>  
> -	rte_memcpy(dlb2_info, &handle->info.hw_rsrc_max, sizeof(*dlb2_info));
> -
>  	return 0;
>  }

Please add Fixes and CC author.
Fixes: e7c9971a857a ("event/dlb2: add probe-time hardware init")
Cc: timothy.mcdaniel@intel.com


Acked-by: Stephen Hemminger <stephen@networkplumber.org>