From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Romain Naour <romain.naour@gmail.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 2/4] package/qemu: split long lines
Date: Wed, 28 Dec 2022 20:52:23 +0100 [thread overview]
Message-ID: <20221228195223.GF2498764@scaer> (raw)
In-Reply-To: <20221217153729.545952-2-romain.naour@gmail.com>
Romain, All,
On 2022-12-17 16:37 +0100, Romain Naour spake thusly:
> Split the list of dependencies to ease further addition.
>
> Signed-off-by: Romain Naour <romain.naour@gmail.com>
> ---
> package/qemu/qemu.mk | 14 ++++++++++++--
> 1 file changed, 12 insertions(+), 2 deletions(-)
>
> diff --git a/package/qemu/qemu.mk b/package/qemu/qemu.mk
> index a991d49993..e800f31e7e 100644
> --- a/package/qemu/qemu.mk
> +++ b/package/qemu/qemu.mk
> @@ -20,7 +20,12 @@ QEMU_CPE_ID_VENDOR = qemu
> # However, building is still done with configure and make as in previous versions of QEMU.
>
> # Target-qemu
> -QEMU_DEPENDENCIES = host-meson host-pkgconf libglib2 zlib pixman host-python3
> +QEMU_DEPENDENCIES = host-meson \
I like that the first item is also on its own line, and this is what we
do elsewhere most of the time too, so I also changed that.
Applied to master, thanks.
Regards,
Yann E. MORIN.
> + host-pkgconf \
> + libglib2 \
> + zlib \
> + pixman \
> + host-python3
>
> # Need the LIBS variable because librt and libm are
> # not automatically pulled. :-(
> @@ -246,7 +251,12 @@ $(eval $(generic-package))
> #-------------------------------------------------------------
> # Host-qemu
>
> -HOST_QEMU_DEPENDENCIES = host-meson host-pkgconf host-zlib host-libglib2 host-pixman host-python3
> +HOST_QEMU_DEPENDENCIES = host-meson \
> + host-pkgconf \
> + host-zlib \
> + host-libglib2 \
> + host-pixman \
> + host-python3
>
> # BR ARCH qemu
> # ------- ----
> --
> 2.38.1
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-12-28 19:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-17 15:37 [Buildroot] [PATCH 1/4] package/slirp: add host variant for host-qemu Romain Naour
2022-12-17 15:37 ` [Buildroot] [PATCH 2/4] package/qemu: split long lines Romain Naour
2022-12-28 19:52 ` Yann E. MORIN [this message]
2022-12-17 15:37 ` [Buildroot] [PATCH 3/4] package/qemu: reorder dependencies alphabetically Romain Naour
2022-12-28 19:52 ` Yann E. MORIN
2022-12-17 15:37 ` [Buildroot] [PATCH 4/4] package/qemu: bump to version 7.2.0 Romain Naour
2022-12-28 19:53 ` Yann E. MORIN
2022-12-28 19:51 ` [Buildroot] [PATCH 1/4] package/slirp: add host variant for host-qemu Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221228195223.GF2498764@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@buildroot.org \
--cc=romain.naour@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.