All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: bernd.kuhls@t-online.de, chrismcc@gmail.com,
	yann.morin.1998@free.fr, mmayer@broadcom.com,
	buildroot@buildroot.org, fontaine.fabrice@gmail.com
Subject: Re: [Buildroot] [PATCH] package/slang: Add option to enable/disable slsh
Date: Wed, 28 Dec 2022 20:52:09 +0100	[thread overview]
Message-ID: <20221228205209.5ed73ae5@windsurf> (raw)
In-Reply-To: <20221220200805.2686768-1-f.fainelli@gmail.com>

Hello Florian,

(Hope you're doing well!)

On Tue, 20 Dec 2022 12:08:05 -0800
Florian Fainelli <f.fainelli@gmail.com> wrote:

> The S-lang shell is currently installed by default but most packages are
> typically interested in the shared libraries only. Add a configuration
> option to disable the slsh program and its supporting files.
> 
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>

I've applied to master, with some small changes, see below.

> diff --git a/package/slang/Config.in b/package/slang/Config.in
> index a500ff5b7d75..b09b0cd8fc84 100644
> --- a/package/slang/Config.in
> +++ b/package/slang/Config.in
> @@ -5,3 +5,10 @@ config BR2_PACKAGE_SLANG
>  	  Multi-platform console display library.
>  
>  	  http://www.jedsoft.org/slang/index.html
> +
> +config BR2_PACKAGE_SLANG_SLSH
> +	bool "enable slsh"
> +	default y

I dropped this "default y". I know you added it to preserve existing
behavior, but we also try in Buildroot to aim for minimalism. Since I
believe most people who had slang enabled needed only the shared
library, it makes sense to have slsh disabled by default. We'll see if
some users complain about this.

> +	depends on BR2_PACKAGE_SLANG

Changed to a if ... endif block.

> +ifneq ($(BR2_PACKAGE_SLANG_SLSH),y)

Changed to positive logic:

ifeq ($(BR2_PACKAGE_SLANG_SLSH),)

> +define SLANG_REMOVE_SLSH
> +	rm -rf $(TARGET_DIR)/etc/slsh.rc \
> +		$(TARGET_DIR)/usr/share/slsh \
> +		$(TARGET_DIR)/usr/bin/slsh
> +endef
> +endif
> +
> +SLANG_POST_INSTALL_TARGET_HOOKS += SLANG_REMOVE_SLSH

Hook registration moved inside the ifeq ... endif block.

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      reply	other threads:[~2022-12-28 19:52 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-20 20:08 [Buildroot] [PATCH] package/slang: Add option to enable/disable slsh Florian Fainelli
2022-12-28 19:52 ` Thomas Petazzoni via buildroot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221228205209.5ed73ae5@windsurf \
    --to=buildroot@buildroot.org \
    --cc=bernd.kuhls@t-online.de \
    --cc=chrismcc@gmail.com \
    --cc=f.fainelli@gmail.com \
    --cc=fontaine.fabrice@gmail.com \
    --cc=mmayer@broadcom.com \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=yann.morin.1998@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.