From: Bjorn Andersson <andersson@kernel.org>
To: Yang Yingliang <yangyingliang@huawei.com>
Cc: linux-i2c@vger.kernel.org, linux-arm-msm@vger.kernel.org,
agross@kernel.org, konrad.dybcio@linaro.org,
neil.armstrong@linaro.org, wsa@kernel.org
Subject: Re: [PATCH -next] i2c: qcom-geni: change i2c_master_hub to static
Date: Wed, 28 Dec 2022 21:45:29 -0600 [thread overview]
Message-ID: <20221229034529.yrs6u3yj4ge6e7mr@builder.lan> (raw)
In-Reply-To: <20221228093403.3165722-1-yangyingliang@huawei.com>
On Wed, Dec 28, 2022 at 05:34:02PM +0800, Yang Yingliang wrote:
> i2c_master_hub is only used in i2c-qcom-geni.c now,
> change it to static.
>
> Fixes: cacd9643eca7 ("i2c: qcom-geni: add support for I2C Master Hub variant")
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Reviewed-by: Bjorn Andersson <andersson@kernel.org>
Regards,
Bjorn
> ---
> drivers/i2c/busses/i2c-qcom-geni.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-qcom-geni.c b/drivers/i2c/busses/i2c-qcom-geni.c
> index f292e4dab98f..fd22fcb07da2 100644
> --- a/drivers/i2c/busses/i2c-qcom-geni.c
> +++ b/drivers/i2c/busses/i2c-qcom-geni.c
> @@ -1029,7 +1029,7 @@ static const struct dev_pm_ops geni_i2c_pm_ops = {
> NULL)
> };
>
> -const struct geni_i2c_desc i2c_master_hub = {
> +static const struct geni_i2c_desc i2c_master_hub = {
> .has_core_clk = true,
> .icc_ddr = NULL,
> .no_dma_support = true,
> --
> 2.25.1
>
next prev parent reply other threads:[~2022-12-29 3:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-28 9:34 [PATCH -next] i2c: qcom-geni: change i2c_master_hub to static Yang Yingliang
2022-12-29 3:45 ` Bjorn Andersson [this message]
2023-01-09 15:21 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221229034529.yrs6u3yj4ge6e7mr@builder.lan \
--to=andersson@kernel.org \
--cc=agross@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=wsa@kernel.org \
--cc=yangyingliang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.