From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: Bernd Kuhls <bernd.kuhls@t-online.de>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/2] package/xxhash: fix static library install
Date: Thu, 29 Dec 2022 10:02:49 +0100 [thread overview]
Message-ID: <20221229100249.373ee881@windsurf> (raw)
In-Reply-To: <20221228221522.280696-1-fontaine.fabrice@gmail.com>
On Wed, 28 Dec 2022 23:15:21 +0100
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> Install headers when building statically
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Applied thanks. One suggestion below.
> ifeq ($(BR2_STATIC_LIBS),y)
> XXHASH_TARGETS += libxxhash.a libxxhash.pc
> -XXHASH_INSTALL_TARGETS += install_libxxhash.a install_libxxhash.pc
> +XXHASH_INSTALL_TARGETS += \
> + install_libxxhash.a \
> + install_libxxhash.includes \
> + install_libxxhash.pc
> else ifeq ($(BR2_SHARED_LIBS),y)
> XXHASH_TARGETS += libxxhash libxxhash.pc
> -XXHASH_INSTALL_TARGETS += install_libxxhash install_libxxhash.pc
> +XXHASH_INSTALL_TARGETS += \
> + install_libxxhash \
> + install_libxxhash.includes \
> + install_libxxhash.pc
> else ifeq ($(BR2_SHARED_STATIC_LIBS),y)
> XXHASH_TARGETS += libxxhash.a libxxhash libxxhash.pc
> XXHASH_INSTALL_TARGETS += \
> - install_libxxhash.a install_libxxhash install_libxxhash.pc
> + install_libxxhash.a \
> + install_libxxhash \
> + install_libxxhash.includes \
> + install_libxxhash.pc
> endif
This could be slightly "optimized", to reduce a bit the duplication:
XXHASH_INSTALL_TARGETS = \
install_libxxhash.includes \
install_libxxhash.pc
ifeq ($(BR2_STATIC_LIBS)$(BR2_SHARED_STATIC_LIBS),y)
XXHASH_INSTALL_TARGETS += install_libxxhash.a
endif
ifeq ($(BR2_SHARED_LIBS)$(BR2_SHARED_STATIC_LIBS),y)
XXHASH_INSTALL_TARGETS += install_libxxhash
endif
Best regards,
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-12-29 9:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-28 22:15 [Buildroot] [PATCH 1/2] package/xxhash: fix static library install Fabrice Fontaine
2022-12-28 22:15 ` [Buildroot] [PATCH 2/2] package/rsync: add xxhash support Fabrice Fontaine
2022-12-29 9:03 ` Thomas Petazzoni via buildroot
2022-12-29 9:02 ` Thomas Petazzoni via buildroot [this message]
2023-01-02 14:21 ` [Buildroot] [PATCH 1/2] package/xxhash: fix static library install Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221229100249.373ee881@windsurf \
--to=buildroot@buildroot.org \
--cc=bernd.kuhls@t-online.de \
--cc=fontaine.fabrice@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.