All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Jisoo Jang <jisoo.jang@yonsei.ac.kr>
Cc: linux-wireless@vger.kernel.org, linuxlovemin@yonsei.ac.kr,
	dokyungs@yonsei.ac.kr
Subject: Re: [PATCH] wifi: mt7601u: fix an integer underflow
Date: Thu, 29 Dec 2022 17:18:16 -0800	[thread overview]
Message-ID: <20221229171816.42022e23@kernel.org> (raw)
In-Reply-To: <20221229092906.2328282-1-jisoo.jang@yonsei.ac.kr>

On Thu, 29 Dec 2022 18:29:06 +0900 Jisoo Jang wrote:
> Fix an integer underflow that leads to a null pointer dereference in
> 'mt7601u_rx_skb_from_seg()'. The variable 'dma_len' in the URB packet
> could be manipulated, which could trigger an integer underflow of
> 'seg_len' in 'mt7601u_rx_process_seg()'. This underflow subsequently
> causes the 'bad_frame' checks in 'mt7601u_rx_skb_from_seg()' to be
> bypassed, eventually leading to a dereference of the pointer 'p', which
> is a null pointer.
> 
> Ensure that 'dma_len' is greater than 'min_seg_len'.

Acked-by: Jakub Kicinski <kuba@kernel.org>

  reply	other threads:[~2022-12-30  1:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-29  9:29 [PATCH] wifi: mt7601u: fix an integer underflow Jisoo Jang
2022-12-30  1:18 ` Jakub Kicinski [this message]
2023-01-16 16:23 ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221229171816.42022e23@kernel.org \
    --to=kuba@kernel.org \
    --cc=dokyungs@yonsei.ac.kr \
    --cc=jisoo.jang@yonsei.ac.kr \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linuxlovemin@yonsei.ac.kr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.