All of lore.kernel.org
 help / color / mirror / Atom feed
From: nickel@altlinux.org
To: linux-kernel@vger.kernel.org
Cc: Nikolai Kostrigin <nickel@altlinux.org>,
	Oleg Obidin <obidinog@basealt.ru>
Subject: [PATCH] Revert "ASoC: soc-pcm: Don't zero TDM masks in __soc_pcm_open()"
Date: Fri, 30 Dec 2022 12:30:53 +0300	[thread overview]
Message-ID: <20221230093454.468857-2-nickel@altlinux.org> (raw)
In-Reply-To: <20221230093454.468857-1-nickel@altlinux.org>

From: Nikolai Kostrigin <nickel@altlinux.org>

This reverts commit c34db0d6b88b1da95e7ab3353e674f4f574cccee.

Sudden sound disappearance was reported for some laptops, e.g.
Acer Swift 3 SF314-59-78UR 11th Gen Intel(R) Core(TM) i7-1165G7 @ 2.80GHz

lspci
0000:00:1f.3 Multimedia audio controller: Intel Corporation Tiger Lake-LP Smart Sound Technology Audio Controller (rev 20)
        Subsystem: Acer Incorporated [ALI] Device 148c
        Flags: bus master, fast devsel, latency 32, IRQ 197, IOMMU group 12
        Memory at 601f270000 (64-bit, non-prefetchable) [size=16K]
        Memory at 601f000000 (64-bit, non-prefetchable) [size=1M]
        Capabilities: [50] Power Management version 3
        Capabilities: [80] Vendor Specific Information: Len=14 <?>
        Capabilities: [60] MSI: Enable+ Count=1/1 Maskable- 64bit+
        Kernel driver in use: sof-audio-pci

Bisection revealed the commit being reverted.

Reported-by: Oleg Obidin <obidinog@basealt.ru>
Link: https://bugzilla.altlinux.org/44690
Link: https://bugzilla.kernel.org/show_bug.cgi?id=216861
Signed-off-by: Nikolai Kostrigin <nickel@altlinux.org>
---
 sound/soc/soc-pcm.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/sound/soc/soc-pcm.c b/sound/soc/soc-pcm.c
index 0e2261ee07b67..8b8a9aca2912f 100644
--- a/sound/soc/soc-pcm.c
+++ b/sound/soc/soc-pcm.c
@@ -723,6 +723,11 @@ static int soc_pcm_open(struct snd_pcm_substream *substream)
 		ret = snd_soc_dai_startup(dai, substream);
 		if (ret < 0)
 			goto err;
+
+		if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK)
+			dai->tx_mask = 0;
+		else
+			dai->rx_mask = 0;
 	}
 
 	/* Dynamic PCM DAI links compat checks use dynamic capabilities */
-- 
2.33.5


  reply	other threads:[~2022-12-30  9:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-30  9:30 [PATCH 0/1] Revert patch to fix sound sudden dissapearance nickel
2022-12-30  9:30 ` nickel [this message]
2022-12-30  9:53   ` [PATCH] Revert "ASoC: soc-pcm: Don't zero TDM masks in __soc_pcm_open()" Greg KH
2022-12-30 10:00     ` Thorsten Leemhuis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221230093454.468857-2-nickel@altlinux.org \
    --to=nickel@altlinux.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=obidinog@basealt.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.