From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AF16DC4167B for ; Fri, 30 Dec 2022 15:21:14 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id D51478552C; Fri, 30 Dec 2022 16:21:12 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="hO8MaL/u"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id F00D48553B; Fri, 30 Dec 2022 16:21:10 +0100 (CET) Received: from mail-yb1-xb2d.google.com (mail-yb1-xb2d.google.com [IPv6:2607:f8b0:4864:20::b2d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id BEA628552C for ; Fri, 30 Dec 2022 16:21:07 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-yb1-xb2d.google.com with SMTP id c124so23800896ybb.13 for ; Fri, 30 Dec 2022 07:21:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=rRq0iC1tcI/2Va5NIKsWpOoEr3l95loXlWUOnYm9Obg=; b=hO8MaL/u+5pFEqysJkilhqLzcWdG5VvuPm/eIPW9qRTvbSsh7ukkuo2WYfoEKDnXrs D132UiL9O3tIZLOyRxwEiG5i9mPAl3Ey7CQ+2r8hXQNxEWIKE7JJrKov5xFUN7IC4EbI x373YKPnp59LyQ7nmBZAkaez5nIEtuEH5Ymy8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=rRq0iC1tcI/2Va5NIKsWpOoEr3l95loXlWUOnYm9Obg=; b=vJbI/DTHT/bCqqiO8NewCSGSMmNu43I3j1xoqwAm/84H6qyPidO01EZWf6Wt1CdwRy DSmUszDn/iFpg43UHX0ozX7cQMvyEcMs1OIObQmZDEuK02jQGYo2mNNOK/lyh+EJEzt+ mK0Oe6YXksRao5fEIRruPKbNPkSknRfq4QNCB41EuspSHLAb1hIwH90zOs5Tokhx/QhC XeI7cDVwJuJpvyGOW4wcMJ+L96tZHf9gjEQcDwxkUHhJfLk0Bxhc4+996QgwA10oZmcT bY82Hby28pObvZlTaDRQ/Kl1pQb6s71LPVKiW3ZE5LwVbIV+8mEt80yDMVR5e19VKesY PrXA== X-Gm-Message-State: AFqh2kpKGMY2E6lteoOqlDu+h5q8Jnx+JJA2j6TKCksV6hjdZIByNOGR lHXoe3yj/6aDdet5FPuvbqxC9g== X-Google-Smtp-Source: AMrXdXv/bcxKOIWcn/YSqfnyhR4vNUgBSlCbrUgKF7wUxECZFepSxw9uPm6sUQVsMWG4HxmcZcl0Ug== X-Received: by 2002:a25:6e8a:0:b0:78e:2dd2:6f35 with SMTP id j132-20020a256e8a000000b0078e2dd26f35mr6329501ybc.2.1672413666419; Fri, 30 Dec 2022 07:21:06 -0800 (PST) Received: from bill-the-cat (2603-6081-7b00-6400-a5a5-eb4c-bea2-121a.res6.spectrum.com. [2603:6081:7b00:6400:a5a5:eb4c:bea2:121a]) by smtp.gmail.com with ESMTPSA id w16-20020a05620a445000b007023fc46b64sm2658742qkp.113.2022.12.30.07.21.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Dec 2022 07:21:05 -0800 (PST) Date: Fri, 30 Dec 2022 10:21:04 -0500 From: Tom Rini To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: Simon Glass , Heiko Schocher , u-boot@lists.denx.de Subject: Re: [PATCH u-boot 2/2] Makefile: Build working u-boot-dtb.bin target also for mpc85xx Message-ID: <20221230152104.GZ3787616@bill-the-cat> References: <20221228200437.30971-1-pali@kernel.org> <20221228200437.30971-2-pali@kernel.org> <20221230124811.zkzqgnxszidyy4ae@pali> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="kj1WMr/o5O8PBYMB" Content-Disposition: inline In-Reply-To: <20221230124811.zkzqgnxszidyy4ae@pali> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --kj1WMr/o5O8PBYMB Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Dec 30, 2022 at 01:48:11PM +0100, Pali Roh=E1r wrote: > On Thursday 29 December 2022 16:39:11 Simon Glass wrote: > > Hi Pali, > >=20 > > On Wed, 28 Dec 2022 at 14:06, Pali Roh=E1r wrote: > > > > > > U-Boot build process currently always produces broken u-boot-dtb.bin = binary > > > for PowerPC mpc85xx architecture on boards which needs mpc85xx reset > > > vector. For these boards this (intermediate) binary is not used as in= put > > > for any other Makefile target on this architecture, so there is no re= al > > > problem with it. > > > > > > But it is not a good idea to produce broken binaries during build pha= se. So > > > try to improve it. Binary u-boot-dtb.bin should contains u-boot code = with > > > DTB blob. Such binary for those boards is build by binman. So change = binman > > > output file name from u-boot.bin to u-boot-dtb.bin and then let gener= ic > > > Makefile rule to generate final u-boot.bin from u-boot-dtb.bin. And f= inally > > > disable generic u-boot-dtb.bin rule for mpc85xx. > > > > > > Signed-off-by: Pali Roh=E1r > > > --- > > > Makefile | 17 ++++++++--------- > > > arch/powerpc/dts/socrates-u-boot.dtsi | 2 +- > > > arch/powerpc/dts/u-boot.dtsi | 2 +- > > > 3 files changed, 10 insertions(+), 11 deletions(-) > >=20 > > Can you instead use a new filename, like u-boot-powerpc.bin for this? >=20 > This would lead to the same situation as described here: > https://patchwork.ozlabs.org/project/uboot/patch/20221228181839.22003-1-p= ali@kernel.org/ >=20 > > I'm not fan of adding SoC-specific rules in the Makefile - in fact > > one of the goals of binman is to drop these. >=20 > In this case it would be better to build u-boot-dts.bin only by binman > (for all platforms) instead of cat-ing rules in Makefile. This would also be an easier path forward perhaps for making sure that the dtb is always 8 byte aligned? --=20 Tom --kj1WMr/o5O8PBYMB Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmOvAeAACgkQFHw5/5Y0 tyyhqgwAqVuAIXAA9WZeoMp4vktp8ywN0qyJ2LMfy7Q1Z2iz6mp3b1+xG1QZIq6u V5Kutl6PKF/UXnZli+HEw0AiOrbFNlcmBvAoeAIJZVqlR81z77CEtz5zGvzUrw6D 7iq4+ont3gOtlHxXB2Y7h4fWF7Q1B04u/qCZnrc128O6kYO+llClwe7hjZ0n3qVE yhjIpRXbmXyqe0V8QjYMCzl4EEYN9ypg3uNWdZd8NJGwGCzzK/SQlLOyfE1XyvF0 SMOEmOZGT/gd1J3PPh0eYm5wj2fLwURAlsG7bmdFdKQrvNGqbkcIQD7Ug0NCatjc pmncFmUaw/mLbe1CDmafTdNLIScC+cuUJZxipoCSC1g+l3+qL4ZwyE84kA6RBEbY cd1VMGHuI0bLWbg6GA5eGA7zeMHxxAHHUVdypl16bIIf7W3XEAG3oqnDoF5JyJV+ qMz3fm8eov2MWuqmCmFCJ3EtxJHD8zEGcyuD90k0XwSujlGMG730GGb64hRf7z+U cDSihRMk =ljL3 -----END PGP SIGNATURE----- --kj1WMr/o5O8PBYMB--