From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EEB6BC4167B for ; Fri, 30 Dec 2022 15:41:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=fpsccE2JHCzrgqY+UVgYs9aelUB4t7/CzdwWRTpmSt4=; b=fjZIS5d+xxib3z HAuW4Egkk8NfpcgjH8b7WKyOQlDU6gwK9CkLXW63tOW/Foyh8VrEolDDkpNjvTKb24Fyi5Flzbg6d asu3orDM8plBXaTt1S2u842OzhtUJZnZ961a4T5LY1KTmbSXhG/cw2dhyUz0O4T70Fh5zv2kbmp7h Lp9E4jTdB2mPiiyE91lCxcdAf9wDfRVBe6pw9iXwYkjRfhf4s1/dIS4BfYZK+dKIdhTXqEJtawYwG YPii9/ezjvNr7pp5yUOa4P3+E4NqzFubHbHYfqKm9/nnOqvzacawDdbxboABnW2JljEXapQ4S1+l3 LJwY8Fk3e2u9GZc15GKQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pBHV8-00Af3j-Oe; Fri, 30 Dec 2022 15:40:54 +0000 Received: from vps.xff.cz ([195.181.215.36]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pBHSI-00AcMD-Mq; Fri, 30 Dec 2022 15:38:01 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=xff.cz; s=mail; t=1672414666; bh=4K+H1Twpy1ukKx/TDvXBwwQinHSIB0GXM7v670fi4GI=; h=Date:From:To:Cc:Subject:X-My-GPG-KeyId:References:From; b=gKUWtCeVzQ5JAARUI2Vec6vpym+9hBAgyhSMn3DPrwTAO3bnYsDZ8ptNOy3M2oblR 0V3CoeKx5u4+8+3rDwbd2wmk1/BDVnUcm7GPP4tg5r9HwO3zmOc101FmaUkHtDjAkd Zv6j7efal9lbFOGkSvjEZQ9VUgIsgUnGtZ+7qFtE= Date: Fri, 30 Dec 2022 16:37:45 +0100 From: =?utf-8?Q?Ond=C5=99ej?= Jirman To: Javier Martinez Canillas Cc: linux-kernel@vger.kernel.org, Kamil =?utf-8?Q?Trzci=C5=84ski?= , Martijn Braam , Sam Ravnborg , Robert Mader , Tom Fitzhenry , Peter Robinson , Onuralp Sezer , dri-devel@lists.freedesktop.org, Maya Matuszczyk , Neal Gompa , linux-arm-kernel@lists.infradead.org, Krzysztof Kozlowski , Jagan Teki , Caleb Connolly , Heiko Stuebner , Krzysztof Kozlowski , Rob Herring , devicetree@vger.kernel.org, linux-rockchip@lists.infradead.org Subject: Re: [PATCH v4 4/4] arm64: dts: rk3399-pinephone-pro: Add internal display support Message-ID: <20221230153745.tfs6n4zy4xfwugbw@core> Mail-Followup-To: =?utf-8?Q?Ond=C5=99ej?= Jirman , Javier Martinez Canillas , linux-kernel@vger.kernel.org, Kamil =?utf-8?Q?Trzci=C5=84ski?= , Martijn Braam , Sam Ravnborg , Robert Mader , Tom Fitzhenry , Peter Robinson , Onuralp Sezer , dri-devel@lists.freedesktop.org, Maya Matuszczyk , Neal Gompa , linux-arm-kernel@lists.infradead.org, Krzysztof Kozlowski , Jagan Teki , Caleb Connolly , Heiko Stuebner , Krzysztof Kozlowski , Rob Herring , devicetree@vger.kernel.org, linux-rockchip@lists.infradead.org X-My-GPG-KeyId: EBFBDDE11FB918D44D1F56C1F9F0A873BE9777ED References: <20221230113155.3430142-1-javierm@redhat.com> <20221230113155.3430142-5-javierm@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221230113155.3430142-5-javierm@redhat.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221230_073759_568129_3389B693 X-CRM114-Status: GOOD ( 21.28 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org SGkgSmF2aWVyLAoKT24gRnJpLCBEZWMgMzAsIDIwMjIgYXQgMTI6MzE6NTRQTSArMDEwMCwgSmF2 aWVyIE1hcnRpbmV6IENhbmlsbGFzIHdyb3RlOgo+IEZyb206IE9uZHJlaiBKaXJtYW4gPG1lZ2lA eGZmLmN6Pgo+IAo+IFRoZSBwaG9uZSdzIGRpc3BsYXkgaXMgdXNpbmcgSGFubnN0YXIgTENEIHBh bmVsLCBhbmQgR29vZGl4IGJhc2VkCj4gdG91Y2hzY3JlZW4uIFN1cHBvcnQgaXQuCj4gCj4gU2ln bmVkLW9mZi1ieTogT25kcmVqIEppcm1hbiA8bWVnaUB4ZmYuY3o+Cj4gQ28tZGV2ZWxvcGVkLWJ5 OiBNYXJ0aWpuIEJyYWFtIDxtYXJ0aWpuQGJyaXhpdC5ubD4KPiBTaWduZWQtb2ZmLWJ5OiBNYXJ0 aWpuIEJyYWFtIDxtYXJ0aWpuQGJyaXhpdC5ubD4KPiBDby1kZXZlbG9wZWQtYnk6IEthbWlsIFRy emNpxYRza2kgPGF5dWZhbkBheXVmYW4uZXU+Cj4gU2lnbmVkLW9mZi1ieTogS2FtaWwgVHJ6Y2nF hHNraSA8YXl1ZmFuQGF5dWZhbi5ldT4KPiBTaWduZWQtb2ZmLWJ5OiBKYXZpZXIgTWFydGluZXog Q2FuaWxsYXMgPGphdmllcm1AcmVkaGF0LmNvbT4KPiBUZXN0ZWQtYnk6IFRvbSBGaXR6aGVucnkg PHRvbUB0b20tZml0emhlbnJ5Lm1lLnVrPgo+IC0tLQo+IAo+IENoYW5nZXMgaW4gdjQ6Cj4gLSBB ZGQgVG9tIEZpdHpoZW5yeSdzIFRlc3RlZC1ieSB0YWcuCj4gLSBLZWVwIHRoZSBEVFMgbm9kZXMg c29ydGVkIGFscGhhYmV0aWNhbGx5IChUb20gRml0emhlbnJ5KS4KPiAKPiBDaGFuZ2VzIGluIHYy Ogo+IC0gRml4IHJlZ3VsYXRvciBub2RlIG5hbWVzIChNYXlhIE1hdHVzemN6eWspLgo+IC0gRHJv cCBub24tZXhpc3RlbnQgInBvd2Vyb2ZmLWluLXN1c3BlbmQiIHByb3BlcnR5IChNYXlhIE1hdHVz emN6eWspLgo+IC0gUmVtb3ZlIHVubmVjZXNzYXJ5IGNvbW1lbnRzIGluIHBhbmVsIG5vZGUgKE1h eWEgTWF0dXN6Y3p5aykuCj4gCj4gIC4uLi9kdHMvcm9ja2NoaXAvcmszMzk5LXBpbmVwaG9uZS1w cm8uZHRzICAgICB8IDEyMyArKysrKysrKysrKysrKysrKysKPiAgMSBmaWxlIGNoYW5nZWQsIDEy MyBpbnNlcnRpb25zKCspCj4gCj4gZGlmZiAtLWdpdCBhL2FyY2gvYXJtNjQvYm9vdC9kdHMvcm9j a2NoaXAvcmszMzk5LXBpbmVwaG9uZS1wcm8uZHRzIGIvYXJjaC9hcm02NC9ib290L2R0cy9yb2Nr Y2hpcC9yazMzOTktcGluZXBob25lLXByby5kdHMKPiBpbmRleCAwNDQwM2E3NjIzOGIuLjBkNDhm YmM1ZGJlNCAxMDA2NDQKPiAtLS0gYS9hcmNoL2FybTY0L2Jvb3QvZHRzL3JvY2tjaGlwL3JrMzM5 OS1waW5lcGhvbmUtcHJvLmR0cwo+ICsrKyBiL2FyY2gvYXJtNjQvYm9vdC9kdHMvcm9ja2NoaXAv cmszMzk5LXBpbmVwaG9uZS1wcm8uZHRzCj4gQEAgLTI1LDYgKzI1LDEyIEBAIGFsaWFzZXMgewo+ ICAJCW1tYzIgPSAmc2RoY2k7Cj4gIAl9Owo+ICAKPiArCWJhY2tsaWdodDogYmFja2xpZ2h0IHsK PiArCQljb21wYXRpYmxlID0gInB3bS1iYWNrbGlnaHQiOwo+ICsJCXB3bXMgPSA8JnB3bTAgMCAx MDAwMDAwIDA+Owo+ICsJCXB3bS1kZWxheS11cyA9IDwxMDAwMD47Cj4gKwl9Owo+ICsKPiAgCWNo b3NlbiB7Cj4gIAkJc3Rkb3V0LXBhdGggPSAic2VyaWFsMjoxMTUyMDBuOCI7Cj4gIAl9Owo+IEBA IC04Miw2ICs4OCwzMiBAQCB2Y2MxdjhfY29kZWM6IHZjYzF2OC1jb2RlYy1yZWd1bGF0b3Igewo+ ICAJCXZpbi1zdXBwbHkgPSA8JnZjYzN2M19zeXM+Owo+ICAJfTsKPiAgCj4gKwkvKiBNSVBJIERT SSBwYW5lbCAxLjh2IHN1cHBseSAqLwo+ICsJdmNjMXY4X2xjZDogdmNjMXY4LWxjZC1yZWd1bGF0 b3Igewo+ICsJCWNvbXBhdGlibGUgPSAicmVndWxhdG9yLWZpeGVkIjsKPiArCQllbmFibGUtYWN0 aXZlLWhpZ2g7Cj4gKwkJcmVndWxhdG9yLW5hbWUgPSAidmNjMXY4X2xjZCI7Cj4gKwkJcmVndWxh dG9yLW1pbi1taWNyb3ZvbHQgPSA8MTgwMDAwMD47Cj4gKwkJcmVndWxhdG9yLW1heC1taWNyb3Zv bHQgPSA8MTgwMDAwMD47Cj4gKwkJdmluLXN1cHBseSA9IDwmdmNjM3YzX3N5cz47Cj4gKwkJZ3Bp byA9IDwmZ3BpbzMgUktfUEE1IEdQSU9fQUNUSVZFX0hJR0g+Owo+ICsJCXBpbmN0cmwtbmFtZXMg PSAiZGVmYXVsdCI7Cj4gKwkJcGluY3RybC0wID0gPCZkaXNwbGF5X3B3cmVuMT47Cj4gKwl9Owo+ ICsKPiArCS8qIE1JUEkgRFNJIHBhbmVsIDIuOHYgc3VwcGx5ICovCj4gKwl2Y2MydjhfbGNkOiB2 Y2MydjgtbGNkLXJlZ3VsYXRvciB7Cj4gKwkJY29tcGF0aWJsZSA9ICJyZWd1bGF0b3ItZml4ZWQi Owo+ICsJCWVuYWJsZS1hY3RpdmUtaGlnaDsKPiArCQlyZWd1bGF0b3ItbmFtZSA9ICJ2Y2Mydjhf bGNkIjsKPiArCQlyZWd1bGF0b3ItbWluLW1pY3Jvdm9sdCA9IDwyODAwMDAwPjsKPiArCQlyZWd1 bGF0b3ItbWF4LW1pY3Jvdm9sdCA9IDwyODAwMDAwPjsKPiArCQl2aW4tc3VwcGx5ID0gPCZ2Y2Mz djNfc3lzPjsKPiArCQlncGlvID0gPCZncGlvMyBSS19QQTEgR1BJT19BQ1RJVkVfSElHSD47Cj4g KwkJcGluY3RybC1uYW1lcyA9ICJkZWZhdWx0IjsKPiArCQlwaW5jdHJsLTAgPSA8JmRpc3BsYXlf cHdyZW4+Owo+ICsJfTsKPiArCj4gIAl3aWZpX3B3cnNlcTogc2Rpby13aWZpLXB3cnNlcSB7Cj4g IAkJY29tcGF0aWJsZSA9ICJtbWMtcHdyc2VxLXNpbXBsZSI7Cj4gIAkJY2xvY2tzID0gPCZyazgx OCAxPjsKPiBAQCAtMTMyLDYgKzE2NCwxMSBAQCAmZW1tY19waHkgewo+ICAJc3RhdHVzID0gIm9r YXkiOwo+ICB9Owo+ICAKPiArJmdwdSB7Cj4gKwltYWxpLXN1cHBseSA9IDwmdmRkX2dwdT47Cj4g KwlzdGF0dXMgPSAib2theSI7Cj4gK307Cj4gKwo+ICAmaTJjMCB7Cj4gIAljbG9jay1mcmVxdWVu Y3kgPSA8NDAwMDAwPjsKPiAgCWkyYy1zY2wtcmlzaW5nLXRpbWUtbnMgPSA8MTY4PjsKPiBAQCAt MjE0LDYgKzI1MSw5IEBAIHZjYzN2MF90b3VjaDogTERPX1JFRzIgewo+ICAJCQkJcmVndWxhdG9y LW5hbWUgPSAidmNjM3YwX3RvdWNoIjsKPiAgCQkJCXJlZ3VsYXRvci1taW4tbWljcm92b2x0ID0g PDMwMDAwMDA+Owo+ICAJCQkJcmVndWxhdG9yLW1heC1taWNyb3ZvbHQgPSA8MzAwMDAwMD47Cj4g KwkJCQlyZWd1bGF0b3Itc3RhdGUtbWVtIHsKPiArCQkJCQlyZWd1bGF0b3Itb2ZmLWluLXN1c3Bl bmQ7Cj4gKwkJCQl9OwoKWW91J3JlIGluc3RydWN0aW5nIFJLODE4IHRvIHNodXQgZG93biB0aGUg cmVndWxhdG9yIGZvciB0b3VjaCBjb250cm9sbGVyIGR1cmluZwpzdXNwZW5kLCBidXQgSSB0aGlu ayBHb29kaXggZHJpdmVyIGV4cGVjdHMgdG91Y2ggY29udHJvbGxlciB0byBiZSBrZXB0IHBvd2Vy ZWQgb24KZHVyaW5nIHN1c3BlbmQuIEFtIEkgbWlzc2luZyBzb21ldGhpbmc/CgpodHRwczovL2Vs aXhpci5ib290bGluLmNvbS9saW51eC9sYXRlc3Qvc291cmNlL2RyaXZlcnMvaW5wdXQvdG91Y2hz Y3JlZW4vZ29vZGl4LmMjTDE0MDUKCj4gIAkJCX07Cj4gIAo+ICAJCQl2Y2NhMXY4X2NvZGVjOiBM RE9fUkVHMyB7Cj4gQEAgLTM0Nyw2ICszODcsMjUgQEAgb3BwMDcgewo+ICAJfTsKPiAgfTsKPiAg Cj4gKyZpMmMzIHsKPiArCWkyYy1zY2wtcmlzaW5nLXRpbWUtbnMgPSA8NDUwPjsKPiArCWkyYy1z Y2wtZmFsbGluZy10aW1lLW5zID0gPDE1PjsKPiArCXN0YXR1cyA9ICJva2F5IjsKPiArCj4gKwl0 b3VjaHNjcmVlbkAxNCB7Cj4gKwkJY29tcGF0aWJsZSA9ICJnb29kaXgsZ3Q5MTdzIjsKClRoaXMg aXMgbm90IHRoZSBjb3JyZWN0IGNvbXBhdGlibGUuIFBpbmVwaG9uZSBQcm8gdXNlcyBHb29kaXgg R1QxMTU4OgoKR29vZGl4LVRTIDMtMDAxNDogSUQgMTE1OCwgdmVyc2lvbjogMDEwMApHb29kaXgt VFMgMy0wMDE0OiBEaXJlY3QgZmlybXdhcmUgbG9hZCBmb3IgZ29vZGl4XzExNThfY2ZnLmJpbiBm YWlsZWQgd2l0aCBlcnJvciAtMgoKCj4gKwkJcmVnID0gPDB4MTQ+Owo+ICsJCWludGVycnVwdC1w YXJlbnQgPSA8JmdwaW8zPjsKPiArCQlpbnRlcnJ1cHRzID0gPFJLX1BCNSBJUlFfVFlQRV9FREdF X1JJU0lORz47Cj4gKwkJaXJxLWdwaW9zID0gPCZncGlvMyBSS19QQjUgR1BJT19BQ1RJVkVfSElH SD47Cj4gKwkJcmVzZXQtZ3Bpb3MgPSA8JmdwaW8zIFJLX1BCNCBHUElPX0FDVElWRV9ISUdIPjsK PiArCQlBVkREMjgtc3VwcGx5ID0gPCZ2Y2MzdjBfdG91Y2g+Owo+ICsJCVZERElPLXN1cHBseSA9 IDwmdmNjM3YwX3RvdWNoPjsKPiArCQl0b3VjaHNjcmVlbi1zaXplLXggPSA8NzIwPjsKPiArCQl0 b3VjaHNjcmVlbi1zaXplLXkgPSA8MTQ0MD47Cj4gKwl9Owo+ICt9Owo+ICsKPiAgJmlvX2RvbWFp bnMgewo+ICAJYnQ2NTYtc3VwcGx5ID0gPCZ2Y2MxdjhfZHZwPjsKPiAgCWF1ZGlvLXN1cHBseSA9 IDwmdmNjYTF2OF9jb2RlYz47Cj4gQEAgLTM1NSw2ICs0MTQsNDAgQEAgJmlvX2RvbWFpbnMgewo+ ICAJc3RhdHVzID0gIm9rYXkiOwo+ICB9Owo+ICAKPiArJm1pcGlfZHNpIHsKPiArCXN0YXR1cyA9 ICJva2F5IjsKPiArCWNsb2NrLW1hc3RlcjsKPiArCj4gKwlwb3J0cyB7Cj4gKwkJbWlwaV9vdXQ6 IHBvcnRAMSB7Cj4gKwkJCSNhZGRyZXNzLWNlbGxzID0gPDA+Owo+ICsJCQkjc2l6ZS1jZWxscyA9 IDwwPjsKPiArCQkJcmVnID0gPDE+Owo+ICsKPiArCQkJbWlwaV9vdXRfcGFuZWw6IGVuZHBvaW50 IHsKPiArCQkJCXJlbW90ZS1lbmRwb2ludCA9IDwmbWlwaV9pbl9wYW5lbD47Cj4gKwkJCX07Cj4g KwkJfTsKPiArCX07Cj4gKwo+ICsJcGFuZWxAMCB7Cj4gKwkJY29tcGF0aWJsZSA9ICJoYW5uc3Rh cixoc2QwNjBiaHc0IiwgImhpbWF4LGh4ODM5NCI7Cj4gKwkJcmVnID0gPDA+Owo+ICsJCWJhY2ts aWdodCA9IDwmYmFja2xpZ2h0PjsKPiArCQlyZXNldC1ncGlvcyA9IDwmZ3BpbzQgUktfUEQxIEdQ SU9fQUNUSVZFX0xPVz47Cj4gKwkJdmNjLXN1cHBseSA9IDwmdmNjMnY4X2xjZD47Cj4gKwkJaW92 Y2Mtc3VwcGx5ID0gPCZ2Y2MxdjhfbGNkPjsKPiArCQlwaW5jdHJsLW5hbWVzID0gImRlZmF1bHQi Owo+ICsJCXBpbmN0cmwtMCA9IDwmZGlzcGxheV9yc3RfbD47Cj4gKwo+ICsJCXBvcnQgewo+ICsJ CQltaXBpX2luX3BhbmVsOiBlbmRwb2ludCB7Cj4gKwkJCQlyZW1vdGUtZW5kcG9pbnQgPSA8Jm1p cGlfb3V0X3BhbmVsPjsKPiArCQkJfTsKPiArCQl9Owo+ICsJfTsKPiArfTsKPiArCj4gICZwbXVf aW9fZG9tYWlucyB7Cj4gIAlwbXUxODMwLXN1cHBseSA9IDwmdmNjXzF2OD47Cj4gIAlzdGF0dXMg PSAib2theSI7Cj4gQEAgLTM2Nyw2ICs0NjAsMjAgQEAgcHdyYnRuX3BpbjogcHdyYnRuLXBpbiB7 Cj4gIAkJfTsKPiAgCX07Cj4gIAo+ICsJZHNpIHsKPiArCQlkaXNwbGF5X3JzdF9sOiBkaXNwbGF5 LXJzdC1sIHsKPiArCQkJcm9ja2NoaXAscGlucyA9IDw0IFJLX1BEMSBSS19GVU5DX0dQSU8gJnBj ZmdfcHVsbF9kb3duPjsKPiArCQl9Owo+ICsKPiArCQlkaXNwbGF5X3B3cmVuOiBkaXNwbGF5LXB3 cmVuIHsKPiArCQkJcm9ja2NoaXAscGlucyA9IDwzIFJLX1BBMSBSS19GVU5DX0dQSU8gJnBjZmdf cHVsbF9kb3duPjsKPiArCQl9Owo+ICsKPiArCQlkaXNwbGF5X3B3cmVuMTogZGlzcGxheS1wd3Jl bjEgewo+ICsJCQlyb2NrY2hpcCxwaW5zID0gPDMgUktfUEE1IFJLX0ZVTkNfR1BJTyAmcGNmZ19w dWxsX2Rvd24+Owo+ICsJCX07Cj4gKwl9Owo+ICsKPiAgCXBtaWMgewo+ICAJCXBtaWNfaW50X2w6 IHBtaWMtaW50LWwgewo+ICAJCQlyb2NrY2hpcCxwaW5zID0gPDEgUktfUEM1IFJLX0ZVTkNfR1BJ TyAmcGNmZ19wdWxsX3VwPjsKPiBAQCAtNDA4LDYgKzUxNSwxMCBAQCBidF9yZXNldF9waW46IGJ0 LXJlc2V0LXBpbiB7Cj4gIAl9Owo+ICB9Owo+ICAKPiArJnB3bTAgewo+ICsJc3RhdHVzID0gIm9r YXkiOwo+ICt9Owo+ICsKPiAgJnNkaW8wIHsKPiAgCWJ1cy13aWR0aCA9IDw0PjsKPiAgCWNhcC1z ZC1oaWdoc3BlZWQ7Cj4gQEAgLTQ3MiwzICs1ODMsMTUgQEAgYmx1ZXRvb3RoIHsKPiAgJnVhcnQy IHsKPiAgCXN0YXR1cyA9ICJva2F5IjsKPiAgfTsKPiArCj4gKyZ2b3BiIHsKPiArCXN0YXR1cyA9 ICJva2F5IjsKPiArCWFzc2lnbmVkLWNsb2NrcyA9IDwmY3J1IERDTEtfVk9QMF9ESVY+LCA8JmNy dSBEQ0xLX1ZPUDA+LAo+ICsJCQkgIDwmY3J1IEFDTEtfVk9QMD4sIDwmY3J1IEhDTEtfVk9QMD47 Cj4gKwlhc3NpZ25lZC1jbG9jay1yYXRlcyA9IDwwPiwgPDA+LCA8NDAwMDAwMDAwPiwgPDEwMDAw MDAwMD47Cj4gKwlhc3NpZ25lZC1jbG9jay1wYXJlbnRzID0gPCZjcnUgUExMX0NQTEw+LCA8JmNy dSBEQ0xLX1ZPUDBfRlJBQz47Cj4gK307CgpTbyBoZXJlIHlvdSdyZSBwdXR0aW5nIGEgZnJhY3Rp b25hbCBjbG9jayBpbnRvIHBhdGggYmV0d2VlbiBDUExMIC0+IFZPUDBfRElWCi0+IERDTEtfVk9Q MF9GUkFDIC0+IERDTEtfVk9QMC4KCkZyYWN0aW9uYWwgY2xvY2tzIHJlcXVpcmUgMjB4IGRpZmZl cmVuY2UgYmV0d2VlbiBpbnB1dCBhbmQgb3V0cHV0IHJhdGVzLCBhbmQKQ1BMTCBpcyA4MDBNaHog SUlSQywgd2hpbGUgeW91IHJlcXVpcmUgNzQuMjVNSHogRENMSywgc28gdGhpcyB3aWxsIG5vdCB3 b3JrCmNvcnJlY3RseS4KCkV2ZW4gaWYgdGhpcyBzb21laG93IHdvcmtzIGJ5IGZyYWN0aW9uYWwg Y2xvY2sgYmVpbmcgYnlwYXNzZWQsIEkgZGlkIG5vdCBkZXNpZ24KdGhlIHBhbmVsIG1vZGUgdG8g YmUgdXNlZCB3aXRoIENQTEwncyA4MDAgTUh6LCBidXQgd2l0aCBHUExMIGZyZXF1ZWN5IG9mIDU5 NCBNSHouCgpHUExMIDU5NC83NC4yNSA9IDggIChpbnRlZ3JhbCBkaXZpZGVyIHdpdGhvdXQgdGhl IG5lZWQgZm9yIGZyYWN0aW9uYWwgY2xvY2spCkNQTEwgODAwLzc0LjI1ID0gfjEwLjc3NDQxMDc3 NDQxMDc3NDQxMDc3CgpJZiB5b3UgcmVhbGx5IHdhbnQgdG8gdXNlIGZyYWN0aW9uYWwgY2xvY2ss IHlvdSdkIG5lZWQgdG8gcGFyZW50IGl0IHRvIFZQTEwKYW5kIHNldCBWUExMIHJlYWxseSBoaWdo LCBsaWtlIGNsb3NlIHRvIDJHSHouCgpraW5kIHJlZ2FyZHMsCglvLgoKPiArJnZvcGJfbW11IHsK PiArCXN0YXR1cyA9ICJva2F5IjsKPiArfTsKPiAtLSAKPiAyLjM4LjEKPiAKCl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkxpbnV4LXJvY2tjaGlwIG1haWxp bmcgbGlzdApMaW51eC1yb2NrY2hpcEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5p bmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtcm9ja2NoaXAK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E0616C4167B for ; Fri, 30 Dec 2022 19:02:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YFQOJXoVV8bgMzjaq3M/rtcUGBP/F2S/hR94uyBg6io=; b=n3B3K7Nb2lifCl CbdyhGzW2s7baKOnJG3yHk0jekYgSorWzGvUi8CO09TlnoTDAfbod7UP9NQDgTCHkVMO7HqilZnew dUk4HAWIEah1adc2VoxTXr4AQFsBQrj7T7gfbIXhtNjl0EPNyqyKulFB2YIoasWPG7Y8/mhOYVlTK jgpBDi9L94Ck+FA6GUn5whVYZHavOZlRSawxet0uJLcwVIbHDz8vP4drsvNo4PEjeWJBt4JhQR23U vbrnDxErkpWOYJLIyCaJzaKTEz9bHLnWr5z6SaKjTVLUkXTWW6Zi1qsxTrqRnx6NWZOni8TtK4dET qpBeRi04NffmK0XrOnmw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pBKcR-00CRDD-5q; Fri, 30 Dec 2022 19:00:40 +0000 Received: from vps.xff.cz ([195.181.215.36]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pBHSI-00AcMD-Mq; Fri, 30 Dec 2022 15:38:01 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=xff.cz; s=mail; t=1672414666; bh=4K+H1Twpy1ukKx/TDvXBwwQinHSIB0GXM7v670fi4GI=; h=Date:From:To:Cc:Subject:X-My-GPG-KeyId:References:From; b=gKUWtCeVzQ5JAARUI2Vec6vpym+9hBAgyhSMn3DPrwTAO3bnYsDZ8ptNOy3M2oblR 0V3CoeKx5u4+8+3rDwbd2wmk1/BDVnUcm7GPP4tg5r9HwO3zmOc101FmaUkHtDjAkd Zv6j7efal9lbFOGkSvjEZQ9VUgIsgUnGtZ+7qFtE= Date: Fri, 30 Dec 2022 16:37:45 +0100 From: =?utf-8?Q?Ond=C5=99ej?= Jirman To: Javier Martinez Canillas Cc: linux-kernel@vger.kernel.org, Kamil =?utf-8?Q?Trzci=C5=84ski?= , Martijn Braam , Sam Ravnborg , Robert Mader , Tom Fitzhenry , Peter Robinson , Onuralp Sezer , dri-devel@lists.freedesktop.org, Maya Matuszczyk , Neal Gompa , linux-arm-kernel@lists.infradead.org, Krzysztof Kozlowski , Jagan Teki , Caleb Connolly , Heiko Stuebner , Krzysztof Kozlowski , Rob Herring , devicetree@vger.kernel.org, linux-rockchip@lists.infradead.org Subject: Re: [PATCH v4 4/4] arm64: dts: rk3399-pinephone-pro: Add internal display support Message-ID: <20221230153745.tfs6n4zy4xfwugbw@core> Mail-Followup-To: =?utf-8?Q?Ond=C5=99ej?= Jirman , Javier Martinez Canillas , linux-kernel@vger.kernel.org, Kamil =?utf-8?Q?Trzci=C5=84ski?= , Martijn Braam , Sam Ravnborg , Robert Mader , Tom Fitzhenry , Peter Robinson , Onuralp Sezer , dri-devel@lists.freedesktop.org, Maya Matuszczyk , Neal Gompa , linux-arm-kernel@lists.infradead.org, Krzysztof Kozlowski , Jagan Teki , Caleb Connolly , Heiko Stuebner , Krzysztof Kozlowski , Rob Herring , devicetree@vger.kernel.org, linux-rockchip@lists.infradead.org X-My-GPG-KeyId: EBFBDDE11FB918D44D1F56C1F9F0A873BE9777ED References: <20221230113155.3430142-1-javierm@redhat.com> <20221230113155.3430142-5-javierm@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221230113155.3430142-5-javierm@redhat.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221230_073759_568129_3389B693 X-CRM114-Status: GOOD ( 21.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgSmF2aWVyLAoKT24gRnJpLCBEZWMgMzAsIDIwMjIgYXQgMTI6MzE6NTRQTSArMDEwMCwgSmF2 aWVyIE1hcnRpbmV6IENhbmlsbGFzIHdyb3RlOgo+IEZyb206IE9uZHJlaiBKaXJtYW4gPG1lZ2lA eGZmLmN6Pgo+IAo+IFRoZSBwaG9uZSdzIGRpc3BsYXkgaXMgdXNpbmcgSGFubnN0YXIgTENEIHBh bmVsLCBhbmQgR29vZGl4IGJhc2VkCj4gdG91Y2hzY3JlZW4uIFN1cHBvcnQgaXQuCj4gCj4gU2ln bmVkLW9mZi1ieTogT25kcmVqIEppcm1hbiA8bWVnaUB4ZmYuY3o+Cj4gQ28tZGV2ZWxvcGVkLWJ5 OiBNYXJ0aWpuIEJyYWFtIDxtYXJ0aWpuQGJyaXhpdC5ubD4KPiBTaWduZWQtb2ZmLWJ5OiBNYXJ0 aWpuIEJyYWFtIDxtYXJ0aWpuQGJyaXhpdC5ubD4KPiBDby1kZXZlbG9wZWQtYnk6IEthbWlsIFRy emNpxYRza2kgPGF5dWZhbkBheXVmYW4uZXU+Cj4gU2lnbmVkLW9mZi1ieTogS2FtaWwgVHJ6Y2nF hHNraSA8YXl1ZmFuQGF5dWZhbi5ldT4KPiBTaWduZWQtb2ZmLWJ5OiBKYXZpZXIgTWFydGluZXog Q2FuaWxsYXMgPGphdmllcm1AcmVkaGF0LmNvbT4KPiBUZXN0ZWQtYnk6IFRvbSBGaXR6aGVucnkg PHRvbUB0b20tZml0emhlbnJ5Lm1lLnVrPgo+IC0tLQo+IAo+IENoYW5nZXMgaW4gdjQ6Cj4gLSBB ZGQgVG9tIEZpdHpoZW5yeSdzIFRlc3RlZC1ieSB0YWcuCj4gLSBLZWVwIHRoZSBEVFMgbm9kZXMg c29ydGVkIGFscGhhYmV0aWNhbGx5IChUb20gRml0emhlbnJ5KS4KPiAKPiBDaGFuZ2VzIGluIHYy Ogo+IC0gRml4IHJlZ3VsYXRvciBub2RlIG5hbWVzIChNYXlhIE1hdHVzemN6eWspLgo+IC0gRHJv cCBub24tZXhpc3RlbnQgInBvd2Vyb2ZmLWluLXN1c3BlbmQiIHByb3BlcnR5IChNYXlhIE1hdHVz emN6eWspLgo+IC0gUmVtb3ZlIHVubmVjZXNzYXJ5IGNvbW1lbnRzIGluIHBhbmVsIG5vZGUgKE1h eWEgTWF0dXN6Y3p5aykuCj4gCj4gIC4uLi9kdHMvcm9ja2NoaXAvcmszMzk5LXBpbmVwaG9uZS1w cm8uZHRzICAgICB8IDEyMyArKysrKysrKysrKysrKysrKysKPiAgMSBmaWxlIGNoYW5nZWQsIDEy MyBpbnNlcnRpb25zKCspCj4gCj4gZGlmZiAtLWdpdCBhL2FyY2gvYXJtNjQvYm9vdC9kdHMvcm9j a2NoaXAvcmszMzk5LXBpbmVwaG9uZS1wcm8uZHRzIGIvYXJjaC9hcm02NC9ib290L2R0cy9yb2Nr Y2hpcC9yazMzOTktcGluZXBob25lLXByby5kdHMKPiBpbmRleCAwNDQwM2E3NjIzOGIuLjBkNDhm YmM1ZGJlNCAxMDA2NDQKPiAtLS0gYS9hcmNoL2FybTY0L2Jvb3QvZHRzL3JvY2tjaGlwL3JrMzM5 OS1waW5lcGhvbmUtcHJvLmR0cwo+ICsrKyBiL2FyY2gvYXJtNjQvYm9vdC9kdHMvcm9ja2NoaXAv cmszMzk5LXBpbmVwaG9uZS1wcm8uZHRzCj4gQEAgLTI1LDYgKzI1LDEyIEBAIGFsaWFzZXMgewo+ ICAJCW1tYzIgPSAmc2RoY2k7Cj4gIAl9Owo+ICAKPiArCWJhY2tsaWdodDogYmFja2xpZ2h0IHsK PiArCQljb21wYXRpYmxlID0gInB3bS1iYWNrbGlnaHQiOwo+ICsJCXB3bXMgPSA8JnB3bTAgMCAx MDAwMDAwIDA+Owo+ICsJCXB3bS1kZWxheS11cyA9IDwxMDAwMD47Cj4gKwl9Owo+ICsKPiAgCWNo b3NlbiB7Cj4gIAkJc3Rkb3V0LXBhdGggPSAic2VyaWFsMjoxMTUyMDBuOCI7Cj4gIAl9Owo+IEBA IC04Miw2ICs4OCwzMiBAQCB2Y2MxdjhfY29kZWM6IHZjYzF2OC1jb2RlYy1yZWd1bGF0b3Igewo+ ICAJCXZpbi1zdXBwbHkgPSA8JnZjYzN2M19zeXM+Owo+ICAJfTsKPiAgCj4gKwkvKiBNSVBJIERT SSBwYW5lbCAxLjh2IHN1cHBseSAqLwo+ICsJdmNjMXY4X2xjZDogdmNjMXY4LWxjZC1yZWd1bGF0 b3Igewo+ICsJCWNvbXBhdGlibGUgPSAicmVndWxhdG9yLWZpeGVkIjsKPiArCQllbmFibGUtYWN0 aXZlLWhpZ2g7Cj4gKwkJcmVndWxhdG9yLW5hbWUgPSAidmNjMXY4X2xjZCI7Cj4gKwkJcmVndWxh dG9yLW1pbi1taWNyb3ZvbHQgPSA8MTgwMDAwMD47Cj4gKwkJcmVndWxhdG9yLW1heC1taWNyb3Zv bHQgPSA8MTgwMDAwMD47Cj4gKwkJdmluLXN1cHBseSA9IDwmdmNjM3YzX3N5cz47Cj4gKwkJZ3Bp byA9IDwmZ3BpbzMgUktfUEE1IEdQSU9fQUNUSVZFX0hJR0g+Owo+ICsJCXBpbmN0cmwtbmFtZXMg PSAiZGVmYXVsdCI7Cj4gKwkJcGluY3RybC0wID0gPCZkaXNwbGF5X3B3cmVuMT47Cj4gKwl9Owo+ ICsKPiArCS8qIE1JUEkgRFNJIHBhbmVsIDIuOHYgc3VwcGx5ICovCj4gKwl2Y2MydjhfbGNkOiB2 Y2MydjgtbGNkLXJlZ3VsYXRvciB7Cj4gKwkJY29tcGF0aWJsZSA9ICJyZWd1bGF0b3ItZml4ZWQi Owo+ICsJCWVuYWJsZS1hY3RpdmUtaGlnaDsKPiArCQlyZWd1bGF0b3ItbmFtZSA9ICJ2Y2Mydjhf bGNkIjsKPiArCQlyZWd1bGF0b3ItbWluLW1pY3Jvdm9sdCA9IDwyODAwMDAwPjsKPiArCQlyZWd1 bGF0b3ItbWF4LW1pY3Jvdm9sdCA9IDwyODAwMDAwPjsKPiArCQl2aW4tc3VwcGx5ID0gPCZ2Y2Mz djNfc3lzPjsKPiArCQlncGlvID0gPCZncGlvMyBSS19QQTEgR1BJT19BQ1RJVkVfSElHSD47Cj4g KwkJcGluY3RybC1uYW1lcyA9ICJkZWZhdWx0IjsKPiArCQlwaW5jdHJsLTAgPSA8JmRpc3BsYXlf cHdyZW4+Owo+ICsJfTsKPiArCj4gIAl3aWZpX3B3cnNlcTogc2Rpby13aWZpLXB3cnNlcSB7Cj4g IAkJY29tcGF0aWJsZSA9ICJtbWMtcHdyc2VxLXNpbXBsZSI7Cj4gIAkJY2xvY2tzID0gPCZyazgx OCAxPjsKPiBAQCAtMTMyLDYgKzE2NCwxMSBAQCAmZW1tY19waHkgewo+ICAJc3RhdHVzID0gIm9r YXkiOwo+ICB9Owo+ICAKPiArJmdwdSB7Cj4gKwltYWxpLXN1cHBseSA9IDwmdmRkX2dwdT47Cj4g KwlzdGF0dXMgPSAib2theSI7Cj4gK307Cj4gKwo+ICAmaTJjMCB7Cj4gIAljbG9jay1mcmVxdWVu Y3kgPSA8NDAwMDAwPjsKPiAgCWkyYy1zY2wtcmlzaW5nLXRpbWUtbnMgPSA8MTY4PjsKPiBAQCAt MjE0LDYgKzI1MSw5IEBAIHZjYzN2MF90b3VjaDogTERPX1JFRzIgewo+ICAJCQkJcmVndWxhdG9y LW5hbWUgPSAidmNjM3YwX3RvdWNoIjsKPiAgCQkJCXJlZ3VsYXRvci1taW4tbWljcm92b2x0ID0g PDMwMDAwMDA+Owo+ICAJCQkJcmVndWxhdG9yLW1heC1taWNyb3ZvbHQgPSA8MzAwMDAwMD47Cj4g KwkJCQlyZWd1bGF0b3Itc3RhdGUtbWVtIHsKPiArCQkJCQlyZWd1bGF0b3Itb2ZmLWluLXN1c3Bl bmQ7Cj4gKwkJCQl9OwoKWW91J3JlIGluc3RydWN0aW5nIFJLODE4IHRvIHNodXQgZG93biB0aGUg cmVndWxhdG9yIGZvciB0b3VjaCBjb250cm9sbGVyIGR1cmluZwpzdXNwZW5kLCBidXQgSSB0aGlu ayBHb29kaXggZHJpdmVyIGV4cGVjdHMgdG91Y2ggY29udHJvbGxlciB0byBiZSBrZXB0IHBvd2Vy ZWQgb24KZHVyaW5nIHN1c3BlbmQuIEFtIEkgbWlzc2luZyBzb21ldGhpbmc/CgpodHRwczovL2Vs aXhpci5ib290bGluLmNvbS9saW51eC9sYXRlc3Qvc291cmNlL2RyaXZlcnMvaW5wdXQvdG91Y2hz Y3JlZW4vZ29vZGl4LmMjTDE0MDUKCj4gIAkJCX07Cj4gIAo+ICAJCQl2Y2NhMXY4X2NvZGVjOiBM RE9fUkVHMyB7Cj4gQEAgLTM0Nyw2ICszODcsMjUgQEAgb3BwMDcgewo+ICAJfTsKPiAgfTsKPiAg Cj4gKyZpMmMzIHsKPiArCWkyYy1zY2wtcmlzaW5nLXRpbWUtbnMgPSA8NDUwPjsKPiArCWkyYy1z Y2wtZmFsbGluZy10aW1lLW5zID0gPDE1PjsKPiArCXN0YXR1cyA9ICJva2F5IjsKPiArCj4gKwl0 b3VjaHNjcmVlbkAxNCB7Cj4gKwkJY29tcGF0aWJsZSA9ICJnb29kaXgsZ3Q5MTdzIjsKClRoaXMg aXMgbm90IHRoZSBjb3JyZWN0IGNvbXBhdGlibGUuIFBpbmVwaG9uZSBQcm8gdXNlcyBHb29kaXgg R1QxMTU4OgoKR29vZGl4LVRTIDMtMDAxNDogSUQgMTE1OCwgdmVyc2lvbjogMDEwMApHb29kaXgt VFMgMy0wMDE0OiBEaXJlY3QgZmlybXdhcmUgbG9hZCBmb3IgZ29vZGl4XzExNThfY2ZnLmJpbiBm YWlsZWQgd2l0aCBlcnJvciAtMgoKCj4gKwkJcmVnID0gPDB4MTQ+Owo+ICsJCWludGVycnVwdC1w YXJlbnQgPSA8JmdwaW8zPjsKPiArCQlpbnRlcnJ1cHRzID0gPFJLX1BCNSBJUlFfVFlQRV9FREdF X1JJU0lORz47Cj4gKwkJaXJxLWdwaW9zID0gPCZncGlvMyBSS19QQjUgR1BJT19BQ1RJVkVfSElH SD47Cj4gKwkJcmVzZXQtZ3Bpb3MgPSA8JmdwaW8zIFJLX1BCNCBHUElPX0FDVElWRV9ISUdIPjsK PiArCQlBVkREMjgtc3VwcGx5ID0gPCZ2Y2MzdjBfdG91Y2g+Owo+ICsJCVZERElPLXN1cHBseSA9 IDwmdmNjM3YwX3RvdWNoPjsKPiArCQl0b3VjaHNjcmVlbi1zaXplLXggPSA8NzIwPjsKPiArCQl0 b3VjaHNjcmVlbi1zaXplLXkgPSA8MTQ0MD47Cj4gKwl9Owo+ICt9Owo+ICsKPiAgJmlvX2RvbWFp bnMgewo+ICAJYnQ2NTYtc3VwcGx5ID0gPCZ2Y2MxdjhfZHZwPjsKPiAgCWF1ZGlvLXN1cHBseSA9 IDwmdmNjYTF2OF9jb2RlYz47Cj4gQEAgLTM1NSw2ICs0MTQsNDAgQEAgJmlvX2RvbWFpbnMgewo+ ICAJc3RhdHVzID0gIm9rYXkiOwo+ICB9Owo+ICAKPiArJm1pcGlfZHNpIHsKPiArCXN0YXR1cyA9 ICJva2F5IjsKPiArCWNsb2NrLW1hc3RlcjsKPiArCj4gKwlwb3J0cyB7Cj4gKwkJbWlwaV9vdXQ6 IHBvcnRAMSB7Cj4gKwkJCSNhZGRyZXNzLWNlbGxzID0gPDA+Owo+ICsJCQkjc2l6ZS1jZWxscyA9 IDwwPjsKPiArCQkJcmVnID0gPDE+Owo+ICsKPiArCQkJbWlwaV9vdXRfcGFuZWw6IGVuZHBvaW50 IHsKPiArCQkJCXJlbW90ZS1lbmRwb2ludCA9IDwmbWlwaV9pbl9wYW5lbD47Cj4gKwkJCX07Cj4g KwkJfTsKPiArCX07Cj4gKwo+ICsJcGFuZWxAMCB7Cj4gKwkJY29tcGF0aWJsZSA9ICJoYW5uc3Rh cixoc2QwNjBiaHc0IiwgImhpbWF4LGh4ODM5NCI7Cj4gKwkJcmVnID0gPDA+Owo+ICsJCWJhY2ts aWdodCA9IDwmYmFja2xpZ2h0PjsKPiArCQlyZXNldC1ncGlvcyA9IDwmZ3BpbzQgUktfUEQxIEdQ SU9fQUNUSVZFX0xPVz47Cj4gKwkJdmNjLXN1cHBseSA9IDwmdmNjMnY4X2xjZD47Cj4gKwkJaW92 Y2Mtc3VwcGx5ID0gPCZ2Y2MxdjhfbGNkPjsKPiArCQlwaW5jdHJsLW5hbWVzID0gImRlZmF1bHQi Owo+ICsJCXBpbmN0cmwtMCA9IDwmZGlzcGxheV9yc3RfbD47Cj4gKwo+ICsJCXBvcnQgewo+ICsJ CQltaXBpX2luX3BhbmVsOiBlbmRwb2ludCB7Cj4gKwkJCQlyZW1vdGUtZW5kcG9pbnQgPSA8Jm1p cGlfb3V0X3BhbmVsPjsKPiArCQkJfTsKPiArCQl9Owo+ICsJfTsKPiArfTsKPiArCj4gICZwbXVf aW9fZG9tYWlucyB7Cj4gIAlwbXUxODMwLXN1cHBseSA9IDwmdmNjXzF2OD47Cj4gIAlzdGF0dXMg PSAib2theSI7Cj4gQEAgLTM2Nyw2ICs0NjAsMjAgQEAgcHdyYnRuX3BpbjogcHdyYnRuLXBpbiB7 Cj4gIAkJfTsKPiAgCX07Cj4gIAo+ICsJZHNpIHsKPiArCQlkaXNwbGF5X3JzdF9sOiBkaXNwbGF5 LXJzdC1sIHsKPiArCQkJcm9ja2NoaXAscGlucyA9IDw0IFJLX1BEMSBSS19GVU5DX0dQSU8gJnBj ZmdfcHVsbF9kb3duPjsKPiArCQl9Owo+ICsKPiArCQlkaXNwbGF5X3B3cmVuOiBkaXNwbGF5LXB3 cmVuIHsKPiArCQkJcm9ja2NoaXAscGlucyA9IDwzIFJLX1BBMSBSS19GVU5DX0dQSU8gJnBjZmdf cHVsbF9kb3duPjsKPiArCQl9Owo+ICsKPiArCQlkaXNwbGF5X3B3cmVuMTogZGlzcGxheS1wd3Jl bjEgewo+ICsJCQlyb2NrY2hpcCxwaW5zID0gPDMgUktfUEE1IFJLX0ZVTkNfR1BJTyAmcGNmZ19w dWxsX2Rvd24+Owo+ICsJCX07Cj4gKwl9Owo+ICsKPiAgCXBtaWMgewo+ICAJCXBtaWNfaW50X2w6 IHBtaWMtaW50LWwgewo+ICAJCQlyb2NrY2hpcCxwaW5zID0gPDEgUktfUEM1IFJLX0ZVTkNfR1BJ TyAmcGNmZ19wdWxsX3VwPjsKPiBAQCAtNDA4LDYgKzUxNSwxMCBAQCBidF9yZXNldF9waW46IGJ0 LXJlc2V0LXBpbiB7Cj4gIAl9Owo+ICB9Owo+ICAKPiArJnB3bTAgewo+ICsJc3RhdHVzID0gIm9r YXkiOwo+ICt9Owo+ICsKPiAgJnNkaW8wIHsKPiAgCWJ1cy13aWR0aCA9IDw0PjsKPiAgCWNhcC1z ZC1oaWdoc3BlZWQ7Cj4gQEAgLTQ3MiwzICs1ODMsMTUgQEAgYmx1ZXRvb3RoIHsKPiAgJnVhcnQy IHsKPiAgCXN0YXR1cyA9ICJva2F5IjsKPiAgfTsKPiArCj4gKyZ2b3BiIHsKPiArCXN0YXR1cyA9 ICJva2F5IjsKPiArCWFzc2lnbmVkLWNsb2NrcyA9IDwmY3J1IERDTEtfVk9QMF9ESVY+LCA8JmNy dSBEQ0xLX1ZPUDA+LAo+ICsJCQkgIDwmY3J1IEFDTEtfVk9QMD4sIDwmY3J1IEhDTEtfVk9QMD47 Cj4gKwlhc3NpZ25lZC1jbG9jay1yYXRlcyA9IDwwPiwgPDA+LCA8NDAwMDAwMDAwPiwgPDEwMDAw MDAwMD47Cj4gKwlhc3NpZ25lZC1jbG9jay1wYXJlbnRzID0gPCZjcnUgUExMX0NQTEw+LCA8JmNy dSBEQ0xLX1ZPUDBfRlJBQz47Cj4gK307CgpTbyBoZXJlIHlvdSdyZSBwdXR0aW5nIGEgZnJhY3Rp b25hbCBjbG9jayBpbnRvIHBhdGggYmV0d2VlbiBDUExMIC0+IFZPUDBfRElWCi0+IERDTEtfVk9Q MF9GUkFDIC0+IERDTEtfVk9QMC4KCkZyYWN0aW9uYWwgY2xvY2tzIHJlcXVpcmUgMjB4IGRpZmZl cmVuY2UgYmV0d2VlbiBpbnB1dCBhbmQgb3V0cHV0IHJhdGVzLCBhbmQKQ1BMTCBpcyA4MDBNaHog SUlSQywgd2hpbGUgeW91IHJlcXVpcmUgNzQuMjVNSHogRENMSywgc28gdGhpcyB3aWxsIG5vdCB3 b3JrCmNvcnJlY3RseS4KCkV2ZW4gaWYgdGhpcyBzb21laG93IHdvcmtzIGJ5IGZyYWN0aW9uYWwg Y2xvY2sgYmVpbmcgYnlwYXNzZWQsIEkgZGlkIG5vdCBkZXNpZ24KdGhlIHBhbmVsIG1vZGUgdG8g YmUgdXNlZCB3aXRoIENQTEwncyA4MDAgTUh6LCBidXQgd2l0aCBHUExMIGZyZXF1ZWN5IG9mIDU5 NCBNSHouCgpHUExMIDU5NC83NC4yNSA9IDggIChpbnRlZ3JhbCBkaXZpZGVyIHdpdGhvdXQgdGhl IG5lZWQgZm9yIGZyYWN0aW9uYWwgY2xvY2spCkNQTEwgODAwLzc0LjI1ID0gfjEwLjc3NDQxMDc3 NDQxMDc3NDQxMDc3CgpJZiB5b3UgcmVhbGx5IHdhbnQgdG8gdXNlIGZyYWN0aW9uYWwgY2xvY2ss IHlvdSdkIG5lZWQgdG8gcGFyZW50IGl0IHRvIFZQTEwKYW5kIHNldCBWUExMIHJlYWxseSBoaWdo LCBsaWtlIGNsb3NlIHRvIDJHSHouCgpraW5kIHJlZ2FyZHMsCglvLgoKPiArJnZvcGJfbW11IHsK PiArCXN0YXR1cyA9ICJva2F5IjsKPiArfTsKPiAtLSAKPiAyLjM4LjEKPiAKCl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFp bGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlz dHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02DB5C4167B for ; Fri, 30 Dec 2022 15:39:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235309AbiL3Pj2 (ORCPT ); Fri, 30 Dec 2022 10:39:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49596 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235311AbiL3PjM (ORCPT ); Fri, 30 Dec 2022 10:39:12 -0500 Received: from vps.xff.cz (vps.xff.cz [195.181.215.36]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 185821C425; Fri, 30 Dec 2022 07:37:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=xff.cz; s=mail; t=1672414666; bh=4K+H1Twpy1ukKx/TDvXBwwQinHSIB0GXM7v670fi4GI=; h=Date:From:To:Cc:Subject:X-My-GPG-KeyId:References:From; b=gKUWtCeVzQ5JAARUI2Vec6vpym+9hBAgyhSMn3DPrwTAO3bnYsDZ8ptNOy3M2oblR 0V3CoeKx5u4+8+3rDwbd2wmk1/BDVnUcm7GPP4tg5r9HwO3zmOc101FmaUkHtDjAkd Zv6j7efal9lbFOGkSvjEZQ9VUgIsgUnGtZ+7qFtE= Date: Fri, 30 Dec 2022 16:37:45 +0100 From: =?utf-8?Q?Ond=C5=99ej?= Jirman To: Javier Martinez Canillas Cc: linux-kernel@vger.kernel.org, Kamil =?utf-8?Q?Trzci=C5=84ski?= , Martijn Braam , Sam Ravnborg , Robert Mader , Tom Fitzhenry , Peter Robinson , Onuralp Sezer , dri-devel@lists.freedesktop.org, Maya Matuszczyk , Neal Gompa , linux-arm-kernel@lists.infradead.org, Krzysztof Kozlowski , Jagan Teki , Caleb Connolly , Heiko Stuebner , Krzysztof Kozlowski , Rob Herring , devicetree@vger.kernel.org, linux-rockchip@lists.infradead.org Subject: Re: [PATCH v4 4/4] arm64: dts: rk3399-pinephone-pro: Add internal display support Message-ID: <20221230153745.tfs6n4zy4xfwugbw@core> Mail-Followup-To: =?utf-8?Q?Ond=C5=99ej?= Jirman , Javier Martinez Canillas , linux-kernel@vger.kernel.org, Kamil =?utf-8?Q?Trzci=C5=84ski?= , Martijn Braam , Sam Ravnborg , Robert Mader , Tom Fitzhenry , Peter Robinson , Onuralp Sezer , dri-devel@lists.freedesktop.org, Maya Matuszczyk , Neal Gompa , linux-arm-kernel@lists.infradead.org, Krzysztof Kozlowski , Jagan Teki , Caleb Connolly , Heiko Stuebner , Krzysztof Kozlowski , Rob Herring , devicetree@vger.kernel.org, linux-rockchip@lists.infradead.org X-My-GPG-KeyId: EBFBDDE11FB918D44D1F56C1F9F0A873BE9777ED References: <20221230113155.3430142-1-javierm@redhat.com> <20221230113155.3430142-5-javierm@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20221230113155.3430142-5-javierm@redhat.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Javier, On Fri, Dec 30, 2022 at 12:31:54PM +0100, Javier Martinez Canillas wrote: > From: Ondrej Jirman > > The phone's display is using Hannstar LCD panel, and Goodix based > touchscreen. Support it. > > Signed-off-by: Ondrej Jirman > Co-developed-by: Martijn Braam > Signed-off-by: Martijn Braam > Co-developed-by: Kamil Trzciński > Signed-off-by: Kamil Trzciński > Signed-off-by: Javier Martinez Canillas > Tested-by: Tom Fitzhenry > --- > > Changes in v4: > - Add Tom Fitzhenry's Tested-by tag. > - Keep the DTS nodes sorted alphabetically (Tom Fitzhenry). > > Changes in v2: > - Fix regulator node names (Maya Matuszczyk). > - Drop non-existent "poweroff-in-suspend" property (Maya Matuszczyk). > - Remove unnecessary comments in panel node (Maya Matuszczyk). > > .../dts/rockchip/rk3399-pinephone-pro.dts | 123 ++++++++++++++++++ > 1 file changed, 123 insertions(+) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts > index 04403a76238b..0d48fbc5dbe4 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts > +++ b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts > @@ -25,6 +25,12 @@ aliases { > mmc2 = &sdhci; > }; > > + backlight: backlight { > + compatible = "pwm-backlight"; > + pwms = <&pwm0 0 1000000 0>; > + pwm-delay-us = <10000>; > + }; > + > chosen { > stdout-path = "serial2:115200n8"; > }; > @@ -82,6 +88,32 @@ vcc1v8_codec: vcc1v8-codec-regulator { > vin-supply = <&vcc3v3_sys>; > }; > > + /* MIPI DSI panel 1.8v supply */ > + vcc1v8_lcd: vcc1v8-lcd-regulator { > + compatible = "regulator-fixed"; > + enable-active-high; > + regulator-name = "vcc1v8_lcd"; > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + vin-supply = <&vcc3v3_sys>; > + gpio = <&gpio3 RK_PA5 GPIO_ACTIVE_HIGH>; > + pinctrl-names = "default"; > + pinctrl-0 = <&display_pwren1>; > + }; > + > + /* MIPI DSI panel 2.8v supply */ > + vcc2v8_lcd: vcc2v8-lcd-regulator { > + compatible = "regulator-fixed"; > + enable-active-high; > + regulator-name = "vcc2v8_lcd"; > + regulator-min-microvolt = <2800000>; > + regulator-max-microvolt = <2800000>; > + vin-supply = <&vcc3v3_sys>; > + gpio = <&gpio3 RK_PA1 GPIO_ACTIVE_HIGH>; > + pinctrl-names = "default"; > + pinctrl-0 = <&display_pwren>; > + }; > + > wifi_pwrseq: sdio-wifi-pwrseq { > compatible = "mmc-pwrseq-simple"; > clocks = <&rk818 1>; > @@ -132,6 +164,11 @@ &emmc_phy { > status = "okay"; > }; > > +&gpu { > + mali-supply = <&vdd_gpu>; > + status = "okay"; > +}; > + > &i2c0 { > clock-frequency = <400000>; > i2c-scl-rising-time-ns = <168>; > @@ -214,6 +251,9 @@ vcc3v0_touch: LDO_REG2 { > regulator-name = "vcc3v0_touch"; > regulator-min-microvolt = <3000000>; > regulator-max-microvolt = <3000000>; > + regulator-state-mem { > + regulator-off-in-suspend; > + }; You're instructing RK818 to shut down the regulator for touch controller during suspend, but I think Goodix driver expects touch controller to be kept powered on during suspend. Am I missing something? https://elixir.bootlin.com/linux/latest/source/drivers/input/touchscreen/goodix.c#L1405 > }; > > vcca1v8_codec: LDO_REG3 { > @@ -347,6 +387,25 @@ opp07 { > }; > }; > > +&i2c3 { > + i2c-scl-rising-time-ns = <450>; > + i2c-scl-falling-time-ns = <15>; > + status = "okay"; > + > + touchscreen@14 { > + compatible = "goodix,gt917s"; This is not the correct compatible. Pinephone Pro uses Goodix GT1158: Goodix-TS 3-0014: ID 1158, version: 0100 Goodix-TS 3-0014: Direct firmware load for goodix_1158_cfg.bin failed with error -2 > + reg = <0x14>; > + interrupt-parent = <&gpio3>; > + interrupts = ; > + irq-gpios = <&gpio3 RK_PB5 GPIO_ACTIVE_HIGH>; > + reset-gpios = <&gpio3 RK_PB4 GPIO_ACTIVE_HIGH>; > + AVDD28-supply = <&vcc3v0_touch>; > + VDDIO-supply = <&vcc3v0_touch>; > + touchscreen-size-x = <720>; > + touchscreen-size-y = <1440>; > + }; > +}; > + > &io_domains { > bt656-supply = <&vcc1v8_dvp>; > audio-supply = <&vcca1v8_codec>; > @@ -355,6 +414,40 @@ &io_domains { > status = "okay"; > }; > > +&mipi_dsi { > + status = "okay"; > + clock-master; > + > + ports { > + mipi_out: port@1 { > + #address-cells = <0>; > + #size-cells = <0>; > + reg = <1>; > + > + mipi_out_panel: endpoint { > + remote-endpoint = <&mipi_in_panel>; > + }; > + }; > + }; > + > + panel@0 { > + compatible = "hannstar,hsd060bhw4", "himax,hx8394"; > + reg = <0>; > + backlight = <&backlight>; > + reset-gpios = <&gpio4 RK_PD1 GPIO_ACTIVE_LOW>; > + vcc-supply = <&vcc2v8_lcd>; > + iovcc-supply = <&vcc1v8_lcd>; > + pinctrl-names = "default"; > + pinctrl-0 = <&display_rst_l>; > + > + port { > + mipi_in_panel: endpoint { > + remote-endpoint = <&mipi_out_panel>; > + }; > + }; > + }; > +}; > + > &pmu_io_domains { > pmu1830-supply = <&vcc_1v8>; > status = "okay"; > @@ -367,6 +460,20 @@ pwrbtn_pin: pwrbtn-pin { > }; > }; > > + dsi { > + display_rst_l: display-rst-l { > + rockchip,pins = <4 RK_PD1 RK_FUNC_GPIO &pcfg_pull_down>; > + }; > + > + display_pwren: display-pwren { > + rockchip,pins = <3 RK_PA1 RK_FUNC_GPIO &pcfg_pull_down>; > + }; > + > + display_pwren1: display-pwren1 { > + rockchip,pins = <3 RK_PA5 RK_FUNC_GPIO &pcfg_pull_down>; > + }; > + }; > + > pmic { > pmic_int_l: pmic-int-l { > rockchip,pins = <1 RK_PC5 RK_FUNC_GPIO &pcfg_pull_up>; > @@ -408,6 +515,10 @@ bt_reset_pin: bt-reset-pin { > }; > }; > > +&pwm0 { > + status = "okay"; > +}; > + > &sdio0 { > bus-width = <4>; > cap-sd-highspeed; > @@ -472,3 +583,15 @@ bluetooth { > &uart2 { > status = "okay"; > }; > + > +&vopb { > + status = "okay"; > + assigned-clocks = <&cru DCLK_VOP0_DIV>, <&cru DCLK_VOP0>, > + <&cru ACLK_VOP0>, <&cru HCLK_VOP0>; > + assigned-clock-rates = <0>, <0>, <400000000>, <100000000>; > + assigned-clock-parents = <&cru PLL_CPLL>, <&cru DCLK_VOP0_FRAC>; > +}; So here you're putting a fractional clock into path between CPLL -> VOP0_DIV -> DCLK_VOP0_FRAC -> DCLK_VOP0. Fractional clocks require 20x difference between input and output rates, and CPLL is 800Mhz IIRC, while you require 74.25MHz DCLK, so this will not work correctly. Even if this somehow works by fractional clock being bypassed, I did not design the panel mode to be used with CPLL's 800 MHz, but with GPLL frequecy of 594 MHz. GPLL 594/74.25 = 8 (integral divider without the need for fractional clock) CPLL 800/74.25 = ~10.77441077441077441077 If you really want to use fractional clock, you'd need to parent it to VPLL and set VPLL really high, like close to 2GHz. kind regards, o. > +&vopb_mmu { > + status = "okay"; > +}; > -- > 2.38.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B7140C4167B for ; Fri, 30 Dec 2022 15:45:42 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 076E510E452; Fri, 30 Dec 2022 15:45:42 +0000 (UTC) Received: from vps.xff.cz (vps.xff.cz [195.181.215.36]) by gabe.freedesktop.org (Postfix) with ESMTPS id 673DD10E452 for ; Fri, 30 Dec 2022 15:45:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=xff.cz; s=mail; t=1672414666; bh=4K+H1Twpy1ukKx/TDvXBwwQinHSIB0GXM7v670fi4GI=; h=Date:From:To:Cc:Subject:X-My-GPG-KeyId:References:From; b=gKUWtCeVzQ5JAARUI2Vec6vpym+9hBAgyhSMn3DPrwTAO3bnYsDZ8ptNOy3M2oblR 0V3CoeKx5u4+8+3rDwbd2wmk1/BDVnUcm7GPP4tg5r9HwO3zmOc101FmaUkHtDjAkd Zv6j7efal9lbFOGkSvjEZQ9VUgIsgUnGtZ+7qFtE= Date: Fri, 30 Dec 2022 16:37:45 +0100 From: =?utf-8?Q?Ond=C5=99ej?= Jirman To: Javier Martinez Canillas Subject: Re: [PATCH v4 4/4] arm64: dts: rk3399-pinephone-pro: Add internal display support Message-ID: <20221230153745.tfs6n4zy4xfwugbw@core> Mail-Followup-To: =?utf-8?Q?Ond=C5=99ej?= Jirman , Javier Martinez Canillas , linux-kernel@vger.kernel.org, Kamil =?utf-8?Q?Trzci=C5=84ski?= , Martijn Braam , Sam Ravnborg , Robert Mader , Tom Fitzhenry , Peter Robinson , Onuralp Sezer , dri-devel@lists.freedesktop.org, Maya Matuszczyk , Neal Gompa , linux-arm-kernel@lists.infradead.org, Krzysztof Kozlowski , Jagan Teki , Caleb Connolly , Heiko Stuebner , Krzysztof Kozlowski , Rob Herring , devicetree@vger.kernel.org, linux-rockchip@lists.infradead.org X-My-GPG-KeyId: EBFBDDE11FB918D44D1F56C1F9F0A873BE9777ED References: <20221230113155.3430142-1-javierm@redhat.com> <20221230113155.3430142-5-javierm@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20221230113155.3430142-5-javierm@redhat.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jagan Teki , Robert Mader , devicetree@vger.kernel.org, Onuralp Sezer , Neal Gompa , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Tom Fitzhenry , Martijn Braam , Caleb Connolly , Krzysztof Kozlowski , Rob Herring , Peter Robinson , Krzysztof Kozlowski , Kamil =?utf-8?Q?Trzci=C5=84ski?= , linux-rockchip@lists.infradead.org, Sam Ravnborg , linux-arm-kernel@lists.infradead.org, Maya Matuszczyk Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Javier, On Fri, Dec 30, 2022 at 12:31:54PM +0100, Javier Martinez Canillas wrote: > From: Ondrej Jirman > > The phone's display is using Hannstar LCD panel, and Goodix based > touchscreen. Support it. > > Signed-off-by: Ondrej Jirman > Co-developed-by: Martijn Braam > Signed-off-by: Martijn Braam > Co-developed-by: Kamil Trzciński > Signed-off-by: Kamil Trzciński > Signed-off-by: Javier Martinez Canillas > Tested-by: Tom Fitzhenry > --- > > Changes in v4: > - Add Tom Fitzhenry's Tested-by tag. > - Keep the DTS nodes sorted alphabetically (Tom Fitzhenry). > > Changes in v2: > - Fix regulator node names (Maya Matuszczyk). > - Drop non-existent "poweroff-in-suspend" property (Maya Matuszczyk). > - Remove unnecessary comments in panel node (Maya Matuszczyk). > > .../dts/rockchip/rk3399-pinephone-pro.dts | 123 ++++++++++++++++++ > 1 file changed, 123 insertions(+) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts > index 04403a76238b..0d48fbc5dbe4 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts > +++ b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts > @@ -25,6 +25,12 @@ aliases { > mmc2 = &sdhci; > }; > > + backlight: backlight { > + compatible = "pwm-backlight"; > + pwms = <&pwm0 0 1000000 0>; > + pwm-delay-us = <10000>; > + }; > + > chosen { > stdout-path = "serial2:115200n8"; > }; > @@ -82,6 +88,32 @@ vcc1v8_codec: vcc1v8-codec-regulator { > vin-supply = <&vcc3v3_sys>; > }; > > + /* MIPI DSI panel 1.8v supply */ > + vcc1v8_lcd: vcc1v8-lcd-regulator { > + compatible = "regulator-fixed"; > + enable-active-high; > + regulator-name = "vcc1v8_lcd"; > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + vin-supply = <&vcc3v3_sys>; > + gpio = <&gpio3 RK_PA5 GPIO_ACTIVE_HIGH>; > + pinctrl-names = "default"; > + pinctrl-0 = <&display_pwren1>; > + }; > + > + /* MIPI DSI panel 2.8v supply */ > + vcc2v8_lcd: vcc2v8-lcd-regulator { > + compatible = "regulator-fixed"; > + enable-active-high; > + regulator-name = "vcc2v8_lcd"; > + regulator-min-microvolt = <2800000>; > + regulator-max-microvolt = <2800000>; > + vin-supply = <&vcc3v3_sys>; > + gpio = <&gpio3 RK_PA1 GPIO_ACTIVE_HIGH>; > + pinctrl-names = "default"; > + pinctrl-0 = <&display_pwren>; > + }; > + > wifi_pwrseq: sdio-wifi-pwrseq { > compatible = "mmc-pwrseq-simple"; > clocks = <&rk818 1>; > @@ -132,6 +164,11 @@ &emmc_phy { > status = "okay"; > }; > > +&gpu { > + mali-supply = <&vdd_gpu>; > + status = "okay"; > +}; > + > &i2c0 { > clock-frequency = <400000>; > i2c-scl-rising-time-ns = <168>; > @@ -214,6 +251,9 @@ vcc3v0_touch: LDO_REG2 { > regulator-name = "vcc3v0_touch"; > regulator-min-microvolt = <3000000>; > regulator-max-microvolt = <3000000>; > + regulator-state-mem { > + regulator-off-in-suspend; > + }; You're instructing RK818 to shut down the regulator for touch controller during suspend, but I think Goodix driver expects touch controller to be kept powered on during suspend. Am I missing something? https://elixir.bootlin.com/linux/latest/source/drivers/input/touchscreen/goodix.c#L1405 > }; > > vcca1v8_codec: LDO_REG3 { > @@ -347,6 +387,25 @@ opp07 { > }; > }; > > +&i2c3 { > + i2c-scl-rising-time-ns = <450>; > + i2c-scl-falling-time-ns = <15>; > + status = "okay"; > + > + touchscreen@14 { > + compatible = "goodix,gt917s"; This is not the correct compatible. Pinephone Pro uses Goodix GT1158: Goodix-TS 3-0014: ID 1158, version: 0100 Goodix-TS 3-0014: Direct firmware load for goodix_1158_cfg.bin failed with error -2 > + reg = <0x14>; > + interrupt-parent = <&gpio3>; > + interrupts = ; > + irq-gpios = <&gpio3 RK_PB5 GPIO_ACTIVE_HIGH>; > + reset-gpios = <&gpio3 RK_PB4 GPIO_ACTIVE_HIGH>; > + AVDD28-supply = <&vcc3v0_touch>; > + VDDIO-supply = <&vcc3v0_touch>; > + touchscreen-size-x = <720>; > + touchscreen-size-y = <1440>; > + }; > +}; > + > &io_domains { > bt656-supply = <&vcc1v8_dvp>; > audio-supply = <&vcca1v8_codec>; > @@ -355,6 +414,40 @@ &io_domains { > status = "okay"; > }; > > +&mipi_dsi { > + status = "okay"; > + clock-master; > + > + ports { > + mipi_out: port@1 { > + #address-cells = <0>; > + #size-cells = <0>; > + reg = <1>; > + > + mipi_out_panel: endpoint { > + remote-endpoint = <&mipi_in_panel>; > + }; > + }; > + }; > + > + panel@0 { > + compatible = "hannstar,hsd060bhw4", "himax,hx8394"; > + reg = <0>; > + backlight = <&backlight>; > + reset-gpios = <&gpio4 RK_PD1 GPIO_ACTIVE_LOW>; > + vcc-supply = <&vcc2v8_lcd>; > + iovcc-supply = <&vcc1v8_lcd>; > + pinctrl-names = "default"; > + pinctrl-0 = <&display_rst_l>; > + > + port { > + mipi_in_panel: endpoint { > + remote-endpoint = <&mipi_out_panel>; > + }; > + }; > + }; > +}; > + > &pmu_io_domains { > pmu1830-supply = <&vcc_1v8>; > status = "okay"; > @@ -367,6 +460,20 @@ pwrbtn_pin: pwrbtn-pin { > }; > }; > > + dsi { > + display_rst_l: display-rst-l { > + rockchip,pins = <4 RK_PD1 RK_FUNC_GPIO &pcfg_pull_down>; > + }; > + > + display_pwren: display-pwren { > + rockchip,pins = <3 RK_PA1 RK_FUNC_GPIO &pcfg_pull_down>; > + }; > + > + display_pwren1: display-pwren1 { > + rockchip,pins = <3 RK_PA5 RK_FUNC_GPIO &pcfg_pull_down>; > + }; > + }; > + > pmic { > pmic_int_l: pmic-int-l { > rockchip,pins = <1 RK_PC5 RK_FUNC_GPIO &pcfg_pull_up>; > @@ -408,6 +515,10 @@ bt_reset_pin: bt-reset-pin { > }; > }; > > +&pwm0 { > + status = "okay"; > +}; > + > &sdio0 { > bus-width = <4>; > cap-sd-highspeed; > @@ -472,3 +583,15 @@ bluetooth { > &uart2 { > status = "okay"; > }; > + > +&vopb { > + status = "okay"; > + assigned-clocks = <&cru DCLK_VOP0_DIV>, <&cru DCLK_VOP0>, > + <&cru ACLK_VOP0>, <&cru HCLK_VOP0>; > + assigned-clock-rates = <0>, <0>, <400000000>, <100000000>; > + assigned-clock-parents = <&cru PLL_CPLL>, <&cru DCLK_VOP0_FRAC>; > +}; So here you're putting a fractional clock into path between CPLL -> VOP0_DIV -> DCLK_VOP0_FRAC -> DCLK_VOP0. Fractional clocks require 20x difference between input and output rates, and CPLL is 800Mhz IIRC, while you require 74.25MHz DCLK, so this will not work correctly. Even if this somehow works by fractional clock being bypassed, I did not design the panel mode to be used with CPLL's 800 MHz, but with GPLL frequecy of 594 MHz. GPLL 594/74.25 = 8 (integral divider without the need for fractional clock) CPLL 800/74.25 = ~10.77441077441077441077 If you really want to use fractional clock, you'd need to parent it to VPLL and set VPLL really high, like close to 2GHz. kind regards, o. > +&vopb_mmu { > + status = "okay"; > +}; > -- > 2.38.1 >