From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A49A5C4167B for ; Fri, 30 Dec 2022 15:41:58 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 659028500F; Fri, 30 Dec 2022 16:41:56 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="uose7Ocf"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 3BD5883013; Fri, 30 Dec 2022 16:41:55 +0100 (CET) Received: from mail-qt1-x82e.google.com (mail-qt1-x82e.google.com [IPv6:2607:f8b0:4864:20::82e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 3F5BC8552C for ; Fri, 30 Dec 2022 16:41:51 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x82e.google.com with SMTP id s9so17375949qtx.6 for ; Fri, 30 Dec 2022 07:41:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Q0t2I+ZRaufmuiDlH2QU/s9W3qupGkBNpIFSN9f7c98=; b=uose7OcfHpfOMLu58z3MEsxUT94oOS1F3//q4adHGvY76B7g7VgCNUEkNO4ue4cUuV BJhLYznRM/Zhe2bWonWuvwAgpVhYpRUimVV0ompRyPOfZuO0szTp9QQ77aOT3FXELTFX GeZJEw9HtL9TJEM6dBR4PJ3Ehn/4IynI9XbpQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Q0t2I+ZRaufmuiDlH2QU/s9W3qupGkBNpIFSN9f7c98=; b=TkyILd6+GbfqFI8Qr/cymyWMn4UNmJHveEZ+n3kazTaX3zI7Xf6TY7VQ/C7da+maFJ l5IOPeoNqF1xeQpP1lrGsy8kwLJwVz+OUfe91t96A4qXEcVEVE5zADlSMetJuSu+od63 lAXt8o+1eoIP1dFTWwNqFWOXxaKqNx1fu+6EvAB9WTi+3THVnLu1mrU27nglRW3ptLsH vlYx4iI6DF0jRjAM4R1ZoqMb1Lv2S/3wnFwh9LbiK60V/e13RMilT4FLhM9I12Uhwtzf QSvE8Fzu2F6whI4GKHNuq+9yYAssMnorCu8yugRz3ByxEzm7AGZ2sapx007MaaU2ZSxL qagg== X-Gm-Message-State: AFqh2kpXYNdFH4ViUTFosYqUNVDNLEV2D74/uQuYq68+yoYf9UsTayzG MmhP9J8PnLApdkgqLRp6UrSfvA== X-Google-Smtp-Source: AMrXdXtMYnjZJUj73TiwZ5mh7oxk+4ZlutzMpZVtaNq7J4JuRI3UxFYjkOqvInymLWBURWUP5lxUmw== X-Received: by 2002:ac8:7c8f:0:b0:3ab:67d3:8f59 with SMTP id y15-20020ac87c8f000000b003ab67d38f59mr36566799qtv.59.1672414909911; Fri, 30 Dec 2022 07:41:49 -0800 (PST) Received: from bill-the-cat (2603-6081-7b00-6400-a5a5-eb4c-bea2-121a.res6.spectrum.com. [2603:6081:7b00:6400:a5a5:eb4c:bea2:121a]) by smtp.gmail.com with ESMTPSA id s10-20020ac8528a000000b003a7e2aea23esm13073111qtn.86.2022.12.30.07.41.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Dec 2022 07:41:49 -0800 (PST) Date: Fri, 30 Dec 2022 10:41:47 -0500 From: Tom Rini To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: Simon Glass , Heiko Schocher , u-boot@lists.denx.de Subject: Re: [PATCH u-boot 2/2] Makefile: Build working u-boot-dtb.bin target also for mpc85xx Message-ID: <20221230154147.GA3787616@bill-the-cat> References: <20221228200437.30971-1-pali@kernel.org> <20221228200437.30971-2-pali@kernel.org> <20221230124811.zkzqgnxszidyy4ae@pali> <20221230152104.GZ3787616@bill-the-cat> <20221230152443.pnpahsbn5hn25zks@pali> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Ecq120F6Lm/k9jBh" Content-Disposition: inline In-Reply-To: <20221230152443.pnpahsbn5hn25zks@pali> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --Ecq120F6Lm/k9jBh Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Dec 30, 2022 at 04:24:43PM +0100, Pali Roh=E1r wrote: > On Friday 30 December 2022 10:21:04 Tom Rini wrote: > > > In this case it would be better to build u-boot-dts.bin only by binman > > > (for all platforms) instead of cat-ing rules in Makefile. > >=20 > > This would also be an easier path forward perhaps for making sure that > > the dtb is always 8 byte aligned? >=20 > Well, no. With DTB the problem is that it is not put to the correct > offset as can be specified in linker script. So moving this code from > Makefile to binman also moves this problem to another location. > 8 byte alignment is just subset of the "correct offset" problem. Right, the high level answer is binman is intended to be the tool to assemble binaries, and has to deal with "make sure binary X is at offset Y, which also has a linker symbol for run-time references". --=20 Tom --Ecq120F6Lm/k9jBh Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmOvBrgACgkQFHw5/5Y0 tyyN/gv7B9MgsnJeydqXs0JXB86wjvqNvd5HPvHo5lDp+torP+ecPj/aKhlPJVB8 bgGCFAIkM3mFmxkeDx6pVXWuqrDnF0KRita/YwmnWWVdfUAsXsV55OteiZZ8ReZP 6uTBaMR+JVb8En+NyoBPJIfPbZbJrFzHZZA81JHhL8XeW852Nf8mZ8QeGdRlG8V2 O0mtwwaDhakbZQSilo6l5vFmLVzd4YzFxwolOH7axCgI5bXLtLxVVfspyFuAyEEL 8Kh0GHc4flb2tgj9L2gmM64cBTo5Nm2ZfZ5IN4AubfKt+sHhXl6jwmPBUovhXoGB fmEKpmDaLpm9F5GaXrz+FPa4nSMO0rv2WShFr3k/2qRG+65+IIiVoEDwsdwQVHXF +8EmEE+85TLO5i1MVS5OmN8rk2I6Slbc8ZWSGLw1CgIK71lVAkIpej9wOmV0vqGb uhIInYIj8zS8vfj//UJo9qawUMaya4gnwekw7UNOQvlIfl+7U+xrbfGZs7iwVLx6 p0KUF/zL =9jdL -----END PGP SIGNATURE----- --Ecq120F6Lm/k9jBh--