From: Shawn Guo <shawnguo@kernel.org>
To: Lucas Stach <l.stach@pengutronix.de>
Cc: Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>, Peng Fan <peng.fan@nxp.com>,
Kieran Bingham <kieran.bingham@ideasonboard.com>,
linux-arm-kernel@lists.infradead.org,
patchwork-lst@pengutronix.de, kernel@pengutronix.de
Subject: Re: [PATCH 1/3] soc: imx: imx8mp-blk-ctrl: don't set power device name in
Date: Sat, 31 Dec 2022 13:31:47 +0800 [thread overview]
Message-ID: <20221231053146.GA6112@T480> (raw)
In-Reply-To: <20220826191305.3215706-1-l.stach@pengutronix.de>
On Fri, Aug 26, 2022 at 09:13:03PM +0200, Lucas Stach wrote:
> Setting the device name after it has been registered confuses the sysfs
> cleanup paths. This has already been fixed for the imx8m-blk-ctrl driver in
> b64b46fbaa1d ("Revert "soc: imx: imx8m-blk-ctrl: set power device name""),
> but the same problem exists in imx8mp-blk-ctrl.
>
> Fixes: 556f5cf9568a ("soc: imx: add i.MX8MP HSIO blk-ctrl")
> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
For patch subject, what does "in" mean there? Should we just drop it or
add something after it?
Shawn
> ---
> drivers/soc/imx/imx8mp-blk-ctrl.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/soc/imx/imx8mp-blk-ctrl.c b/drivers/soc/imx/imx8mp-blk-ctrl.c
> index 4ca2ede6871b..9401df25c85a 100644
> --- a/drivers/soc/imx/imx8mp-blk-ctrl.c
> +++ b/drivers/soc/imx/imx8mp-blk-ctrl.c
> @@ -529,7 +529,6 @@ static int imx8mp_blk_ctrl_probe(struct platform_device *pdev)
> ret = PTR_ERR(domain->power_dev);
> goto cleanup_pds;
> }
> - dev_set_name(domain->power_dev, "%s", data->name);
>
> domain->genpd.name = data->name;
> domain->genpd.power_on = imx8mp_blk_ctrl_power_on;
> --
> 2.30.2
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-12-31 5:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-26 19:13 [PATCH 1/3] soc: imx: imx8mp-blk-ctrl: don't set power device name in Lucas Stach
2022-08-26 19:13 ` [PATCH 2/3] soc: imx: imx8mp-blk-ctrl: enable global pixclk with HDMI_TX_PHY PD Lucas Stach
2022-08-29 1:56 ` Peng Fan
2022-12-15 15:09 ` Lucas Stach
2022-12-31 5:41 ` Shawn Guo
2022-08-26 19:13 ` [PATCH 3/3] soc: imx: gpcv2: split PGC domain probe in two passes Lucas Stach
2022-08-29 1:55 ` Peng Fan
2022-08-29 7:15 ` Lucas Stach
2022-08-29 1:51 ` [PATCH 1/3] soc: imx: imx8mp-blk-ctrl: don't set power device name in Peng Fan
2022-12-31 5:31 ` Shawn Guo [this message]
2023-01-01 3:15 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221231053146.GA6112@T480 \
--to=shawnguo@kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=kieran.bingham@ideasonboard.com \
--cc=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=patchwork-lst@pengutronix.de \
--cc=peng.fan@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.