From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0AA64C3DA7A for ; Mon, 2 Jan 2023 10:58:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=PCbLpVEzhgrx8rRD287D3+oQU4E26GjqLwz9NJ/mcIA=; b=mfsDY0igSlyQk+ 9Gqdo32J1tZaAZ5R+F5Bu3bpELA+ZO/9cGMebf1AlX3iQ6HSOnZVDqzAk9TXyRPu0Gw2nl0PTIpr/ zb/favwhKhj3YXbP4BSPMEPYZriY6O9TfX9f7wRcxxKs4WH65T/YVj7thh1KXxCS849suDOosiACF 13kVaObDF4HqGsY64ITGyIvzGEHoMAZspMAE4UNTCwg6r3KWSkBOtn5XYGq7jRPQFDgi+BUqg4jYz eulcEa67eM/BnVmVrmlaGi6tibSlfdoIGl1HpDTtG2F/WikrBnhSKDiChZ6+C/NdGub6Y06M6V8xU 05iaLFpCrmTxObTfUcMA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pCIWY-00AZM8-MQ; Mon, 02 Jan 2023 10:58:35 +0000 Received: from vps.xff.cz ([195.181.215.36]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pCIVw-00AZ4h-0p; Mon, 02 Jan 2023 10:58:15 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=xff.cz; s=mail; t=1672657066; bh=F4SkNUKtXmiMKcbm5JjpkGe1luxSiwhxxZE9A69pJoQ=; h=Date:From:To:Cc:Subject:X-My-GPG-KeyId:References:From; b=t3Gf17cNfS97ha3LFp5M06o5kw9u6PX4x3stnGo1CUvJAdNqxmXcnyjcI3Wg19En1 e0HZPRGHjG+pd5NWMDj7TuyAgXfpQpKvc+jNNZhox38nBMbbSOS5zCSwZMii5slNhQ JPV0KP8jgpKaGjz/aBAeO5OPqzeb0BKBDBRYtbnc= Date: Mon, 2 Jan 2023 11:57:46 +0100 From: =?utf-8?Q?Ond=C5=99ej?= Jirman To: Javier Martinez Canillas Cc: linux-kernel@vger.kernel.org, Kamil =?utf-8?Q?Trzci=C5=84ski?= , Martijn Braam , Sam Ravnborg , Robert Mader , Tom Fitzhenry , Peter Robinson , Onuralp Sezer , dri-devel@lists.freedesktop.org, Maya Matuszczyk , Neal Gompa , linux-arm-kernel@lists.infradead.org, Krzysztof Kozlowski , Jagan Teki , Caleb Connolly , Heiko Stuebner , Krzysztof Kozlowski , Rob Herring , devicetree@vger.kernel.org, linux-rockchip@lists.infradead.org Subject: Re: [PATCH v4 4/4] arm64: dts: rk3399-pinephone-pro: Add internal display support Message-ID: <20230102105746.5abnjzwf365c6hy2@core> Mail-Followup-To: =?utf-8?Q?Ond=C5=99ej?= Jirman , Javier Martinez Canillas , linux-kernel@vger.kernel.org, Kamil =?utf-8?Q?Trzci=C5=84ski?= , Martijn Braam , Sam Ravnborg , Robert Mader , Tom Fitzhenry , Peter Robinson , Onuralp Sezer , dri-devel@lists.freedesktop.org, Maya Matuszczyk , Neal Gompa , linux-arm-kernel@lists.infradead.org, Krzysztof Kozlowski , Jagan Teki , Caleb Connolly , Heiko Stuebner , Krzysztof Kozlowski , Rob Herring , devicetree@vger.kernel.org, linux-rockchip@lists.infradead.org X-My-GPG-KeyId: EBFBDDE11FB918D44D1F56C1F9F0A873BE9777ED References: <20221230113155.3430142-1-javierm@redhat.com> <20221230113155.3430142-5-javierm@redhat.com> <20221230153745.tfs6n4zy4xfwugbw@core> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230102_025756_290322_5CBE0B94 X-CRM114-Status: GOOD ( 37.77 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org SGVsbG8gSmF2aWVyLAoKT24gU2F0LCBEZWMgMzEsIDIwMjIgYXQgMDQ6Mjk6NDlQTSArMDEwMCwg SmF2aWVyIE1hcnRpbmV6IENhbmlsbGFzIHdyb3RlOgo+IEhlbGxvIE9uZMWZZWosCj4gCj4gVGhh bmtzIGEgbG90IGZvciB5b3VyIGZlZWRiYWNrLgo+IAo+IE9uIDEyLzMwLzIyIDE2OjM3LCBPbmTF mWVqIEppcm1hbiB3cm90ZToKPiAKPiBbLi4uXQo+IAo+ID4+ICAmaTJjMCB7Cj4gPj4gIAljbG9j ay1mcmVxdWVuY3kgPSA8NDAwMDAwPjsKPiA+PiAgCWkyYy1zY2wtcmlzaW5nLXRpbWUtbnMgPSA8 MTY4PjsKPiA+PiBAQCAtMjE0LDYgKzI1MSw5IEBAIHZjYzN2MF90b3VjaDogTERPX1JFRzIgewo+ ID4+ICAJCQkJcmVndWxhdG9yLW5hbWUgPSAidmNjM3YwX3RvdWNoIjsKPiA+PiAgCQkJCXJlZ3Vs YXRvci1taW4tbWljcm92b2x0ID0gPDMwMDAwMDA+Owo+ID4+ICAJCQkJcmVndWxhdG9yLW1heC1t aWNyb3ZvbHQgPSA8MzAwMDAwMD47Cj4gPj4gKwkJCQlyZWd1bGF0b3Itc3RhdGUtbWVtIHsKPiA+ PiArCQkJCQlyZWd1bGF0b3Itb2ZmLWluLXN1c3BlbmQ7Cj4gPj4gKwkJCQl9Owo+ID4gCj4gPiBZ b3UncmUgaW5zdHJ1Y3RpbmcgUks4MTggdG8gc2h1dCBkb3duIHRoZSByZWd1bGF0b3IgZm9yIHRv dWNoIGNvbnRyb2xsZXIgZHVyaW5nCj4gPiBzdXNwZW5kLCBidXQgSSB0aGluayBHb29kaXggZHJp dmVyIGV4cGVjdHMgdG91Y2ggY29udHJvbGxlciB0byBiZSBrZXB0IHBvd2VyZWQgb24KPiA+IGR1 cmluZyBzdXNwZW5kLiBBbSBJIG1pc3Npbmcgc29tZXRoaW5nPwo+ID4gCj4gPiBodHRwczovL2Vs aXhpci5ib290bGluLmNvbS9saW51eC9sYXRlc3Qvc291cmNlL2RyaXZlcnMvaW5wdXQvdG91Y2hz Y3JlZW4vZ29vZGl4LmMjTDE0MDUKPiA+Cj4gCj4gWW91IHRlbGwgbWUsIGl0IGlzIHlvdXIgcGF0 Y2ggOikgSSBqdXN0IGNoZXJyeS1waWNrZWQgdGhpcyBmcm9tIHlvdXIgdHJlZToKCkkgaGF2ZSBv dGhlciBwYXRjaGVzIHRvIGdvb2RpeCBkcml2ZXIgdGhhdCBkbyBwb3dlciBvZmYgdGhlIHRvdWNo IHNlbnNvciBjaGlwCmR1cmluZyBzbGVlcCwgc28gdGhhdCBpdCBkb2Vzbid0IGNvbnN1bWUgZXhj ZXNzaW52ZSBhbW91bnRzIG9mIHBvd2VyIHdoZW4KdGhlIHBob25lIGlzIHN1c3BlbmRlZC4gTWFp bmxpbmUgZG9lc24ndC4gWW91IGhhdmUgdG8gYWRhcHQgdGhpcyB0byBtYWlubGluZSwKYmVjYXVz ZSB5b3UncmUgbm90IHVwc3RyZWFtaW5nIHRoZSByZXF1aXJlZCBHb29kaXggcGF0Y2hlcywgZm9y IHJlZ3VsYXRvci1vZmYtaW4tc3VzcGVuZAp0byBub3QgYnJlYWsgdGhpbmdzLgoKPiBodHRwczov L2dpdGh1Yi5jb20vbWVnb3VzL2xpbnV4L2NvbW1pdC8xMWY4ZGE2MGQ2YTUKPiAKPiBCdXQgaWYg dGhhdCBpcyBub3QgY29ycmVjdCwgdGhlbiBJIGNhbiBkcm9wIHRoZSByZWd1bGF0b3Itb2ZmLWlu LXN1c3BlbmQuCj4gIAo+IFsuLi5dCj4gCj4gPj4gKwo+ID4+ICsJdG91Y2hzY3JlZW5AMTQgewo+ ID4+ICsJCWNvbXBhdGlibGUgPSAiZ29vZGl4LGd0OTE3cyI7Cj4gPiAKPiA+IFRoaXMgaXMgbm90 IHRoZSBjb3JyZWN0IGNvbXBhdGlibGUuIFBpbmVwaG9uZSBQcm8gdXNlcyBHb29kaXggR1QxMTU4 Ogo+ID4gCj4gPiBHb29kaXgtVFMgMy0wMDE0OiBJRCAxMTU4LCB2ZXJzaW9uOiAwMTAwCj4gPiBH b29kaXgtVFMgMy0wMDE0OiBEaXJlY3QgZmlybXdhcmUgbG9hZCBmb3IgZ29vZGl4XzExNThfY2Zn LmJpbiBmYWlsZWQgd2l0aCBlcnJvciAtMgo+ID4gCj4gPgo+IAo+IFNhbWUgdGhpbmcuIEkgd2Fz bid0IGF3YXJlIG9mIHRoaXMgc2luY2UgeW91ciBwYXRjaCB3YXMgdXNpbmcgdGhpcyBjb21wYXRp YmxlCj4gc3RyaW5nLiBJZiAiZ29vZGl4LGd0MTE1OCIgaXMgdGhlIGNvcnJlY3QgY29tcGF0aWJs ZSBzdHJpbmcsIHRoZW4gSSBhZ3JlZSB3ZQo+IHNob3VsZCBoYXZlIHRoYXQgaW5zdGVhZCBldmVu IHdoZW4gdGhlIGZpcm13YXJlIGlzIG1pc3NpbmcuIEJlY2F1c2UgdGhlIERUIGlzCj4gc3VwcG9z ZWQgdG8gZGVzY3JpYmUgdGhlIGhhcmR3YXJlLiBUaGUgRlcgaXNzdWUgY2FuIGJlIHRhY2tsZWQg YXMgYSBmb2xsb3ctdXAuCj4gCj4gWy4uLl0gCgpZZXMsIGNvbXBhdGlibGUgc3RyaW5nIGlzIHNv cnQgb2YgaXJyZWxldmFudCwgYmVjYXVzZSB0aGUgZHJpdmVyIGRvZXMgcnVudGltZQphdXRvLWRl dGVjdGlvbiBiYXNlZCBvbiBjaGlwIElELiBJIGRpZG4ndCBib3RoZXIgd2l0aCBzdXBlcmZpY2lh bCBpc3N1ZXMgaW4gdGhlCm9yaWdpbmFsIGNvZGUgZnJvbSBNYXJ0aWpuL0thbWlsLiBOb3cgdGhh dCB5b3UncmUgbWFpbmxpbmluZyB0aGUgY29kZSwgdGhpcwpzaG91bGQgYmUgc29ydGVkIG91dCwg dGhvdWdoLgoKVGhlcmUncyBubyBGVyBpc3N1ZSwgSSB3YXMganVzdCB1c2luZyB0aGUgbG9nIHRv IHNob3cgeW91IHRoZSBhY3R1YWwgY2hpcCBJRCB0aGUKZHJpdmVyIGRldGVjdHMuCgooWW91IHNo b3VsZCBwcm9iYWJseSBwdXQgbXkgU29CIGFmdGVyIEthbWlsL01hcnRpam4sIHNpbmNlIEkgdG9v ayB0aGUKbWFpbnRlbmFuY2UvZGV2ZWxvcG1lbnQgb2YgdGhlIGRyaXZlciBhZnRlciB0aGV5IHdy b3RlIHRoZSBiYXNlIHN1cHBvcnQKaW5pdGlhbGx5IGluIHNlY3JldC4gSSdtIG5vdCB0aGUgb3Jp Z2luYWwgYXV0aG9yIG9mIHRoZSBjb2RlLikKCj4gPj4gKwo+ID4+ICsmdm9wYiB7Cj4gPj4gKwlz dGF0dXMgPSAib2theSI7Cj4gPj4gKwlhc3NpZ25lZC1jbG9ja3MgPSA8JmNydSBEQ0xLX1ZPUDBf RElWPiwgPCZjcnUgRENMS19WT1AwPiwKPiA+PiArCQkJICA8JmNydSBBQ0xLX1ZPUDA+LCA8JmNy dSBIQ0xLX1ZPUDA+Owo+ID4+ICsJYXNzaWduZWQtY2xvY2stcmF0ZXMgPSA8MD4sIDwwPiwgPDQw MDAwMDAwMD4sIDwxMDAwMDAwMDA+Owo+ID4+ICsJYXNzaWduZWQtY2xvY2stcGFyZW50cyA9IDwm Y3J1IFBMTF9DUExMPiwgPCZjcnUgRENMS19WT1AwX0ZSQUM+Owo+ID4+ICt9Owo+ID4gCj4gPiBT byBoZXJlIHlvdSdyZSBwdXR0aW5nIGEgZnJhY3Rpb25hbCBjbG9jayBpbnRvIHBhdGggYmV0d2Vl biBDUExMIC0+IFZPUDBfRElWCj4gPiAtPiBEQ0xLX1ZPUDBfRlJBQyAtPiBEQ0xLX1ZPUDAuCj4g PiAKPiA+IEZyYWN0aW9uYWwgY2xvY2tzIHJlcXVpcmUgMjB4IGRpZmZlcmVuY2UgYmV0d2VlbiBp bnB1dCBhbmQgb3V0cHV0IHJhdGVzLCBhbmQKPiA+IENQTEwgaXMgODAwTWh6IElJUkMsIHdoaWxl IHlvdSByZXF1aXJlIDc0LjI1TUh6IERDTEssIHNvIHRoaXMgd2lsbCBub3Qgd29yawo+ID4gY29y cmVjdGx5Lgo+ID4gCj4gPiBFdmVuIGlmIHRoaXMgc29tZWhvdyB3b3JrcyBieSBmcmFjdGlvbmFs IGNsb2NrIGJlaW5nIGJ5cGFzc2VkLCBJIGRpZCBub3QgZGVzaWduCj4gPiB0aGUgcGFuZWwgbW9k ZSB0byBiZSB1c2VkIHdpdGggQ1BMTCdzIDgwMCBNSHosIGJ1dCB3aXRoIEdQTEwgZnJlcXVlY3kg b2YgNTk0IE1Iei4KPiA+IAo+ID4gR1BMTCA1OTQvNzQuMjUgPSA4ICAoaW50ZWdyYWwgZGl2aWRl ciB3aXRob3V0IHRoZSBuZWVkIGZvciBmcmFjdGlvbmFsIGNsb2NrKQo+ID4gQ1BMTCA4MDAvNzQu MjUgPSB+MTAuNzc0NDEwNzc0NDEwNzc0NDEwNzcKPiA+IAo+ID4gSWYgeW91IHJlYWxseSB3YW50 IHRvIHVzZSBmcmFjdGlvbmFsIGNsb2NrLCB5b3UnZCBuZWVkIHRvIHBhcmVudCBpdCB0byBWUExM Cj4gPiBhbmQgc2V0IFZQTEwgcmVhbGx5IGhpZ2gsIGxpa2UgY2xvc2UgdG8gMkdIei4KPiA+Cj4g Cj4gVGhhbmtzIGZvciB0aGUgZXhwbGFuYXRpb24uIFRoZW4gSSBqdXN0IG5lZWQgdG8gc3F1YXNo IG9uIHRvcCBvZiB0aGlzLCB0aGUKPiBmb2xsb3dpbmcgcGF0Y2guIElzIHRoYXQgY29ycmVjdD8K PiAKPiBodHRwczovL2dpdGh1Yi5jb20vbWVnb3VzL2xpbnV4L2NvbW1pdC9mMTljZTdiYjdkNzIK ClllcywgYW5kIHRlc3QgdGhlIGRyaXZlciBtb3JlIHRob3JvdWdobHk6CgotIGxvb2sgYXQgY2xr X3N1bW1hcnkgdG8gdmVyaWZ5IGNsb2NrIHJhdGUgdGhlIGtlcm5lbCB0aGlua3MgaXQncyB1c2lu ZwotIHRlc3QgcmVmcmVzaCByYXRlLCBzb21laG93LCB0byBhZ2FpbiB2ZXJpZnkgdGhlIGFjdHVh bCBjbG9jayByYXRlIChrZXJuZWwgY2FuCiAgbGllIGluIGRlYnVnZnMpCi0gdGVzdCBwb3dlciBj eWNsaW5nIHRoZSBwYW5lbCAoZWcuIHZpYSBzeXN0ZW0gc3VzcGVuZC9yZXN1bWUgb3Igb3RoZXIg bWVhbnMpCgp0aGFuayB5b3UgYW5kIGtpbmQgcmVnYXJkcywKCW8uCgo+IC0tIAo+IEJlc3QgcmVn YXJkcywKPiAKPiBKYXZpZXIgTWFydGluZXogQ2FuaWxsYXMKPiBDb3JlIFBsYXRmb3Jtcwo+IFJl ZCBIYXQKPiAKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CkxpbnV4LXJvY2tjaGlwIG1haWxpbmcgbGlzdApMaW51eC1yb2NrY2hpcEBsaXN0cy5pbmZyYWRl YWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgt cm9ja2NoaXAK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1806CC3DA7A for ; Mon, 2 Jan 2023 11:00:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=aPrvYlxyyYAQSjJd6WUzBrci4DSTSsCWuGd9uoJqd/8=; b=d/VGlzEB4DojHc YpZCkHfoxodNLlXAs+Hby8gtE0ad7vzcNpaEW+SrcsLa9DUihQUtI1DtgzLRESubgivoORCPWwmE8 hn5ecjz41PMIbshEZ5LIVjO2uhIdqFQ1bCdiU6YgHEYc7+pgaI2MYv6+G6h163dHOm3AzrbWGmO2J g2Ub7QS7N2vQp5HbQfnI4LuuyiszuYq5uK8J+hulAkUyFETl3wahuTyXoOBtzGivmQ295DN9QKNi0 xS4CM9pdTm6rDnIM5w2+e95LD5hKv4bEBIwg7yURB9ABSosdQ3qN6zR20o5z2DFlALMnBM7MfTfCC 7bDjv084ZQJPxkRY+xcw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pCIX5-00AZaH-8m; Mon, 02 Jan 2023 10:59:07 +0000 Received: from vps.xff.cz ([195.181.215.36]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pCIVw-00AZ4h-0p; Mon, 02 Jan 2023 10:58:15 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=xff.cz; s=mail; t=1672657066; bh=F4SkNUKtXmiMKcbm5JjpkGe1luxSiwhxxZE9A69pJoQ=; h=Date:From:To:Cc:Subject:X-My-GPG-KeyId:References:From; b=t3Gf17cNfS97ha3LFp5M06o5kw9u6PX4x3stnGo1CUvJAdNqxmXcnyjcI3Wg19En1 e0HZPRGHjG+pd5NWMDj7TuyAgXfpQpKvc+jNNZhox38nBMbbSOS5zCSwZMii5slNhQ JPV0KP8jgpKaGjz/aBAeO5OPqzeb0BKBDBRYtbnc= Date: Mon, 2 Jan 2023 11:57:46 +0100 From: =?utf-8?Q?Ond=C5=99ej?= Jirman To: Javier Martinez Canillas Cc: linux-kernel@vger.kernel.org, Kamil =?utf-8?Q?Trzci=C5=84ski?= , Martijn Braam , Sam Ravnborg , Robert Mader , Tom Fitzhenry , Peter Robinson , Onuralp Sezer , dri-devel@lists.freedesktop.org, Maya Matuszczyk , Neal Gompa , linux-arm-kernel@lists.infradead.org, Krzysztof Kozlowski , Jagan Teki , Caleb Connolly , Heiko Stuebner , Krzysztof Kozlowski , Rob Herring , devicetree@vger.kernel.org, linux-rockchip@lists.infradead.org Subject: Re: [PATCH v4 4/4] arm64: dts: rk3399-pinephone-pro: Add internal display support Message-ID: <20230102105746.5abnjzwf365c6hy2@core> Mail-Followup-To: =?utf-8?Q?Ond=C5=99ej?= Jirman , Javier Martinez Canillas , linux-kernel@vger.kernel.org, Kamil =?utf-8?Q?Trzci=C5=84ski?= , Martijn Braam , Sam Ravnborg , Robert Mader , Tom Fitzhenry , Peter Robinson , Onuralp Sezer , dri-devel@lists.freedesktop.org, Maya Matuszczyk , Neal Gompa , linux-arm-kernel@lists.infradead.org, Krzysztof Kozlowski , Jagan Teki , Caleb Connolly , Heiko Stuebner , Krzysztof Kozlowski , Rob Herring , devicetree@vger.kernel.org, linux-rockchip@lists.infradead.org X-My-GPG-KeyId: EBFBDDE11FB918D44D1F56C1F9F0A873BE9777ED References: <20221230113155.3430142-1-javierm@redhat.com> <20221230113155.3430142-5-javierm@redhat.com> <20221230153745.tfs6n4zy4xfwugbw@core> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230102_025756_290322_5CBE0B94 X-CRM114-Status: GOOD ( 37.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGVsbG8gSmF2aWVyLAoKT24gU2F0LCBEZWMgMzEsIDIwMjIgYXQgMDQ6Mjk6NDlQTSArMDEwMCwg SmF2aWVyIE1hcnRpbmV6IENhbmlsbGFzIHdyb3RlOgo+IEhlbGxvIE9uZMWZZWosCj4gCj4gVGhh bmtzIGEgbG90IGZvciB5b3VyIGZlZWRiYWNrLgo+IAo+IE9uIDEyLzMwLzIyIDE2OjM3LCBPbmTF mWVqIEppcm1hbiB3cm90ZToKPiAKPiBbLi4uXQo+IAo+ID4+ICAmaTJjMCB7Cj4gPj4gIAljbG9j ay1mcmVxdWVuY3kgPSA8NDAwMDAwPjsKPiA+PiAgCWkyYy1zY2wtcmlzaW5nLXRpbWUtbnMgPSA8 MTY4PjsKPiA+PiBAQCAtMjE0LDYgKzI1MSw5IEBAIHZjYzN2MF90b3VjaDogTERPX1JFRzIgewo+ ID4+ICAJCQkJcmVndWxhdG9yLW5hbWUgPSAidmNjM3YwX3RvdWNoIjsKPiA+PiAgCQkJCXJlZ3Vs YXRvci1taW4tbWljcm92b2x0ID0gPDMwMDAwMDA+Owo+ID4+ICAJCQkJcmVndWxhdG9yLW1heC1t aWNyb3ZvbHQgPSA8MzAwMDAwMD47Cj4gPj4gKwkJCQlyZWd1bGF0b3Itc3RhdGUtbWVtIHsKPiA+ PiArCQkJCQlyZWd1bGF0b3Itb2ZmLWluLXN1c3BlbmQ7Cj4gPj4gKwkJCQl9Owo+ID4gCj4gPiBZ b3UncmUgaW5zdHJ1Y3RpbmcgUks4MTggdG8gc2h1dCBkb3duIHRoZSByZWd1bGF0b3IgZm9yIHRv dWNoIGNvbnRyb2xsZXIgZHVyaW5nCj4gPiBzdXNwZW5kLCBidXQgSSB0aGluayBHb29kaXggZHJp dmVyIGV4cGVjdHMgdG91Y2ggY29udHJvbGxlciB0byBiZSBrZXB0IHBvd2VyZWQgb24KPiA+IGR1 cmluZyBzdXNwZW5kLiBBbSBJIG1pc3Npbmcgc29tZXRoaW5nPwo+ID4gCj4gPiBodHRwczovL2Vs aXhpci5ib290bGluLmNvbS9saW51eC9sYXRlc3Qvc291cmNlL2RyaXZlcnMvaW5wdXQvdG91Y2hz Y3JlZW4vZ29vZGl4LmMjTDE0MDUKPiA+Cj4gCj4gWW91IHRlbGwgbWUsIGl0IGlzIHlvdXIgcGF0 Y2ggOikgSSBqdXN0IGNoZXJyeS1waWNrZWQgdGhpcyBmcm9tIHlvdXIgdHJlZToKCkkgaGF2ZSBv dGhlciBwYXRjaGVzIHRvIGdvb2RpeCBkcml2ZXIgdGhhdCBkbyBwb3dlciBvZmYgdGhlIHRvdWNo IHNlbnNvciBjaGlwCmR1cmluZyBzbGVlcCwgc28gdGhhdCBpdCBkb2Vzbid0IGNvbnN1bWUgZXhj ZXNzaW52ZSBhbW91bnRzIG9mIHBvd2VyIHdoZW4KdGhlIHBob25lIGlzIHN1c3BlbmRlZC4gTWFp bmxpbmUgZG9lc24ndC4gWW91IGhhdmUgdG8gYWRhcHQgdGhpcyB0byBtYWlubGluZSwKYmVjYXVz ZSB5b3UncmUgbm90IHVwc3RyZWFtaW5nIHRoZSByZXF1aXJlZCBHb29kaXggcGF0Y2hlcywgZm9y IHJlZ3VsYXRvci1vZmYtaW4tc3VzcGVuZAp0byBub3QgYnJlYWsgdGhpbmdzLgoKPiBodHRwczov L2dpdGh1Yi5jb20vbWVnb3VzL2xpbnV4L2NvbW1pdC8xMWY4ZGE2MGQ2YTUKPiAKPiBCdXQgaWYg dGhhdCBpcyBub3QgY29ycmVjdCwgdGhlbiBJIGNhbiBkcm9wIHRoZSByZWd1bGF0b3Itb2ZmLWlu LXN1c3BlbmQuCj4gIAo+IFsuLi5dCj4gCj4gPj4gKwo+ID4+ICsJdG91Y2hzY3JlZW5AMTQgewo+ ID4+ICsJCWNvbXBhdGlibGUgPSAiZ29vZGl4LGd0OTE3cyI7Cj4gPiAKPiA+IFRoaXMgaXMgbm90 IHRoZSBjb3JyZWN0IGNvbXBhdGlibGUuIFBpbmVwaG9uZSBQcm8gdXNlcyBHb29kaXggR1QxMTU4 Ogo+ID4gCj4gPiBHb29kaXgtVFMgMy0wMDE0OiBJRCAxMTU4LCB2ZXJzaW9uOiAwMTAwCj4gPiBH b29kaXgtVFMgMy0wMDE0OiBEaXJlY3QgZmlybXdhcmUgbG9hZCBmb3IgZ29vZGl4XzExNThfY2Zn LmJpbiBmYWlsZWQgd2l0aCBlcnJvciAtMgo+ID4gCj4gPgo+IAo+IFNhbWUgdGhpbmcuIEkgd2Fz bid0IGF3YXJlIG9mIHRoaXMgc2luY2UgeW91ciBwYXRjaCB3YXMgdXNpbmcgdGhpcyBjb21wYXRp YmxlCj4gc3RyaW5nLiBJZiAiZ29vZGl4LGd0MTE1OCIgaXMgdGhlIGNvcnJlY3QgY29tcGF0aWJs ZSBzdHJpbmcsIHRoZW4gSSBhZ3JlZSB3ZQo+IHNob3VsZCBoYXZlIHRoYXQgaW5zdGVhZCBldmVu IHdoZW4gdGhlIGZpcm13YXJlIGlzIG1pc3NpbmcuIEJlY2F1c2UgdGhlIERUIGlzCj4gc3VwcG9z ZWQgdG8gZGVzY3JpYmUgdGhlIGhhcmR3YXJlLiBUaGUgRlcgaXNzdWUgY2FuIGJlIHRhY2tsZWQg YXMgYSBmb2xsb3ctdXAuCj4gCj4gWy4uLl0gCgpZZXMsIGNvbXBhdGlibGUgc3RyaW5nIGlzIHNv cnQgb2YgaXJyZWxldmFudCwgYmVjYXVzZSB0aGUgZHJpdmVyIGRvZXMgcnVudGltZQphdXRvLWRl dGVjdGlvbiBiYXNlZCBvbiBjaGlwIElELiBJIGRpZG4ndCBib3RoZXIgd2l0aCBzdXBlcmZpY2lh bCBpc3N1ZXMgaW4gdGhlCm9yaWdpbmFsIGNvZGUgZnJvbSBNYXJ0aWpuL0thbWlsLiBOb3cgdGhh dCB5b3UncmUgbWFpbmxpbmluZyB0aGUgY29kZSwgdGhpcwpzaG91bGQgYmUgc29ydGVkIG91dCwg dGhvdWdoLgoKVGhlcmUncyBubyBGVyBpc3N1ZSwgSSB3YXMganVzdCB1c2luZyB0aGUgbG9nIHRv IHNob3cgeW91IHRoZSBhY3R1YWwgY2hpcCBJRCB0aGUKZHJpdmVyIGRldGVjdHMuCgooWW91IHNo b3VsZCBwcm9iYWJseSBwdXQgbXkgU29CIGFmdGVyIEthbWlsL01hcnRpam4sIHNpbmNlIEkgdG9v ayB0aGUKbWFpbnRlbmFuY2UvZGV2ZWxvcG1lbnQgb2YgdGhlIGRyaXZlciBhZnRlciB0aGV5IHdy b3RlIHRoZSBiYXNlIHN1cHBvcnQKaW5pdGlhbGx5IGluIHNlY3JldC4gSSdtIG5vdCB0aGUgb3Jp Z2luYWwgYXV0aG9yIG9mIHRoZSBjb2RlLikKCj4gPj4gKwo+ID4+ICsmdm9wYiB7Cj4gPj4gKwlz dGF0dXMgPSAib2theSI7Cj4gPj4gKwlhc3NpZ25lZC1jbG9ja3MgPSA8JmNydSBEQ0xLX1ZPUDBf RElWPiwgPCZjcnUgRENMS19WT1AwPiwKPiA+PiArCQkJICA8JmNydSBBQ0xLX1ZPUDA+LCA8JmNy dSBIQ0xLX1ZPUDA+Owo+ID4+ICsJYXNzaWduZWQtY2xvY2stcmF0ZXMgPSA8MD4sIDwwPiwgPDQw MDAwMDAwMD4sIDwxMDAwMDAwMDA+Owo+ID4+ICsJYXNzaWduZWQtY2xvY2stcGFyZW50cyA9IDwm Y3J1IFBMTF9DUExMPiwgPCZjcnUgRENMS19WT1AwX0ZSQUM+Owo+ID4+ICt9Owo+ID4gCj4gPiBT byBoZXJlIHlvdSdyZSBwdXR0aW5nIGEgZnJhY3Rpb25hbCBjbG9jayBpbnRvIHBhdGggYmV0d2Vl biBDUExMIC0+IFZPUDBfRElWCj4gPiAtPiBEQ0xLX1ZPUDBfRlJBQyAtPiBEQ0xLX1ZPUDAuCj4g PiAKPiA+IEZyYWN0aW9uYWwgY2xvY2tzIHJlcXVpcmUgMjB4IGRpZmZlcmVuY2UgYmV0d2VlbiBp bnB1dCBhbmQgb3V0cHV0IHJhdGVzLCBhbmQKPiA+IENQTEwgaXMgODAwTWh6IElJUkMsIHdoaWxl IHlvdSByZXF1aXJlIDc0LjI1TUh6IERDTEssIHNvIHRoaXMgd2lsbCBub3Qgd29yawo+ID4gY29y cmVjdGx5Lgo+ID4gCj4gPiBFdmVuIGlmIHRoaXMgc29tZWhvdyB3b3JrcyBieSBmcmFjdGlvbmFs IGNsb2NrIGJlaW5nIGJ5cGFzc2VkLCBJIGRpZCBub3QgZGVzaWduCj4gPiB0aGUgcGFuZWwgbW9k ZSB0byBiZSB1c2VkIHdpdGggQ1BMTCdzIDgwMCBNSHosIGJ1dCB3aXRoIEdQTEwgZnJlcXVlY3kg b2YgNTk0IE1Iei4KPiA+IAo+ID4gR1BMTCA1OTQvNzQuMjUgPSA4ICAoaW50ZWdyYWwgZGl2aWRl ciB3aXRob3V0IHRoZSBuZWVkIGZvciBmcmFjdGlvbmFsIGNsb2NrKQo+ID4gQ1BMTCA4MDAvNzQu MjUgPSB+MTAuNzc0NDEwNzc0NDEwNzc0NDEwNzcKPiA+IAo+ID4gSWYgeW91IHJlYWxseSB3YW50 IHRvIHVzZSBmcmFjdGlvbmFsIGNsb2NrLCB5b3UnZCBuZWVkIHRvIHBhcmVudCBpdCB0byBWUExM Cj4gPiBhbmQgc2V0IFZQTEwgcmVhbGx5IGhpZ2gsIGxpa2UgY2xvc2UgdG8gMkdIei4KPiA+Cj4g Cj4gVGhhbmtzIGZvciB0aGUgZXhwbGFuYXRpb24uIFRoZW4gSSBqdXN0IG5lZWQgdG8gc3F1YXNo IG9uIHRvcCBvZiB0aGlzLCB0aGUKPiBmb2xsb3dpbmcgcGF0Y2guIElzIHRoYXQgY29ycmVjdD8K PiAKPiBodHRwczovL2dpdGh1Yi5jb20vbWVnb3VzL2xpbnV4L2NvbW1pdC9mMTljZTdiYjdkNzIK ClllcywgYW5kIHRlc3QgdGhlIGRyaXZlciBtb3JlIHRob3JvdWdobHk6CgotIGxvb2sgYXQgY2xr X3N1bW1hcnkgdG8gdmVyaWZ5IGNsb2NrIHJhdGUgdGhlIGtlcm5lbCB0aGlua3MgaXQncyB1c2lu ZwotIHRlc3QgcmVmcmVzaCByYXRlLCBzb21laG93LCB0byBhZ2FpbiB2ZXJpZnkgdGhlIGFjdHVh bCBjbG9jayByYXRlIChrZXJuZWwgY2FuCiAgbGllIGluIGRlYnVnZnMpCi0gdGVzdCBwb3dlciBj eWNsaW5nIHRoZSBwYW5lbCAoZWcuIHZpYSBzeXN0ZW0gc3VzcGVuZC9yZXN1bWUgb3Igb3RoZXIg bWVhbnMpCgp0aGFuayB5b3UgYW5kIGtpbmQgcmVnYXJkcywKCW8uCgo+IC0tIAo+IEJlc3QgcmVn YXJkcywKPiAKPiBKYXZpZXIgTWFydGluZXogQ2FuaWxsYXMKPiBDb3JlIFBsYXRmb3Jtcwo+IFJl ZCBIYXQKPiAKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5m cmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xp bnV4LWFybS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60883C3DA7A for ; Mon, 2 Jan 2023 10:57:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232730AbjABK5y (ORCPT ); Mon, 2 Jan 2023 05:57:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59546 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232724AbjABK5x (ORCPT ); Mon, 2 Jan 2023 05:57:53 -0500 Received: from vps.xff.cz (vps.xff.cz [195.181.215.36]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BFD1C25E; Mon, 2 Jan 2023 02:57:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=xff.cz; s=mail; t=1672657066; bh=F4SkNUKtXmiMKcbm5JjpkGe1luxSiwhxxZE9A69pJoQ=; h=Date:From:To:Cc:Subject:X-My-GPG-KeyId:References:From; b=t3Gf17cNfS97ha3LFp5M06o5kw9u6PX4x3stnGo1CUvJAdNqxmXcnyjcI3Wg19En1 e0HZPRGHjG+pd5NWMDj7TuyAgXfpQpKvc+jNNZhox38nBMbbSOS5zCSwZMii5slNhQ JPV0KP8jgpKaGjz/aBAeO5OPqzeb0BKBDBRYtbnc= Date: Mon, 2 Jan 2023 11:57:46 +0100 From: =?utf-8?Q?Ond=C5=99ej?= Jirman To: Javier Martinez Canillas Cc: linux-kernel@vger.kernel.org, Kamil =?utf-8?Q?Trzci=C5=84ski?= , Martijn Braam , Sam Ravnborg , Robert Mader , Tom Fitzhenry , Peter Robinson , Onuralp Sezer , dri-devel@lists.freedesktop.org, Maya Matuszczyk , Neal Gompa , linux-arm-kernel@lists.infradead.org, Krzysztof Kozlowski , Jagan Teki , Caleb Connolly , Heiko Stuebner , Krzysztof Kozlowski , Rob Herring , devicetree@vger.kernel.org, linux-rockchip@lists.infradead.org Subject: Re: [PATCH v4 4/4] arm64: dts: rk3399-pinephone-pro: Add internal display support Message-ID: <20230102105746.5abnjzwf365c6hy2@core> Mail-Followup-To: =?utf-8?Q?Ond=C5=99ej?= Jirman , Javier Martinez Canillas , linux-kernel@vger.kernel.org, Kamil =?utf-8?Q?Trzci=C5=84ski?= , Martijn Braam , Sam Ravnborg , Robert Mader , Tom Fitzhenry , Peter Robinson , Onuralp Sezer , dri-devel@lists.freedesktop.org, Maya Matuszczyk , Neal Gompa , linux-arm-kernel@lists.infradead.org, Krzysztof Kozlowski , Jagan Teki , Caleb Connolly , Heiko Stuebner , Krzysztof Kozlowski , Rob Herring , devicetree@vger.kernel.org, linux-rockchip@lists.infradead.org X-My-GPG-KeyId: EBFBDDE11FB918D44D1F56C1F9F0A873BE9777ED References: <20221230113155.3430142-1-javierm@redhat.com> <20221230113155.3430142-5-javierm@redhat.com> <20221230153745.tfs6n4zy4xfwugbw@core> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hello Javier, On Sat, Dec 31, 2022 at 04:29:49PM +0100, Javier Martinez Canillas wrote: > Hello Ondřej, > > Thanks a lot for your feedback. > > On 12/30/22 16:37, Ondřej Jirman wrote: > > [...] > > >> &i2c0 { > >> clock-frequency = <400000>; > >> i2c-scl-rising-time-ns = <168>; > >> @@ -214,6 +251,9 @@ vcc3v0_touch: LDO_REG2 { > >> regulator-name = "vcc3v0_touch"; > >> regulator-min-microvolt = <3000000>; > >> regulator-max-microvolt = <3000000>; > >> + regulator-state-mem { > >> + regulator-off-in-suspend; > >> + }; > > > > You're instructing RK818 to shut down the regulator for touch controller during > > suspend, but I think Goodix driver expects touch controller to be kept powered on > > during suspend. Am I missing something? > > > > https://elixir.bootlin.com/linux/latest/source/drivers/input/touchscreen/goodix.c#L1405 > > > > You tell me, it is your patch :) I just cherry-picked this from your tree: I have other patches to goodix driver that do power off the touch sensor chip during sleep, so that it doesn't consume excessinve amounts of power when the phone is suspended. Mainline doesn't. You have to adapt this to mainline, because you're not upstreaming the required Goodix patches, for regulator-off-in-suspend to not break things. > https://github.com/megous/linux/commit/11f8da60d6a5 > > But if that is not correct, then I can drop the regulator-off-in-suspend. > > [...] > > >> + > >> + touchscreen@14 { > >> + compatible = "goodix,gt917s"; > > > > This is not the correct compatible. Pinephone Pro uses Goodix GT1158: > > > > Goodix-TS 3-0014: ID 1158, version: 0100 > > Goodix-TS 3-0014: Direct firmware load for goodix_1158_cfg.bin failed with error -2 > > > > > > Same thing. I wasn't aware of this since your patch was using this compatible > string. If "goodix,gt1158" is the correct compatible string, then I agree we > should have that instead even when the firmware is missing. Because the DT is > supposed to describe the hardware. The FW issue can be tackled as a follow-up. > > [...] Yes, compatible string is sort of irrelevant, because the driver does runtime auto-detection based on chip ID. I didn't bother with superficial issues in the original code from Martijn/Kamil. Now that you're mainlining the code, this should be sorted out, though. There's no FW issue, I was just using the log to show you the actual chip ID the driver detects. (You should probably put my SoB after Kamil/Martijn, since I took the maintenance/development of the driver after they wrote the base support initially in secret. I'm not the original author of the code.) > >> + > >> +&vopb { > >> + status = "okay"; > >> + assigned-clocks = <&cru DCLK_VOP0_DIV>, <&cru DCLK_VOP0>, > >> + <&cru ACLK_VOP0>, <&cru HCLK_VOP0>; > >> + assigned-clock-rates = <0>, <0>, <400000000>, <100000000>; > >> + assigned-clock-parents = <&cru PLL_CPLL>, <&cru DCLK_VOP0_FRAC>; > >> +}; > > > > So here you're putting a fractional clock into path between CPLL -> VOP0_DIV > > -> DCLK_VOP0_FRAC -> DCLK_VOP0. > > > > Fractional clocks require 20x difference between input and output rates, and > > CPLL is 800Mhz IIRC, while you require 74.25MHz DCLK, so this will not work > > correctly. > > > > Even if this somehow works by fractional clock being bypassed, I did not design > > the panel mode to be used with CPLL's 800 MHz, but with GPLL frequecy of 594 MHz. > > > > GPLL 594/74.25 = 8 (integral divider without the need for fractional clock) > > CPLL 800/74.25 = ~10.77441077441077441077 > > > > If you really want to use fractional clock, you'd need to parent it to VPLL > > and set VPLL really high, like close to 2GHz. > > > > Thanks for the explanation. Then I just need to squash on top of this, the > following patch. Is that correct? > > https://github.com/megous/linux/commit/f19ce7bb7d72 Yes, and test the driver more thoroughly: - look at clk_summary to verify clock rate the kernel thinks it's using - test refresh rate, somehow, to again verify the actual clock rate (kernel can lie in debugfs) - test power cycling the panel (eg. via system suspend/resume or other means) thank you and kind regards, o. > -- > Best regards, > > Javier Martinez Canillas > Core Platforms > Red Hat > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D30ADC46467 for ; Mon, 2 Jan 2023 10:57:52 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3F22D10E302; Mon, 2 Jan 2023 10:57:51 +0000 (UTC) Received: from vps.xff.cz (vps.xff.cz [195.181.215.36]) by gabe.freedesktop.org (Postfix) with ESMTPS id BF65710E302 for ; Mon, 2 Jan 2023 10:57:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=xff.cz; s=mail; t=1672657066; bh=F4SkNUKtXmiMKcbm5JjpkGe1luxSiwhxxZE9A69pJoQ=; h=Date:From:To:Cc:Subject:X-My-GPG-KeyId:References:From; b=t3Gf17cNfS97ha3LFp5M06o5kw9u6PX4x3stnGo1CUvJAdNqxmXcnyjcI3Wg19En1 e0HZPRGHjG+pd5NWMDj7TuyAgXfpQpKvc+jNNZhox38nBMbbSOS5zCSwZMii5slNhQ JPV0KP8jgpKaGjz/aBAeO5OPqzeb0BKBDBRYtbnc= Date: Mon, 2 Jan 2023 11:57:46 +0100 From: =?utf-8?Q?Ond=C5=99ej?= Jirman To: Javier Martinez Canillas Subject: Re: [PATCH v4 4/4] arm64: dts: rk3399-pinephone-pro: Add internal display support Message-ID: <20230102105746.5abnjzwf365c6hy2@core> Mail-Followup-To: =?utf-8?Q?Ond=C5=99ej?= Jirman , Javier Martinez Canillas , linux-kernel@vger.kernel.org, Kamil =?utf-8?Q?Trzci=C5=84ski?= , Martijn Braam , Sam Ravnborg , Robert Mader , Tom Fitzhenry , Peter Robinson , Onuralp Sezer , dri-devel@lists.freedesktop.org, Maya Matuszczyk , Neal Gompa , linux-arm-kernel@lists.infradead.org, Krzysztof Kozlowski , Jagan Teki , Caleb Connolly , Heiko Stuebner , Krzysztof Kozlowski , Rob Herring , devicetree@vger.kernel.org, linux-rockchip@lists.infradead.org X-My-GPG-KeyId: EBFBDDE11FB918D44D1F56C1F9F0A873BE9777ED References: <20221230113155.3430142-1-javierm@redhat.com> <20221230113155.3430142-5-javierm@redhat.com> <20221230153745.tfs6n4zy4xfwugbw@core> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jagan Teki , Robert Mader , devicetree@vger.kernel.org, Onuralp Sezer , Neal Gompa , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Tom Fitzhenry , Martijn Braam , Caleb Connolly , Krzysztof Kozlowski , Rob Herring , Peter Robinson , Krzysztof Kozlowski , Kamil =?utf-8?Q?Trzci=C5=84ski?= , linux-rockchip@lists.infradead.org, Sam Ravnborg , linux-arm-kernel@lists.infradead.org, Maya Matuszczyk Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hello Javier, On Sat, Dec 31, 2022 at 04:29:49PM +0100, Javier Martinez Canillas wrote: > Hello Ondřej, > > Thanks a lot for your feedback. > > On 12/30/22 16:37, Ondřej Jirman wrote: > > [...] > > >> &i2c0 { > >> clock-frequency = <400000>; > >> i2c-scl-rising-time-ns = <168>; > >> @@ -214,6 +251,9 @@ vcc3v0_touch: LDO_REG2 { > >> regulator-name = "vcc3v0_touch"; > >> regulator-min-microvolt = <3000000>; > >> regulator-max-microvolt = <3000000>; > >> + regulator-state-mem { > >> + regulator-off-in-suspend; > >> + }; > > > > You're instructing RK818 to shut down the regulator for touch controller during > > suspend, but I think Goodix driver expects touch controller to be kept powered on > > during suspend. Am I missing something? > > > > https://elixir.bootlin.com/linux/latest/source/drivers/input/touchscreen/goodix.c#L1405 > > > > You tell me, it is your patch :) I just cherry-picked this from your tree: I have other patches to goodix driver that do power off the touch sensor chip during sleep, so that it doesn't consume excessinve amounts of power when the phone is suspended. Mainline doesn't. You have to adapt this to mainline, because you're not upstreaming the required Goodix patches, for regulator-off-in-suspend to not break things. > https://github.com/megous/linux/commit/11f8da60d6a5 > > But if that is not correct, then I can drop the regulator-off-in-suspend. > > [...] > > >> + > >> + touchscreen@14 { > >> + compatible = "goodix,gt917s"; > > > > This is not the correct compatible. Pinephone Pro uses Goodix GT1158: > > > > Goodix-TS 3-0014: ID 1158, version: 0100 > > Goodix-TS 3-0014: Direct firmware load for goodix_1158_cfg.bin failed with error -2 > > > > > > Same thing. I wasn't aware of this since your patch was using this compatible > string. If "goodix,gt1158" is the correct compatible string, then I agree we > should have that instead even when the firmware is missing. Because the DT is > supposed to describe the hardware. The FW issue can be tackled as a follow-up. > > [...] Yes, compatible string is sort of irrelevant, because the driver does runtime auto-detection based on chip ID. I didn't bother with superficial issues in the original code from Martijn/Kamil. Now that you're mainlining the code, this should be sorted out, though. There's no FW issue, I was just using the log to show you the actual chip ID the driver detects. (You should probably put my SoB after Kamil/Martijn, since I took the maintenance/development of the driver after they wrote the base support initially in secret. I'm not the original author of the code.) > >> + > >> +&vopb { > >> + status = "okay"; > >> + assigned-clocks = <&cru DCLK_VOP0_DIV>, <&cru DCLK_VOP0>, > >> + <&cru ACLK_VOP0>, <&cru HCLK_VOP0>; > >> + assigned-clock-rates = <0>, <0>, <400000000>, <100000000>; > >> + assigned-clock-parents = <&cru PLL_CPLL>, <&cru DCLK_VOP0_FRAC>; > >> +}; > > > > So here you're putting a fractional clock into path between CPLL -> VOP0_DIV > > -> DCLK_VOP0_FRAC -> DCLK_VOP0. > > > > Fractional clocks require 20x difference between input and output rates, and > > CPLL is 800Mhz IIRC, while you require 74.25MHz DCLK, so this will not work > > correctly. > > > > Even if this somehow works by fractional clock being bypassed, I did not design > > the panel mode to be used with CPLL's 800 MHz, but with GPLL frequecy of 594 MHz. > > > > GPLL 594/74.25 = 8 (integral divider without the need for fractional clock) > > CPLL 800/74.25 = ~10.77441077441077441077 > > > > If you really want to use fractional clock, you'd need to parent it to VPLL > > and set VPLL really high, like close to 2GHz. > > > > Thanks for the explanation. Then I just need to squash on top of this, the > following patch. Is that correct? > > https://github.com/megous/linux/commit/f19ce7bb7d72 Yes, and test the driver more thoroughly: - look at clk_summary to verify clock rate the kernel thinks it's using - test refresh rate, somehow, to again verify the actual clock rate (kernel can lie in debugfs) - test power cycling the panel (eg. via system suspend/resume or other means) thank you and kind regards, o. > -- > Best regards, > > Javier Martinez Canillas > Core Platforms > Red Hat >