From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4129EC3DA7A for ; Mon, 2 Jan 2023 11:02:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=JO/blAATDMivjAg/jWBxF6j+IcB5WSF17US1KqCO61o=; b=NHa7slMZSP324j 7T5/tfeXuqlLGJ9I1GmbKS5nswCb5mopRg+gRp/KKnZe17C8tjigcS+epqP+8uuF+r5AsFhpKNq3J sZ9umis97KpnLJ5Yq7it5iGL+k8bsmebQq8rj6Ctm1pz3OC6jbipjR1gyjAB9U+Ji9JXTm+pY7Ujo jo95zHGeJRjXktFKhjJK+ZRNJkRXSzTRuUVVW0EbNUPaVHJnUaH5Q4egBtXfzg0yEjsIKS6YI9UUX rXEYVaSZtQ49Tvafo8vfrMbECcOhWBNQomPcgRxn3p9j0UXBcYHEJNoS9Wj32TzMStvWH+x+rn6TO HgMj0/b6dnh7sRGKe8TA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pCIYq-00AavB-80; Mon, 02 Jan 2023 11:00:56 +0000 Received: from vps.xff.cz ([195.181.215.36]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pCIXF-00AZgl-Gp for linux-arm-kernel@lists.infradead.org; Mon, 02 Jan 2023 10:59:31 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=xff.cz; s=mail; t=1672657155; bh=QXfPTXA8nXZzmzygkWncKX/Z5d6842FAife/WSilhWU=; h=Date:From:To:Cc:Subject:X-My-GPG-KeyId:References:From; b=TV7R2AP5aGmGLW9LhEZ2syT9g5eGvwX9cTfk750JrK1ufMfIcjBSm50HsIO+zdvXS oiwFxIq6QLeBzPzlo6bdGy3APWGEYKz9VFFU6vjlLcC9P2WUGWNfa3zCs3kcwZfrxN SoG6/GOzyTbbTCS7NImuIRnslgw8arRJnOoYfcTo= Date: Mon, 2 Jan 2023 11:59:15 +0100 From: =?utf-8?Q?Ond=C5=99ej?= Jirman To: Javier Martinez Canillas Cc: linux-kernel@vger.kernel.org, Kamil =?utf-8?Q?Trzci=C5=84ski?= , Martijn Braam , Sam Ravnborg , Robert Mader , Tom Fitzhenry , Peter Robinson , Onuralp Sezer , dri-devel@lists.freedesktop.org, Maya Matuszczyk , Neal Gompa , linux-arm-kernel@lists.infradead.org, Krzysztof Kozlowski , Jagan Teki , Daniel Vetter , David Airlie , Thierry Reding Subject: Re: [PATCH v4 2/4] drm: panel: Add Himax HX8394 panel controller driver Message-ID: <20230102105915.gbfhletcm4dunrlf@core> Mail-Followup-To: =?utf-8?Q?Ond=C5=99ej?= Jirman , Javier Martinez Canillas , linux-kernel@vger.kernel.org, Kamil =?utf-8?Q?Trzci=C5=84ski?= , Martijn Braam , Sam Ravnborg , Robert Mader , Tom Fitzhenry , Peter Robinson , Onuralp Sezer , dri-devel@lists.freedesktop.org, Maya Matuszczyk , Neal Gompa , linux-arm-kernel@lists.infradead.org, Krzysztof Kozlowski , Jagan Teki , Daniel Vetter , David Airlie , Thierry Reding X-My-GPG-KeyId: EBFBDDE11FB918D44D1F56C1F9F0A873BE9777ED References: <20221230113155.3430142-1-javierm@redhat.com> <20221230113155.3430142-3-javierm@redhat.com> <20221230154043.7v3zmzqdrnouqzd2@core> <7120dfd4-305f-69ac-fee8-123196ed06a9@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <7120dfd4-305f-69ac-fee8-123196ed06a9@redhat.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230102_025918_638605_F6FE4DB8 X-CRM114-Status: GOOD ( 40.90 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGVsbG8gSmF2aWVyLAoKT24gU2F0LCBEZWMgMzEsIDIwMjIgYXQgMDQ6MTU6MjRQTSArMDEwMCwg SmF2aWVyIE1hcnRpbmV6IENhbmlsbGFzIHdyb3RlOgo+IEhlbGxvIE9uZMWZZWosCj4gCj4gVGhh bmtzIGEgbG90IGZvciB5b3VyIGNvbW1lbnRzLgo+IAo+IE9uIDEyLzMwLzIyIDE2OjQwLCBPbmTF mWVqIEppcm1hbiB3cm90ZToKPiA+IEhpIEphdmllciwKPiA+IAo+ID4gT24gRnJpLCBEZWMgMzAs IDIwMjIgYXQgMTI6MzE6NTJQTSArMDEwMCwgSmF2aWVyIE1hcnRpbmV6IENhbmlsbGFzIHdyb3Rl Ogo+ID4+IEZyb206IEthbWlsIFRyemNpxYRza2kgPGF5dWZhbkBheXVmYW4uZXU+Cj4gPj4KPiA+ PiBUaGUgZHJpdmVyIGlzIGZvciBwYW5lbHMgYmFzZWQgb24gdGhlIEhpbWF4IEhYODM5NCBjb250 cm9sbGVyLCBzdWNoIGFzIHRoZQo+ID4+IEhhbm5TdGFyIEhTRDA2MEJIVzQgNzIweDE0NDAgVEZU IExDRCBwYW5lbCB0aGF0IHVzZXMgYSBNSVBJLURTSSBpbnRlcmZhY2UuCj4gPiAKPiA+IEkgc2Vl IHlvdSd2ZSByZW1vdmVkIGRlYnVnIHByaW50a3MgZnJvbSBlbmFibGUvZGlzYWJsZS9wcmVwYXJl L3VucHJlcGFyZQo+IAo+IFllcywgYmVjYXVzZSBhcyB5b3Ugc2FpZCB3ZXJlIGRlYnVnIHByaW50 a3MuIEZlZWwgZnJlZSB0byBwcm9wb3NlIGFkZGluZyB0aGUKPiBkZWJ1ZyBwcmludGtzIGlmIHlv dSBjb25zaWRlciB1c2VmdWwgZm9yIG5vcm1hbCB1c2FnZSBhbmQgbm90IGp1c3QgZm9yIGRldmVs Cj4gcHVycG9zZXMuCgpJIGFscmVhZHkgZGlkLCBhbmQgdXNlZCB0aGVtIGRvIGRlYnVnIGFuZCBm aXggdGhlIGlzc3Vlcy4gVGhpcyBzdWJtaXNzaW9uIGp1c3QKZG9lc24ndCBpbmNsdWRlIHRoZSBm aXhlcy4KCj4gPiBob29rcy4gSGF2ZSB5b3UgdGVzdGVkIHRoZSBkcml2ZXIgdGhvcm91Z2hseSB3 aXRoIHZhcmlvdXMgRFJNIGFwcHMsCj4gPiB3aXRoIERQTS9zdXNwZW5kL3Jlc3VtZSwgZXRjLj8K PiA+Cj4gCj4gSSBkaWQgbm90LiBJIHdhc24ndCBleHBlY3Rpbmcgc3VzcGVuZCBhbmQgcmVzdW1l IHRvIHdvcmsgb24gdGhlIFBQUCBnaXZlbiBpdHMKPiBzdXBwb3J0IGlzIHF1aXRlIG1pbmltYWwg Y3VycmVudGx5LgoKU3lzdGVtIHN1c3BlbmQvcmVzdW1lIHdvcmtzIGFuZCBpcyB1c2VkIGJ5IGRp c3RyaWJ1dGlvbnMuIERpc3BsYXkgYmxhbmtpbmcgaXMKYWxzbyB1c2VkIGJ5IG5vcm1hbCBkaXN0 cm9zLCBldmVuIGlmIHlvdSBkb24ndCB1c2Ugc3lzdGVtIHN1c3BlbmQvcmVzdW1lLgoKPiA+IFRo ZSBkdy1taXBpLWRzaSBkcml2ZXIgZG9lcyBzb21lIHVub3J0aG9kb3ggdGhpbmdzWzFdLCB0aGF0 IGNhbiBsZWFkIHRvIHVuYmFsYW5jZWQKPiA+IGNhbGxzIHRvIHRoZXNlIGZ1bmN0aW9ucyBpbiBz b21lIHNpdHVhdGlvbnMsIGFuZCB0aGF0J3Mgd2h5IGFsbCB0aGVzZSBwcmludGtzCj4gPiB3ZXJl IHRoZXJlLiBUbyBlbnN1cmUgdGhlIGRyaXZlciBob29rcyBhcmUgY2FsbGVkIGNvcnJlY3RseSwg d2hpbGUgcHJlcGFyaW5nCj4gPiB0aGUgY29kZSBmb3IgdXBzdHJlYW1pbmcuIFRoaXMgbGVhZCB0 byBicm9rZW4gZGlzcGxheSBpbiBzb21lIHNpdHVhdGlvbnMgZHVyaW5nCj4gPiBzdXNwZW5kL3Jl c3VtZS4KPiA+IAo+ID4gaHR0cHM6Ly9lbGl4aXIuYm9vdGxpbi5jb20vbGludXgvbGF0ZXN0L3Nv dXJjZS9kcml2ZXJzL2dwdS9kcm0vYnJpZGdlL3N5bm9wc3lzL2R3LW1pcGktZHNpLmMjTDg2OAo+ ID4KPiAKPiBUaGlzIG5lZWRzIHRvIGJlIGZpeGVkIGluIHRoZSBkdy1taXBpLWRzaSBkcml2ZXIg dGhlbi4gQnV0IGF0IGxlYXN0IHdlIHdpbGwgZ2V0Cj4gYSBwYW5lbC1oaW1heC1oeDgzOTQgZHJp dmVyIGluIG1haW5saW5lIHRvIGF2b2lkIGhhdmluZyB0byB1c2UgZG93bnN0cmVhbSB0cmVlcwo+ IGZvciBkZXZlbG9wbWVudCBhbmQgdGVzdGluZy4KClRoZSBvbmx5IHRoaW5nIHRoaXMgZHJpdmVy IGlzIHN1cHBvc2VkIHRvIGRvIGlzIHRvIHBvd2VyIHVwICgrY29uZmlndXJlKSBhbmQgcG93ZXIK ZG93biB0aGUgZGlzcGxheSwgdGhlIHJlc3QgaXMgYm9pbGVycGxhdGUuIFBvd2VyY3ljbGluZyB2 aWEgc3VzcGVuZC9yZXN1bWUKYW5kL29yIG90aGVyIG1lYW5zIChsaWtlIGRpc2FibGluZyB0aGUg Y3J0YyB2aWEgRFJNIEFQSSksIGhhcyB0byBiZSB0ZXN0ZWQsCnRvIHZlcmlmeSB0aGUgZHJpdmVy IGNhbiBhdCBsZWFzdCBkbyBhIHBvd2VyIGRvd24vdXAgY3ljbGUgYW5kIG5vdCBqdXN0IGluaXRp YWwKcG93ZXJ1cC4KCj4gPiBBbHNvLCBoYXZlIHlvdSBjaGVja2VkIHRoZSBjbG9ja3MgYXJlIGFj dHVhbGx5IGNvbmZpZ3VyZWQgY29ycmVjdGx5IGJ5IHRoZQo+ID4gcmszMzk5IGNydSBkcml2ZXI/ IEkgaGF2ZSBhIGxvdCBvZiB0cm91YmxlIHdpdGggdGhhdCwgdG9vLiBjbGsgZHJpdmVyIHNvbWV0 aW1lcwo+ID4gc2VsZWN0cyB0aGUgZnJhY3Rpb25hbCBjbG9jaywgYnV0IGRvZXMgbm90IGdpdmUg aXQgdGhlIG5lY2Vzc2FyeSA+MjB4IGRpZmZlcmVuY2UKPiA+IGJldHdlZW4gaW5wdXQvb3V0cHV0 IGNsb2NrIHJhdGVzLiBZb3UnbGwgb25seSBub3RpY2UgaWYgeW91IG1lYXN1cmUgY2xvY2sgcmF0 ZXMKPiA+IGRpcmVjdGx5LCBieSBsb29raW5nIGF0IGFjdHVhbCByZWZyZXNoIHJhdGUsIGJ5IHVz aW5nIHNvbWUgdGVzdGluZyBEUk0gYXBwLgo+ID4gQ2xvY2sgc3Vic3lzdGVtIHNvbWV0aW1lcyBz aHVmZmxlcyB0aGluZ3MgYXJvdW5kIGlmIHlvdSBzd2l0Y2ggVk9QcyBhbmQgdXNlIGJpZwo+ID4g Vk9QIGZvciBtaXBpLWRzaSBkaXNwbGF5LCBpbnN0ZWFkIG9mIHRoZSBkZWZhdWx0IHNtYWxsIFZP UC4KPiA+Cj4gCj4gSSBoYXZlIG5vdC4gSnVzdCB2ZXJpZmllZCB0aGF0IHRoZSBkaXNwbGF5IHdh cyB3b3JraW5nIG9uIG15IFBQUCBhbmQgY291bGQgc3RhcnQKPiBhIG11dHRlciB3YXlsYW5kIHNl c3Npb24uIFdlIGNvdWxkIGZpeCB0aGUgY2xvY2sgY29uZmlndXJhdGlvbiBhcyBmb2xsb3ctdXAg SU1PLgoKVGhlIGRpc3BsYXkgb3V0cHV0IHdpbGwgYmUgYnJva2VuIGFmdGVyIHlvdSBmaXggdGhl IGFzc2lnbmVkLWNsb2NrcyBpbiBEVCB0bwpleHBlY3RlZCB2YWx1ZXMgKHVzZSBHUExMIHBhcmVu dCwgdG8gbWFrZSB0aGUgSFcgZ2VuZXJhdGUgdGhlIGV4YWN0IHBpeGVsIGNsb2NrCmRlZmluZWQg aW4gdGhlIGRpc3BsYXkgbW9kZSkuIFNvIHRoaXMgbmVlZHMgdG8gYmUgZGVhbHQgd2l0aCBub3cs IG5vdCBsYXRlci4KCgpUaGUgZHJpdmVyIGlzc3VlcyBhcmUgYWxsIGtub3duIGF0IHRoaXMgdGlt ZSBhbmQgaGF2ZSBmaXhlcyBhdmFpbGFibGUsIHVubGlrZQphIHllYXIgYWdvOgoKLSBwYW5lbCBt b2RlIG5vdCB3b3JraW5nIHdpdGggYWN0dWFsIGNsb2NrIHJhdGUgaXQgcmVxdWVzdHMgKHNldmVy ZSBpbWFnZQogIGNvcnJ1cHRpb24gb24gc29tZSBwaW5lcGhvbmUgcHJvJ3MpCi0gbm8gZGlzcGxh eSBvdXRwdXQgYWZ0ZXIgc3VzcGVuZC9yZXN1bWUgY3ljbGUgb3IgYSBibGFua2luZy91bmJsYW5r aW5nIGN5Y2xlCgpTbyBpZiB5b3UncmUgc3VibWl0dGluZyBhIGtub3duIGJyb2tlbiBjb2RlLCBh dCBsZWFzdCBtZW50aW9uIHRoZSBpc3N1ZXMgaW4gY29kZQpjb21tZW50cywgc28gdGhhdCBwZW9w bGUgdGhhdCB3aWxsIGluZXZpdGFibHkgaGl0IHRoZSBidWdzIHdpbGwgbm90IHNwZW5kIGxhcmdl CmFtb3VudCBvZiB0aW1lIGh1bnRpbmcgZm9yIHRoZSBjYXVzZSBhZ2Fpbiwgd2hlbiB0aGUgaXNz dWUgYW5kIGNhdXNlcyBhcmUga25vd24KYWxyZWFkeS4KCkp1c3QgZmlndXJpbmcgb3V0IHRoZSBp bWFnZSBjb3JydXB0aW9uIHRvb2sgbW9yZSB0aGFuIGEgeWVhciBzaW5jZSBpdCB3YXMKZGlzY292 ZXJlZC4gQmV0dGVyIG5vdCBpbmZsaWN0IHRoYXQgb24gb3RoZXJzLgoKcmVnYXJkcywKCW8uCgo+ ID4gSSdsbCB0ZXN0IHRoaXMgcGF0Y2hzZXQgaW4gYSBmZXcgZGF5cyBhZ2FpbnN0IHB1cmVseSBt YWlubGluZSBjb2RlLCBidXQgSSdtCj4gPiBwcmV0dHkgc3VyZSBsb29raW5nIGF0IHRoZSBtb2Rl cyB5b3UgdXNlLCB0aGF0IHRoaXMgd2lsbCBub3Qgd29yayBvbiBzb21lCj4gPiBQaW5lcGhvbmUg UHJvJ3MsIGFuZCB3aWxsIGNhdXNlIGRpc3BsYXkgY29ycnVwdGlvbiB3aGVuIHlvdSBmaXggeW91 ciBjbG9jawo+ID4gc2V0dXAsIHNvIHRoYXQgQ1JVIGFjdHVhbGx5IG91dHB1dHMgNzQuMjVNSHog YXMgcmVxdWVzdGVkIGJ5IHRoZSBtb2RlLiAoV2hpY2gKPiA+IGNhbiBiZSBmaXhlZCBieSB0aGlz IHBhdGNoIGh0dHBzOi8vZ2l0aHViLmNvbS9tZWdvdXMvbGludXgvY29tbWl0L2Y3ZWUxNmYxMmVl OGE0NGVlMjQ3MmYyOTY3Y2EyNzc2ODEwNmUwMGYpCj4gPiAKPiAKPiBBcyBtZW50aW9uZWQsIEkg cHJlZmVyIHRvIG1ha2UgdGhlIHN1cHBvcnQgaW5jcmVtZW50YWwuIEZpcnN0IGhhdmluZyB0aGUg cGFuZWwKPiBkcml2ZXIgYW5kIHRoZW4gd2UgY2FuIGZpeCBhbnkgcmVtYWluaW5nIGlzc3VlIGFz IGZvbGxvdy11cCBwYXRjaCBzZXJpZXMuCj4gCj4gLS0gCj4gQmVzdCByZWdhcmRzLAo+IAo+IEph dmllciBNYXJ0aW5leiBDYW5pbGxhcwo+IENvcmUgUGxhdGZvcm1zCj4gUmVkIEhhdAo+IAoKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtl cm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0 dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5l bAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6B28BC3DA7A for ; Mon, 2 Jan 2023 10:59:22 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5A4DE10E304; Mon, 2 Jan 2023 10:59:21 +0000 (UTC) Received: from vps.xff.cz (vps.xff.cz [195.181.215.36]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9FAFC10E304 for ; Mon, 2 Jan 2023 10:59:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=xff.cz; s=mail; t=1672657155; bh=QXfPTXA8nXZzmzygkWncKX/Z5d6842FAife/WSilhWU=; h=Date:From:To:Cc:Subject:X-My-GPG-KeyId:References:From; b=TV7R2AP5aGmGLW9LhEZ2syT9g5eGvwX9cTfk750JrK1ufMfIcjBSm50HsIO+zdvXS oiwFxIq6QLeBzPzlo6bdGy3APWGEYKz9VFFU6vjlLcC9P2WUGWNfa3zCs3kcwZfrxN SoG6/GOzyTbbTCS7NImuIRnslgw8arRJnOoYfcTo= Date: Mon, 2 Jan 2023 11:59:15 +0100 From: =?utf-8?Q?Ond=C5=99ej?= Jirman To: Javier Martinez Canillas Subject: Re: [PATCH v4 2/4] drm: panel: Add Himax HX8394 panel controller driver Message-ID: <20230102105915.gbfhletcm4dunrlf@core> Mail-Followup-To: =?utf-8?Q?Ond=C5=99ej?= Jirman , Javier Martinez Canillas , linux-kernel@vger.kernel.org, Kamil =?utf-8?Q?Trzci=C5=84ski?= , Martijn Braam , Sam Ravnborg , Robert Mader , Tom Fitzhenry , Peter Robinson , Onuralp Sezer , dri-devel@lists.freedesktop.org, Maya Matuszczyk , Neal Gompa , linux-arm-kernel@lists.infradead.org, Krzysztof Kozlowski , Jagan Teki , Daniel Vetter , David Airlie , Thierry Reding X-My-GPG-KeyId: EBFBDDE11FB918D44D1F56C1F9F0A873BE9777ED References: <20221230113155.3430142-1-javierm@redhat.com> <20221230113155.3430142-3-javierm@redhat.com> <20221230154043.7v3zmzqdrnouqzd2@core> <7120dfd4-305f-69ac-fee8-123196ed06a9@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <7120dfd4-305f-69ac-fee8-123196ed06a9@redhat.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jagan Teki , Robert Mader , Onuralp Sezer , Neal Gompa , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Tom Fitzhenry , Martijn Braam , Krzysztof Kozlowski , Thierry Reding , Peter Robinson , Kamil =?utf-8?Q?Trzci=C5=84ski?= , Sam Ravnborg , linux-arm-kernel@lists.infradead.org, Maya Matuszczyk Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hello Javier, On Sat, Dec 31, 2022 at 04:15:24PM +0100, Javier Martinez Canillas wrote: > Hello Ondřej, > > Thanks a lot for your comments. > > On 12/30/22 16:40, Ondřej Jirman wrote: > > Hi Javier, > > > > On Fri, Dec 30, 2022 at 12:31:52PM +0100, Javier Martinez Canillas wrote: > >> From: Kamil Trzciński > >> > >> The driver is for panels based on the Himax HX8394 controller, such as the > >> HannStar HSD060BHW4 720x1440 TFT LCD panel that uses a MIPI-DSI interface. > > > > I see you've removed debug printks from enable/disable/prepare/unprepare > > Yes, because as you said were debug printks. Feel free to propose adding the > debug printks if you consider useful for normal usage and not just for devel > purposes. I already did, and used them do debug and fix the issues. This submission just doesn't include the fixes. > > hooks. Have you tested the driver thoroughly with various DRM apps, > > with DPM/suspend/resume, etc.? > > > > I did not. I wasn't expecting suspend and resume to work on the PPP given its > support is quite minimal currently. System suspend/resume works and is used by distributions. Display blanking is also used by normal distros, even if you don't use system suspend/resume. > > The dw-mipi-dsi driver does some unorthodox things[1], that can lead to unbalanced > > calls to these functions in some situations, and that's why all these printks > > were there. To ensure the driver hooks are called correctly, while preparing > > the code for upstreaming. This lead to broken display in some situations during > > suspend/resume. > > > > https://elixir.bootlin.com/linux/latest/source/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c#L868 > > > > This needs to be fixed in the dw-mipi-dsi driver then. But at least we will get > a panel-himax-hx8394 driver in mainline to avoid having to use downstream trees > for development and testing. The only thing this driver is supposed to do is to power up (+configure) and power down the display, the rest is boilerplate. Powercycling via suspend/resume and/or other means (like disabling the crtc via DRM API), has to be tested, to verify the driver can at least do a power down/up cycle and not just initial powerup. > > Also, have you checked the clocks are actually configured correctly by the > > rk3399 cru driver? I have a lot of trouble with that, too. clk driver sometimes > > selects the fractional clock, but does not give it the necessary >20x difference > > between input/output clock rates. You'll only notice if you measure clock rates > > directly, by looking at actual refresh rate, by using some testing DRM app. > > Clock subsystem sometimes shuffles things around if you switch VOPs and use big > > VOP for mipi-dsi display, instead of the default small VOP. > > > > I have not. Just verified that the display was working on my PPP and could start > a mutter wayland session. We could fix the clock configuration as follow-up IMO. The display output will be broken after you fix the assigned-clocks in DT to expected values (use GPLL parent, to make the HW generate the exact pixel clock defined in the display mode). So this needs to be dealt with now, not later. The driver issues are all known at this time and have fixes available, unlike a year ago: - panel mode not working with actual clock rate it requests (severe image corruption on some pinephone pro's) - no display output after suspend/resume cycle or a blanking/unblanking cycle So if you're submitting a known broken code, at least mention the issues in code comments, so that people that will inevitably hit the bugs will not spend large amount of time hunting for the cause again, when the issue and causes are known already. Just figuring out the image corruption took more than a year since it was discovered. Better not inflict that on others. regards, o. > > I'll test this patchset in a few days against purely mainline code, but I'm > > pretty sure looking at the modes you use, that this will not work on some > > Pinephone Pro's, and will cause display corruption when you fix your clock > > setup, so that CRU actually outputs 74.25MHz as requested by the mode. (Which > > can be fixed by this patch https://github.com/megous/linux/commit/f7ee16f12ee8a44ee2472f2967ca27768106e00f) > > > > As mentioned, I prefer to make the support incremental. First having the panel > driver and then we can fix any remaining issue as follow-up patch series. > > -- > Best regards, > > Javier Martinez Canillas > Core Platforms > Red Hat > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4EBB6C3DA7A for ; Mon, 2 Jan 2023 11:00:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232880AbjABK7s (ORCPT ); Mon, 2 Jan 2023 05:59:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60628 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232705AbjABK7S (ORCPT ); Mon, 2 Jan 2023 05:59:18 -0500 Received: from vps.xff.cz (vps.xff.cz [195.181.215.36]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 99B93B7A for ; Mon, 2 Jan 2023 02:59:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=xff.cz; s=mail; t=1672657155; bh=QXfPTXA8nXZzmzygkWncKX/Z5d6842FAife/WSilhWU=; h=Date:From:To:Cc:Subject:X-My-GPG-KeyId:References:From; b=TV7R2AP5aGmGLW9LhEZ2syT9g5eGvwX9cTfk750JrK1ufMfIcjBSm50HsIO+zdvXS oiwFxIq6QLeBzPzlo6bdGy3APWGEYKz9VFFU6vjlLcC9P2WUGWNfa3zCs3kcwZfrxN SoG6/GOzyTbbTCS7NImuIRnslgw8arRJnOoYfcTo= Date: Mon, 2 Jan 2023 11:59:15 +0100 From: =?utf-8?Q?Ond=C5=99ej?= Jirman To: Javier Martinez Canillas Cc: linux-kernel@vger.kernel.org, Kamil =?utf-8?Q?Trzci=C5=84ski?= , Martijn Braam , Sam Ravnborg , Robert Mader , Tom Fitzhenry , Peter Robinson , Onuralp Sezer , dri-devel@lists.freedesktop.org, Maya Matuszczyk , Neal Gompa , linux-arm-kernel@lists.infradead.org, Krzysztof Kozlowski , Jagan Teki , Daniel Vetter , David Airlie , Thierry Reding Subject: Re: [PATCH v4 2/4] drm: panel: Add Himax HX8394 panel controller driver Message-ID: <20230102105915.gbfhletcm4dunrlf@core> Mail-Followup-To: =?utf-8?Q?Ond=C5=99ej?= Jirman , Javier Martinez Canillas , linux-kernel@vger.kernel.org, Kamil =?utf-8?Q?Trzci=C5=84ski?= , Martijn Braam , Sam Ravnborg , Robert Mader , Tom Fitzhenry , Peter Robinson , Onuralp Sezer , dri-devel@lists.freedesktop.org, Maya Matuszczyk , Neal Gompa , linux-arm-kernel@lists.infradead.org, Krzysztof Kozlowski , Jagan Teki , Daniel Vetter , David Airlie , Thierry Reding X-My-GPG-KeyId: EBFBDDE11FB918D44D1F56C1F9F0A873BE9777ED References: <20221230113155.3430142-1-javierm@redhat.com> <20221230113155.3430142-3-javierm@redhat.com> <20221230154043.7v3zmzqdrnouqzd2@core> <7120dfd4-305f-69ac-fee8-123196ed06a9@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <7120dfd4-305f-69ac-fee8-123196ed06a9@redhat.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Javier, On Sat, Dec 31, 2022 at 04:15:24PM +0100, Javier Martinez Canillas wrote: > Hello Ondřej, > > Thanks a lot for your comments. > > On 12/30/22 16:40, Ondřej Jirman wrote: > > Hi Javier, > > > > On Fri, Dec 30, 2022 at 12:31:52PM +0100, Javier Martinez Canillas wrote: > >> From: Kamil Trzciński > >> > >> The driver is for panels based on the Himax HX8394 controller, such as the > >> HannStar HSD060BHW4 720x1440 TFT LCD panel that uses a MIPI-DSI interface. > > > > I see you've removed debug printks from enable/disable/prepare/unprepare > > Yes, because as you said were debug printks. Feel free to propose adding the > debug printks if you consider useful for normal usage and not just for devel > purposes. I already did, and used them do debug and fix the issues. This submission just doesn't include the fixes. > > hooks. Have you tested the driver thoroughly with various DRM apps, > > with DPM/suspend/resume, etc.? > > > > I did not. I wasn't expecting suspend and resume to work on the PPP given its > support is quite minimal currently. System suspend/resume works and is used by distributions. Display blanking is also used by normal distros, even if you don't use system suspend/resume. > > The dw-mipi-dsi driver does some unorthodox things[1], that can lead to unbalanced > > calls to these functions in some situations, and that's why all these printks > > were there. To ensure the driver hooks are called correctly, while preparing > > the code for upstreaming. This lead to broken display in some situations during > > suspend/resume. > > > > https://elixir.bootlin.com/linux/latest/source/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c#L868 > > > > This needs to be fixed in the dw-mipi-dsi driver then. But at least we will get > a panel-himax-hx8394 driver in mainline to avoid having to use downstream trees > for development and testing. The only thing this driver is supposed to do is to power up (+configure) and power down the display, the rest is boilerplate. Powercycling via suspend/resume and/or other means (like disabling the crtc via DRM API), has to be tested, to verify the driver can at least do a power down/up cycle and not just initial powerup. > > Also, have you checked the clocks are actually configured correctly by the > > rk3399 cru driver? I have a lot of trouble with that, too. clk driver sometimes > > selects the fractional clock, but does not give it the necessary >20x difference > > between input/output clock rates. You'll only notice if you measure clock rates > > directly, by looking at actual refresh rate, by using some testing DRM app. > > Clock subsystem sometimes shuffles things around if you switch VOPs and use big > > VOP for mipi-dsi display, instead of the default small VOP. > > > > I have not. Just verified that the display was working on my PPP and could start > a mutter wayland session. We could fix the clock configuration as follow-up IMO. The display output will be broken after you fix the assigned-clocks in DT to expected values (use GPLL parent, to make the HW generate the exact pixel clock defined in the display mode). So this needs to be dealt with now, not later. The driver issues are all known at this time and have fixes available, unlike a year ago: - panel mode not working with actual clock rate it requests (severe image corruption on some pinephone pro's) - no display output after suspend/resume cycle or a blanking/unblanking cycle So if you're submitting a known broken code, at least mention the issues in code comments, so that people that will inevitably hit the bugs will not spend large amount of time hunting for the cause again, when the issue and causes are known already. Just figuring out the image corruption took more than a year since it was discovered. Better not inflict that on others. regards, o. > > I'll test this patchset in a few days against purely mainline code, but I'm > > pretty sure looking at the modes you use, that this will not work on some > > Pinephone Pro's, and will cause display corruption when you fix your clock > > setup, so that CRU actually outputs 74.25MHz as requested by the mode. (Which > > can be fixed by this patch https://github.com/megous/linux/commit/f7ee16f12ee8a44ee2472f2967ca27768106e00f) > > > > As mentioned, I prefer to make the support incremental. First having the panel > driver and then we can fix any remaining issue as follow-up patch series. > > -- > Best regards, > > Javier Martinez Canillas > Core Platforms > Red Hat >