From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BDB5AC3DA7A for ; Mon, 2 Jan 2023 15:23:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+4ftoIPjTJxMb2f+z45v6fRd5vsdO8Z1fBB8RDPBjiU=; b=o6jnpWRBpgmLDS 2zoN+nNF/baBI41mAMa/4rbOEp7kBll39QqOqxrc7qRrx9vXxNWbz9Cnn3XLJi1EUyypd596yjQpf 5riTO4s3p8gnqjwA90sG5hn7EXKRLZl/SqZ+9/NwYYNAamAnkP/5Fvx34o4EgJ/OrUqRIhj6Osowz bFQdjlWvTy+OG0aI74skVXdH6zMQfEtaQFmfrOJj2PMiScKVdRw+E5fx1Ye9Vyy3ENE81hFzq69VU brpzsxvrJPBSqRMQnpkxuPdd9GJR7NDVHzwmeKOUT4FHII4MoFlQ3/51mBBWpLL41TWoktHb8rk3z jvK7lIMRuBw8ptGXE6ww==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pCMdq-00C9c0-PS; Mon, 02 Jan 2023 15:22:23 +0000 Received: from vps.xff.cz ([195.181.215.36]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pCMcL-00C8fO-1w for linux-arm-kernel@lists.infradead.org; Mon, 02 Jan 2023 15:20:51 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=xff.cz; s=mail; t=1672672842; bh=tMFKm6S1vYdEhPMSbHlLVghOqqrmdl6HWg/Ar6Ny41A=; h=Date:From:To:Cc:Subject:X-My-GPG-KeyId:References:From; b=HEcl9avXBPZybBtlbrOD07EfhoBsITX+HBGhDDJPUVH4AVgXH7uufhQ46/fg/5xYi svWsZhI5C5zDH9Kfd4zAcJfVTd8IRThxSbRY4LV9sCY0xdFmMCJ7hFpVpr0NkWfLht HxSPUMstPNX3YryGhepMQmUQc/Iv4ObCQD75ahmo= Date: Mon, 2 Jan 2023 16:20:41 +0100 From: =?utf-8?Q?Ond=C5=99ej?= Jirman To: Javier Martinez Canillas Cc: linux-kernel@vger.kernel.org, Kamil =?utf-8?Q?Trzci=C5=84ski?= , Martijn Braam , Sam Ravnborg , Robert Mader , Tom Fitzhenry , Peter Robinson , Onuralp Sezer , dri-devel@lists.freedesktop.org, Maya Matuszczyk , Neal Gompa , linux-arm-kernel@lists.infradead.org, Krzysztof Kozlowski , Jagan Teki , Daniel Vetter , David Airlie , Thierry Reding Subject: Re: [PATCH v4 2/4] drm: panel: Add Himax HX8394 panel controller driver Message-ID: <20230102152041.7rc2uts7o37fnsen@core> Mail-Followup-To: =?utf-8?Q?Ond=C5=99ej?= Jirman , Javier Martinez Canillas , linux-kernel@vger.kernel.org, Kamil =?utf-8?Q?Trzci=C5=84ski?= , Martijn Braam , Sam Ravnborg , Robert Mader , Tom Fitzhenry , Peter Robinson , Onuralp Sezer , dri-devel@lists.freedesktop.org, Maya Matuszczyk , Neal Gompa , linux-arm-kernel@lists.infradead.org, Krzysztof Kozlowski , Jagan Teki , Daniel Vetter , David Airlie , Thierry Reding X-My-GPG-KeyId: EBFBDDE11FB918D44D1F56C1F9F0A873BE9777ED References: <20221230113155.3430142-1-javierm@redhat.com> <20221230113155.3430142-3-javierm@redhat.com> <20221230154043.7v3zmzqdrnouqzd2@core> <7120dfd4-305f-69ac-fee8-123196ed06a9@redhat.com> <20230102105915.gbfhletcm4dunrlf@core> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230102_072049_278581_5FD890A7 X-CRM114-Status: GOOD ( 23.09 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uLCBKYW4gMDIsIDIwMjMgYXQgMDI6NTE6NDJQTSArMDEwMCwgSmF2aWVyIE1hcnRpbmV6 IENhbmlsbGFzIHdyb3RlOgo+IEhlbGxvIE9uZMWZZWosCj4gCj4gWy4uLl0KPgo+IE15IGdvYWwg d2FzIHRvIGhhdmUgc29tZSBpbml0aWFsIHN1cHBvcnQgaW4gbWFpbmxpbmUgZXZlbiBpZiB0aGVy ZSBjb3VsZCBiZSBzb21lCj4gaXNzdWVzLiBJTU8gaXQgaXMgYmV0dGVyIHRvIHVzZSB1cHN0cmVh bSBhcyBhIGJhc2VsaW5lIGFuZCBhdHRlbXB0IHRvIHN1cHBvcnQgdGhlCj4gUFBQIGluY3JlbWVu dGFsbHkuCj4gCj4gQnV0IHNpbmNlIHlvdSBhcmUgYXdhcmUgb2YgdGhlIGlzc3VlcyBhbmQga25v dyB3aGF0IGFyZSB0aGUgYXZhaWxhYmxlIGZpeGVzLCBJJ2xsCj4gbGV0IHlvdSBjb250aW51ZSB3 aXRoIHRoZSBlZmZvcnQgYW5kIHRha2UgY2FyZSBvZiB0aGUgcGF0Y2hlcy4gSG9wZWZ1bGx5IHRo ZXJlIG1heQo+IGJlIHRoaW5ncyB0aGF0IHdpbGwgYmUgaGVscGZ1bCwgc3VjaCBhcyB0aGUgYmlu ZGluZyBzY2hlbWEgcGF0Y2ggYW5kIHRoZSBjb2xsZWN0ZWQKPiB0YWdzLiBJIGNhbiBhbHNvIHRh a2UgY2FyZSBvZiBwdXNoaW5nIHRoZSBEUk0gYml0cyB0byB0aGUgZHJtLW1pc2MtbmV4dCB0cmVl IG9uY2UKPiB5b3UgZmVlbCB0aGF0IHRob3NlIGFyZSByZWFkeSB0byBnZXQgbWVyZ2VkLgoKT2su IFRoZSBwYW5lbCBkcml2ZXIgaXRzZWxmIHdvcmtzIGZpbmUgd2l0aCBzb21lIGNoYW5nZXMgaW4g b3RoZXIgRFJNIGRyaXZlcnMuCkluIGZhY3QsIGl0IHdpbGwgbm90IG5lZWQgYW55IGNoYW5nZXMs IGFzc3VtaW5nIHRoZSB0byBiZSBwcm9wb3NlZCBmaXhlcyB0bwpkdy1taXBpLWRzaSB3aWxsIHBh c3MsIHRvby4gU28gSSBkb24ndCBoYXZlIG1hbnkgb2JqZWN0aW9ucyBhZ2FpbnN0IHRoaXMgZHJp dmVyCml0c2VsZi4KCkknbSBub3Qgc3VyZSBJIHNob3VsZCBiZSBnaXZpbmcgcmV2aWV3ZWQtYnkg dG8gZHJpdmVyIEkgY28td3JvdGUuIDopIEFueXdheSwKSSBjaGVja2VkIGl0IGFnYWluLCBhbmQg b25seSBpc3N1ZSBJIGZvdW5kIHdhcyB0aGF0IHNodXRkb3duIGNhbGxiYWNrIHRyaWVzCnRvIGRp c2FibGUgdGhlIHBhbmVsIGV2ZW4gaWYgaXQgbWF5IGFscmVhZHkgYmUgZGlzYWJsZWQsIHdoaWNo IHdpbGwgbGVhZCB0bwp1bmJhbGFuY2VkIGNhbGxzIHRvIHJlZ3VsYXRvcl9kaXNhYmxlIGZ1bmN0 aW9ucywgd2hpY2ggbWF5IHByb2R1Y2Ugc29tZSBuZWVkbGVzcwp3YXJuaW5ncyBvbiBzaHV0ZG93 bi9yZWJvb3QuCgpTbyBpZiB5b3Ugd2FudCB0byBjb21taXQgdGhpcyBkcml2ZXIgbm93LCBnbyBh aGVhZC4gRFQgd2lsbCBuZWVkIG9uZSBtb3JlIHJvdW5kLgoKQXMgeW91IHNheSwgdGhlIG92ZXJh bGwgdXNhYmxlIHN1cHBvcnQgZm9yIFBpbmVwaG9uZSBQcm8gaW4gbWFpbmxpbmUgaXMgc3RpbGwK d2F5IG9mZiBpbnRvIHRoZSBmdXR1cmUsIHNvIEkgYWdyZWUgaXQncyBub3QgbmVjZXNzYXJ5IHRv IGdldCBodW5nIHVwIG9uIHRoZXNlCmlzc3Vlcy4gSSBjYW4gZG8gYSBEVCByZXZpc2lvbiArIGFk ZCBpbiB0aGUgb3RoZXIgc3VnZ2VzdGVkIERSTSBwYXRjaGVzLCBzbyB0aGF0CnRoZXJlJ3MgYXQg bGVhc3QgYSBzZWFyY2hhYmxlIHB1YmxpYyByZWNvcmQgb2YgdGhlIHJlbWFpbmluZyBpc3N1ZXMu CgpraW5kIHJlZ2FyZHMsCglvLgoKPiAtLSAKPiBCZXN0IHJlZ2FyZHMsCj4gCj4gSmF2aWVyIE1h cnRpbmV6IENhbmlsbGFzCj4gQ29yZSBQbGF0Zm9ybXMKPiBSZWQgSGF0Cj4gCgpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1h aWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xp c3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C5C04C3DA7A for ; Mon, 2 Jan 2023 15:20:47 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1434D10E1B2; Mon, 2 Jan 2023 15:20:47 +0000 (UTC) Received: from vps.xff.cz (vps.xff.cz [195.181.215.36]) by gabe.freedesktop.org (Postfix) with ESMTPS id 050DB10E1B2 for ; Mon, 2 Jan 2023 15:20:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=xff.cz; s=mail; t=1672672842; bh=tMFKm6S1vYdEhPMSbHlLVghOqqrmdl6HWg/Ar6Ny41A=; h=Date:From:To:Cc:Subject:X-My-GPG-KeyId:References:From; b=HEcl9avXBPZybBtlbrOD07EfhoBsITX+HBGhDDJPUVH4AVgXH7uufhQ46/fg/5xYi svWsZhI5C5zDH9Kfd4zAcJfVTd8IRThxSbRY4LV9sCY0xdFmMCJ7hFpVpr0NkWfLht HxSPUMstPNX3YryGhepMQmUQc/Iv4ObCQD75ahmo= Date: Mon, 2 Jan 2023 16:20:41 +0100 From: =?utf-8?Q?Ond=C5=99ej?= Jirman To: Javier Martinez Canillas Subject: Re: [PATCH v4 2/4] drm: panel: Add Himax HX8394 panel controller driver Message-ID: <20230102152041.7rc2uts7o37fnsen@core> Mail-Followup-To: =?utf-8?Q?Ond=C5=99ej?= Jirman , Javier Martinez Canillas , linux-kernel@vger.kernel.org, Kamil =?utf-8?Q?Trzci=C5=84ski?= , Martijn Braam , Sam Ravnborg , Robert Mader , Tom Fitzhenry , Peter Robinson , Onuralp Sezer , dri-devel@lists.freedesktop.org, Maya Matuszczyk , Neal Gompa , linux-arm-kernel@lists.infradead.org, Krzysztof Kozlowski , Jagan Teki , Daniel Vetter , David Airlie , Thierry Reding X-My-GPG-KeyId: EBFBDDE11FB918D44D1F56C1F9F0A873BE9777ED References: <20221230113155.3430142-1-javierm@redhat.com> <20221230113155.3430142-3-javierm@redhat.com> <20221230154043.7v3zmzqdrnouqzd2@core> <7120dfd4-305f-69ac-fee8-123196ed06a9@redhat.com> <20230102105915.gbfhletcm4dunrlf@core> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jagan Teki , Robert Mader , Onuralp Sezer , Neal Gompa , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Tom Fitzhenry , Martijn Braam , Krzysztof Kozlowski , Thierry Reding , Peter Robinson , Kamil =?utf-8?Q?Trzci=C5=84ski?= , Sam Ravnborg , linux-arm-kernel@lists.infradead.org, Maya Matuszczyk Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, Jan 02, 2023 at 02:51:42PM +0100, Javier Martinez Canillas wrote: > Hello Ondřej, > > [...] > > My goal was to have some initial support in mainline even if there could be some > issues. IMO it is better to use upstream as a baseline and attempt to support the > PPP incrementally. > > But since you are aware of the issues and know what are the available fixes, I'll > let you continue with the effort and take care of the patches. Hopefully there may > be things that will be helpful, such as the binding schema patch and the collected > tags. I can also take care of pushing the DRM bits to the drm-misc-next tree once > you feel that those are ready to get merged. Ok. The panel driver itself works fine with some changes in other DRM drivers. In fact, it will not need any changes, assuming the to be proposed fixes to dw-mipi-dsi will pass, too. So I don't have many objections against this driver itself. I'm not sure I should be giving reviewed-by to driver I co-wrote. :) Anyway, I checked it again, and only issue I found was that shutdown callback tries to disable the panel even if it may already be disabled, which will lead to unbalanced calls to regulator_disable functions, which may produce some needless warnings on shutdown/reboot. So if you want to commit this driver now, go ahead. DT will need one more round. As you say, the overall usable support for Pinephone Pro in mainline is still way off into the future, so I agree it's not necessary to get hung up on these issues. I can do a DT revision + add in the other suggested DRM patches, so that there's at least a searchable public record of the remaining issues. kind regards, o. > -- > Best regards, > > Javier Martinez Canillas > Core Platforms > Red Hat > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64E20C4708E for ; Mon, 2 Jan 2023 15:21:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236312AbjABPVP (ORCPT ); Mon, 2 Jan 2023 10:21:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59344 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235785AbjABPUs (ORCPT ); Mon, 2 Jan 2023 10:20:48 -0500 Received: from vps.xff.cz (vps.xff.cz [195.181.215.36]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3442B127 for ; Mon, 2 Jan 2023 07:20:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=xff.cz; s=mail; t=1672672842; bh=tMFKm6S1vYdEhPMSbHlLVghOqqrmdl6HWg/Ar6Ny41A=; h=Date:From:To:Cc:Subject:X-My-GPG-KeyId:References:From; b=HEcl9avXBPZybBtlbrOD07EfhoBsITX+HBGhDDJPUVH4AVgXH7uufhQ46/fg/5xYi svWsZhI5C5zDH9Kfd4zAcJfVTd8IRThxSbRY4LV9sCY0xdFmMCJ7hFpVpr0NkWfLht HxSPUMstPNX3YryGhepMQmUQc/Iv4ObCQD75ahmo= Date: Mon, 2 Jan 2023 16:20:41 +0100 From: =?utf-8?Q?Ond=C5=99ej?= Jirman To: Javier Martinez Canillas Cc: linux-kernel@vger.kernel.org, Kamil =?utf-8?Q?Trzci=C5=84ski?= , Martijn Braam , Sam Ravnborg , Robert Mader , Tom Fitzhenry , Peter Robinson , Onuralp Sezer , dri-devel@lists.freedesktop.org, Maya Matuszczyk , Neal Gompa , linux-arm-kernel@lists.infradead.org, Krzysztof Kozlowski , Jagan Teki , Daniel Vetter , David Airlie , Thierry Reding Subject: Re: [PATCH v4 2/4] drm: panel: Add Himax HX8394 panel controller driver Message-ID: <20230102152041.7rc2uts7o37fnsen@core> Mail-Followup-To: =?utf-8?Q?Ond=C5=99ej?= Jirman , Javier Martinez Canillas , linux-kernel@vger.kernel.org, Kamil =?utf-8?Q?Trzci=C5=84ski?= , Martijn Braam , Sam Ravnborg , Robert Mader , Tom Fitzhenry , Peter Robinson , Onuralp Sezer , dri-devel@lists.freedesktop.org, Maya Matuszczyk , Neal Gompa , linux-arm-kernel@lists.infradead.org, Krzysztof Kozlowski , Jagan Teki , Daniel Vetter , David Airlie , Thierry Reding X-My-GPG-KeyId: EBFBDDE11FB918D44D1F56C1F9F0A873BE9777ED References: <20221230113155.3430142-1-javierm@redhat.com> <20221230113155.3430142-3-javierm@redhat.com> <20221230154043.7v3zmzqdrnouqzd2@core> <7120dfd4-305f-69ac-fee8-123196ed06a9@redhat.com> <20230102105915.gbfhletcm4dunrlf@core> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 02, 2023 at 02:51:42PM +0100, Javier Martinez Canillas wrote: > Hello Ondřej, > > [...] > > My goal was to have some initial support in mainline even if there could be some > issues. IMO it is better to use upstream as a baseline and attempt to support the > PPP incrementally. > > But since you are aware of the issues and know what are the available fixes, I'll > let you continue with the effort and take care of the patches. Hopefully there may > be things that will be helpful, such as the binding schema patch and the collected > tags. I can also take care of pushing the DRM bits to the drm-misc-next tree once > you feel that those are ready to get merged. Ok. The panel driver itself works fine with some changes in other DRM drivers. In fact, it will not need any changes, assuming the to be proposed fixes to dw-mipi-dsi will pass, too. So I don't have many objections against this driver itself. I'm not sure I should be giving reviewed-by to driver I co-wrote. :) Anyway, I checked it again, and only issue I found was that shutdown callback tries to disable the panel even if it may already be disabled, which will lead to unbalanced calls to regulator_disable functions, which may produce some needless warnings on shutdown/reboot. So if you want to commit this driver now, go ahead. DT will need one more round. As you say, the overall usable support for Pinephone Pro in mainline is still way off into the future, so I agree it's not necessary to get hung up on these issues. I can do a DT revision + add in the other suggested DRM patches, so that there's at least a searchable public record of the remaining issues. kind regards, o. > -- > Best regards, > > Javier Martinez Canillas > Core Platforms > Red Hat >