From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 078B4C3DA7D for ; Tue, 3 Jan 2023 16:17:03 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 9CCA02B08; Tue, 3 Jan 2023 17:16:11 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 9CCA02B08 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1672762621; bh=fRnV6HJZy0l413BAw85MVar89rZtdB7QolzvCeFzCGk=; h=Date:From:To:Subject:References:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=GRqhI75f+JvtChyk1W9FuuZyeArKBqP85CCvIWVNKlgSxDX/5zlGNTH7idIkcUsau kuh+N4ThUymu/44yGRSem/bgPD4cH3m9UcHOFQteEn6jac3jnP9goX63O7svRhXBqg jR6xwH2xW4YY9luJe3TQLmoaKuMMmN+NgfSE+thk= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 16654F8047B; Tue, 3 Jan 2023 17:16:11 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 1F02EF803DC; Tue, 3 Jan 2023 17:16:09 +0100 (CET) Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 82BABF804AD for ; Tue, 3 Jan 2023 17:16:00 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 82BABF804AD Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=cerno.tech header.i=@cerno.tech header.a=rsa-sha256 header.s=fm3 header.b=pjCYKo7g; dkim=pass (2048-bit key, unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.a=rsa-sha256 header.s=fm2 header.b=j531BDLW Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 2C3583200902; Tue, 3 Jan 2023 11:15:55 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Tue, 03 Jan 2023 11:15:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h=cc :cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm3; t=1672762554; x=1672848954; bh=wNHGYeVYFI zxBf24jgwJU2T/wl2hD0aiCUszvE1r6qc=; b=pjCYKo7gkCK5f2pIymt6QPnLBC 1DAk7msGDlygQAQNqEVyCIpFaOyMgaHSi40KVwP+w+L6RrW2p5XYYI1VqB3rG7dx KEjGnr8HJwsjwZoQRvabZE5YxL8qXbJz8wRykSz3ERcPZx7n7E/OG+hl11/vLkbg a06mvms0SGOqlyX0iMJ83oydOETkNwpTTu7grzSiLToon31tLFhkz4o7eh5iBou4 MxVnC/ZDnvM9P94hvHrcDURJq58ZYxwA3SlT3lGqJlK0eSF0GPHMddpVHO2ldnjB uhG30YyVqwEtr/cCfgAAU1RUwWaiMmfwyBP76iCkiVBIeOBs/K8Nobgq0IpQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1672762554; x=1672848954; bh=wNHGYeVYFIzxBf24jgwJU2T/wl2h D0aiCUszvE1r6qc=; b=j531BDLWxm/ohYQJ7nDDhf9HZ38aqVzvC/s9TGxSWFOF iiYyCfot5ViuJBPsApS5/UR9lIF4taTuAL4+nbDvqMjQkZGhHU9h03T8aaJaQjHJ KTOMF2W1onoAb/5nUCjwe3LJeMQJeuG9q89F1Y0ozgV/zdROkYA9crYI+U05Jvmt nCvLmp92lk26OKxFnXrgHeSFA3iVvwxkR69pcDKumWR3J0EWWdDUkd0mLpuBi97M l/88gmqhLrZQCuPWRLEuc553zwBBHOTY2e+B+OrNT8lgoICwo/vmtj+9+DkWcXSd NotMN9hkOPXxvXxGe/ixjYNbxBvbmJ+YFvUJxxpuLg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrjeeggdekiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvvefukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpeforgigihhm vgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrfgrth htvghrnheptdelkeejiedufedvhfeiffetlefhiedvleeigfeiuefghfdvleeiffejieeg teejnecuffhomhgrihhnpehkvghrnhgvlhdrohhrghenucevlhhushhtvghrufhiiigvpe dtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrgigihhmvgestggvrhhnohdrthgvtghh X-ME-Proxy: Feedback-ID: i8771445c:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 3 Jan 2023 11:15:53 -0500 (EST) Date: Tue, 3 Jan 2023 17:15:50 +0100 From: Maxime Ripard To: Robin Murphy Subject: Re: [PATCH v2 2/3] iommu/sound: Use component_match_add_of helper Message-ID: <20230103161550.4tui3ihl65olvkd7@houat> References: <20221222233759.1934852-1-sean.anderson@seco.com> <20221222233759.1934852-3-sean.anderson@seco.com> <7897d4a6-bf43-becd-3437-7a254f38f6be@arm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="7v4zidzdfmuud6o5" Content-Disposition: inline In-Reply-To: <7897d4a6-bf43-becd-3437-7a254f38f6be@arm.com> X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alsa-devel@alsa-project.org, Daniel Vetter , Liam Girdwood , Sean Anderson , Will Deacon , Joerg Roedel , Takashi Iwai , Maarten Lankhorst , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, iommu@lists.linux.dev, Mark Brown , linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Thomas Zimmermann , Matthias Brugger , David Airlie , Yong Wu Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" --7v4zidzdfmuud6o5 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Robin, On Tue, Jan 03, 2023 at 01:01:07PM +0000, Robin Murphy wrote: > Hi Sean, >=20 > On 22/12/2022 11:37 pm, Sean Anderson wrote: > > Convert users of component_match_add_release with component_release_of > > and component_compare_of to component_match_add_of. > >=20 > > Signed-off-by: Sean Anderson > > Acked-by: Mark Brown > > --- > >=20 > > Changes in v2: > > - Split off from helper addition > >=20 > > drivers/iommu/mtk_iommu.c | 3 +-- > > drivers/iommu/mtk_iommu_v1.c | 3 +-- > > sound/soc/codecs/wcd938x.c | 6 ++---- > > 3 files changed, 4 insertions(+), 8 deletions(-) > >=20 > > diff --git a/drivers/iommu/mtk_iommu.c b/drivers/iommu/mtk_iommu.c > > index 2ab2ecfe01f8..483b7a9e4410 100644 > > --- a/drivers/iommu/mtk_iommu.c > > +++ b/drivers/iommu/mtk_iommu.c > > @@ -1079,8 +1079,7 @@ static int mtk_iommu_mm_dts_parse(struct device *= dev, struct component_match **m > > } > > data->larb_imu[id].dev =3D &plarbdev->dev; > > - component_match_add_release(dev, match, component_release_of, > > - component_compare_of, larbnode); > > + component_match_add_of(dev, match, larbnode); >=20 > I've long since given up trying to make sense of how the DRM tree works, = but > the conflicting change is definitely already in mainline: >=20 > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit= ?id=3Db5765a1b44bea9dfcae69c53ffeb4c689d0922a7 As far as I can see, that patch doesn't affect DRM at all, and the commit you pointed to doesn't either, nor has it been merged through the DRM tree. Can you expand a bit on how we're involved in this, what we should clarify or help with? Maxime --7v4zidzdfmuud6o5 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCY7RUtgAKCRDj7w1vZxhR xdWgAQCl2SxPgHcEj92AdlH7Y2VvK6G5Bczcu2wrB4ZrHXVpawEAsJlD4MKrpINP IZalK2KlJTqUilPQudOtqmCeQzWQqAo= =cdeC -----END PGP SIGNATURE----- --7v4zidzdfmuud6o5-- From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 232708483 for ; Tue, 3 Jan 2023 16:15:58 +0000 (UTC) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 2C3583200902; Tue, 3 Jan 2023 11:15:55 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Tue, 03 Jan 2023 11:15:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h=cc :cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm3; t=1672762554; x=1672848954; bh=wNHGYeVYFI zxBf24jgwJU2T/wl2hD0aiCUszvE1r6qc=; b=pjCYKo7gkCK5f2pIymt6QPnLBC 1DAk7msGDlygQAQNqEVyCIpFaOyMgaHSi40KVwP+w+L6RrW2p5XYYI1VqB3rG7dx KEjGnr8HJwsjwZoQRvabZE5YxL8qXbJz8wRykSz3ERcPZx7n7E/OG+hl11/vLkbg a06mvms0SGOqlyX0iMJ83oydOETkNwpTTu7grzSiLToon31tLFhkz4o7eh5iBou4 MxVnC/ZDnvM9P94hvHrcDURJq58ZYxwA3SlT3lGqJlK0eSF0GPHMddpVHO2ldnjB uhG30YyVqwEtr/cCfgAAU1RUwWaiMmfwyBP76iCkiVBIeOBs/K8Nobgq0IpQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1672762554; x=1672848954; bh=wNHGYeVYFIzxBf24jgwJU2T/wl2h D0aiCUszvE1r6qc=; b=j531BDLWxm/ohYQJ7nDDhf9HZ38aqVzvC/s9TGxSWFOF iiYyCfot5ViuJBPsApS5/UR9lIF4taTuAL4+nbDvqMjQkZGhHU9h03T8aaJaQjHJ KTOMF2W1onoAb/5nUCjwe3LJeMQJeuG9q89F1Y0ozgV/zdROkYA9crYI+U05Jvmt nCvLmp92lk26OKxFnXrgHeSFA3iVvwxkR69pcDKumWR3J0EWWdDUkd0mLpuBi97M l/88gmqhLrZQCuPWRLEuc553zwBBHOTY2e+B+OrNT8lgoICwo/vmtj+9+DkWcXSd NotMN9hkOPXxvXxGe/ixjYNbxBvbmJ+YFvUJxxpuLg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrjeeggdekiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvvefukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpeforgigihhm vgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrfgrth htvghrnheptdelkeejiedufedvhfeiffetlefhiedvleeigfeiuefghfdvleeiffejieeg teejnecuffhomhgrihhnpehkvghrnhgvlhdrohhrghenucevlhhushhtvghrufhiiigvpe dtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrgigihhmvgestggvrhhnohdrthgvtghh X-ME-Proxy: Feedback-ID: i8771445c:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 3 Jan 2023 11:15:53 -0500 (EST) Date: Tue, 3 Jan 2023 17:15:50 +0100 From: Maxime Ripard To: Robin Murphy Cc: Sean Anderson , David Airlie , Daniel Vetter , Maarten Lankhorst , Thomas Zimmermann , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Mark Brown , Jaroslav Kysela , Joerg Roedel , Liam Girdwood , Matthias Brugger , Takashi Iwai , Will Deacon , Yong Wu , alsa-devel@alsa-project.org, iommu@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH v2 2/3] iommu/sound: Use component_match_add_of helper Message-ID: <20230103161550.4tui3ihl65olvkd7@houat> References: <20221222233759.1934852-1-sean.anderson@seco.com> <20221222233759.1934852-3-sean.anderson@seco.com> <7897d4a6-bf43-becd-3437-7a254f38f6be@arm.com> Precedence: bulk X-Mailing-List: iommu@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="7v4zidzdfmuud6o5" Content-Disposition: inline In-Reply-To: <7897d4a6-bf43-becd-3437-7a254f38f6be@arm.com> --7v4zidzdfmuud6o5 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Robin, On Tue, Jan 03, 2023 at 01:01:07PM +0000, Robin Murphy wrote: > Hi Sean, >=20 > On 22/12/2022 11:37 pm, Sean Anderson wrote: > > Convert users of component_match_add_release with component_release_of > > and component_compare_of to component_match_add_of. > >=20 > > Signed-off-by: Sean Anderson > > Acked-by: Mark Brown > > --- > >=20 > > Changes in v2: > > - Split off from helper addition > >=20 > > drivers/iommu/mtk_iommu.c | 3 +-- > > drivers/iommu/mtk_iommu_v1.c | 3 +-- > > sound/soc/codecs/wcd938x.c | 6 ++---- > > 3 files changed, 4 insertions(+), 8 deletions(-) > >=20 > > diff --git a/drivers/iommu/mtk_iommu.c b/drivers/iommu/mtk_iommu.c > > index 2ab2ecfe01f8..483b7a9e4410 100644 > > --- a/drivers/iommu/mtk_iommu.c > > +++ b/drivers/iommu/mtk_iommu.c > > @@ -1079,8 +1079,7 @@ static int mtk_iommu_mm_dts_parse(struct device *= dev, struct component_match **m > > } > > data->larb_imu[id].dev =3D &plarbdev->dev; > > - component_match_add_release(dev, match, component_release_of, > > - component_compare_of, larbnode); > > + component_match_add_of(dev, match, larbnode); >=20 > I've long since given up trying to make sense of how the DRM tree works, = but > the conflicting change is definitely already in mainline: >=20 > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit= ?id=3Db5765a1b44bea9dfcae69c53ffeb4c689d0922a7 As far as I can see, that patch doesn't affect DRM at all, and the commit you pointed to doesn't either, nor has it been merged through the DRM tree. Can you expand a bit on how we're involved in this, what we should clarify or help with? Maxime --7v4zidzdfmuud6o5 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCY7RUtgAKCRDj7w1vZxhR xdWgAQCl2SxPgHcEj92AdlH7Y2VvK6G5Bczcu2wrB4ZrHXVpawEAsJlD4MKrpINP IZalK2KlJTqUilPQudOtqmCeQzWQqAo= =cdeC -----END PGP SIGNATURE----- --7v4zidzdfmuud6o5-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EDA68C46467 for ; Tue, 3 Jan 2023 17:52:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=WFzQaeZ+Qi63ASdMQgp9jJ9BpHj27YJ6/Es++/zty24=; b=hPpPztjxBSGdRz/TIavAeRDI4O JeZriJsVa4taWId1jWcYjnMaOTrU78R7PghS2VnZBVSs42mkmjMbSonoDw7wdC0/lJc/zifqoGrYr Xt7ACKdg+vgqY8rRkznR6vKU3Zyr5OTkXJGfCZNX7I6GnC4a5o4x6v1Im/mzZXmL+VgiGl9FwjDmQ Ng0OwQyKtWPmOfeN+RKG1RaAH+XzrffcXJkqcBGH42DQB++9PCfDTP8rVaWRRE7U4eJNIxZVpahJj NKOy6qJX4aqwofv1qCkhc7gWmkxI2upzjSrY81fnmd273cpEFsZcPqOIfud0gWlWPVMH1sgU8kN0z 7/Y1zyCA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pClQm-003aBS-B6; Tue, 03 Jan 2023 17:50:35 +0000 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pCjxN-002pl8-8l; Tue, 03 Jan 2023 16:16:11 +0000 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 2C3583200902; Tue, 3 Jan 2023 11:15:55 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Tue, 03 Jan 2023 11:15:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h=cc :cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm3; t=1672762554; x=1672848954; bh=wNHGYeVYFI zxBf24jgwJU2T/wl2hD0aiCUszvE1r6qc=; b=pjCYKo7gkCK5f2pIymt6QPnLBC 1DAk7msGDlygQAQNqEVyCIpFaOyMgaHSi40KVwP+w+L6RrW2p5XYYI1VqB3rG7dx KEjGnr8HJwsjwZoQRvabZE5YxL8qXbJz8wRykSz3ERcPZx7n7E/OG+hl11/vLkbg a06mvms0SGOqlyX0iMJ83oydOETkNwpTTu7grzSiLToon31tLFhkz4o7eh5iBou4 MxVnC/ZDnvM9P94hvHrcDURJq58ZYxwA3SlT3lGqJlK0eSF0GPHMddpVHO2ldnjB uhG30YyVqwEtr/cCfgAAU1RUwWaiMmfwyBP76iCkiVBIeOBs/K8Nobgq0IpQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1672762554; x=1672848954; bh=wNHGYeVYFIzxBf24jgwJU2T/wl2h D0aiCUszvE1r6qc=; b=j531BDLWxm/ohYQJ7nDDhf9HZ38aqVzvC/s9TGxSWFOF iiYyCfot5ViuJBPsApS5/UR9lIF4taTuAL4+nbDvqMjQkZGhHU9h03T8aaJaQjHJ KTOMF2W1onoAb/5nUCjwe3LJeMQJeuG9q89F1Y0ozgV/zdROkYA9crYI+U05Jvmt nCvLmp92lk26OKxFnXrgHeSFA3iVvwxkR69pcDKumWR3J0EWWdDUkd0mLpuBi97M l/88gmqhLrZQCuPWRLEuc553zwBBHOTY2e+B+OrNT8lgoICwo/vmtj+9+DkWcXSd NotMN9hkOPXxvXxGe/ixjYNbxBvbmJ+YFvUJxxpuLg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrjeeggdekiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvvefukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpeforgigihhm vgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrfgrth htvghrnheptdelkeejiedufedvhfeiffetlefhiedvleeigfeiuefghfdvleeiffejieeg teejnecuffhomhgrihhnpehkvghrnhgvlhdrohhrghenucevlhhushhtvghrufhiiigvpe dtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrgigihhmvgestggvrhhnohdrthgvtghh X-ME-Proxy: Feedback-ID: i8771445c:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 3 Jan 2023 11:15:53 -0500 (EST) Date: Tue, 3 Jan 2023 17:15:50 +0100 From: Maxime Ripard To: Robin Murphy Cc: Sean Anderson , David Airlie , Daniel Vetter , Maarten Lankhorst , Thomas Zimmermann , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Mark Brown , Jaroslav Kysela , Joerg Roedel , Liam Girdwood , Matthias Brugger , Takashi Iwai , Will Deacon , Yong Wu , alsa-devel@alsa-project.org, iommu@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH v2 2/3] iommu/sound: Use component_match_add_of helper Message-ID: <20230103161550.4tui3ihl65olvkd7@houat> References: <20221222233759.1934852-1-sean.anderson@seco.com> <20221222233759.1934852-3-sean.anderson@seco.com> <7897d4a6-bf43-becd-3437-7a254f38f6be@arm.com> MIME-Version: 1.0 In-Reply-To: <7897d4a6-bf43-becd-3437-7a254f38f6be@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230103_081605_380738_3DE8DCA4 X-CRM114-Status: GOOD ( 21.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============8495807802832168966==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============8495807802832168966== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="7v4zidzdfmuud6o5" Content-Disposition: inline --7v4zidzdfmuud6o5 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Robin, On Tue, Jan 03, 2023 at 01:01:07PM +0000, Robin Murphy wrote: > Hi Sean, >=20 > On 22/12/2022 11:37 pm, Sean Anderson wrote: > > Convert users of component_match_add_release with component_release_of > > and component_compare_of to component_match_add_of. > >=20 > > Signed-off-by: Sean Anderson > > Acked-by: Mark Brown > > --- > >=20 > > Changes in v2: > > - Split off from helper addition > >=20 > > drivers/iommu/mtk_iommu.c | 3 +-- > > drivers/iommu/mtk_iommu_v1.c | 3 +-- > > sound/soc/codecs/wcd938x.c | 6 ++---- > > 3 files changed, 4 insertions(+), 8 deletions(-) > >=20 > > diff --git a/drivers/iommu/mtk_iommu.c b/drivers/iommu/mtk_iommu.c > > index 2ab2ecfe01f8..483b7a9e4410 100644 > > --- a/drivers/iommu/mtk_iommu.c > > +++ b/drivers/iommu/mtk_iommu.c > > @@ -1079,8 +1079,7 @@ static int mtk_iommu_mm_dts_parse(struct device *= dev, struct component_match **m > > } > > data->larb_imu[id].dev =3D &plarbdev->dev; > > - component_match_add_release(dev, match, component_release_of, > > - component_compare_of, larbnode); > > + component_match_add_of(dev, match, larbnode); >=20 > I've long since given up trying to make sense of how the DRM tree works, = but > the conflicting change is definitely already in mainline: >=20 > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit= ?id=3Db5765a1b44bea9dfcae69c53ffeb4c689d0922a7 As far as I can see, that patch doesn't affect DRM at all, and the commit you pointed to doesn't either, nor has it been merged through the DRM tree. Can you expand a bit on how we're involved in this, what we should clarify or help with? Maxime --7v4zidzdfmuud6o5 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCY7RUtgAKCRDj7w1vZxhR xdWgAQCl2SxPgHcEj92AdlH7Y2VvK6G5Bczcu2wrB4ZrHXVpawEAsJlD4MKrpINP IZalK2KlJTqUilPQudOtqmCeQzWQqAo= =cdeC -----END PGP SIGNATURE----- --7v4zidzdfmuud6o5-- --===============8495807802832168966== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============8495807802832168966==-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C2CE9C3DA7D for ; Tue, 3 Jan 2023 16:16:04 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C314510E261; Tue, 3 Jan 2023 16:16:03 +0000 (UTC) Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8BF6610E261 for ; Tue, 3 Jan 2023 16:16:01 +0000 (UTC) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 2C3583200902; Tue, 3 Jan 2023 11:15:55 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Tue, 03 Jan 2023 11:15:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h=cc :cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm3; t=1672762554; x=1672848954; bh=wNHGYeVYFI zxBf24jgwJU2T/wl2hD0aiCUszvE1r6qc=; b=pjCYKo7gkCK5f2pIymt6QPnLBC 1DAk7msGDlygQAQNqEVyCIpFaOyMgaHSi40KVwP+w+L6RrW2p5XYYI1VqB3rG7dx KEjGnr8HJwsjwZoQRvabZE5YxL8qXbJz8wRykSz3ERcPZx7n7E/OG+hl11/vLkbg a06mvms0SGOqlyX0iMJ83oydOETkNwpTTu7grzSiLToon31tLFhkz4o7eh5iBou4 MxVnC/ZDnvM9P94hvHrcDURJq58ZYxwA3SlT3lGqJlK0eSF0GPHMddpVHO2ldnjB uhG30YyVqwEtr/cCfgAAU1RUwWaiMmfwyBP76iCkiVBIeOBs/K8Nobgq0IpQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1672762554; x=1672848954; bh=wNHGYeVYFIzxBf24jgwJU2T/wl2h D0aiCUszvE1r6qc=; b=j531BDLWxm/ohYQJ7nDDhf9HZ38aqVzvC/s9TGxSWFOF iiYyCfot5ViuJBPsApS5/UR9lIF4taTuAL4+nbDvqMjQkZGhHU9h03T8aaJaQjHJ KTOMF2W1onoAb/5nUCjwe3LJeMQJeuG9q89F1Y0ozgV/zdROkYA9crYI+U05Jvmt nCvLmp92lk26OKxFnXrgHeSFA3iVvwxkR69pcDKumWR3J0EWWdDUkd0mLpuBi97M l/88gmqhLrZQCuPWRLEuc553zwBBHOTY2e+B+OrNT8lgoICwo/vmtj+9+DkWcXSd NotMN9hkOPXxvXxGe/ixjYNbxBvbmJ+YFvUJxxpuLg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrjeeggdekiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvvefukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpeforgigihhm vgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrfgrth htvghrnheptdelkeejiedufedvhfeiffetlefhiedvleeigfeiuefghfdvleeiffejieeg teejnecuffhomhgrihhnpehkvghrnhgvlhdrohhrghenucevlhhushhtvghrufhiiigvpe dtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrgigihhmvgestggvrhhnohdrthgvtghh X-ME-Proxy: Feedback-ID: i8771445c:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 3 Jan 2023 11:15:53 -0500 (EST) Date: Tue, 3 Jan 2023 17:15:50 +0100 From: Maxime Ripard To: Robin Murphy Subject: Re: [PATCH v2 2/3] iommu/sound: Use component_match_add_of helper Message-ID: <20230103161550.4tui3ihl65olvkd7@houat> References: <20221222233759.1934852-1-sean.anderson@seco.com> <20221222233759.1934852-3-sean.anderson@seco.com> <7897d4a6-bf43-becd-3437-7a254f38f6be@arm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="7v4zidzdfmuud6o5" Content-Disposition: inline In-Reply-To: <7897d4a6-bf43-becd-3437-7a254f38f6be@arm.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alsa-devel@alsa-project.org, Liam Girdwood , Sean Anderson , Will Deacon , Joerg Roedel , Takashi Iwai , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Jaroslav Kysela , iommu@lists.linux.dev, Mark Brown , linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Thomas Zimmermann , Matthias Brugger , Yong Wu Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" --7v4zidzdfmuud6o5 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Robin, On Tue, Jan 03, 2023 at 01:01:07PM +0000, Robin Murphy wrote: > Hi Sean, >=20 > On 22/12/2022 11:37 pm, Sean Anderson wrote: > > Convert users of component_match_add_release with component_release_of > > and component_compare_of to component_match_add_of. > >=20 > > Signed-off-by: Sean Anderson > > Acked-by: Mark Brown > > --- > >=20 > > Changes in v2: > > - Split off from helper addition > >=20 > > drivers/iommu/mtk_iommu.c | 3 +-- > > drivers/iommu/mtk_iommu_v1.c | 3 +-- > > sound/soc/codecs/wcd938x.c | 6 ++---- > > 3 files changed, 4 insertions(+), 8 deletions(-) > >=20 > > diff --git a/drivers/iommu/mtk_iommu.c b/drivers/iommu/mtk_iommu.c > > index 2ab2ecfe01f8..483b7a9e4410 100644 > > --- a/drivers/iommu/mtk_iommu.c > > +++ b/drivers/iommu/mtk_iommu.c > > @@ -1079,8 +1079,7 @@ static int mtk_iommu_mm_dts_parse(struct device *= dev, struct component_match **m > > } > > data->larb_imu[id].dev =3D &plarbdev->dev; > > - component_match_add_release(dev, match, component_release_of, > > - component_compare_of, larbnode); > > + component_match_add_of(dev, match, larbnode); >=20 > I've long since given up trying to make sense of how the DRM tree works, = but > the conflicting change is definitely already in mainline: >=20 > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit= ?id=3Db5765a1b44bea9dfcae69c53ffeb4c689d0922a7 As far as I can see, that patch doesn't affect DRM at all, and the commit you pointed to doesn't either, nor has it been merged through the DRM tree. Can you expand a bit on how we're involved in this, what we should clarify or help with? Maxime --7v4zidzdfmuud6o5 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCY7RUtgAKCRDj7w1vZxhR xdWgAQCl2SxPgHcEj92AdlH7Y2VvK6G5Bczcu2wrB4ZrHXVpawEAsJlD4MKrpINP IZalK2KlJTqUilPQudOtqmCeQzWQqAo= =cdeC -----END PGP SIGNATURE----- --7v4zidzdfmuud6o5--