Re: [Buildroot] [PATCH 2/2] package/ncurses: Switch to git repo with snapshots

From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Dennis Van Hoorick <dennis.van.hoorick@gmail.com>
Cc: Dennis Van Hoorick <dennis.vanhoorick@barco.com>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 2/2] package/ncurses: Switch to git repo with snapshots
Date: Tue, 3 Jan 2023 21:32:33 +0100	[thread overview]
Message-ID: <20230103203233.GA2498764@scaer> (raw)
In-Reply-To: <20230103103438.1889-2-dennis.vanhoorick@barco.com>

Dennis, All,

On 2023-01-03 11:34 +0100, Dennis Van Hoorick spake thusly:
> Switching to Thomas E. Dickey's github (Thomas is the ncurses maintainer, so we can trust him).
> This avoids needing to list all incremental patches, and will make future bumping easier.

I've extended on the commit log a bit, but mostly see below...

> Signed-off-by: Dennis Van Hoorick <dennis.vanhoorick@barco.com>
[--SNIP--]
> diff --git a/package/ncurses/ncurses.mk b/package/ncurses/ncurses.mk
> index 4d93a992e4..0ba98b4d64 100644
> --- a/package/ncurses/ncurses.mk
> +++ b/package/ncurses/ncurses.mk
> @@ -4,79 +4,20 @@
>  #
>  ################################################################################
>  
> -NCURSES_VERSION = 6.3
> -NCURSES_SITE = $(BR2_GNU_MIRROR)/ncurses

So, 6.4 is out now, and I was wondering what would happen if we wanted
to use a version that had no snapshot yet [0]...

> +NCURSES_VERSION_MAJOR = 6.3
> +NCURSES_SNAPSHOT_DATE = 20221224
> +NCURSES_VERSION = v$(subst .,_,$(NCURSES_VERSION_MAJOR))_$(NCURSES_SNAPSHOT_DATE)

... so here we would generate version like "v6_4_" which is not nice at
all.

First, we do not include the 'v' prefix in the version string; we only
add it in the call to the github macro.

Second, of course, is that the version ends in an underscore, bleh...
And the version people are usually used to is 6.4, not 6_4, so meh
too...

So, I extended a bit to fix all that. Please look at the resulting
commit.

Applied to master, thanks! :-)

Oh, and since 6.4 is out now, I'll take you at your word: "This [...]
will make future bumping easier". So... ;-)

[0] There actually is a snapshot now, but I don't think we can rely on
one to be available on the first day of the release.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot