From: Jakub Kicinski <kuba@kernel.org>
To: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Michael Jamet <michael.jamet@intel.com>,
Yehezkel Bernat <YehezkelShB@gmail.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH 3/3] net: thunderbolt: Add tracepoints
Date: Wed, 4 Jan 2023 20:50:17 -0800 [thread overview]
Message-ID: <20230104205017.3e3cff38@kernel.org> (raw)
In-Reply-To: <20230104081731.45928-4-mika.westerberg@linux.intel.com>
On Wed, 4 Jan 2023 10:17:31 +0200 Mika Westerberg wrote:
> +DECLARE_EVENT_CLASS(tbnet_ip_frame,
> + TP_PROTO(u32 size, u32 id, u32 index, u32 count),
> + TP_ARGS(size, id, index, count),
> + TP_STRUCT__entry(
> + __field(u32, size)
> + __field(u32, id)
> + __field(u32, index)
> + __field(u32, count)
> + ),
> + TP_fast_assign(
> + __entry->size = le32_to_cpu(size);
> + __entry->id = le32_to_cpu(id);
> + __entry->index = le32_to_cpu(index);
> + __entry->count = le32_to_cpu(count);
Looks like sparse is not happy with the byte swaps, perhaps PROTO
can also use the __le32 type?
Could you make sure there are no new warnings when building with
make drivers/net/thunderbolt/ C=1 W=1
?
next prev parent reply other threads:[~2023-01-05 4:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-04 8:17 [PATCH 0/3] net: thunderbolt: Add tracepoints Mika Westerberg
2023-01-04 8:17 ` [PATCH 1/3] net: thunderbolt: Move into own directory Mika Westerberg
2023-01-04 8:17 ` [PATCH 2/3] net: thunderbolt: Add debugging when sending/receiving control packets Mika Westerberg
2023-01-04 8:17 ` [PATCH 3/3] net: thunderbolt: Add tracepoints Mika Westerberg
2023-01-05 4:50 ` Jakub Kicinski [this message]
2023-01-05 8:57 ` Mika Westerberg
2023-01-04 8:29 ` [PATCH 0/3] " Yehezkel Bernat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230104205017.3e3cff38@kernel.org \
--to=kuba@kernel.org \
--cc=YehezkelShB@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=michael.jamet@intel.com \
--cc=mika.westerberg@linux.intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.