From: Jakub Kicinski <kuba@kernel.org>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: "David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next 1/3] ezchip: Remove some redundant clean-up functions
Date: Wed, 4 Jan 2023 20:52:36 -0800 [thread overview]
Message-ID: <20230104205236.3c0f90de@kernel.org> (raw)
In-Reply-To: <43e9d047a036cd8a84aad8e9fffdfdcb17a1cf2a.1672865629.git.christophe.jaillet@wanadoo.fr>
On Wed, 4 Jan 2023 22:05:32 +0100 Christophe JAILLET wrote:
> @@ -640,7 +639,6 @@ static s32 nps_enet_remove(struct platform_device *pdev)
> struct nps_enet_priv *priv = netdev_priv(ndev);
>
> unregister_netdev(ndev);
> - netif_napi_del(&priv->napi);
> free_netdev(ndev);
This adds an unused variable warning, which is fixed by the next patch.
Could you remove the @priv variable here already?
next prev parent reply other threads:[~2023-01-05 4:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-04 21:05 [PATCH net-next 0/3] ezchip: Simplify some code Christophe JAILLET
2023-01-04 21:05 ` [PATCH net-next 1/3] ezchip: Remove some redundant clean-up functions Christophe JAILLET
2023-01-05 4:52 ` Jakub Kicinski [this message]
2023-01-04 21:05 ` [PATCH net-next 2/3] ezchip: Switch to some devm_ function to simplify code Christophe JAILLET
2023-01-05 4:54 ` Jakub Kicinski
2023-01-05 6:27 ` Christophe JAILLET
2023-01-05 8:01 ` Leon Romanovsky
2023-01-05 18:31 ` Jakub Kicinski
2023-01-04 21:05 ` [PATCH net-next 3/3] ezchip: Further clean-up Christophe JAILLET
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230104205236.3c0f90de@kernel.org \
--to=kuba@kernel.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.