All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: qemu-devel@nongnu.org, xieyongji@bytedance.com, pbonzini@redhat.com
Subject: Re: [PATCH v4 00/12] Compiler warning fixes for libvhost-user,libvduse
Date: Wed, 4 Jan 2023 20:58:17 -0500	[thread overview]
Message-ID: <20230104205302-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <cover.1671741278.git.marcel@holtmann.org>

On Thu, Dec 22, 2022 at 09:36:39PM +0100, Marcel Holtmann wrote:
> The libvhost-user and libvduse libraries are also useful for external
> usage outside of QEMU and thus it would be nice if their files could
> be just copied and used. However due to different compiler settings, a
> lot of manual fixups are needed. This is the first attempt at some
> obvious fixes that can be done without any harm to the code and its
> readability.
> 
> Marcel Holtmann (12):
>   libvhost-user: Provide _GNU_SOURCE when compiling outside of QEMU
>   libvhost-user: Replace typeof with __typeof__
>   libvhost-user: Cast rc variable to avoid compiler warning
>   libvhost-user: Use unsigned int i for some for-loop iterations
>   libvhost-user: Declare uffdio_register early to make it C90 compliant
>   libvhost-user: Change dev->postcopy_ufd assignment to make it C90 compliant
>   libvduse: Provide _GNU_SOURCE when compiling outside of QEMU
>   libvduse: Switch to unsigned int for inuse field in struct VduseVirtq
>   libvduse: Fix assignment in vring_set_avail_event
>   libvhost-user: Fix assignment in vring_set_avail_event
>   libvhost-user: Add extra compiler warnings
>   libvduse: Add extra compiler warnings


series looks good to me.

Paolo I understand you are merging this?

Reviewed-by: Michael S. Tsirkin <mst@redhat.com>

>  subprojects/libvduse/libvduse.c           |  9 ++++--
>  subprojects/libvduse/meson.build          |  8 ++++-
>  subprojects/libvhost-user/libvhost-user.c | 36 +++++++++++++----------
>  subprojects/libvhost-user/meson.build     |  8 ++++-
>  4 files changed, 42 insertions(+), 19 deletions(-)
> 
> -- 
> 2.38.1
> 
> 
> 



  parent reply	other threads:[~2023-01-05  1:58 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-22 20:36 [PATCH v4 00/12] Compiler warning fixes for libvhost-user,libvduse Marcel Holtmann
2022-12-22 20:36 ` [PATCH v4 01/12] libvhost-user: Provide _GNU_SOURCE when compiling outside of QEMU Marcel Holtmann
2022-12-22 20:36 ` [PATCH v4 02/12] libvhost-user: Replace typeof with __typeof__ Marcel Holtmann
2022-12-22 20:36 ` [PATCH v4 03/12] libvhost-user: Cast rc variable to avoid compiler warning Marcel Holtmann
2022-12-22 20:36 ` [PATCH v4 04/12] libvhost-user: Use unsigned int i for some for-loop iterations Marcel Holtmann
2022-12-22 20:36 ` [PATCH v4 05/12] libvhost-user: Declare uffdio_register early to make it C90 compliant Marcel Holtmann
2022-12-22 20:36 ` [PATCH v4 06/12] libvhost-user: Change dev->postcopy_ufd assignment " Marcel Holtmann
2022-12-22 20:36 ` [PATCH v4 07/12] libvduse: Provide _GNU_SOURCE when compiling outside of QEMU Marcel Holtmann
2022-12-22 20:36 ` [PATCH v4 08/12] libvduse: Switch to unsigned int for inuse field in struct VduseVirtq Marcel Holtmann
2022-12-22 20:36 ` [PATCH v4 09/12] libvduse: Fix assignment in vring_set_avail_event Marcel Holtmann
2022-12-22 20:36 ` [PATCH v4 10/12] libvhost-user: " Marcel Holtmann
2022-12-22 20:36 ` [PATCH v4 11/12] libvhost-user: Add extra compiler warnings Marcel Holtmann
2022-12-22 20:36 ` [PATCH v4 12/12] libvduse: " Marcel Holtmann
2022-12-23 15:21 ` [PATCH v4 00/12] Compiler warning fixes for libvhost-user,libvduse Paolo Bonzini
2022-12-23 15:28   ` Marcel Holtmann
2022-12-23 17:55   ` Michael S. Tsirkin
2023-01-05  1:58 ` Michael S. Tsirkin [this message]
2023-01-10  9:54   ` [PATCH v4 00/12] Compiler warning fixes for libvhost-user, libvduse Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230104205302-mutt-send-email-mst@kernel.org \
    --to=mst@redhat.com \
    --cc=marcel@holtmann.org \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=xieyongji@bytedance.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.