From: Ben Carter <craterrender@gmail.com>
To: "Jaroslav Kysela" <perex@perex.cz>,
"Takashi Iwai" <tiwai@suse.com>,
"Cezary Rojewski" <cezary.rojewski@intel.com>,
"Amadeusz Sławiński" <amadeuszx.slawinski@linux.intel.com>,
"Mark Brown" <broonie@kernel.org>,
"Divya Prakash" <divya1.prakash@intel.com>,
"Ben Carter" <craterrender@gmail.com>
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: [PATCH] sound: hda: increase timeouts to stop crash on resume with ALC3204 and others
Date: Wed, 4 Jan 2023 22:10:24 +0000 [thread overview]
Message-ID: <20230104221024.23524-1-craterrender@gmail.com> (raw)
Upon waking after system suspend, ALSA often crashed with:
snd_hda_intel 0000:00:1f.3: CORB reset timeout#2, CORBRP = 65535
snd_hda_codec_hdmi hdaudioC1D2: Unable to sync register 0x2f8100. -5
snd_hda_codec_realtek hdaudioC1D0: Unable to sync register 0x2b8000. -5
A temporary fix was established by reloading snd_hda_intel, but increasing
the rather strict timeout of 1ms to 100ms has remedied the issue on my
device. Although this is a much larger delay, most hardware took less than
1ms anyway and it's preferable to the whole audio system crashing.
Signed-off-by: Ben Carter <craterrender@gmail.com>
---
sound/hda/hdac_controller.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/hda/hdac_controller.c b/sound/hda/hdac_controller.c
index 3c7af6558249..1ab573248452 100644
--- a/sound/hda/hdac_controller.c
+++ b/sound/hda/hdac_controller.c
@@ -16,7 +16,7 @@ static void azx_clear_corbrp(struct hdac_bus *bus)
{
int timeout;
- for (timeout = 1000; timeout > 0; timeout--) {
+ for (timeout = 100000; timeout > 0; timeout--) {
if (snd_hdac_chip_readw(bus, CORBRP) & AZX_CORBRP_RST)
break;
udelay(1);
@@ -26,7 +26,7 @@ static void azx_clear_corbrp(struct hdac_bus *bus)
snd_hdac_chip_readw(bus, CORBRP));
snd_hdac_chip_writew(bus, CORBRP, 0);
- for (timeout = 1000; timeout > 0; timeout--) {
+ for (timeout = 100000; timeout > 0; timeout--) {
if (snd_hdac_chip_readw(bus, CORBRP) == 0)
break;
udelay(1);
--
2.39.0
next reply other threads:[~2023-01-05 9:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-04 22:10 Ben Carter [this message]
2023-01-05 8:55 ` [PATCH] sound: hda: increase timeouts to stop crash on resume with ALC3204 and others Takashi Iwai
2023-01-05 8:55 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230104221024.23524-1-craterrender@gmail.com \
--to=craterrender@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=amadeuszx.slawinski@linux.intel.com \
--cc=broonie@kernel.org \
--cc=cezary.rojewski@intel.com \
--cc=divya1.prakash@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.