From: Jakub Kicinski <kuba@kernel.org>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: "David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next 2/3] ezchip: Switch to some devm_ function to simplify code
Date: Thu, 5 Jan 2023 10:31:14 -0800 [thread overview]
Message-ID: <20230105103114.6c1ee8ec@kernel.org> (raw)
In-Reply-To: <94876618-bc7c-dd42-6d41-eda80deb6f1d@wanadoo.fr>
On Thu, 5 Jan 2023 07:27:00 +0100 Christophe JAILLET wrote:
> My main point is in the cover letter. I look for feed-back to know if
> patches like that are welcomed. Only the first, Only the second, Both or
> None.
Sorry, missed that.
> These patches (at least 1 and 2) can be seen as an RFC for net
> MAINTAINERS, to see if there is any interest in:
> - axing useless netif_napi_del() calls, when free_netdev() is called
> just after. (patch 1)
I think it'd be too much noise. I'd vote no.
> - simplifying code with axing the error handling path of the probe
> and the remove function in favor of using devm_ functions (patch 2)
I believe DaveM was historically opposed to those helpers in general.
I think we should avoid pure conversions, unless they are part of
development of new features or fix bugs.
next prev parent reply other threads:[~2023-01-05 18:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-04 21:05 [PATCH net-next 0/3] ezchip: Simplify some code Christophe JAILLET
2023-01-04 21:05 ` [PATCH net-next 1/3] ezchip: Remove some redundant clean-up functions Christophe JAILLET
2023-01-05 4:52 ` Jakub Kicinski
2023-01-04 21:05 ` [PATCH net-next 2/3] ezchip: Switch to some devm_ function to simplify code Christophe JAILLET
2023-01-05 4:54 ` Jakub Kicinski
2023-01-05 6:27 ` Christophe JAILLET
2023-01-05 8:01 ` Leon Romanovsky
2023-01-05 18:31 ` Jakub Kicinski [this message]
2023-01-04 21:05 ` [PATCH net-next 3/3] ezchip: Further clean-up Christophe JAILLET
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230105103114.6c1ee8ec@kernel.org \
--to=kuba@kernel.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.